fix potential crash in QProcessEnvironment::systemEnvironment() on windows

GetEnvironmentStrings() can theoretically return null

1 files changed, 11 insertions, 10 deletions

diff --git a/src/corelib/io/qprocess_win.cpp b/src/corelib/io/qprocess_win.cpp
index 7739bbd..0c8becc 100644
--- a/src/corelib/io/qprocess_win.cpp
+++ b/src/corelib/io/qprocess_win.cpp
@@ -283,18 +283,19 @@ QProcessEnvironment QProcessEnvironment::systemEnvironment()
     QProcessEnvironment env;
     // Calls to setenv() affect the low-level environment as well.
     // This is not the case the other way round.
-    wchar_t *envStrings = GetEnvironmentStringsW();
-    for (const wchar_t *entry = envStrings; *entry; ) {
-        int entryLen = wcslen(entry);
-        if (const wchar_t *equal = wcschr(entry, L'=')) {
-            int nameLen = equal - entry;
-            QString name = QString::fromWCharArray(entry, nameLen);
-            QString value = QString::fromWCharArray(equal + 1, entryLen - nameLen - 1);
-            env.d->hash.insert(QProcessEnvironmentPrivate::Key(name), value);
+    if (wchar_t *envStrings = GetEnvironmentStringsW()) {
+        for (const wchar_t *entry = envStrings; *entry; ) {
+            int entryLen = wcslen(entry);
+            if (const wchar_t *equal = wcschr(entry, L'=')) {
+                int nameLen = equal - entry;
+                QString name = QString::fromWCharArray(entry, nameLen);
+                QString value = QString::fromWCharArray(equal + 1, entryLen - nameLen - 1);
+                env.d->hash.insert(QProcessEnvironmentPrivate::Key(name), value);
+            }
+            entry += entryLen + 1;
         }
-        entry += entryLen + 1;
+        FreeEnvironmentStrings(envStrings);
     }
-    FreeEnvironmentStrings(envStrings);
     return env;
 }