summaryrefslogtreecommitdiffstats
path: root/tests/auto/declarative/qmlvisual
diff options
context:
space:
mode:
authorAlan Alpert <alan.alpert@nokia.com>2010-11-18 23:19:41 (GMT)
committerAlan Alpert <alan.alpert@nokia.com>2010-11-18 23:19:41 (GMT)
commitd4cd9c899e705ff01f597f0007def8fbd3ab8b39 (patch)
tree12745de2bf7c305e1fcd6f0996565615ce5735c2 /tests/auto/declarative/qmlvisual
parent0ced71e4dddc12240b22fd5786ed41a529e49c47 (diff)
downloadQt-d4cd9c899e705ff01f597f0007def8fbd3ab8b39.zip
Qt-d4cd9c899e705ff01f597f0007def8fbd3ab8b39.tar.gz
Qt-d4cd9c899e705ff01f597f0007def8fbd3ab8b39.tar.bz2
Add a test on QWS
Without a single test, it fails anyways. Task-number: QTBUG-14792
Diffstat (limited to 'tests/auto/declarative/qmlvisual')
-rw-r--r--tests/auto/declarative/qmlvisual/TEST_GUIDELINES2
-rw-r--r--tests/auto/declarative/qmlvisual/tst_qmlvisual.cpp6
2 files changed, 5 insertions, 3 deletions
diff --git a/tests/auto/declarative/qmlvisual/TEST_GUIDELINES b/tests/auto/declarative/qmlvisual/TEST_GUIDELINES
index cb53b6e..469832f 100644
--- a/tests/auto/declarative/qmlvisual/TEST_GUIDELINES
+++ b/tests/auto/declarative/qmlvisual/TEST_GUIDELINES
@@ -4,4 +4,4 @@ Guidelines for creating new visual tests:
2. Keep it short. It is hoped that these tests can be run regularly, perhaps even for every commit, and if you add up ten seconds for every time someone commits a change to QML then we'll be sitting here for a long time. Completeness is more important than haste, but consider the most time efficient ways to achieve said completeness. Do not forget about snapshot mode (tst_qmlvisual -help for details on -recordsnapshot) when testing that a static scene looks right.
-3. Avoid text. Text is relatively unstable due to platform specific peculiarities. If you need to identify an area, consider a unique color as opposed to a unique text label. If you must use Text, TextEdit, or TextInput, use the test-friendlier versions in the 'shared' directory.
+3. Avoid text. Text is relatively unstable due to platform specific peculiarities. If you need to identify an area, consider a unique color as opposed to a unique text label. If you must use Text, TextEdit, or TextInput, use the test-friendlier versions in the 'shared' directory. Also keep in mind that text anti-aliasing is disabled during tests for greater consistency, and you should never use point sizes in tests. Text autotests can thus only test some aspects of the elements.
diff --git a/tests/auto/declarative/qmlvisual/tst_qmlvisual.cpp b/tests/auto/declarative/qmlvisual/tst_qmlvisual.cpp
index 8d4d0d1..2a15102 100644
--- a/tests/auto/declarative/qmlvisual/tst_qmlvisual.cpp
+++ b/tests/auto/declarative/qmlvisual/tst_qmlvisual.cpp
@@ -104,14 +104,16 @@ void tst_qmlvisual::visual_data()
QStringList files;
files << findQmlFiles(QDir(QT_TEST_SOURCE_DIR));
if (qgetenv("QMLVISUAL_ALL") != "1") {
- //Text on X11 varies per distro - and the CI system is currently using something outdated.
#if defined(Q_WS_X11)
+ //Text on X11 varies per distro - and the CI system is currently using something outdated.
foreach(const QString &str, files.filter(QRegExp(".*text.*")))
files.removeAll(str);
#endif
- //We don't want QWS test results to mire down the CI system
#if defined(Q_WS_QWS)
+ //We don't want QWS test results to mire down the CI system
files.clear();
+ //Needs at least one test data or it fails anyways
+ files << QT_TEST_SOURCE_DIR "/selftest_noimages/selftest_noimages.qml";
#endif
}