diff options
author | Orgad Shaneh <orgad.shaneh@audiocodes.com> | 2012-11-04 19:21:31 (GMT) |
---|---|---|
committer | The Qt Project <gerrit-noreply@qt-project.org> | 2012-11-08 14:11:56 (GMT) |
commit | 17bea1689abc695d88f13cd15f73b0a59fcffdff (patch) | |
tree | 3686d3b4face64fb47fdb643a8bb73c887481101 /tests/auto/qfuture | |
parent | a4b5cd2893a5eef09d615340ae899f785de84858 (diff) | |
download | Qt-17bea1689abc695d88f13cd15f73b0a59fcffdff.zip Qt-17bea1689abc695d88f13cd15f73b0a59fcffdff.tar.gz Qt-17bea1689abc695d88f13cd15f73b0a59fcffdff.tar.bz2 |
QtConcurrent: Fix for leak in QFuture
To avoid leaking when converting a QFuture<T> to a QFuture<void> we need
to have a separate ref. counter for QFuture<T>. When the last QFuture<T>
goes out of scope, we need to clean out the result data.
backported from qt/qtbase commit 731ba8ed08f80644b403556638c7f6229e678ebe
Original commit by Christian Strømme
Task-number: QTBUG-27224
Change-Id: I0c6b525cf241b5c559a1bab4e0066cd4de556ea8
Reviewed-by: Christian Stromme <christian.stromme@digia.com>
Diffstat (limited to 'tests/auto/qfuture')
-rw-r--r-- | tests/auto/qfuture/tst_qfuture.cpp | 30 |
1 files changed, 22 insertions, 8 deletions
diff --git a/tests/auto/qfuture/tst_qfuture.cpp b/tests/auto/qfuture/tst_qfuture.cpp index f6ed5a9..0f1836c 100644 --- a/tests/auto/qfuture/tst_qfuture.cpp +++ b/tests/auto/qfuture/tst_qfuture.cpp @@ -1282,18 +1282,32 @@ void tst_QFuture::throttling() void tst_QFuture::voidConversions() { - QFutureInterface<int> iface; - iface.reportStarted(); + { + QFutureInterface<int> iface; + iface.reportStarted(); - QFuture<int> intFuture(&iface); + QFuture<int> intFuture(&iface); + int value = 10; + iface.reportFinished(&value); - int value = 10; - iface.reportFinished(&value); + QFuture<void> voidFuture(intFuture); + voidFuture = intFuture; + + QVERIFY(voidFuture == intFuture); + } - QFuture<void> voidFuture(intFuture); - voidFuture = intFuture; + { + QFuture<void> voidFuture; + { + QFutureInterface<QList<int> > iface; + iface.reportStarted(); - QVERIFY(voidFuture == intFuture); + QFuture<QList<int> > listFuture(&iface); + iface.reportResult(QList<int>() << 1 << 2 << 3); + voidFuture = listFuture; + } + QCOMPARE(voidFuture.resultCount(), 0); + } } |