diff options
| author | Jason McDonald <jason.mcdonald@nokia.com> | 2011-04-12 04:53:36 (GMT) |
|---|---|---|
| committer | Jason McDonald <jason.mcdonald@nokia.com> | 2011-04-12 05:38:20 (GMT) |
| commit | 3475168550c1a804f04f2a4edfeb30c04cd36551 (patch) | |
| tree | ec1587bdc87e6f554c31e09cb1a3a2e26f16b181 /tests/auto/qtextcodec/tst_qtextcodec.cpp | |
| parent | 78722d6b6e9ba0f6de1a4eba232aad2f96a339f2 (diff) | |
| download | Qt-3475168550c1a804f04f2a4edfeb30c04cd36551.zip Qt-3475168550c1a804f04f2a4edfeb30c04cd36551.tar.gz Qt-3475168550c1a804f04f2a4edfeb30c04cd36551.tar.bz2 | |
Reduce usage of Q_ASSERT in autotests.
Using Q_ASSERT does nothing in release-mode builds, and in debug builds
it causes tests to terminate prematurely. It is much better to use
QVERIFY or QCOMPARE.
Task-number: QTBUG-17582
Reviewed-by: Rohan McGovern
Diffstat (limited to 'tests/auto/qtextcodec/tst_qtextcodec.cpp')
| -rw-r--r-- | tests/auto/qtextcodec/tst_qtextcodec.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tests/auto/qtextcodec/tst_qtextcodec.cpp b/tests/auto/qtextcodec/tst_qtextcodec.cpp index 43656c8..d122b0b 100644 --- a/tests/auto/qtextcodec/tst_qtextcodec.cpp +++ b/tests/auto/qtextcodec/tst_qtextcodec.cpp @@ -428,7 +428,7 @@ void tst_QTextCodec::flagCodepointFFFF() const QString input(ch); QTextCodec *const codec = QTextCodec::codecForMib(106); // UTF-8 - Q_ASSERT(codec); + QVERIFY(codec); const QByteArray asDecoded(codec->fromUnicode(input)); QCOMPARE(asDecoded, QByteArray("?")); @@ -465,7 +465,7 @@ void tst_QTextCodec::flagF7808080() const QTextCodec *const codec = QTextCodec::codecForMib(106); // UTF-8 - Q_ASSERT(codec); + QVERIFY(codec); //QVERIFY(!codec->canEncode(QChar(0x1C0000))); @@ -482,7 +482,7 @@ void tst_QTextCodec::flagEFBFBF() const invalidInput[2] = char(0xBF); const QTextCodec *const codec = QTextCodec::codecForMib(106); // UTF-8 - Q_ASSERT(codec); + QVERIFY(codec); { //QVERIFY(!codec->canEncode(QChar(0xFFFF))); @@ -1627,7 +1627,7 @@ void tst_QTextCodec::utf8bom() QFETCH(QString, result); QTextCodec *const codec = QTextCodec::codecForMib(106); // UTF-8 - Q_ASSERT(codec); + QVERIFY(codec); QCOMPARE(codec->toUnicode(data.constData(), data.length(), 0), result); |