diff options
author | Jesper Thomschütz <jesper@trolltech.com> | 2009-05-14 13:48:31 (GMT) |
---|---|---|
committer | Jesper Thomschütz <jesper@trolltech.com> | 2009-05-14 13:55:14 (GMT) |
commit | 8e9b041f0081cd5af67c5c5f3cee0cf2b70ffe11 (patch) | |
tree | feed93dc8771667dd2f9ef73fd18c53426e50f17 /tools | |
parent | f09304d46bac91f3e8329cb7147f8df44898d1e0 (diff) | |
download | Qt-8e9b041f0081cd5af67c5c5f3cee0cf2b70ffe11.zip Qt-8e9b041f0081cd5af67c5c5f3cee0cf2b70ffe11.tar.gz Qt-8e9b041f0081cd5af67c5c5f3cee0cf2b70ffe11.tar.bz2 |
Use isNull() for strings instead of comparing against QString().
foo == QString() should be foo.isNull(). Fixes 7 warnings in the Norwegian Breakfast Network
Reviewed-by: Samuel
Diffstat (limited to 'tools')
-rw-r--r-- | tools/macdeployqt/shared/shared.cpp | 4 | ||||
-rw-r--r-- | tools/porting/src/portingrules.cpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/tools/macdeployqt/shared/shared.cpp b/tools/macdeployqt/shared/shared.cpp index db76ef2..1faa63a 100644 --- a/tools/macdeployqt/shared/shared.cpp +++ b/tools/macdeployqt/shared/shared.cpp @@ -343,7 +343,7 @@ DeploymentInfo deployQtFrameworks(QList<FrameworkInfo> frameworks, const QString copiedFrameworks.append(framework.frameworkName); // Get the qt path from one of the Qt frameworks; - if (deploymenInfo.qtPath == QString() && framework.frameworkName.contains("Qt") + if (deploymenInfo.qtPath.isNull() && framework.frameworkName.contains("Qt") && framework.frameworkDirectory.contains("/lib")) { deploymenInfo.qtPath = framework.frameworkDirectory; @@ -364,7 +364,7 @@ DeploymentInfo deployQtFrameworks(QList<FrameworkInfo> frameworks, const QString // Copy farmework to app bundle. const QString deployedBinaryPath = copyFramework(framework, bundlePath); // Skip the rest if already was deployed. - if (deployedBinaryPath == QString()) + if (deployedBinaryPath.isNull()) continue; runStrip(deployedBinaryPath); diff --git a/tools/porting/src/portingrules.cpp b/tools/porting/src/portingrules.cpp index 4931064..cd29403 100644 --- a/tools/porting/src/portingrules.cpp +++ b/tools/porting/src/portingrules.cpp @@ -189,7 +189,7 @@ void PortingRules::parseXml(QString fileName) QString includeFile = xml[QLatin1String("Rules")][QLatin1String("Include")].text(); - if(includeFile != QString()) { + if(!includeFile.isNull()) { QString resolvedIncludeFile = resolveFileName(fileName, includeFile); if (!resolvedIncludeFile.isEmpty()) parseXml(resolvedIncludeFile); |