| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
Use qmake -query QT_INSTALL_HEADERS at test startup time instead of
relying on the dead QTDIR environment variable.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
| |
Remove unused QTDIR tests.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have to pass the correct include paths when testing the multiple
inheritance warning, because we want moc to find the QtGui and QObject
headers.
In addition we have to adjust the line numbers and include QObject in
the qobject test to avoid a warning about the unknown QObject
superclass.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
|
|
| |
We changed the logic for determining sheets, but it seems we forgot to
take the parentWidget() into account. It's required for WindowModality
to make any sense.
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
|
|
|
| |
The default scheduling policy on Linux doesn't allow specifying thread
priorities, so the priority passed to start() and setPriority() has no
effect. Document this.
Task number: 249997
Reviewed-by: Kavindra Devi Palaraja <kavindra.palaraja@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems that GetThemeTextColor is not available at all for 64-bit
versions of the operating system and there is no good equivalent.
We were using a technique where we would create a small pixmap and then
use HIThemeSetTextFillColor() with the proper enum. However, this
function will silently set a black color if it doesn't know about the
enum. So, we get black when we really shouldn't. It also seems to
produce colors that are a bit different from the Carbon function. So, in
the meantime, just hard code the values in. It might break if you are
hacking the resources in Mac OS X, but we'll have to live with that
until we get a real function.
Task-number: 248918
Reviewed-by: Prasanth Ullattil
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
more than 64k.
This issue was found by Warwick: the copyReadyRead() slot is called
only once as a result of readyRead(), but since there's no more data
to be received (the source QIODevice is a QBuffer), we'll never get a
readyRead() again.
So, if we don't have a limited buffer size, we should read
everything. This applies to QFile as well.
The side-effect is that we cause the entire QFile to be loaded to
memory, so if you had a 2 GB cache entry, you'll probably run out of
memory.
Future optimisations:
- don't memcpy the data from a QBuffer into another buffer
- find a way to avoid loading the entire contents of the file
(probably not possible with the default QNetworkDiskCache since that
may compress the data, so we won't know the size and thus can't fake
finished())
Reviewed-by: Warwick Allison
|
|
|
|
|
|
| |
processed.
Reviewed-by: TrustMe
|
|
|
|
|
| |
Reviewed-by: TrustMe
BT: yes
|
|
|
|
|
|
|
| |
Add some frames-per-second output for debugging when QT_DIRECTFB_TIMING
is defined.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
| |
We don't need to chain to the base class anymore.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
| |
Even though these variables couldn't really be used uninitialized GCC
4.3.2 thinks it could. This is nicer, more readable and faster anyway.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Well actually this change is a bit bigger than just that.
*We no longer override the palette you provide in polish so it should
be a bit more frienly toward custom application changes.
* Another issue was that we would generate the palette information
when we got the style callback from gtkButton but then the line edits might not yet have been
polished. Hence we now return from the callback and instead post the
update for later.
* We had to modify the PE_Frame entry to draw a raised menu when the
custom combo box delegate was used.
* We now simply ignore custom
qtconfig palette entries when using GtkStyle since they only cause
trouble with it.
Task-number: 250142
Reviewed-by: nrc
|
|
|
|
|
|
|
|
|
| |
If we get an hover event while the model gets invalidated, we might ends
up calling itemDecorationAt before the viewitem is refreshed.
Can be reproduced in KTorrent (Relates to KDE bug 172198) or Kopete trunk
Reviewed-by: Thierry
|
|
|
|
|
|
|
|
| |
This fixes KRunner on XMonad. The Qt::Dialog flag of the krunner dialog
was lost when the Qt::WA_TranslucentBackground was set, leading to
incorrect behaviour in some window manager (such as xmonad)
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main problem is that enterDirectory received a QModelIndex that can
be a proxy index and not a source index if there is a proxy set on the
QFileDialog. This fix basically discover some other crashes in the
completer. The problem was that we didn't apply the proxy to the
completer too. So we basically messed up source and proxy indexes.
Both have a proxy set now and convert the model indexes if needed.
Task-number:250194
Reviewed-by:jasplin
|
|
|
|
|
|
|
|
|
| |
The OpenGL ES config tests are there to test if there's enough to build
QtOpenGL, not OpenGL applications using Qt. Therefore we should use
QMAKE_LIBS_OPENGL_QT rather than QMAKE_LIBS_OPENGL. This is mostely
because Qt needs to link against EGL whereas Qt applications do not.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
Previously, it was entirely possible to successfully configure Qt/X11
without any X11 installed. The problems would only start showing up once
you stated building. This is not very useful if you're cross-compiling
and trying to setup the paths correctly.
Reviewed-by: Denis
|
|
|
|
| |
Reviewed-by: Kim
|
|
|
|
|
|
|
|
|
|
|
|
| |
types.
C++ is nice, but we don't have to use confusing syntax when plain old
C works (and is correct). This apparently fixes a compilation error on
MSVC 6, that doesn't like the constructor-like initialisation for POD
types.
Reviewed-by: Trust Me
BT: yes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since there is no way to find out if gradient stops have been added to a
gradient, a gradient stop at NaN was earlier used in the SVG module to
mark the gradient as empty. This could cause floating point exceptions.
The usage of NaN has now been replaced by a boolean in
QSvgGradientStyle.
Duplicate entry "qxmlpatterns" was removed from auto.pro in the auto
test directory.
Task-number: 250146
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 4a00810cc394b7da99ddb2d13eb045352ede25d3 ensures
that setting the focus policy of a widget applies to its
proxy (if any) as well. This propagation effect is however
unfortunate for a QCompleter in PopupCompletion mode.
The client widget (typically a QLineEdit or a QTextEdit)
acts as the focus proxy to the popup menu. Internally,
the completer sets the focus policy of the popup menu to
NoFocus, but this should not affect the focus policy of
the editor.
Reviewed-by: janarve
Task-number: 250064
|
| |
|
|
|
|
|
|
|
| |
The wrong temporary surface id was being used to recreate the EGL
surface. It was "tempSurface" when it should have been -1.
Reviewed-by: Ian Walters
|
|
|
|
|
|
|
| |
The QT_QWS_CLIENTBLIT and QT_NO_QWS_CURSOR defines must be supplied
or the direct paint regions used by the PowerVR driver won't work.
Reviewed-by: trustme
|
|
|
|
| |
sometimes, even two reviews are not enough ...
|
|
|
|
|
|
|
| |
Task-number: 244500
Task-number: 244485
Reviewed-by: ossi
Reviewed-by: thiago
|
|
|
|
|
|
|
|
|
|
|
| |
This issue would cause Qt Creator and similar apps with proxy styles to loose
their custom styling whenever any x11 system settings changed.
This happened because we would re-read the settings and override the
system style even if the system style did not actually change would be set on
the application. We
Task-number: 250199
Reviewed-by: ogoffart
|
|
|
|
|
|
|
| |
Explicitly unset QTDIR_build, to make sure we generate Makefiles with
real rules to call the extra tools.
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
|
|\ |
|
| |
| |
| |
| | |
i.e., use "", not <> and thus rely on the include path
|
| |
| |
| |
| |
| |
| |
| | |
this time, it can deal with directories which are absolute to start
with.
Reviewed-by: mariusSO
|
| | |
|
| |
| |
| |
| | |
cherry-picked from creator's b3ec859c80bd0656cfc48cfe6514ec4f631b8206
|
| |
| |
| |
| | |
cherry-pick 28dacdfdf3eed04ec47a1e8eb206bd3ffb979c08 from creator
|
| |
| |
| |
| |
| | |
Task-number: none
Reviewed-by: --global
|
|/
|
|
|
| |
Task-number: none
Reviewed-by: --global
|
|
|
|
|
| |
Task-number: none
Reviewed-by: --global
|
|
|
|
|
|
|
|
|
| |
The eclipse integration is namespaced, but it pulls in system plugins like the
oxygen style. This breaks as the (non-namespaced) style plugin does not find a
suitable QApplication instantiated (only a namespace one is there)
Reviewed-by: thiago
Task-number: 250185
|
|
|
|
|
|
|
| |
Removed dead code and simplified conditionals. This should not otherwise
change behavior or output of qmake in any way.
Reviewed-by: mariusSO
|
|
|
|
|
|
| |
... without having to change the parent process's environment.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
|
| |
And some indentation fixes in qmake itself.
Fixes indentation; TRUE => true; FALSE => false; #includes and #defines
cleanup; removes dead code; comments... and somewhere along the way
marked a function static.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
| |
Qt3 support prevented the tests from running on Mac Cocoa.
Also started some Spring cleaning (it's just around the corner!) and
applied some YAGNI :-)
Reviewed-by: NRC
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
|
|
| |
This is an untested bugfix -- comes solely from reading the code.
In QFile::copy's fallback implementation a (temporary) file is created
for block copying from the source file. When Qt is built without
temporary file support this doesn't seem to be deleted in case of an
error while block copying or renaming to the final destination.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
|
| |
QFile made no attempt to reset the file name on a rename. We now reset
the fileEngine's fileName if it was able to handle the rename.
Otherwise, we call setFileName, which will result in reallocation of the
fileEngine.
Task-number: 244485
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
| |
The fallback implementation for rename would return true in some
situations where the move failed. Also the destination file might be
created and left there in these cases.
Task-number: 244500
Reviewed-by: mariusSO
|
|
|
|
|
|
|
| |
When generating nmake makefiles, the same inference rules were
generated several times.
Reviewed-by: mariusSO
|
| |
|
|
|
|
| |
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
|
|
|
|
|
|
|
|
|
|
| |
This makes sure that style sheets set both ButtonText and WindowText roles
for all widgets. This fixes among other things the fact that you could not
configure text colors for combo box popups on Mac, Gtk and CleanLooks or
set the background for the whole scrollbar.
Task-number: 160713
Reviewed-by: ogoffart
|