| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
We could do it or we couldn't. It's simply a judgement call and I think
the comments in the task are a good argument for NOT doing it.
Task-number: 227875
|
|
|
|
|
|
|
|
|
|
|
|
| |
The style was assuming that the combo box is painted at (0,0). This is
not the case when the painting is done in the delegate of an item view.
The offset of the rect is now taken into account to paint the style.
HIRect has been replaced by QRect when it make sense.
Task-number: 00026815
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
|
|
| |
The function hitTestComplexControl() of the mac style returned
SC_ComboBoxArrow when the point is not over an element of the widget.
Task-number: 252857
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
|
|
|
| |
A QPushButton with a height if (say) three pixels would cause
HIThemeGetButtonContentBounds ot return a rect with dimentions
{int_min, int_min, 0, 0}. Detect that case and return the button
rect instead.
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
| |
The magic number 22 was based on windows sized icons, a size of 16
should be correct for mac
Task-number: 259289
Reviewed-by: NRC
|
|
|
|
|
|
|
|
| |
That should fix compilation on platforms that do not have xinput
headers installed.
Reviewed-by: Thiago Macieira
(cherry picked from commit 0a13188468997d6c3253db5b29f05a119945f131)
|
|
|
|
| |
Reviewed-by: Leo
|
|
|
|
|
| |
Reviewed-By: mauricek
Reviewed-By: thartman
|
|
|
|
|
|
|
|
| |
This test created a widget at position (0,0) and grabbed the screen.
That's a bad idea on Windows mobile because the upper task bar will
cover the widget.
Reviewed-by: thartman
|
|
|
|
|
|
|
|
| |
The widget must be created before calling QInputContext::setFocusWidget.
Otherwise we run into an assertion. Yes, this only occurs in debug
configuration but its still annoying...
Reviewed-by: thartman
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
Code is adapted from QCommonStyle which handles this case for other
styles.
Reviewed-by: thartman
|
|
|
|
|
|
|
|
| |
This function was too strict. It returned 0 if the property wasn't of
type QVariant::Double. Now it tests for QMetaType::Float too.
Reviewed-by: kh1
Reviewed-by: mauricek
|
|
|
|
|
|
|
|
| |
Widgets with the WA_DontShowOnScreen attribute must not have a window
decoration.
Autotest: tst_QWidget::initialPosForDontShowOnScreenWidgets
Reviewed-by: thartman
|
|
|
|
|
| |
Make sure the testcase and directory name are the same
(excluding `tst_').
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
|
| |
This reverts commit 6844dea0cb583a86bc72e7f008720ab76deef040.
added to wrong branch. should be in 4.6 but this was added to 4.5
|
|
|
|
|
|
|
|
|
|
|
| |
calendar popup
A frame was always drawn around the QDateTimeEdit editor if a popup
calendar had been set. QStyleOptionsComboBox options are being set in
paintEvent and initialised from the properties of QStyleOptionsSpinBox but
were missing the frame bool property. Now, if the user sets a frame on the
QDateTimeEdit, this property will be consistent with setFrame() property
of the QDateTimeEdit widget.
|
|
|
|
| |
Task-number: 259482
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
| |
After the coverity fix, the proper code path executed, which failed to
enquote the date field properly, so this fix fixes that issue.
|
|
|
|
| |
Found by coverity.
|
| |
|
|
|
|
| |
Genarated->generated
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using streaming, it could happen that the last reference to the
MediaSource is in another thread. So the objects are destroyed from
another thread. In which case we would delete QObject (ioDevice) in
another thread. That is fixed by calling deleteLater which will ensure
that they are deleted in their own thread.
Note: there was a nother assert that could happen due to a race
condition in the worker thread. That is also fixed with this patch.
Reviewed-by: jbache
|
|
|
|
|
|
| |
Kramer is no longer accessible from the pulse test system
Reviewed-by: jesperht
|
|
|
|
|
|
|
| |
Also, the info() function was modified to use an assert rather than an
pointer check with an if to make it consistent with the rest of the file.
Reviewed-by: jesperht
|
| |
|
|
|
|
|
|
|
| |
See 3ae2cab9c8bd1790a00da2755ac036143a3a35f4 for another similar fix.
Reviewed-by: Trust Me
(cherry picked from commit 18fbfdf0f774198e2e1277e064cc3a8eb9dbb29d)
|
|
|
|
|
|
|
| |
"../shared/qm.cpp", line 556.45: 1540-0207 (S) No common type found for operands with type "const char [7]" and "QByteArray".
Reviewed-by: Trust Me
(cherry picked from commit 3ae2cab9c8bd1790a00da2755ac036143a3a35f4)
|
|
|
|
| |
(cherry picked from commit cb64ac587249f5dc6563a035e2ef5a3ad2bc5d13)
|
|
|
|
|
|
|
|
| |
It was reported to be auto-detected, but wasn't. Apparently, AIX 6's
X11 doesn't have this.
Reviewed-By: Denis Dzyubenko <denis.dzyubenko@nokia.com>
(cherry picked from commit 0a63875d787e1b035ace2c76fa1d0de6329127d7)
|
|
|
|
|
|
| |
This is a vulnerability in some implementations. Qt isn't affected
because... well, we never implemented the decoding of escape sequences
:-)
|
|
|
|
|
| |
Task-number: 239108
Reviewed-by: Andy Shaw
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QTemporaryFile on Windows doesn't open the file as a sharable, and
doens't close the file when you call .close(). So the testcase
fails on Windows with a Sharing Violation when the compiler tries
to compile the file.
By switching to QFile we can at least close the file before letting
the compiler chew on it, and remove it at the end when the testcase
is done. Open the file with Truncate, in case the testcase fails to
remove the file.
Reviewed-by: trustme
|
|
|
|
|
|
|
| |
Task-number: 259143
Merge-request: 1119
Reviewed-by: Denis Dzyubenko <denis.dzyubenko@nokia.com>
|
| |
|
|
|
|
|
|
|
|
| |
On mac, we prefer testing with mp3 rather than ogg, Because in the latter
case, you must install perian to make it work. And the test machines
dont.
Reviewed-by: brad
|
| |
|
|
|
|
|
|
|
|
| |
The test was failing because the goal of the test expect to get only
directories displayed. But if you don't have some in the current dir
then it fails. home dir should be enough.
Reviewed-by:TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an autotest fails to compile, there's no way to determine which
testcase(s) have been prevented from running.
Our results parsing tools have been guessing, under the assumption that
a directory called `qdogwalker' always contains a testcase named
`tst_qdogwalker'. That wasn't true for all our tests, so let's make it
true.
Also changed the platform-specific tests so that qmake will simply skip
those tests on unsupported platforms, instead of wasting time compiling
a useless QTEST_NOOP_MAIN test.
|
|
|
|
|
|
|
|
|
|
| |
The HideNameFilterDetails was not taken in account for windows
file dialog. This patch fix that. For Windows Vista and later we use
now the new COMMON_ITEM_DIALOG API (in master) where it add always
the filter extension like *.txt so no point to take that flag in account.
Task-number: None, during testing
Reviewed-by: prasanth
|