| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Using a OK/Cancel message box is weird for a yes/no question, esp. on a
Windows CE device where such a message box doesn't have real push
buttons but must be OK'ed / cancelled via system buttons in the title
bar.
Task-number: 255112
Reviewed-by: thartman
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was quite a bug and it showed to some issues that I hadn't taken
into account when doing the initial port to Cocoa. The issue was that we
weren't "merging" items into the application menu if an item had already
been associated with it. Which seems OK for applications that create one
window with one menubar, but breaks down horrible when you have multiple
windows with each having their own menubar. The result is that items in
the application menu potentially go to the wrong window (and the
potential crash). Since there can only ever be one "Quit", "About", or
"Preferences" menu item in Cocoa, we need to make sure that we keep
these items in sync whenever we switch the menubar or remove actions
that are being deleted. That's what we do here.
FWIW, QActions with "ApplicationSpecificRole" for their menu role have
potential to cause memory leaks or other bugs if abused. If you are a
happy open source hacker who wants a thankless job, solving them would
get you lots of goodwill in my book.
Task-number: 255038
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a problem where qmake would not compile when it was built
from it's .pro file because this method uses the pre-compiled header.
This header was causing a compile error in qlocale.cpp because
qtextstream.h was included and this includes qlocale.h. The problem in
qlocale.cpp was that it uses a define called QLOCALE_CPP to enable
extra functions in the class declaration, but the pre-compiled header
was preventing the qlocale.h from being re-processed and therefore the
function was never compiled in.
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
|
| |
The blend functions assume the width / height of the images being
blended to be greater than 0. A width of 0 caused the first iteration of
a duff's device memcpy (QT_MEMCPY_USHORT) to be executed, thus blending
8 pixels instead of none.
BT: yes
Task-number: 255014
Reviewed-by: Trond
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
The BOM was created correctly, but half of the BOM was then overwritten
by the converted data afterwards.
Also made the autotest also do reverse encoding tests where possible.
Task-number: 255095
Reviewed-by: lars
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tick timer is always active, even if the moving gree Qt logo is not visible.
But the code that is supposed to pause it when the app loose the focus doesn't works if
the moving Qt logo is not visible.
Also the call to syncX makes Xorg takes lot of cpu.
It doesn't fix the fact that the timer is still running while the green logo is not visible,
but at least doesn't take the cpu anymore if qtdemo loose the focus.
Task-number: 255020
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
| |
Reviewed-By: TrustMe
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
otherwise PeekNamedPipe() may block in threaded environments.
Reviewed-by: thiago
|
|
|
|
| |
Reviewed-by: Kavindra Palaraja
|
|
|
|
| |
Reviewed-By: TrustMe
|
|
|
|
| |
Reviewed-by: mauricek
|
|
|
|
|
|
|
|
| |
The R and B channels were swapped on little endian machines with
BGR layout.
Task-number: 254934
Reviewed-by: Samuel
|
| |
|
| |
|
|
|
|
|
|
|
| |
The example SVG must be deployed on Windows CE devices to be used.
Reviewed-by: mauricek
BT: yes
|
|
|
|
|
|
|
|
|
|
|
|
| |
both visible and invisible widgets.
This is a quick hack to avoid a crash in Qt when setting a focus on a
visible widget that has invisible parent. Proper fix was committed
into master 1a7da7096bbda17197738061902f4489af234bc0, see it's
description for more details.
Task-number: 254563
Reviewed-by: Thierry Bastian
|
|
|
|
|
|
|
|
|
|
|
| |
QFont has a feature that you can pass a comma-separated list and it will
walk through the list and match the font that it hits first. There's a
nice static function that X11 and Windows uses, but the Mac was using an
older copied version of it. This old version didn't handle quoting which
is what happens in the style sheet. So, using the same code makes
everything work well. As a bonus, Creator looks correct again.
Reviewed-by: Simon Hausmann
|
|
|
|
| |
QFont() returns the app font, not an invalid font.
|
|
|
|
|
|
| |
- When changing the aspect ratio, the video wouldn't update.
- The VMR9 can in some cases try to manage the aspect ratio itself
and then fights our system. This is now disabled.
|
|
|
|
|
|
|
| |
This won't leak on error case, and will work with arbitrary sizes.
Also changed from int to short as instructed by Samuel.
Reviewed-by: Samuel <qt-info@nokia.com>
|
| |
|
| |
|
|
|
|
|
|
|
| |
preserve some consistency. Also added a screenshot of the Object
Insepector displaying a form where its widget has no top level layout.
Reviewed-By: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mac, a widget with a NoFocus policy could still get focus
(if only temporarily) as the result of a native focus event.
In particular, a line edit with a completer should
not lose focus (if only for a brief moment) as a result of the
completer popup being shown. This will for example cause an
item delegate to think that the user has navigated away from
the cell and delete the line edit as a result. This will in turn
cause the completer to access a null pointer.
Reviewed-by: Richard Moe Gustavsen
Task-number: 254456 and 254460
|
| |
|
|
|
|
|
| |
KDE Bug: https://bugs.kde.org/show_bug.cgi?id=191759
Reviewed-by: Bradley T. Hughes
|
|
|
|
| |
Better late than never.
|
|
|
|
|
|
| |
The batch-blits buys us nothing and this is much more readable.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cherry-pick of 548da9a5434d615456a7a6efda3380b7138c6000 and some
earlier changes predating public repo.
Note that this test is not failing if using Qt 4.5 only.
However, it fails if using Qt 4.5 selftests against Qt master testlib.
We want to be able to use master testlib to run 4.5 testcases,
and this change does no harm when using Qt 4.5 testlib, so backport
it to 4.5 for convenience.
Original change description follows:
A few tests use printf, which means they interfere with the XML test
logging. Blacklist them for the XML test.
Note that these tests happened to pass under the old test logger
implementation. That was because the test logger always printed XML
tags on a single line, and the printf calls contained no special XML
characters. The test logs generated were technically valid XML but
contained extraneous text.
|
|
|
|
|
|
|
|
| |
DirectFB and Qt treats these things rather differently so the mapping
just doesn't work very well. Only use DirectFB for SourceOver stuff
(which is the default mode anyway)
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
| |
Reviewed-by: David Boddie
|
| |
|
|
|
|
|
|
|
|
| |
The new glyph cache may return null images for e.g. space characters.
Task-number: 253468
Reviewed-by: Samuel
BT: yes
|
|
|
|
|
|
|
|
|
|
| |
Only the Solution Generator was using the fixFilename() function, so
under some circumstances the solution filename wouldn't find the
correct vcproj file to include. This created a problem with
network-chat.vcproj.
Task-number: 254772
Reviewed-by: joao
|
|
|
|
|
|
| |
Task-number: 254451
Reviewed-by: trustme
BT: yes
|
|
|
|
|
|
| |
Task-number: 254451
Reviewed-by: eskil
BT: yes
|
|
|
|
|
|
|
|
|
|
| |
in atomic operations, we declare Interlock... functions in the namespace
That can confuse the compiler because they are also declared in another
header outside the namespace.
Same problem in clucene where we include windows.h from within the NS.
Task-number: 254214
Reviewed-by: ogoffart
|
|
|
|
|
| |
Task-number: 254549
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: TrustMe
|