| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In certain uncommon situations, where different Qt versions are used
on the same system, the plugin caching optimization may identify a dll
as a valid plugin, even though it will later fail to load. This fix
will avoid that Qt repeatdly tries to reopen such dlls, something
which caused a significant performance hit in these cases. E.g. where
Qt would unsuccessfully try to load a number of KDE image format plugins
for every image loading operation.
Task-number: QTBUG-10066
Reviewed-by: thiago
Reviewed-by: janarve
|
|
|
|
|
|
|
| |
This fix is needed since windows uses case insensitive filesystems.
Reviewed-by: Joao
Task-number: QTBUG-10305
|
|
|
|
|
|
|
|
|
|
| |
Function converting from QVariant to QScriptValue is smart and tries
to unwrap a value. So QVariant(1234) after conversion will be equal
to QScriptValue(1234). It is ok, but QVariant(QVariant(...)) should be
unpacked only once.
Reviewed-by: Kent Hansen
Task-number: QTBUG-10315
|
|
|
|
|
|
|
| |
Auto-test included
Reviewed-by: Olivier
Task-number: QTBUG-10491
|
|
|
|
|
|
|
|
|
|
| |
We dont use the WS_POPUP style when one of the following window flags
are set (WindowSystemMenuHint, WindowTitleHint, WindowMinMaxButtonsHint
WindowCloseButtonHint, WindowContextHelpButtonHint). None of these flags
can conflict with this style, hence being removed.
Task-number: QTBUG-10589
Reviewed-by: Denis
|
|
|
|
|
|
|
| |
The problem was that the internal state of the tree was not correctly
reset. Patch comes from the task.
Task-number: QTBUG-10850
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes two issues.
- The indeterminate animation was sometimes incorrectly disabled
when value was 0
- The progress animation was incorrectly stopped when progress
bars were disabled
Task-number: QTBUG-10957
Reviewed-by: richard
|
|
|
|
|
|
|
|
|
| |
QLibrary::isLibrary() returns true for files with the sufix .bundle.
But we did not use to determine the proper library within the bundle
in that case.
Reviewed-by: Fabien Freling
Task-number: QTBUG-11217
|
|
|
|
|
|
|
|
| |
This is mainly done by reverting the commit
04e34fe3aecca482abeeabe2e31778e9102eeb08
Task-number: QTBUG-11518
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
|
|
| |
Because of the time zone change we get an "overflow" in the min and max time.
For example min 00:00:00 becomes 01:00:00 and max 23:59:59 becomes 00:59:59
which is an invalid time span and the displayed time gets fixed to the newly
set min/max value.
Autotest included.
Task-number: QTBUG-12384
Reviewed-by: Gabriel
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason is that cocoa expects the unicode control character for
"enter", rather than the glyph showing an arrow. So rather than
using the glyph-table from QKeySequence, we should use a table
containing a mapping from Qt::Key to Cocoa control key. Luckily,
such a table exists allready in qt_cocoa_helpers, but reversed (
cocoa key to Qt::Key). So this patch creates a function that
binds all this together.
Reviewed-by: cduclos
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating the native key sequences for menu items, Qt prefers the
non private unicode characters. But the characters in the NSEvent for
keyboard events can contain characters form the unicode range reserved
for Apple.
For e.g. when user presses the "delete" key, the event contains
NSDeleteFunctionKey, where in Qt is expecting NSDeleteCharacter. For now
this is the only key identified for translation. If we find similar
translations, those can be added to qt_mac_removePrivateUnicode().
Task-number: QTBUG-12495
Reviewed-by: Denis
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Libraries on Windows 7 are user-defined collection of folders, which
is only a logical representation. There are no file system entries
associated with it .
This patch makes sure that user cannot choose a library when using the
QFileDialog::getExistingDirectory(), in such cases it will show a
standard windows warning message.
Task-number: QTBUG-12655
Reviewed-by: Thierry Bastian
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to the c++ specificaiton, 3.9.1 [basic.fundamentals]
Plain char, signed char, and unsigned char are three distinct types
In QMetaType, I decide that 'signed char' alias with 'char'
This allow qint8 to work nice (and which is already registered as
an alias to char (QMetaType::Char)
Reviewed-by: Joao
Task-number: QTBUG-12920
|
|
|
|
|
| |
Task-number: QTBUG-13055
Reviewed-by: Markus Goetz
|
|
|
|
|
| |
Task-number: QTBUG-13055
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
|
|
|
| |
Setting the QTextOption::SuppressColors tag on a QTextDocument
breaks all text format, not just colors. This patch fix this by
selectively ignoring color properties in the format and keeping
other properties.
Task-number: QTBUG-13090
Reviewed-by: Eskil
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, if QSqlField's QVariant value had type "invalid", this
caused the field to be omitted in data-changing SQL statements generated
from QSqlRecord edit buffers.
Complaints against this mechanism:
- It precludes initializing value type to field type, which would
otherwise seem sensible and useful, such as when using model.data() in
contexts where the field type is not readily available.
- QSqlField::clear() does initialize value type to match field type and
so is incompatible with this mechanism.
- Problems such as described in QTBUG-13211.
- Unwanted distinction between "invalid" and "null" when mapping field
values to SQL values.
- QSqlField's generated flag already provides a mechanism for
controlling SQL generation.
These complaints are redressed here by replacing this mechanism with
reliance on QSqlField's generated flag. The flag is initialized to false
in new edit records and set to true when a value is set. Applications
can still manipulate generated flags directly to control SQL generation.
Generation of SELECT statements already used the generated flag and is
unaffected by this change.
Merge-request: 1114
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
Reviewed-by: Michael Goddard
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Qt clobbers the cache-control headers set by WebCore when
CacheLoadControlAttribute == QNetworkRequest::AlwaysNetwork.
This causes at least one QtWebKit layout test to fail:
http/tests/misc/refresh-headers.php
Qt needs to detect if the client has already made a cache-control
decision in the headers before overwriting them.
See https://bugs.webkit.org/show_bug.cgi?id=45598
Task-Number: QTBUG-13564
Merge-request: 2472
Reviewed-by: Markus Goetz <Markus.Goetz@nokia.com>
|
|
|
|
|
| |
Task-number: QTBUG-13593
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. The opentype init feature was applied to some characters
even when the character appeared inside a word.
2. Using the ZWJ to separate Ra and Halant Ya should connect
the two latter characters and form a Yaphala
3. Some Oriya chars were not correctly marked as below-base
form.
Task-number: QTBUG-13620, QTBUG-13616, QTBUG-13542
Merge-request: 2484
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
|
|
|
|
|
|
|
| |
This is how dialogs work natively on Mac; you can choose the
"Don't Save" button by using the shortcut "Cmd-D"
Rev-By: jbache
|
|
|
|
|
|
|
|
|
|
|
| |
When handling control characters (ZWJ, ZWNJ) in Indic syllables,
we only moved glyphs and attributes of the item, advances should
also be moved forward, otherwise we will use the advance of ZWJ/
ZWNJ for the part of syllable, which is normally zero, it results
some positioning problems.
Task-number: QTBUG-14204
Reviewed-by: Lars Knoll
|
|
|
|
|
|
|
|
|
|
|
| |
So that they will match the family names returned by
QFontDatabase::families. Because the family names returned
by FcFreeTypeQueryFace are not sorted with locale as the
names returned by FcFontList, we have to find out the
family name matching the system language in the former case.
Task-number: QTBUG-14269
Reviewed-by: Eskil
|
|
|
|
|
|
|
|
|
|
| |
If you have set the edit triggers to AnyKeyPressed and you press a key
the completer would not kick in because the key event would come before
the lineedit gets focus. The completer is only active when the lineedit
has focus.
Task-number: QTBUG14363
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
| |
This reverts commit d91a8f3a5dbcf3e4c4c0afb28463b25e192b00e4
and introduces a minimal fix for the original crash report.
Task-number: QTBUG-21433
Reviewed-by: gabriel
|
|
|
|
|
|
|
|
| |
The problem is that the layout code was called recursively because
the visibility of the scroll bars was constently changed.
Task-Number: QTBUG-14412
Reviewed-By: ogoffart
|
|
|
|
|
|
|
|
|
|
| |
as POSIX man says, if semop() is interrupted by a signal,
it shall return -1 and set errno to EINTR.
in qcore_unix_p.h, we have EINTR_LOOP helper macro exactly for such cases ;)
Task-number: QTBUG-14434
Merge-request: 998
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When GSource prepare or check functions return TRUE, Glib does not
necessary call the dispatch function immediatelly (probably depends
on the ordering of processing events). This means that
timerSourceDispatch() may get called from different call of
QEventDispatcherGlib::processEvents() than its accompanying
timerSourcePrepareHelper() or timerSourceCheckHelper().
This is a problem if a timer becomes pending during a normal
processEvents() call but will only be executed during a call
to processEvents() with QEventLoop::X11ExcludeTimers. The attached
patch fixes this problem by rescheduling the timer for another pass.
As for a testcase, this happens when making LibreOffice's KDE
integration use Qt event loop, requires setting the useEventLoop
property on the QClipboard object, so I'm afraid I don't have anything
simple. But fact that Glib can keep an event pending for a little
moment is rather obvious from its sources or can be triggered
from any Qt application, and I hope the rest is an obvious consequence.
Merge-request: 2492
Reviewed-by: Olivier Goffart <olivier.goffart@nokia.com>
|
| |
|
|
|
|
|
| |
Task-number: QTBUG-14807
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
|
| |
qScriptValueFromValue_helper() (or rather,
QScriptEnginePrivate::create()) will fall back to wrapping the
value using newVariant(), so there is no reason for the QVariant
specialization to check the return value. (In particular, if
the return value was invalid, that's _because_ the engine was
null, so we should definitely not call a function on the engine.)
Task-number: QTBUG-14842
Reviewed-by: Jedrzej Nowacki
|
|
|
|
|
|
|
|
|
| |
The socket will not close as long as there are bytes left to write.
So by deleting the pipeWriter bytesToTrite will be 0 and the socket
will close directly.
Task-number: QTBUG-14939
Reviewed-by: Joerg Bornemann
|
|
|
|
|
|
|
|
|
|
|
|
| |
QThread::quit() is threadsafe, and can safely (and should) be called
from the parent thread.
Using invokeMethod requires an instance of QCoreApplication. There
is no reason we should depend on that.
Task-number: QTBUG-15255
Task-number: QT-3305
Reviewed-by: Denis
Reviewed-by: Brad
|
|
|
|
|
| |
Task-number: QTBUG-15504
Reviewed-by: Trust-Me
|
|
|
|
|
|
|
| |
Make sure that waitForReadyRead times out if the read buffer is full.
Task-number: QTBUG-16123
Reviewed-by: Peter Hartmann
|
|
|
|
|
|
| |
The transformIsSimple was a bit to restrictive
Reviewed-by: bnilsen
|
|
|
|
| |
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
| |
Task-number: QTBUG-16262
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
| |
it is initially shown maximized.
Task-number: QTBUG-14517
|
|
|
|
|
|
|
|
|
|
|
| |
Following our kill list of moving away from XLFD, and since
the result of XLFD is unreliable and problematic (it requires
maintainence of fonts.dir/fonts.alias which people no longer
care about), remove the usage of XLFD as a fallback for fontconfig
matching.
Task-number: QTBUG-17455
Reviewed-by: Eskil
|
|
|
|
|
|
|
|
|
| |
Selected range is the range of the text that has been edited with
input method, but not yet committed, normally the cursor should be
placed that the end of it (or hidden).
Task-number: QTBUG-17923
Reviewed-by: Morten Sørvig
|
|
|
|
|
| |
Task-number: QTBUG-18149
Reviewed-by: Morten Sorvig
|
|
|
|
|
| |
Merge-request: 1149
Reviewed-by: Zeno Albisser <zeno.albisser@nokia.com>
|
|
|
|
|
| |
Merge-request: 1149
Reviewed-by: Zeno Albisser <zeno.albisser@nokia.com>
|
|
|
|
|
|
|
| |
Fixes QTBUG-18290 and the "missing Z" from QTBUG-9698
Merge-request: 1149
Reviewed-by: Zeno Albisser <zeno.albisser@nokia.com>
|
|
|
|
|
|
|
|
|
|
| |
We should follow
http://tools.ietf.org/html/draft-ietf-httpstate-cookie-23 , which says
parse the value until reaching the next ';' or the end of the line.
Other cookie implementations allow spaces in unquoted values as well.
Reviewed-by: Martin Petersson
Task-number: QTBUG-18876
|
|
|
|
|
|
|
| |
Regression from 4.5 causing performance and size degradation.
Task-number: QTBUG-18997
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
|
|
|
| |
If we give the exact initial QMimeData to the dropEvent, we only get
application/x-qt-image as available mimeType. We need to go through QDropData
to call xdndObtainData, which can still do some in-process optimization,
but there we can do the "saving QImage to the requested format" conversion.
Task-number: QTBUG-4110
Merge-request: 860
Reviewed-by: Denis Dzyubenko <denis.dzyubenko@nokia.com>
|
|
|
|
|
|
|
|
|
| |
Otherwise directories cannot be deleted as long as they are watched,
since the fileInfoGatherer keeps a QFileInfo object with open file
handles.
Reviewed-by: Joao
Task-number: QTBUG-8241
|