| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with QDBusInterface.
The problem was that I didn't know how to implement the operator= for
all types. But it turns out that this was possible all along: the only
types I have to implement the operator= for are the basic types, which
are already demarshalled.
The complex types are left in QDBusArgument semi-demarshalling, but we
have QDBusMetaType::demarshall, which takes a void* to an
already-constructed type and demarshalls into it. That's exactly what
the doctor ordered.
Task-number: 206765
Reviewed-By: Marius Bugge Monsen
|
|
|
|
|
|
|
|
| |
QDBusAbstractInterface.
They're now good enough and as fast.
Reviewed-By: Marius Bugge Monsen
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works for the case of complex types that have to be demarshalled.
We don't need to instantiate a new type because QMetaProperty has already
done that for us.
Also, fix the handling of properties of type variant. I have verified
as well that the sending of those properties on the wire use a
double-variant encoding (i.e., a variant containing a variant
containing some data, the same that Qt 4.5 uses). It's a bit pedantic
and it's hard to use when reading stuff, because you get a QVariant
containing a QDBusVariant which contains data, but I can't change this
anymore.
Reviewed-By: Marius Bugge Monsen
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
The current code allows making calls to QDBusInterface objects that
failed to introspect. It's technically a valid condition. You won't be
able to connect to signals, get or set properties, but making calls
was possible.
I don't know if I want to keep this change in behaviour.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Complex properties require demarshalling before passing on to
QMetaProperty::write(). We can't pass on a QVariant containing an
un-demarshalled QDBusArgument.
So add a new function that does the decoding properly, as well as
error checking.
Also take the opportunity to properly check the interface name in the
case of setting a property exported from the object itself (not an
adaptor).
Task-number: 240608
Reviewed-by: Marius Bugge Monsen
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When calling qt_metacall with the ReadProperty or WriteProperty, the
data is on argv[0] like it was before, but now the QVariant itself is
on argv[1] and there's an extra parameter in argv[2] which the meta
code can use to indicate result.
This allows QtDBus to process properties much more easily. In the case
of property reading, we need to be able to modify the variant itself,
because copying types when we don't have the data isn't very easy.
As for setting, we need to be able to tell setProperty to return true
or false depending on whether we succeeded in setting the property or
not.
Reviewed-By: Kent Hansen
Reviewed-By: Marius Bugge Monsen
|
|
|
|
|
|
|
|
|
|
|
| |
This is a small performance improvement when making a call: we don't
need to validate what we already know to be valid because we either
designed it to be so or because we've already validated.
The D-Bus library unfortunately validates again and there's nothing we
can do about it. But we can avoid doing it twice in our own code.
Reviewed-By: Marius Bugge Monsen
|
|
|
|
|
|
|
|
|
|
|
| |
In case the object creation fails, set isValid to false. This will
prevent any outgoing calls to be made with invalid information. In
that case, lastError will never change either.
This required adding a method to QDBusPendingCall, to be able to
create one such object from an existing QDBusError.
Reviewed-By: Marius Bugge Monsen
|
|
|
|
|
|
| |
marshalling code.
Reviewed-By: Harald Fernengel
|
|
|
|
| |
Reviewed-By: Harald Fernengel
|
|
|
|
|
|
|
| |
These tests are useful in QDBusMessage and QDBusAbstractInterface. It
avoids having the same messages all over the place.
Reviewed-By: Harald Fernengel
|
|
|
|
|
|
|
| |
I'm wondering if I should be adding com.trolltech.QtDBus stuff
now. But since there's already one there, I don't see why not...
Reviewed-By: Harald Fernengel
|
|
|
|
|
|
|
| |
Also reorganise a bit, moving the function to create the interface
name from an object's class name to qdbusmisc.cpp too.
Reviewed-By: Trust Me
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Added documentation about the create_prl and link_prl to the CONFIG variable in the qmake manual
Task-number: 165165
Rev-by: Geir Vattekar
Rev-by: Volker Hilsheimer
|
|
|
|
|
| |
Tinyint only supports 0-255, so mark it as unsigned despite sign flag,
which have the time is inverted/wrong.
|
| |
|
|
|
|
|
|
| |
This ifdef was simply in the wrong place.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
| |
Also. Make sure to call QRasterPaintEngine::end()
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
| |
Move the code from QDirectFBPaintEnginePrivate::(end|begin) into
QDirectFBPaintEngine::(end|begin)
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: kh
|
| |
|
|
|
|
|
|
|
|
| |
Noticed while looking into task 256903, since in case there are no
recent shown pages,we would start Assistant only showning the search.
Task-number: 256903
Reviewed-by: kh
|
|
|
|
|
|
| |
Clearifying details on a warning about a function call (setValue())
Task-number: qtp 4.5Workarea
|
|
|
|
| |
Reviewed-by: trustme
|
|
|
|
|
|
| |
Correcting typos
Task-number: 257225
|
|
|
|
|
|
|
| |
This is related to the following fix:
70137e0601549af1056082cdfbb4f141c70befab
Reviewed-by: trustme
|
|
|
|
|
|
|
| |
Also made sure that the generated code will not have trailing
whitespaces.
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
|
|
|
| |
Reviewed-by: kh <qtc-committer@nokia.com>
|
| |
|
|
|
|
|
|
|
| |
resulted in wrong choice of unique properties for characters 451-45f.
Reviewed-By: Thiago Macieira <thiago.macieira@nokia.com>
Reviewed-By: Denis Dzyubenko <denis.dzyubenko@nokia.com>
|
|
|
|
|
|
| |
- as was not the case for the psqlODBC driver
Reviewed-by: Bill King
|
|
|
|
| |
Task-number: 218935
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was a bug in the Carbon code when an item went in full-screen,
than out with a unified toolbar. In those cases the toolbars would end
up getting but into the mainwindow area. The reason this was happening
was that we were calling transferChildren() after we had set up our
toolbar. This cause problems because we end up pulling the QToolbars
right out of the unified toolbar. The easiest way to solve this is to
just update the status on it again. This should solve any issues. I also
added some logic to avoid calling this too many times in that one case.
Luckily, this seems to only affect Carbon.
Task-number: 254462
Reviewed-by: Jens Bache-Wiig
|
|
|
|
|
| |
Task-number: 253902
Reviewed-by: Thierry Bastian
|
|
|
|
|
| |
Task-number: 256762
Reviewed-by: TrustMe
|
|
|
|
|
| |
Task-number: 256818
Reviewed-by: Trenton Schulz
|
|
|
|
| |
Reviewed-by: mauricek
|
|
|
|
|
|
|
|
| |
Information on issues with the icc compiler has been moved in the docs.
Redirected links that still pointed to the old location.
Task-number: 257039
Reviewed-by: Morten Engvoldsen
|
| |
|
|
|
|
|
|
|
|
| |
The windowDidResize notification now differentiates an internally
triggered resize from a user triggered resize.
Task-number: 256269
Reviewed-by: Norwegian Rock Cat
|
| |
|
|
|
|
|
|
| |
The configuration option was not added to the Windows configure.
Reviewed-by: hjk
|
|
|
|
| |
Reviewed-by: Gareth Pethig
|
|
|
|
|
|
|
| |
- case for QVariant::Bool in switch statement was missing
Task-number: 215511
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
These variables are never used.
Reviewed-by: TrustMe
|