summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove Q_ASSERT's from QObject autotestJason McDonald2011-05-091-3/+6
| | | | | | | | | | Rather than aborting in debug builds and failing silently in release builds, report a fatal error in all builds if the helper class methods are called more than once. Change-Id: Id1fda8dc7caf008bbc8f6ae6384abee1aa8f50eb Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QObject autotestJason McDonald2011-05-091-3/+6
| | | | | | | | | Rather than aborting in debug builds and failing silently in release builds, report a meaningful fatal error in all builds. Change-Id: I3b874f187d482e9785a839cab1a3855b631404c3 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QNetworkReply autotestJason McDonald2011-05-091-2/+7
| | | | | | | | | Rather than aborting in debug builds and ignoring the failure in release builds, report a fatal error in all builds. Change-Id: I1fb8e692c65cf23cf5d2453173db742260ddca48 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qitemmodel autotestJason McDonald2011-05-091-7/+22
| | | | | | | | | Don't perform actions needed for the test inside Q_ASSERT, because these actions won't happen in a non-debug build. Change-Id: I0758e9f29f38c1a83a1501357286877f05beb6c8 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QMutex autotestJason McDonald2011-05-061-4/+7
| | | | | | | | | | Don't perform actions needed for the test inside Q_ASSERT, because these actions won't happen in a non-debug build. Instead count the number of failures and verify that the count is zero at the end of the test. Change-Id: Ibe0d194111e5247118d59a7760f0946d2c44faf9 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from QMetaType autotestJason McDonald2011-05-061-1/+10
| | | | | | | | | | Replace Q_ASSERT in helper class with code to count failures and report meaningful warnings. The test function then fails the test if any failures were recorded. Change-Id: I0d6650e6036c8e45729c16d1dbb7543b4fb42553 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's in qitemview autotestJason McDonald2011-05-061-12/+53
| | | | | | | | | | Rather than aborting in debug builds and failing silently in release builds, report a meaningful warning message and return an appropriate value to indicate the error. Change-Id: I0ceb0a0bfaef34cc6127d768cc75ecfc5a24e3c9 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qitemmodel autotestJason McDonald2011-05-061-1/+1
| | | | | | | | | | If populateTestData() is passed an unknown type of model, report a meaningful fatal error rather than failing silently in a release build and aborting with an uninformative error message in a debug build. Change-Id: I7ee8d1262bbced304f9f24c2ec9b40a38704d982 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from algorithms autotestJason McDonald2011-05-061-1/+2
| | | | | | | | | Report a meaningful warning message rather than aborting in a debug build and failing silently in a release build. Change-Id: Ic77589143ff0d22c95c7b10f2e511f68b3da4d86 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qabstractxmlnodemodel testJason McDonald2011-05-061-2/+5
| | | | | | | | | | Instead of aborting in debug builds and failing silently in release builds, print a meaningful warning message into the test output and return a null QVariant. Change-Id: Idcd70f5cb01528b522d84e391f6f8692a189f420 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qabstractxmlnodemodel testJason McDonald2011-05-061-1/+4
| | | | | | | | | | | Rather than aborting in a debug build and failing silently in a release build, report a warning and return a null model index if the first (root) node of the model is not a document. The null return value will cause initTestCase() to fail gracefully. Change-Id: I15e9456929bbb3f0bd50d30333c49143b6f0aad7 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qabstractxmlnodemodel testJason McDonald2011-05-061-2/+4
| | | | | | | | | | Instead of aborting in a debug build and failing silently in a release build when the internal state of the model is incorrect, report a meaningful fatal error in all builds. Change-Id: I64ca4dde070cb7fbe69684a36092d53e5b84d80a Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qabstractxmlnodemodel testJason McDonald2011-05-061-2/+2
| | | | | | | | | | Constructing a model index from a null pointer will cause the test to crash later. Instead of crashing this way in a release build and aborting in a debug build, report the fatal error in all builds. Change-Id: I43ce4c8fa48caa05aaf09ac3c1453d35a2de65bf Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from qabstractfileengine testJason McDonald2011-05-061-4/+4
| | | | | | | | | | Rather than aborting in debug builds and failing silently in release builds, report a meaningful warning message and skip setting the filename, which should cause a subsequent test failure. Change-Id: I3ae4f4de7b02bf2194019047fa87d8ae06d95634 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from modeltestJason McDonald2011-05-061-10/+42
| | | | | | | | | | | | | | | Rather than aborting in debug builds and ignoring the failures in release builds, report specific warnings on each failure, count the failures, and fail the test if the failure counts are non-zero at the end of the test. The same change is also made for a QCOMPARE that appeared inappropriately inside a helper class. QCOMPARE may only appear directly in a test function. Change-Id: I81f0ce80512fa72c67f5aa72c0511a4b650d5d20 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from modeltestJason McDonald2011-05-061-1/+2
| | | | | | | | | | Report an informative fatal error if passed a null model, rather than aborting in a debug build and giving a bunch of signal connection errors in a release build. Change-Id: Ia240e741b9d6ec03fd5ed3a14cf4fa44b55af911 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qabstractxmlnodemodel testJason McDonald2011-05-061-1/+5
| | | | | | | | | | When no content can be loaded to create the model, return a null model (which will make the test fail gracefully) rather than aborting in a debug build and failing silently in a release build. Change-Id: I28f0bb92c617c8dafd1089d0b3dafcfef0c0da53 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from modeltestJason McDonald2011-05-061-3/+7
| | | | | | | | Report a fatal error in all builds, not just in debug builds. Change-Id: Ia9e265b2082b55fbac18ca046e586de863ac0623 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QAbstractFileEngine autotestJason McDonald2011-05-061-10/+39
| | | | | | | | | | | Rather than aborting in debug builds and ignoring failures in release builds, report meaningful warnings into the test output and return sentinel values that will cause QVERIFY/QCOMPARE of the returned values to fail the test. Change-Id: I2c5a820637337d0762c71db10a4f270d36b31662 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Fix compiler warnings in qabstractxmlnodemodel testJason McDonald2011-05-061-3/+2
| | | | | | | | The first parameter to qWarning() should be a format string to avoid problems caused by the data string containing format specifiers. Change-Id: Ib40c0dcd766203fc41182a50680733fff9035045 Reviewed-by: Rohan McGovern
* Fix compile error.Jason McDonald2011-05-051-2/+6
| | | | | | | | | The previous change to tst_qscriptv8testsuite.cpp introduced a compile error due to insufficient parameters to QTest::qVerify(). Change-Id: I9ea9462d830b9d796676947a3598e3c066b29180 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QTextEdit autotestJason McDonald2011-05-051-3/+3
| | | | | | | | | Convert Q_ASSERT to QCOMPARE and remove mention of Q_ASSERT in comments to make it easier to check for unwanted Q_ASSERT's in the future. Change-Id: I7ae250428d4d5682806e724a7207523e65cd9851 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from large file autotest.Jason McDonald2011-05-051-5/+0
| | | | | | | | These assertions were made obsolete by the previous change to this test. Change-Id: I3156b273a727f753a6c093c8fc7453b694c777ee Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from QMutex autotestJason McDonald2011-05-051-4/+14
| | | | | | | | | | Rather than aborting in debug mode and doing nothing in release mode when the invariant is violated, count the failures and fail the test gracefully. Change-Id: Ie193460c478ddde540b6b15aafdce32f471b4b2b Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qtesselator autotestJason McDonald2011-05-051-1/+3
| | | | | | | | | If the test data is incorrect, print a meaningful warning into the test output. Change-Id: Ibfe64ef41a0ff3eb47c2385d1c31191334a675a8 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from exceptionsafety_objects testJason McDonald2011-05-051-3/+6
| | | | | | | | Report a fatal error in all builds, not just in debug builds. Change-Id: Iad990e2d3b29a55e995254d466e967a4a722bb23 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT in gestures autotestJason McDonald2011-05-051-4/+12
| | | | | | | | | | Rather than aborting on a bad gesture event in debug builds and ignoring the error in release builds, record a count of bad events and fail the test if the count is non-zero at the end of the test function. Change-Id: I6ddd46a5a656185c13eae4bbbb496b986a0c92f6 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QTreeView autotestJason McDonald2011-05-041-5/+9
| | | | | | | | | Issue a meaningful fatal error in preference to aborting in debug mode builds and crashing in release mode builds. Change-Id: I7bb04e1e222fd6167be19b5d88caac27b43d88df Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qtesselator autotestJason McDonald2011-05-041-1/+2
| | | | | | | | | If the test data is incorrect, print a meaningful error message into the test output. Change-Id: I505a86b4411619d3c3be9541c96c082f92589ff7 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QScriptable autotestJason McDonald2011-05-041-6/+21
| | | | | | | | | | | | | The helper class expects a valid script engine to be available and attempted to verify this with Q_ASSERT (which does nothing in release mode) and QVERIFY (which should only be used directly in test functions). This commit makes the helper class avoid using an invalid engine and catches the problem later by verifying that the last script engine used by the scriptable class was valid. Change-Id: I849df32b141b7801b9b5a92f44ff325397e32f2d Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove mention of Q_ASSERT in QTableView test.Jason McDonald2011-05-041-2/+2
| | | | | | Change-Id: If27cb7031cdde222d1dd988188569dca4b1fb6d9 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QXmlStream autotest.Jason McDonald2011-05-041-3/+2
| | | | | | | | | Report a fatal error in all builds rather than only in debug mode builds. Change-Id: I6b3a999dd3ccf00ae66a86b43c125d7082cf0ae5 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qdeclarativexmllistmodel testJason McDonald2011-05-041-1/+4
| | | | | | | | | Report a meaningful warning in all builds rather than aborting in debug builds and doing nothing in release builds. Change-Id: I14aa7bc8699f5307e1ec34b18006b9fbbd8aca8e Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from ecmascript test.Jason McDonald2011-05-041-4/+0
| | | | | | | | | These Q_ASSERT's were redundant as the test functions that call these functions already verify that "value == 0". Change-Id: Ic23e539c5814153d67fea8156ade0783f91d7b83 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from xmlpatterns autotestJason McDonald2011-05-041-4/+4
| | | | | | | | | Verify initial state in initTestCase() rather than asserting in the test class's constructor. Change-Id: Ic7612a5368e35b2abda96828d2a95690baeaf6a9 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from qtestlib selftestsJason McDonald2011-05-041-3/+4
| | | | | | | | | Report a fatal error in all builds rather than just in debug mode builds. Change-Id: Ie54e55ea2dd13bbb12e4265278db832ac1297c28 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove unused code from QXmlStream autotestJason McDonald2011-05-041-15/+2
| | | | | Change-Id: I719e502ef14848a22d41de71245fe6b6758c8d6b Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qxmlsimplereader autotestJason McDonald2011-05-041-10/+14
| | | | | | | | | Verify the success of setting the document content in the test function rather than using Q_ASSERT. Change-Id: I25e017e7f92803867a998b4f09ad9f717212a9bc Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from QXmlInputSource autotestJason McDonald2011-05-041-3/+1
| | | | | | | | | Report a fatal error in all builds rather than aborting in debug mode builds only. Change-Id: I53b348f077c6533433e32bbebd159066a2bc2c37 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from QLibrary autotestJason McDonald2011-05-041-1/+1
| | | | | | | | | Report a regular test failure rather than aborting when an unknown operation is requested. Change-Id: I3678f42f9e9f895d8d0d49a768d4c8b575d1863f Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from QSharedPointer autotestJason McDonald2011-05-041-1/+2
| | | | | | | | | Report a meaningful fatal error instead of aborting in debug mode builds and failing silently in release mode builds. Change-Id: I0f939dc40810f072a3e24aeba085191793c49ef3 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from QThread autotestJason McDonald2011-05-041-1/+1
| | | | | | | | | Report a meaningful fatal error instead of aborting in debug mode builds and failing silently in release mode builds. Change-Id: If9a6c0655e021b3bb6b7d894aefd9bbcc58e4605 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QWizard autotestJason McDonald2011-05-041-10/+11
| | | | | | | | | | Combine the two checking functions (check and checkInvariant) and have the resulting check function return a bool instead of asserting so that the test function can QVERIFY and fail gracefully. Change-Id: Ib069b5424483ba6ffb9caf75036c4f325e9dba51 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove mention of Q_ASSERT in commentsJason McDonald2011-05-041-1/+1
| | | | | | | | This will make it easier to check for stray Q_ASSERT's in the future. Change-Id: I5ddafe1bf26819566460920deae8ff448008c93f Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from QVariant autotest.Jason McDonald2011-05-041-5/+8
| | | | | | | | | Print a meaningful warning message instead of aborting in debug mode builds and failing silently in release mode builds. Change-Id: I44143c5fbe6b6af87bdf5bd231cfaf9a3c9c33f8 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from QTextOdfWriter autotestJason McDonald2011-05-041-4/+7
| | | | | | | | | If the <dummy> tag can't be found in the data, return an empty string rather than asserting, so that the test fails gracefully. Change-Id: I536f08c9c3e942817680849d96d035999d4994db Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qtesselator autotestJason McDonald2011-05-041-2/+6
| | | | | | | | | | If the test data is incorrect, print a meaningful warning into the test output instead of deferencing an iterator beyond the last element in the list. Change-Id: I7be4f282639453de6d8240a2f17253025b415337 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from qsslsocket autotest.Jason McDonald2011-05-041-2/+2
| | | | | | | | | Make the server thread exit early if the socket is invalid. This will make the test fail gracefully instead of crashing. Change-Id: Ia9564c94dd32d65e6e9bdb4a2410f1512409546c Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT's from qsharedpointer autotestJason McDonald2011-05-041-4/+10
| | | | | | | | | Report a meaningful warning message into the test output rather than aborting in debug mode and doing nothing in release mode. Change-Id: I6883fccbce0139c763f36f6839bb3452d8f69c1c Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern
* Remove Q_ASSERT from V8 autotestJason McDonald2011-05-041-1/+1
| | | | | | | | | Replace Q_ASSERT with QTest::qVerify, in line with the rest of this test function. Change-Id: Ia39e62efb9945f72a6a93fddddf36488cd456965 Task-number: QTBUG-17582 Reviewed-by: Rohan McGovern