| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way we avoid having a lot of code in a static (and
unmaintainable) library. The s60main static library now currently has
only one task: to call main().
To move the initialization into QtGui also meant a change in how the
S60 framework is created, because we can no longer use the trick
where we create and start the the S60 event loop and then have the
framework call us back to start main(). The initialization now
follows the creation and destruction of QApplication, which is a lot
more in line with how other platforms do it.
Since S60 doesn't support creating the environment, and *then*
starting it (both are executed by the same call), we had to open up
the S60 framework construction classes and just mirror what they do.
This means that after QApplication construction is done, the S60
framework is initialized, but nothing will run yet and control will
return to main(), where the user can start the event loop himself.
One of the quirks of this approach is that the construction of the
S60 framework makes a new cleanup stack. This means that any active
traps will not be active anymore, and leaving without setting a new
trap will most likely panic. This shouldn't be a problem for us,
since Qt is never supposed to leave, but it means that if anyone uses
the cleanup stack without setting a new trap, they will receive a
panic.
It was considered to add a trap mark in QApplication construction and
then removing it on destruction, but it was dropped because leaving
from main() is still undefined (even if the old cleanup stack would
be restored in the destructor, we wouldn't be able to stop the
exception from unwinding the stack, and the cleanup stack would then
be unbalanced).
RevBy: Jason Barron
RevBy: Janne Anttila
AutoTest: QWidget passed with same failure count
|
|
|
|
|
|
| |
Conflicts:
src/s60main/qts60main.cpp
|
|
|
|
| |
Reviewed-by: hjk
|
|
|
|
|
|
|
|
|
|
| |
QVectorPath::hints() is not a strict bit field, and thus can not be
anded with RectangleHint. Instead, QVectorPath::shape() should be
directly compared with RectangleHint to check if the vector path is a
rectangle or not. In this case the first four points of a regular
painter path were treated as a rectangle with dire consequences.
Reviewed-by: Tom
|
|
|
|
|
|
|
| |
We now need to connect to the slot in the QLineControl and not to the
slot of the QLineEdit (the QLineEdit slot is now also removed).
Reviewed-by: Alan Alpert
|
|
|
|
| |
13 pairs missing...
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Why this happends is a bit blurry. From before, I know that
cocoa is a bit buggy regarding setting a menu item
hidden or not. The solution back then resulted in the function
syncNSMenuItemEnabled in qmenu_mac.mm. This patch basically
applies the same (silly) trick; disabling the menuitem before
enabling it. This seems to force an update to the menu items
enabled state. For the record: this is not a fix that I
embrace. I hope we can remove it again some day. See
task for how to reproduce.
Task: 259600
Rev-By: alexis
|
|
|
|
|
|
|
|
| |
Had left the cursor flash time as half the QApplication cursor flash
time by mistake. The new function sets the whole period and not just the
time between toggling cursor visibility.
Reviewed-by: Trust Me
|
|
|
|
|
|
|
| |
To prevent using IDirectFBImageProviders one can define
QT_NO_DIRECTFB_IMAGEPROVIDER
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
|
|
|
| |
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
|
|
|
|
|
|
|
| |
Some DFB implementations do not support rendering the cursor using the
intended interfaces. In these cases one can define
QT_DIRECTFB_WINDOW_AS_CURSOR and use a window to render the cursor.
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
If you define QT_DIRECTFB_IMAGEPROVIDER_KEEPALIVE we make sure atleast
one IDirectFBImageProvider is alive at all times.
Apparently this is refcounted by DirectFB on atleast one implementation
and there's considerable overhead involved when releasing the
last/creating the first image provider.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
Reimplement QPixmapData::fromFile/fromData to load images using
IDirectFBImage providers. This functionality might be accelerated on
embedded boards and could have potentially large performance
enhancements.
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
|
|
|
|
|
|
| |
If we actually need it locked we'll probably need it locked for
read|write.
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
|
|
|
|
|
| |
Move format into QDirectFBPaintDevice.
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
|
|
|
| |
Reviewed-By: TrustMe
|
|
|
|
| |
Reviewed-By: TrustMe
|
|
|
|
|
|
|
|
| |
The problem was that the mode was not emitting dataChanged.
Note: This still needs to be autotested.
Task-number: 234641
Reviewed-by: ogoffart
|
|
|
|
| |
Also include some spaces fix
|
|
|
|
|
|
| |
This will remove a false pmemleak under valgrind.
Reviewed-by: ogoffart
|
|
|
|
|
|
|
| |
The entry point has been changed to be customShader, taking source
image and texture coordinates as parameters.
Reviewed-by: Tom
|
|
|
|
| |
Reviewed-by: Tom
|
|
|
|
|
|
|
|
| |
QRectF::intersects was optimized as part of the Falcon project, and is
now a bit faster than the inline version used here (drawing of dashed
lines was measured to take 16% less time).
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
|
|
|
|
|
|
|
|
| |
The problem was we were iterating over the list of running animations.
And when calling setCurrentTime(<duration>) on one of them they just
unregister themselves from the timer and we would miss some of them.
Reviewed-by: leo
|
|
|
|
| |
Reviewed-by: Thierry
|
|
|
|
|
|
|
|
|
|
| |
Especially when the widget was not yet shown. Sometimes the rectangle
for an item would get truncated to the size of the viewport.
That should not happen: we only want to expand it to take the whole
height or width of the viewport.
Task-number: 243335
Reviewed-by: ogoffart
|
|\ |
|
| |
| |
| |
| |
| |
| | |
We must not forget to delete the control
Reviewed-by: Paul
|
|/ |
|
|
|
|
| |
QPoint -> QPointF
|
|
|
|
|
|
| |
We export one extra private symbol from QtCore instead, and use that.
RevBy: Miikka Heikkinen
|
|
|
|
|
|
| |
Fix the eyes border in plasma
Author: Kim
|
|
|
|
|
| |
Adding a second patch to this problem. This patch hooks into an
earlier stage in the 'use native' detection
|
|
|
|
| |
Task-number: 259331
|
|
|
|
| |
Author: Kim
|
|
|
|
|
| |
Task-number: 260134
Reviewed-by: ogoffart
|
|
|
|
|
|
|
| |
The bug this commit fixes was introduced by commit
28ac217b04abaa4d226e43e402c14a88539fca3b.
Reviewed-by: Trond
|
|
|
|
|
|
| |
Some minor harmless fixes after feedback from code review.
Reviewed-by: Espen Riskedal
|
|
|
|
|
|
|
|
|
|
|
| |
It seems like we don't respect the Qt::AA_MacPluginApplication
attribute. Setting this attribute means that the native application
should control the menu bar. This patch does a check for this, and
leaves the menubar alone if its set.
We could consider allowing menubars if the Qt::AA_DontUseNativeMenuBar
is set (those should placed inside the window)
Reviewed-by: msorvig
|
|
|
|
|
|
|
| |
Seems like the QMacNativeWidget was almost not
testet at all. It all breaks down when embedding
QLineEdits (with respect to focus). This is a
first patch that fixes this issue.
|
|
|
|
| |
Some compilers don't like them and fail to compile.
|
|
|
|
|
|
|
|
| |
QScriptValuePrivate released by garbage collector later in
~QScriptEnginePrivate (when destroying the agents) would be
added to the freelist and not be released
Reviewed-by: Kent Hansen
|
|
|
|
| |
Reviewed-by: Kent Hansen
|
|\ |
|
| |
| |
| |
| | |
Reviewed-by: Jason Barron
|
| |\ |
|
| | |\
| | | |
| | | |
| | | |
| | | | |
Conflicts:
src/corelib/io/qfilesystemwatcher_symbian.cpp
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Q_OS_UNIX branch of ifdef is ok to execute in homePath and tempPath
cases of QDir autotest for Symbian. Q_OS_SYMBIAN branch was never
even entered for Symbian builds.
Reviewed-by: TrustMe
|
| | |\ \
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
src/corelib/io/qfsfileengine_unix.cpp
|
| | |\ \ \ |
|