| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
The signal could be connected a huge number of times
This is already fixed in master with Qt:UniqueConnection
Task-number: 258381
|
|
|
|
|
|
| |
I had missed this one in my rounds of updates. Bad me.
Reviewed-by: Thorbjorn
|
|
|
|
|
|
|
| |
Setting a file from a resource would result in 'qrc::/file' as
the resource browser returns ':/file'.
Reviewed-by: Jarek Kobus <jkobus@trolltech.com>
Initial-patch-by: andy <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
| |
This is confirmed to resolve a number of problems from the original
reportee. It's already fixed in Qt 4.6 in a more wider fix, but this
one liner is a good to have in Qt 4.5.x anyway.
Task-number: 258194
Reviewed-by: alexis
|
| |
|
|
|
|
| |
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
| |
Don't know how this got lost in the original submit since I had added
both.
Task-number: 257080
Reviewed-by: nrc
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
| |
Task-number: 257080
Reviewed-by: nrc
|
|
|
|
|
|
|
|
|
| |
Properly load the raw headers and properly handle the redirection
when having a network cache in AlwaysCache mode (equals the offline
mode in web browser).
Task-number: 256240
Reviewed-by: Thiago Macieira
|
|
|
|
|
| |
Every source file must end with a newline, otherwise:
"Error: There is extra text on this line."
|
|
|
|
|
|
| |
Fix QDirectFBMousePrivate and QDirectFBKeyboardPrivate
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
In Turkish, lowercase('I') is 'ı', which means comparing "iso-8859-1"
to "ISO-8859-1" will fail.
Reviewed-by: Denis Dzyubenko
|
|
|
|
|
|
|
| |
Trivial fix. Reported by Michael Brasser.
Task-number: 258337
Reviewed-By: Peter Hartmann
|
|
|
|
|
|
|
|
|
|
| |
If you start a hand scrolling and during moving, you press another button
of the mouse than the left one, the scrolling suddently stop working.
In mouseReleaseEvent we just stop the hand scrolling if the button is
left.
Task:258356
Reviewed-by:janarve
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled.
Spend a lot of time looking at this and at the CoreFoundation source
code and it seems that we really do get a notification even after the
notifier is disabled. I suspect there's a race condition between when we
disable the socket notifier, but the kernel flags it as needing a read,
then CoreFoundation just sends the notification without checking if the
CFSocket has been disabled. No further notifications come of course.
Since this breaks the invariant that was set in the assert, I'm
replacing it with an if check.
Task-number: 258198
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
|
| |
during application desctruction globalEngineCache is deleted as part
of Q_GLOBAL_STATIC macro. Other instances of code that happen to use
QRegex after the cache destruction will subsequently crash. Most common
reason are other Q_GLOBAL_STATIC instances which happen to use QRegExp
as part of their destructor.
Reviewed-by: Rhys Weatherley
|
|
|
|
|
| |
- make -input-codec affect PO files, default to UTF-8
- add -output-codec for PO files, same default
|
|
|
|
|
|
| |
There is no QDirIterator::isValid() function.
Reviewed-by: David Boddie
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pushSubDirectory was operating on nextFileInfo when it should really be
using the path received as argument.
This fixes an issue introduced when currentFilePath variable was
removed, that was exposed in the auto-tests; fixes a regression
introduced in 4.5.0 -- test case a couple of commits back.
This also allows refactoring calling code and avoid repetition.
Task-number: 258230
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between a canonical and absolute paths is subtle, and not
what QDirIterator is about. With this change, we still avoid loops
generated by symbolic links but won't duplicate entries because of these
differences.
While at it, when avoiding loops with symbolic links, please don't mess
with the next path! That only added inconsistency.
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
| |
One less variable to maintain reduces the number of bugs and improves
consistency.
Reviewed-by: Olivier Goffart
|
|
|
|
|
| |
Task-number: 258230
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, don't call QWSWindowSurface::winId() in the destructor, as it
will actually request a new id if there isn't already one around - which
is a bit silly and highlighted the "real" bug.
Second, make sure QWSDisplay::Data::takeId() asks for 1 new id before
waiting for more ids to arrive. This is because waitForCreation() calls
QWSServer::processEventQueue(). If the events in the queue cause
takeId() to be called, QWSDisplay::Data::takeId() gets called
recursively. Even though there will be a create 15 ids command in the
queue, that will only allow 15 QWSDisplay::Data::takeId() calls to
return. The 16th call to QWSDisplay::Data::takeId() on the stack will
not be able to return because all the IDs have been taken and (because
it has been called recursively) no new create id commands have been
generated. So the 16th call to takeId() spins in waitForCreate().
Reviewed-by: Paul
|
|
|
|
|
|
| |
replace implicit normalization of individual messages on file writeout
with global normalization which is called by the command line tools.
this should a) be faster and b) cover the most critical case: lrelease.
|
|
|
|
|
| |
Task-number: 236891
Reviewed-By: David Boddie
|
|
|
|
|
|
|
| |
86ea4dbb5a748491656d9621ecd58238bc3e3d82 accidentally took out this
line.
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
Make the code easier to read.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
drawColorSpan is never called from anywhere so we might as well get rid
of the code.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
If DSCAPS_SYSTEMONLY is specified we shouldn't try to create the surface
in video memory.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DirectFB declares variables that are bit fields as enums.
E.g.
DFBSurfaceCapabilities caps;
caps |= DSCAPS_LOCK; // doesn't compile in C++
Work around this problem by declaring operators for these operations.
This greatly improves the readability of the code.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
| |
If the widget under mouse is hidden, Qt can generate a synthetic mouse move
event which gets delivered to the already hidden widget. This can then result
in the wrong item being selected.
Workaround: in QListView, ignore mouse move events when the widget is hidden.
Reviewed-by: Denis
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: Volker Hilsheimer
|
|
|
|
|
|
|
| |
The example TrafficInfo did not compile on GCC 3.3 due to a bug in the
parser of GCC.
Task-number: 258208
|
|
|
|
|
|
|
| |
PorterDuff should only be enabled if the raster engine says it is. E.g.
if we're painting on a format with alpha.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
Regression from Qt 4.4.
Task-number: 257990
Reviewed-by: Tom
|
|
|
|
|
|
|
| |
If you had deleted a VideoWidget, it could not free the memory taken
because we still had a reference on it.
Task-number: 258202
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that we weren't doing any caching of icons provided by the
file system. We now use the similar trick that's used on Windows which
does some caching on the file extension. We do fill up the cache
needlessly with extra information (16, 32, 64, and 128) icons. We
probably could be better with a iconRef engine that generates these
sizes on demand. Still performance is 100% better with this which means
using it in itemviews works.
Reviewed-by: Jens Bache-Wiig
|
|
|
|
|
|
|
|
| |
- Move implementation of debug functions to the bottom of the file.
- Move ImageCache stuff to under QDirectFBPaintEnginePrivate
- Move SurfaceCache stuff to under QDirectFBPaintEnginePrivate
Reviewed-by: Shane McLaughlin <Shane.McLaughlin@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Pretty much every paint operation on DirectFB surfaces starts with
a clipping operations which until now would always cause a
IDirectFBSurface->Lock(). This was to make sure QRasterBuffer::prepare
had been called so QClipData::initialize() would allocate a big enough
array for its spans. We can safely not make
QDirectFBPaintDevice::memory() return 0 until we actually fall back.
Reviewed-By: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
| |
Slight optimization by using the pluralized functions when possible.
Also make templatized helper functions to avoid near-duplication of code
for the float/int cases.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
| |
The drawTiledPixmap code iterated while x < right and y < bottom. This
should be x <= right and y <= bottom.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently some proxy servers can be configured to deny requests based
on User-Agent, even for CONNECT connections. See
https://bugs.kde.org/show_bug.cgi?id=155707#c155 for an example (packet
dump in #c157, analysis in #c158).
So send a User-Agent header with value "Mozilla/5.0", hoping that this
will be enough to allow the connection. I hope it will, because other
tools like libtool send something completely different:
User-Agent: curl/7.19.5 (i586-mandriva-linux-gnu) libcurl/7.19.5
GnuTLS/2.8.1 zlib/1.2.3 c-ares/1.6.0 libidn/1.15 libssh2/1.0
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
Just add a check before calling hooks.
Task-number:258084
Reviewed-by:jbache
|
|/
|
|
| |
Reviewed-by: Joerg
|