| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
We souldn't be returning an empty string for the fileName, just because
the file is closed. E.g., after a rename, the file will be closed, but
should still have a name.
Reviewed-by: Thiago
|
|
|
|
|
|
|
| |
Note: this showed even if the file descriptor was kept open.
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
|
|
|
|
|
|
| |
Reviewed-by: MariusSO
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
|
|
|
|
|
|
|
|
|
| |
When copying a resource file to the native file system the (read-only)
permissions also get copied. On Windows platforms, this was preventing a
test file from being deleted.
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fallback implementation for rename operation should try to copy
permissions from the original file to the destination file. Note that
failures at this point are not treated as errors.
Errors previously set by the native fileEngine are also reset before
returning.
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
|
|
|
|
|
|
|
| |
Also added check in test case for rename fallback.
Task-number: 165920
Reviewed-by: Thiago
|
|
|
|
|
|
|
|
|
|
| |
Changed the fallback implementation to use 'this' instead of a new
QFile. This allows a QTemporaryFile to be block-copied to the
destination and the source to be removed (QTemporaryFile is special
because it isn't really closed).
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Block copying a sequential file is potentially a destructive operation,
because there is no guarantee copy+remove will succeed. In these cases
the fallback should not be tried.
The user is better equipped to decide how to handle such failures and to
ensure no data losses occur, e.g., copy without removing the original
file.
Reviewed-by: MariusSO
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago
|
|
|
|
|
|
| |
Asked by Oswald.
Reviewed-by: Oswald Buddenhagen
|
|
|
|
|
|
|
| |
If ensureSpace causes the layoutData to reallocate then the
initialGlyphs pointers will no longer be valid.
Reviewed-by: Simon Hausmann
|
|
|
|
|
|
|
|
| |
If Harfbuzz shaping adds or merges glyphs we need to move the remaining
glyphs in the glyph layout to compensate.
Task-number: 253783
Reviewed-by: Simon Hausmann
|
|
|
|
|
|
|
|
|
| |
Rather than try to resolve functions or impose configure time
limitations we simply remove the dependancy entirely and rely on the
fallbac for all platforms.
Task-number: 250731
Reviewed-by: thiago
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
origin/qtwebkit-4.5 ( 4ee8af9348b3f57d3c0f3575ae0a58336cf07a92 )
Changes in WebKit since the last update:
++ b/LayoutTests/ChangeLog
2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=24510
Add a test case that Netscape Plugin can properly
determine if a given object has a specific method
and property.
The test will ask the plugin to call hasproperty and
hasmethod and will compare the result with what is
expected. This approach is taken from
netscape-get-property-return-value.html
* plugins/netscape-invoke-browserfuncs-expected.txt: Added.
* plugins/netscape-invoke-browserfuncs.html: Added.
++ b/WebCore/ChangeLog
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Do not call the parent implementation (Widget::) in show() and hide()
of the PluginViewQt, as it always changes the visible state of the
platformWidget (equal to the platformPluginWidget in the Qt port),
thus ignoring the isParentVisible() test.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
2009-04-22 Tamas Szirbucz <szirbucz.tamas@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=25023
Delete reply in QNetworkReplyHandler::abort() to avoid leak.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::abort):
2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=24510
Fix a bug where the browserfuncs were not properly assigned,
make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
Test: plugins/netscape-invoke-browserfuncs.html
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::load): Fix assignment
* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::load): Fix assignment
++ b/WebKit/qt/ChangeLog
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Fix a plugin bug in the WebKit code, similar to the one in WebCore.
The problem is when a non visible QtPluginWidget would show it self
in a sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::):
++ b/WebKitTools/ChangeLog
2009-05-14 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=24510 where
Add testHasProperty and testHasMethod to the existing functions
of the PluginObject to be able to test the browser hasproperty
and hasmethod implementation. Invoke them from pluginInvoke.
Change the defines to an enum to avoid manually updating
NUM_METHOD_IDENTIFIERS and assigning numbers.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testHasProperty): test hasproperty
(testHasMethod): test hasmethod
(pluginInvoke): invoke the two
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test verifies that the network test server is behaving as
expected. I think I caught all the services we need testing in the
server, but there's still some work to be done:
1) verify that the FTP files are there where they're supposed to be
2) verify that FTP writable areas are writable
3) verify that the HTTP server has the correct files too
4) verify that the HTTP server requests credentials for the protected area
5) attempt to do NTLM authentication to verify the password (probably
can't be done with netChat)
6) add Windows SMB tests (//qt-test-server/etc.)
7) add SQL tests (connecting to the SQL server ports)
It would be good as well if we could not use QtNetwork. If you break
QtNetwork, this test breaks too, so we don't know where the fault
is. However, rewriting networking code will add another source of bugs
(same for the NTLM authentication).
Reviewed-By: João Abecasis
|
|
|
|
|
|
|
|
|
| |
This case it was possible to fix by using a union of the types when we
actually declare the variable.
Besides, this avoids a bunch of #ifdef for IPv6 functionality.
Reviewed-By: Oswald Buddenhagen
|
|
|
|
|
|
|
|
|
|
| |
We currently don't support subpixel hinting when drawing text to a
QImage on Mac. The alpha map that is returned by the font engine
is a plain 8 bit gray mask, which means we have to switch off subpixel
hinting when we draw the glyph for caching.
Task-number: 249178
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 30f7edc0aab629499b74263391ae529ad31b2ff8.
There is no way to restore float-equal warning using the pragma trick.
This means (as it was mentioned in the said commit log) anyone that
includes qtransform.h will be forced to deal with float-equal.
Reviewed-by: Samuel Rødal
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In 4.5 the toolbutton icon rendering was changed somewhat and the
bottom line of text for tool buttons icons with TextUnderIcon set is
incorrectly clipped on Windows. The style reserves only 5 pixels but
tries to use 6 pixels for text and icon spacing, hence we adjust the
text rect one pixel up. This should be safe considering the fact that
we have a margin on both sides of the icon already and avoids actually
moving the icon positioning.
Task-number: 252554
Reviewed-by: trond
|
|
|
|
| |
Reviewed-by:cduclos
|
|
|
|
|
|
| |
Explicitly cast to integer.
Reviewed-by: Shane McLaughlin <Shane.McLaughlin@trolltech.com>
|
|
|
|
|
|
| |
Found by valgrind, value isn't set but is used, fixes this.
Reviewed-by: Justin McPherson
|
|
|
|
|
|
|
|
|
|
| |
The previous "fix" caused the effect of the line before the change to be
discarded, which breaks the mac binary package builds. When reviewing
changes, please read the lines of context given in the patch - they are
included for a reason.
Acked-by: Lincoln Ramsay
Acked-by: Rohan McGovern
|
|
|
|
|
|
| |
As found by valgrind. Also add error reporting that was missing.
Reviewed-by: Justin McPherson
|
|
|
|
|
|
|
| |
I tested it with 32 bits compilation and there is no warning any more.
Task-number: 247325
Reviewed-by: ogoffart
|
|
|
|
| |
The typo was in commit 30f7edc0aab629499b74263391ae529ad31b2ff8.
|
|
|
|
| |
Reviewed-by: Samuel
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I made this change to make things look a bit better on the mac. However,
a toolbutton with text only looks strange and as a bonus the arrow
covers some of the text, which no one wants. It seems that similar
consructions in Cocoa don't show the arrow for text button, so we
shouldn't either.
Task-number: 253339
Reviewed-by: Jens Bache-Wiig
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Regression from 4.4 introduced while fixing task 167106
Autotest: tst_QComboBox::task253944_itemDelegateIsReset()
Task-number: 253944
Reviewed-by: jbache
|
| | |
| | |
| | |
| | | |
Reviewed-By: TrustMe
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We changed this primarily for the mac as active appearance on
widgets in itemviews should depend on the window activation state and
not on the focus widget. It was explicitly added back for windows only
but has been reported as a bug on X11 as well so we might as well keep
it mac-only for now.
Reviewed-by: mortens
|
| | |
| | |
| | |
| | |
| | |
| | | |
QMessageBox is like QDialog. It doesn't have any extra magic with window
modality on creation, so don't advertise that it does. The note about
using message boxes as sheets is also updated.
|
| |/
| |
| |
| | |
Task-number: 252565
|
| | |
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
... by being able to load the certificates also in a shadow build
directory
Reviewed-by: Thiago
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The invariant that QCocoaWindow's lifetime is contained in a QWidget is
simply not true.
A top-level QWidget gets associated with a QCocoaWindow (which is
reference counted). However, it can be the case that we've destroyed our
QWidget, the link is removed, the window is hidden, but the window still
gets an event. In that case we would crash with an eventual null pointer
access. However, we don't really need to do anything in this case, so
just call super and return.
Task-number: 253402
Reviewed-by: Morten Sørvig
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The .mm file is not read by qdoc for packages other than for the MAC.
This problem is overcome by moving the qdoc comments from the .mm file
to a .qdoc file in doc/src, because all these files are read by qdoc
for each of the packages.
#Task-number: 252566
|
| |/
|/|
| |
| |
| |
| |
| |
| | |
header + file. Now test check only size of the real file content,
assuming that it is rather boring (9,5MB of '\0'). It simply skip
header.
Reviewed by Peter Hartmann
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In Java, "null" is represented as a keyword, not as the integer 0. The
old code assumed the latter. Code such as
translate("fooBar", "fooBar", null);
would thus not be detected by lupdate when parsing Java files.
Reviewed-by: ossi
|
| | | |
|
|/ /
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| |
| | |
Reviewed-by: Olivier Goffart
Reviewed-by: Peter Hartmann
Reviewed-by: João Abecasis
|
| |
| |
| |
| |
| |
| | |
As suggested in gitorius merge request 421, solution supplied by Harald.
Reviewed-by: Harald Fernengel
|
| | |
|