| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
I actually found a few functions that were not even implemented, only
declared. Those should obviously not be in the header file. I've also
removed a few functions not in use / not belonging to QWidgetPrivate.
Reviewed-by: Olivier
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch cleans up several things, like bit fields that are
interleaved with with other variables, resulting in bits not being
packed properly.
Example: "uint a : 8; int c; uint b: 8;" -> "uint a : 8; uint b : 8; int c;"
In that case we'll use 12 bytes instead of 8 bytes.
I've also changed the order we declare certain variables to avoid
unnecessary gaps/padding on 64-bit architectures.
Example: "char *a; int c; char *b;" -> "char *a; char *b; int c;"
Pointers are 64-bit aligned, so padding appears between 'c' and 'b',
resulting in a total use of 24 bytes instead of 20 bytes.
...and since I anyways was moving the code around, I took the
opportunity to add some overall structure by first declaring
cross-platform functions/variables followed by platform specific
functions/variables. ...and it was kinda scary to actually be
able to see all the QStrings, pointers and whatnot we put into
QWidgetPrivate. I'm sure we can remove lots of stuff, but I'll do
that in a separate commit.
Quick numbers (X11/64 bit):
sizeof(QWidgetPrivate) == before: 472, after: 456
sizeof(QTLWExtra) == before: 112, after: 104
sizeof(QWExtra) == before: 152, after: 144
Acked-by: Olivier
|
|
|
|
|
|
|
|
| |
Our destructor didn't call close, which meant that we never emitted
lastWindowClosed.
Task-number: 253333
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
| |
Task-number: 253427
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
| |
their root. This can be different.
...especially if one manages the selection by program or if you share
the selection model with a treeview.
Task-number: 196118
Reviewed-by: ogoffart
|
|
|
|
| |
Reviewed-by: Kavindra Palaraja
|
|
|
|
|
|
|
|
|
|
| |
shown
The problem is that it gets the previous geometry of the cell whereas
its own sizeHint might lead to change the geometry of the cell.
Task-number: 253109
Reviewed-by: ogoffart
|
|
|
|
|
| |
That code is only executed if the environment varible
QT_GRAPHICSLAYOUT_DEBUG is set to1
|
| |
|
| |
|
|
|
|
| |
Reviewed-by: Kavindra
|
|
|
|
| |
We introduce this new enum, we should be using it.
|
|
|
|
|
| |
Luckilly, that bug was only there if you had QT_GRAPHICSLAYOUT_DEBUG
set as an environment variable.
|
|
|
|
|
| |
aren't really supported.
Also set the default focus to be the preview widget itself.
|
|
|
|
| |
its buttons.
|
|
|
|
| |
when the paper is drawn.
|
|
|
|
|
|
|
|
|
|
| |
It is now possible run the benchmarks with "-chart" to generate
charts for benchmarks that produce chartable data. See
examples/qtestlib/tutorial5 for an example.
This patch has minimal inpact on QTestLib itself. Most of the
functionality is implemented in a separate tool which QTestLIb
calls after detecting the chart command line option.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to help undo the some magic that is in the Qt/Mac port. Qt
automatically flips the Meta and Control keys on Mac. This is a
"feature" that makes porting older programs that don't use standard
shortcuts easier as Ctrl and Command usually map to the same shortcuts
in the application. The upshot of this is that I need to strip the
text() out of key events if they contain the Control or Meta modifier.
This causes much headache for anyone writing a terminal emulator. Though
they would still have to write special code because the keys are swapped
anyway. This allows people to write the terminal emulator where hitting
the Control key will really send a Control key modifier.
We've also done the extra work to ensure that standard shortcuts work
correctly regardless of what the value of the attribute is. That is, if
you specify QKeySequence::Cut for a shortcut you can always hit
Command+X and things will work.
|
|
|
|
|
|
|
|
| |
These are handy to have and make it possible for people to not have to
remember the specific sequences on the different platforms, though some
don't have any.
Reviewed-by: Jens Bache-Wiig
|
|\ |
|
| |
| |
| |
| |
| |
| | |
We don't need Q_D if we don't use the d pointer.
Reviewed-by:TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| | |
This commit add an benchmark to allow testing performance with cache
enable or not. It covers different use cases with item rotating, moving
and so on.
Reviewed-by:bnilsen
|
| |
| |
| |
| |
| |
| |
| | |
The native color picker on Mac supports CMYK colors but this was not available with QColorDialog because the colors were systematically converted to RGB. The color are now initialized with QColor and the result from the color panel is converted to the right format.
Task-number: 253272
Reviewed-by: nrc
|
| | |
|
| | |
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Clarifying details about QTextTable::splitCell() regarding
splitting and merging over several rows and columns
Task-number:193732
Rev-by: Geir Vattekar
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Don't say we produce output when no options are passed if we don't.
Task-number: 222778
Reviewed-by: Trust Me
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We have this function called qDBusInterfaceFromMetaObject that
calculates the interface name from a given meta object. There's no
need to duplicate the code here (and not do it right).
All tests still pss.
Task-number: 236955
Reviewed-by: Trust Me
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 236925
Reviewed-by: Tor Arne Vestbø
|
| | |\ |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The d-pointer was not deleted as it should be.
Reviewed-by: Harald Fernengel
|
| | | |
| | | |
| | | |
| | | | |
Reviewed-by: TrustMe
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |/
| | |/| |
|
| | |/
| | |
| | |
| | | |
Reviewed-By: TrustMe
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | | |
The standard Phonon package has this file and it points to
phononnamespace.h
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The source of the license text is
http://www.w3.org/Consortium/Legal/copyright-software-19980720
Reviewed-by: Trust Me
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 251685
Reviewed-by: mauricek
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
configured with qt3support.
The build system knows when qt3support was turned off, so let's just
skip these tests in that case. That makes more sense than individually
configuring each autotest machine to skip these tests when the
configuration is known to turn off qt3support, which is what's done
previously.
Reviewed-by: Lincoln Ramsay
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We need to protect calls to FcCharSetHasChar with the font database
mutex.
Task-number: 241361
Reviewed-by: Simon Hausmann
|
| | |
| | |
| | |
| | |
| | |
| | | |
We hardcode the lib names for 4.5
Reviewed-by: Maurice
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Better alternative to 9ffcf3737901c49acb1a1bc6b65572d195d78a5d
Task-number: 253052
Reviewed-by: Norwegian Rock Cat
Reviewed-by: MortenS
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 253179
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It's better to set the sourceModel in the constructor for QFSCompletor,
as requiring that it be set separately is error prone.
Surprisingly, the printer dialog crash only appears to happen when using
relative filenames.
Task-number: 253135
Reviewed-by: alexis
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes regression introduced in a794ded85f74516239a08cf848e6b4f8b6dcac6a.
When using UnfilteredPopupCompletion the matchCount is always zero and
completion was being skipped. By adding the check for showAll we still
avoid the assert but retain correct behavior.
Task-number: 253125
Reviewed-by: jasplin
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using setFileName in QFile::copy (introduced recently) has a nasty
side-effect of leaking file descriptors in QTemporaryFile. This happens
because the code assumes the file has been closed. In QTemporaryFile,
we need to explicitly call native file engine close.
Test case by Thiago. Bug report from Arora developers.
Reviewed-by: thiago
|