| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
It seems that Vim or Xcode or whatever I was using to paste these
in messed up and added an extra space. Now we should be consistent with
the .cpp files and I found a file that we missed too.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zero timers on Windows would continue to fire even after being stopped
as long as a new timer was started that reused the pointer address of
the zero timer. Fix this by only re-firing zero timers if the zero
timer hadn't been stopped (we can check this by looking at the
inTimerEvent flag, which is set to false by registerTimer()).
Task-number: 247401
Reviewed-by: Denis Dzyubenko
Reviewed-by: Prasanth Ullattil
|
|
|
|
|
|
|
|
| |
It seems there is a potential for recursion because calling keyDown:
can bubble up to the window which will start the process all over again.
keyDown: will actually call qt_dispatchKeyEvent(), we may as well short
it out here. All the previous cases I tried continue to work and we
don't crash Creator if you are really impatient hitting keys.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CustomProxy class installs an event filter on its child to detect
whether it is shadowed by a popup or not. The problem is it does this
regardless of whether it currently has a scene assigned or not. Styles
that assign palettes, or otherwise cause side effects when assigned
to a QGraphicsProxyWidget, will cause the demo to print warnings to the
console and fail to install the event filter. The reason for the failure
to install the filter is that QGraphicsItem only allows scene event
filters to be installed between items that are in the same scene.
So, depending on the style, you either get an ItemSceneHasChanged or an
ItemChildAddedChange first. The demo must account for this, and install
its filter only when the items are guaranteed to be in the scene already.
Reviewed-by: Alexis
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 35c26d696cbff269d551c012a212c09692dd6f6b.
The change to QComboBox introduces a behavior change; whereas before
the view container would always get its palette set as a response
to QEvent::PaletteChange, it would now miss this event and rely on
regular palette propagation to get the right contens. The difference
in behavior is that QWidget::setPalette() also resolves the palette
mask, and after 35c26d69 this would no longer happen.
The bug in the embedded dialogs demo is caused by the embedded
dialogs demo. See upcoming commit.
Reviewed-by: Alexis
Reviewed-by: Jens Bache-Wiig <jbache@trolltech.com>
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
Reviewed-by: thartman
- in case we explicitly use double as testdata, one cannot push float to
it.
- fuzzyCompare is not fuzzy enough, thus adopt the epsilon check of
other testfunctions.
|
|
|
|
|
|
|
|
|
|
| |
Reviewed-by: joerg
Some of the testfunctions use key/mouse events, which doesn't work
on Windows Mobile due to native menubar integration. Basically the
same situation like on Mac.
In addition there are still two test functions failing, waiting for
input on those.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 7d24c0af8e52687b4e5735950495bb25947ca9f0.
This change removed the accidental recursion leading to console
warnings on Mac OS X by changing the way the scene event filter
is registered for popups. But it also broke the behavior of the
demo with regards to popup handling, in that the custom proxy
no longer can detect popups that close, so dialogs stay zoomed
in after the cursor has left. So before, the demo worked but
printed warnings to the console on Mac OS X, and after, the warnings
were gone but the demo behavior broke on all platforms...
The change also accidentally removed the cache mode from the popup;
I don't think this was intentional.
Reviewed-by: Alexis
|
|
|
|
|
| |
Reviewed-by: mauricek
BT: yes
|
|
|
|
|
|
|
| |
A Nokia build doesn't require a license.
Reviewed-by: mauricek
BT: yes
|
| |
|
|
|
|
| |
While we integrate into native menubar on Windows Mobile, we can still test WinCE itself.
|
|
|
|
|
|
|
|
|
| |
The high precision code path was getting an empty string on the second
call to getstringdata, which was causing it to return empty for the
field. Really only needed to call it once anyway, so use the original
call.
Reviewed-by: Justin McPherson
|
|
|
|
| |
Last of the changes to include behaviour from QPtrVector
|
|
|
|
|
|
|
| |
Looks like they were using the old QPtrVector in qt3, and didn't quite
handle the porting correctly.
Reviewed-by: Lincoln Ramsay
|
|
|
|
|
|
|
|
|
| |
Drawing operations with DirectFB in RGB32 changes the alpha byte to 0.
This doesn't play well with QRasterEngine.
See 5fb7752ff93b31635e64fa321917749744cc9db6 and
34059fba55816496d2570b3306ac2b631b12a5c6
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
| |
Make it more flexible. This patch allows people to use DFB without
DSFLIP_BLIT. Also, before this patch the flip= options weren't really
used for anything.
Reviewed-by: TrustMe
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
It seems DirectFB doesn't preserve alpha value of a blit unless BLEND is
specified and if it is we need to Clear to transparent first.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Using #ifndef QT_NO_OPENSSL without first #include'ing something will
never work. Which means we always include qsslsocket.h. The problem
is: if OpenSSL isn't enabled, then that file is a no-op and we never
include qabstractsocket.h.
Reviewed-by: Markus Goetz
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We had to revert an earlier fix since it obviously did
not work correctly. However since we do not really need to propagate the
palette on the viewContainer _before_ it is created, we can simply avoid
the issue alltogether as it would happen because we implicitly added
a child widget during the polish of the combo box.
Reviewed-by: nrc
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Gah, my original change (f5ef0eb1a6543abdd29e07c23de7fa1128f6d623) had
its heart in the right place, but it seems that it can cause crashes
on closing where we refuse to give up the first responder and we end up
with a dangling pointer. This lets that case happen (when we have no
focus widget and are setting a nil first responder, there's no reason to
stop that, but it refuses to do that when we do have a focus widget.
Hopefully we don't get in a situation where our focus widget gets out of
sync.
Reviewed-by: Prasanth Ullattil
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Symptom: checkboxes didn't get checked if you press, hold for some
seconds and then release the mouse or stylus.
In QAbstractButton we reacted on the contextMenuEvent that gets sent if
the system recognizes the context menu gesture (tap and hold) and did
call setDown(false).
This change has been done because buttons in tool bars stayed in the
down state when displaying the context menu with this gesture.
I've now moved the handling of this to qtoolbar.cpp.
Task-number: 246619
Reviewed-by: thartman
|
|/
|
|
|
| |
RevBy: Joerg
Details: -opengl-es-2 option for configure.exe
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the Cocoa Builds.
The drag move events were compressed based only on the position of the
cursor. It has to be based on both position and the "drag operation" in
native event.
Reviewed-by: nrc
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Mac OS X - cocoa
The filename as NSString that we get from Cocoa does not have
the correct file system encoding. This means that certain characters are
implemented differently than what e.g. QFile::encoded returns. This fix
normalizes the string from cocoa before using it.
Task-number: 249928
Reviewed-by: Trenton Schulz
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In our Cocoa menu we check if we need to send the key event to the
qwidget before the menu has a chance at it, because logically in Qt, the
key event should go to the widget and not the menubar first (a bit
different than what happens on the mac). The way to determine this is to
send a shortcut override event and see if it accepts it. If it does,
that means we should just send it the key event. Previously we were
sending the shortcut override, but not following through on the key
event because we thought (however foolishly). That returning "YES" but
not setting an action would somehow forward the event (it doesn't).
There still seems to be some problems if you have a Dvorak-QWERTY+CWD
layout, but this probably needs to be dealt with at the key mapper
level.
Reviewed-by: Prasanth Ullattil
|
| |
| |
| |
| | |
Someone messed up the whitespace on this comment.
|
| |
| |
| |
| |
| |
| | |
RevBy: mauricek
Details: using prefix qt_ instead of ::global namespace
|
|/
|
|
|
|
|
| |
RevBy: Joerg
AutoTest: mediaobject
Details: Since our wave files on Windows CE are very short (memory) we actually land up in the PausedState
when playback is finished
|
|
|
|
|
|
|
|
|
| |
same value -> crash on SetTitle()
Task: 242484
RevBy: mauricek
AutoTest:
Details: Since we do not respect binary compatibility on Windows CE we just change the enum
|
|
|
|
|
|
|
|
|
| |
We did not enable hover on list view item views. This is
inconsistent with how QTreeView works as well as different
from how native icon views behave.
Reviewed-by: Prasanth Ullattil
Task number: 242519
|
|
|
|
|
|
|
|
| |
In the function initCompilerTool we handled QMAKE_CXXFLAGS twice for
every configuration (debug / release).
The call of parseOptions before the if clause is enough.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
append the source dir to the include path, but only after the dirs with
the generated files.
this seems to have worked before only accidentally: the unqualified
default dirs were expanded to the source dir instead of the build dir,
but the build dir is added implicitly by default, so things magically
worked. now that we qualify the moc/ui dirs, projects relying on the
strange side effect suddenly break.
we should probably add the source dir to the include path by default,
but this coupling to uic/moc is closer to the historical behavior and
thus should be safer.
Reviewed-by: mariusSO
|
|
|
|
|
| |
doesn't seem to be a terribly popular feature, given that nobody noticed
this yet ...
|
|
|
|
| |
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
|
|
| |
When the connection is established, the socket notifier is deleted,
but not the connection timer, so the opened connection will be closed
after 30 seconds.
Task-number: none
Reviewed-by: Andreas
Reviewed-by: Thiago
|
|
|
|
|
|
| |
Looks like a typo.
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QWidget::childAt() makes some assumptions about its children (they are
all contained in its geometry). This does not hold up when using the
unified toolbar because the toolbar ends up in the "non-client" area.
So, when dispatching an enter/leave event in tooltip show, we end up
dispatching to the wrong widgets and that results in the tooltip
cleverly thinking that it needs to hide itself because we've left the
widget that needs the tooltip. I've special cased this by just having a
"native" mapFromParent() that is only called for on the mac, though
there is nothing that is limiting this from being called on other
platfroms.
Also QWidget::mapFromParent() probably needs to be looked at at some
point.
Task-number: 248048
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
| |
Reviewed-by: Trond
|
|
|
|
|
|
|
| |
Full fix will potentially break other code and is thus avoided
Task-number: 248992
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
| |
RevBy: bnilsen
Task: 249394
Details: When going through the backingstore a repaint in a
toplevel resize should just discard the repaint() as
it will repaint shortly after anyway. This is in line
with the implementation of update().
|
|
|
|
|
|
| |
RevBy: Samuel
Details: The IMAGE_FROM_PIXMAP has to be doing a local copy or
something, because it is sure not fast...
|
|
|
|
| |
RevBy: Samuel
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
QT_NO_DIRECTFB_LAYER doesn't work unless QT_NO_DIRECTFB_WM also is
defined.
Reviewed-by: TrustMe
|