| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
| |
After the coverity fix, the proper code path executed, which failed to
enquote the date field properly, so this fix fixes that issue.
|
|
|
|
| |
Found by coverity.
|
| |
|
|
|
|
| |
Genarated->generated
|
|
|
|
|
|
|
|
|
|
|
|
| |
When using streaming, it could happen that the last reference to the
MediaSource is in another thread. So the objects are destroyed from
another thread. In which case we would delete QObject (ioDevice) in
another thread. That is fixed by calling deleteLater which will ensure
that they are deleted in their own thread.
Note: there was a nother assert that could happen due to a race
condition in the worker thread. That is also fixed with this patch.
Reviewed-by: jbache
|
|
|
|
|
|
| |
Kramer is no longer accessible from the pulse test system
Reviewed-by: jesperht
|
|
|
|
|
|
|
| |
Also, the info() function was modified to use an assert rather than an
pointer check with an if to make it consistent with the rest of the file.
Reviewed-by: jesperht
|
| |
|
|
|
|
|
|
|
| |
See 3ae2cab9c8bd1790a00da2755ac036143a3a35f4 for another similar fix.
Reviewed-by: Trust Me
(cherry picked from commit 18fbfdf0f774198e2e1277e064cc3a8eb9dbb29d)
|
|
|
|
|
|
|
| |
"../shared/qm.cpp", line 556.45: 1540-0207 (S) No common type found for operands with type "const char [7]" and "QByteArray".
Reviewed-by: Trust Me
(cherry picked from commit 3ae2cab9c8bd1790a00da2755ac036143a3a35f4)
|
|
|
|
| |
(cherry picked from commit cb64ac587249f5dc6563a035e2ef5a3ad2bc5d13)
|
|
|
|
|
|
|
|
| |
It was reported to be auto-detected, but wasn't. Apparently, AIX 6's
X11 doesn't have this.
Reviewed-By: Denis Dzyubenko <denis.dzyubenko@nokia.com>
(cherry picked from commit 0a63875d787e1b035ace2c76fa1d0de6329127d7)
|
|
|
|
|
|
| |
This is a vulnerability in some implementations. Qt isn't affected
because... well, we never implemented the decoding of escape sequences
:-)
|
|
|
|
|
| |
Task-number: 239108
Reviewed-by: Andy Shaw
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QTemporaryFile on Windows doesn't open the file as a sharable, and
doens't close the file when you call .close(). So the testcase
fails on Windows with a Sharing Violation when the compiler tries
to compile the file.
By switching to QFile we can at least close the file before letting
the compiler chew on it, and remove it at the end when the testcase
is done. Open the file with Truncate, in case the testcase fails to
remove the file.
Reviewed-by: trustme
|
|
|
|
|
|
|
| |
Task-number: 259143
Merge-request: 1119
Reviewed-by: Denis Dzyubenko <denis.dzyubenko@nokia.com>
|
| |
|
|
|
|
|
|
|
|
| |
On mac, we prefer testing with mp3 rather than ogg, Because in the latter
case, you must install perian to make it work. And the test machines
dont.
Reviewed-by: brad
|
| |
|
|
|
|
|
|
|
|
| |
The test was failing because the goal of the test expect to get only
directories displayed. But if you don't have some in the current dir
then it fails. home dir should be enough.
Reviewed-by:TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an autotest fails to compile, there's no way to determine which
testcase(s) have been prevented from running.
Our results parsing tools have been guessing, under the assumption that
a directory called `qdogwalker' always contains a testcase named
`tst_qdogwalker'. That wasn't true for all our tests, so let's make it
true.
Also changed the platform-specific tests so that qmake will simply skip
those tests on unsupported platforms, instead of wasting time compiling
a useless QTEST_NOOP_MAIN test.
|
|
|
|
|
|
|
|
|
|
| |
The HideNameFilterDetails was not taken in account for windows
file dialog. This patch fix that. For Windows Vista and later we use
now the new COMMON_ITEM_DIALOG API (in master) where it add always
the filter extension like *.txt so no point to take that flag in account.
Task-number: None, during testing
Reviewed-by: prasanth
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason is that the C++ compiler needs to add -I/usr/vacpp/include
before -I/usr/include, so our adding of -I/usr/include changes the order.
This causes a compilation error in the C++ header xlocinfo.h.
In any case, these checks done in qmake are unnecessary. If the OpenSSL
headers are in one of those include paths, they will be found on their
own already.
Reviewed-By: Bradley T. Hughes
(cherry picked from commit 04f7834fcd8db4ecb6a4c53de42ac83f571b37c8)
|
|
|
|
|
|
|
|
| |
Note however you still need to -nomake examples -nomake demos
when configuring Qt.
Reviewed-by: Thiago
Task: 259179
|
|
|
|
|
|
|
|
|
| |
If there is severals matching items but all of them are disabled, it
would have produced an infinite loop.
Block the loop once we reach an already matched item.
Task-number: 258949
Reviewed-by: Thierry
|
|
|
|
|
|
|
|
|
|
| |
We never told Cocoa that it needed to redraw the window view
when a window was shown. This is implicit if the window is
shown for the first time, but needs to be done explicit
if you hide and show it again.
Task-number: 254672
Reviewed-by: bnilsen
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The Qt dialog treats extension filters as case insensitive where
the default behavior of the Gtk+ file dialog is to be case
sensitive. The GtkFileFilter allows only simple glob syntax to
be used so we basically rewrite the extension string from .xyz
to .[xX][yY][zZ].
Task-number: 259155
Reviewed-by: joao
|
|
|
|
|
|
|
|
|
|
| |
The problem was that our glib timers were given too high priority,
effectively starving the Gtk event loop. By assigning our timer source,
G_PRIORITY_DEFAULT_IDLE we ensure that all gtk+ events are handled first,
thus allowing the native dialogs to respond and repaint properly.
Task-number: 258433
Reviewed-by: bhughes
|
|
|
|
| |
Reviewed-by:TrustMe
|
|
|
|
|
|
|
|
|
| |
updateAncestorFlags was not reseting the flags if you change the parent
that have for instance itemsClipChildrenToShape to a new one that
doesn't have that flag.
Task-number:258956
Reviewed-by:bnilsen
|
|
|
|
|
|
| |
Don't error out when building qmake, just let it build a 64-bit binary (even for carbon)
RebBy: Richard Moe Gustavsen
|
|\ |
|
| |
| |
| |
| |
| | |
Task-number: 254407
Reviewed-by: Gunnar
|
|/
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
|
|
| |
The functionality these tests tested was broken in 4.5 and has been
disabled. Therefore, these tests simply cannot pass.
It's fixed in 4.6.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Added the needed macros around the classnames the way it
should be done.
Reviewed-by: Prasanth
|
|
|
|
| |
Reviewed-by:TrustMe
|
|
|
|
|
|
|
|
|
| |
On Windows we will add maximize button to the titlebar even if the
window has a fixed size if the user explicitely asked for it by
setting Qt::CustomizeWindowHint | Qt::WindowMaximizeButtonHint.
Task-number: 250188
Reviewed-by: Leonardo Sobral Cunha
|
|
|
|
|
|
|
|
| |
If the user forgot to end their headers with a newline, the
compilation would fail because the next line is #include
<QtCore/QtCore>.
Reviewed-by: Jesper Thomschütz
|
|
|
|
|
|
| |
Remove mem leak / warning in the cocoaport
Reviewed-by: msorvig
|
|
|
|
|
|
| |
CFDictionaryAddValue expects a CFNumberRef, not a pointer-to-CFNumberRef.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is because we try to decide whether the window cocoa tells
us to be active should be active, and if we desagree, we do nothing.
The result is that Qt and Cocoa ends up in different states.
I decided to remove a lot of the logic that went on in this case, and
the resons is:
1. By checking the callplaces to
onApplicationWindowChangedActivation, we know that we always have a
valid widget pointer, and we know that the widget always is a window
(otherwise Cocoa would never tell us that the widget got active).
2. We can never end up doing nothing in this response. The best
we can do is to follow what Cocoa tells us. If this turns out to
break something, it would probably be better to check why we get an
activation call in the first place for a window that should not be
activated (e.g. is canBecomeKeyWindow set correctly?)
Task: 253610
RevBy: msorvig
|
|
|
|
|
|
|
| |
Mysql queries other than select can't be prepared, otherwise they fail
to return the necessary meta-information to enable them to be seen as
returning data under certain versions of mysql. This fixes the hack
to work correctly until we stop preparing queries automagically.
|
|
|
|
|
|
| |
Task: 258895
Reviewed-By: Jens Bache-Wiig
|