| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. QNetworkSession being deleted from the closed signal caused data
abort or E32User-CBase 49 panics. (both observed)
2. Potential E32User-CBase 46 panic in
ConnectionProgressNotifier::StartNotifications()
Reviewed-by: Aaron Tunney
Reviewed-By: Markus Goetz
Task-Number: QTBUG-17196
|
|
|
|
|
|
| |
Opening "searchpath:/file" and other non clean paths was failing
Reviewed-by: joao
|
|
|
|
| |
Reviewed-by: Markus Goetz
|
|
|
|
| |
Reviewed-by: Markus Goetz
|
|
|
|
| |
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
| |
When the application did not set the mandatory content-type header for
POST requests, Qt was putting in application/x-www-urlencoded. While
this is the default for HTML forms, it isn't valid because Qt was not
also encoding the data.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broadcast and multicast are optional features for network interfaces on
Symbian. WLAN supports both, while IPv4 and IPv6 loopback support only
multicast.
The test tries to start the bearer, to get an interface that does support
broadcast.
There is an expect fail for the 0 bytes written case, as this is what
happens on symbian if none of the interfaces support broadcast.
On the phones which don't have WLAN, this is likely.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The low level socket option returns the size including IP headers, as
there is an option in receive to include headers in the datagram.
This is OK for a "size will not exceed" metric for buffer allocation,
but Qt relies on it being an accurate size.
Open C did this by subtracting 28, but that isn't valid for IPv6
which has a 40 byte header. (we can't tell whether the buffered datagram
was received over IPv4 or IPv6)
To fix this, do a read with the peek option set, and only care about the
size. In future it would be good to not peek, but rather return this buffer
to a following call to readDatagram.
Reviewed-by: Aaron Tunney
|
|
|
|
|
| |
Reviewed-by: Aaron Tunney
Reviewed-by: Markus Goetz
|
|
|
|
| |
Reviewed-by: Markus Goetz
|
|
|
|
| |
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
| |
When opening an active session, waitForOpened was failing because
the state was Connected rather than Connecting.
This is fixed to allow Connected as a state.
Reviewed-by: Markus Goetz
|
|
|
|
| |
Task-Number: QT-4378
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of each QNetworkAccessManager owning a QNetworkSession, they now
share a QNetworkSession if they have the same QNetworkConfiguration.
QNetworkAccessManager now uses passive roaming instead of application
level roaming. The state change signal (entering connected state) is used
to indicate reconnection instead of being triggered when sending an ALR
accept().
This preserves the previous behaviour, as QNAM always accepted the
suggested access point from bearer mobility.
In the case of multithreaded applications, one QNetworkSession will be
created for each thread which uses QNetworkAccessManager, as QNetworkSession
is not thread safe.
Task-number: QT-4378
Reviewed-by: Markus Goetz
Reviewed-by: juhvu
|
|
|
|
|
|
|
|
| |
QTcpServer calls accept repeatedly until it fails.
So the KErrWouldBlock is an expected error - ignore this so warnings are
only emitted for unexpected errors.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
| |
Symbian uses KErrBadName to indicate a badly formed socket address.
It also returns this error if the address is invalid for the attempted
operation, for example calling connect() with a broadcast address.
Now handle this error explicitly rather than returning unknown error.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
| |
The unreachable IP test needs a longer timeout than on desktops.
The manual construction of a file:// URL was incorrect in the case where
SRCDIR is "." - this is changed to the recommended QUrl::fromLocalFile
API.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first few tests could randomly timeout due to delays in starting
the WLAN connection.
This is addressed by opening the default bearer in initTestCase, and
closing it in cleanupTestCase. This will keep the connection active for
the duration of the test, instead of activating/deactivating continuously.
The first SSL test could randomly timeout due to the delay in fetching the
CA certificates from the system (which can be very slow on some phones /
SIM cards).
This is addressed by preloading them in initTestCase - all the tests will
then get system SSL certs from the cache.
Reviewed-by: Markus Goetz
|
|
|
|
| |
Reviewed-by: Aaron Tunney
|
|
|
|
|
|
|
| |
The active object used for socket notifications (QAsyncSelect) is
thread specific, so it needs to be deleted and recreated in the new thread.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
|
| |
Symbian treats listening on "0.0.0.0" to mean "accept any IPv4"
and listening on "::" to mean "accept any IPv6".
To accept any connection, you must listen with an unspecified address
As the Qt documentation explicitly says QHostAddress::Any means to
accept any connection, this is converted to an unspecified address
(KAfUnspec) by the symbian socket engine.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
|
| |
Symbian IPC has two modes, either a preallocated message pool for the
process (up to 255 allowed), or the global message pool.
The default for the socket server is 8 preallocated slots, which is not
enough to run the qnetworkreply autotest. However preallocating a large
number of slots would be wasteful for an application that only uses one
or two sockets at a time.
Since we can't predict the usage, the global pool seems the best option.
Reviewed-by: Iain
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to a race condition, the test could fail before its QThread had even
started, resulting in a crash during thread startup. This is addressed
using a semaphore to synchronise startup & ensure the sub thread is running
before continuing the test.
Additionally, if the test failed the QThread would be destroyed while
still running, which according to the documentation will cause crashes.
This is addressed using QScopedPointer to clean up when the test exits
early due to failure.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
| |
Incorrect usage of KAfInet6 in the symbian socket engine.
KAfInet is used for both IPv4 and IPv6 as a protocol family.
KAfInet6 is used as the address family for IPv6 addresses.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
| |
IPv6 addresses.
Reviewed-by: Shane Kearns
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QAbstractSocket requires a handle of -1 to be returned when accept fails.
This is a common case, as it calls accept() in a loop to get all incoming
connections. Also the blank socket wasn't being closed properly on failure
so that is also fixed.
Fixed a possible race condition in QSymbianSocketEngine::close - the
socket descriptor is now deregistered before closing the symbian socket
to avoid another thread getting the symbian handle reused in open and
asserting when trying to register it.
This patch also adds debug around socket handle allocation when socket
engine debug is enabled.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
| |
1. Increase maximum heap, as FTP large file test was running out
2. Add an additional QVERIFY so that a test fails instead of suffering
an assertion failure in case no data is received.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the application (in this case, an autotest) ran out of memory by
calling readAll() in a slot, the exception propagated to the symbian
active scheduler where it caused an assertion failure.
Additionally, QAbstractSocket was left in a bad state because its
member variables that guard against re-entrancy were left set.
1. Catch exceptions and convert to leaves in QAsyncSelect
2. Implement RunError function to set the socket engine error state
3. Use QScopedValueRollback in QAbstractSocket to ensure the reentrancy
guards are reverted if an exception is thrown.
Reviewed-by: Markus Goetz
Reviewed-by: mread
|
|
|
|
| |
Reviewed-by: mread
|
|
|
|
|
|
|
|
|
| |
This template allows a value to be automatically rolled back to a previous
state when the class goes out of scope. This can be used to maintain a
valid state when an exception is thrown.
Reviewed-by: mread
Reviewed-by: joao
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The access point scanner cancels itself in the destructor.
This requires the handle to be valid, but it was closed in the symbian
engine destructor immediately before deleting the AP scanner.
Because of the way symbian active objects work, the crashing function
is only called if there was an asynchronous request in progress.
So it could be missed in cases where the scan completes faster than the
test case.
Task-number: QTBUG-16484
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
| |
The socket server returns KErrAlreadyExists rather than KErrNone when
connect is called as second time after the select ioctl completes.
Reviewed-by: Markus Goetz
Reviewed-by: Aaron Tunney
|
| |
|
|\ |
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
master-integration
* 'master' of scm.dev.nokia.troll.no:qt/oslo-staging-2:
Fixed stroke / fill inconsistencies in GL 2 paint engine.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Get rid of the aliased coordinate delta, like we already did in the
raster paint engine.
Task-number: QTBUG-16043
Reviewed-by: Gunnar Sletta
|
| |\ \
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
scm.dev.nokia.troll.no:qt/qt-file-engines-refactor into master-integration
* 'earth/file-engine-refactor' of scm.dev.nokia.troll.no:qt/qt-file-engines-refactor: (224 commits)
Fix warnings, whitespace cleanup
Don't rely on uninitialized data
Doc: Fixing typo
Doc: Fixing typo
Skip failing tests
Use effective user id instead of getlogin
Fix compile error in tst_qfileinfo on Mac/Linux
Fix tst_QFileInfo owner() & group() failure on Windows.
Fix tst_QFileInfo::canonicalFilePath failure on Windows
Fix QDir::relativeFilePath
Fix spelling in comments
Add missing license header to test case
Define _WIN32_WINNT before any includes
New attempt at fixing compilation failure
Removing unused duplicate definitions
No symbolic links in Windows CE
Set minimum target Windows version to 2000
More missing includes
Add missing include
Fix compile error
...
|
| | |\
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
scm.dev.nokia.troll.no:qt/qt-file-engines-refactor into master-integration
* 'earth/file-engine-refactor' of scm.dev.nokia.troll.no:qt/qt-file-engines-refactor: (224 commits)
Fix warnings, whitespace cleanup
Don't rely on uninitialized data
Doc: Fixing typo
Doc: Fixing typo
Skip failing tests
Use effective user id instead of getlogin
Fix compile error in tst_qfileinfo on Mac/Linux
Fix tst_QFileInfo owner() & group() failure on Windows.
Fix tst_QFileInfo::canonicalFilePath failure on Windows
Fix QDir::relativeFilePath
Fix spelling in comments
Add missing license header to test case
Define _WIN32_WINNT before any includes
New attempt at fixing compilation failure
Removing unused duplicate definitions
No symbolic links in Windows CE
Set minimum target Windows version to 2000
More missing includes
Add missing include
Fix compile error
...
|
| | |
| | |
| | |
| | | |
... and trigger CI :-/
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When we fail to get file attributes, the file times are left in an
uninitialized state, which may lead to a crash. In particular, this was
showing up in QMessageBox's autotest, where the lastModified time is
being queried on a non-existing file.
Before the refactoring, we were returning a default constructed
QDateTime to queries about different file times, with this change we
will return the time corresponding to a default constructed FILETIME
object.
Reviewed-by: Shane Kearns
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
For Mac OS X 10.5 and earlier, QDir::canonicalPath depends on
QDir::cleanPath which is fundamentally broken and specifically fails for
the case of "/./", returning "" instead of "/".
Fixing cleanPath to a sane and correct behaviour seems to break more
code than it is worth so we're skipping these individual tests for the
time being.
|
| | |
| | |
| | |
| | |
| | |
| | | |
And check if this gives us more reliable results.
Reviewed-by: Prasanth Ullattil
|
| | |\
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
scm.dev.nokia.troll.no:qt/qt-file-engines-refactor into master-integration
* 'earth/file-engine-refactor' of scm.dev.nokia.troll.no:qt/qt-file-engines-refactor: (218 commits)
Fix compile error in tst_qfileinfo on Mac/Linux
Fix tst_QFileInfo owner() & group() failure on Windows.
Fix tst_QFileInfo::canonicalFilePath failure on Windows
Fix QDir::relativeFilePath
Fix spelling in comments
Add missing license header to test case
Define _WIN32_WINNT before any includes
New attempt at fixing compilation failure
Removing unused duplicate definitions
No symbolic links in Windows CE
Set minimum target Windows version to 2000
More missing includes
Add missing include
Fix compile error
Update def files
Fix tst_QFile::caseSensitivity test on Mac
Fix typo in QFile test
Add test generated files to .gitignore
Fix compile error for qdir autotest on symbian3
QtDeclarative: make autotests compile on symbian
...
|
| | | |\
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
scm.dev.nokia.troll.no:qt/qt-file-engines-refactor into master-integration
* 'earth/file-engine-refactor' of scm.dev.nokia.troll.no:qt/qt-file-engines-refactor: (218 commits)
Fix compile error in tst_qfileinfo on Mac/Linux
Fix tst_QFileInfo owner() & group() failure on Windows.
Fix tst_QFileInfo::canonicalFilePath failure on Windows
Fix QDir::relativeFilePath
Fix spelling in comments
Add missing license header to test case
Define _WIN32_WINNT before any includes
New attempt at fixing compilation failure
Removing unused duplicate definitions
No symbolic links in Windows CE
Set minimum target Windows version to 2000
More missing includes
Add missing include
Fix compile error
Update def files
Fix tst_QFile::caseSensitivity test on Mac
Fix typo in QFile test
Add test generated files to .gitignore
Fix compile error for qdir autotest on symbian3
QtDeclarative: make autotests compile on symbian
...
|
| | | | |
| | | | |
| | | | |
| | | | | |
Reviewed-by: Shane Kearns
|