| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Removing another data member in QDirIteratorPrivate.
The only reason I see for not doing this is to delay doing work as much
as possible. Since copy constructors are disabled anyway, once
QDirIterator is instantiated one has already signed up for the pain.
The code also looks cleaner this way.
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
|
| |
Setting nextFileInfo in the constructor would generate visible behavior
changes on the first call to QDirIterator::hasNext(), and that's just
wrong.
Namely, fileName(), filePath() would return different results before and
after calling hasNext().
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
| |
The authoritative copy of filters and nameFilters is available, there is
no need to get this from the file engine iterators.
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
|
| |
If we're skipping hidden files, we should skip hidden directories as
well. The user can still request that hidden directories not be skipped
by specifying QDir::AllDirs in the filter.
Incidentally, all other filters are ignored when recursing into
sub-directories. Perhaps that should be addressed as well.
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
| |
Which is faster QFileInfo::isSymlink() or QFileInfo::fileName() followed by
string comparisons?
Reviewed-by: Marius Storm-Olsen
|
|
|
|
| |
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
| |
There's no need for initializing variables twice.
Reviewed-by: Marius Storm-Olsen
|
|\
| |
| |
| |
| |
| | |
Conflicts:
src/gui/graphicsview/qgraphicsscene.cpp
src/gui/kernel/qt_cocoa_helpers_mac_p.h
|
| |
| |
| |
| |
| |
| |
| | |
Setting a file from a resource would result in 'qrc::/file' as
the resource browser returns ':/file'.
Reviewed-by: Jarek Kobus <jkobus@trolltech.com>
Initial-patch-by: andy <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is confirmed to resolve a number of problems from the original
reportee. It's already fixed in Qt 4.6 in a more wider fix, but this
one liner is a good to have in Qt 4.5.x anyway.
Task-number: 258194
Reviewed-by: alexis
|
| | |
|
| |
| |
| |
| | |
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Don't know how this got lost in the original submit since I had added
both.
Task-number: 257080
Reviewed-by: nrc
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| | |
Task-number: 257080
Reviewed-by: nrc
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Properly load the raw headers and properly handle the redirection
when having a network cache in AlwaysCache mode (equals the offline
mode in web browser).
Task-number: 256240
Reviewed-by: Thiago Macieira
|
| |
| |
| |
| |
| | |
Every source file must end with a newline, otherwise:
"Error: There is extra text on this line."
|
| |
| |
| |
| |
| |
| | |
Fix QDirectFBMousePrivate and QDirectFBKeyboardPrivate
Reviewed-by: TrustMe
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| | |
|
| |
| |
| |
| |
| |
| | |
Regression since my last commit.
Task-number: 152227
|
| |
| |
| |
| |
| |
| |
| | |
This is also a work around for a bug in gcc on powerpc (embedded-linux)
Task-number: 258358
Reviewed-by: jbache
|
| |
| |
| |
| | |
Also marked the other QHttpXxx classes as \obsolete.
|
| |
| |
| |
| |
| |
| |
| | |
The classes marked \obsolete are no longer included in the
"All Classes" list. They are listed separately on an
"Obsolete Classes" list. The new page is reachable from the
"All Classes" page and from the "Grouped Classes" page.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
The test for virtual signal did not work.
But we cannot make an error right now or it might break existing code
(exemple in task 210879)
Reviewed-by: Kent Hansen
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | | |
When an extern function is declared in the scope of another function,
MSVC sometimes ignores the enclosing namespace {}.
|
| | |
| | |
| | |
| | | |
Whoops, don't do sigaction for (nonexistent) signal 0.
|
| | |
| | |
| | |
| | | |
the property is set, not what doesn't happen when the property is not set.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Also add additional overload.
Reviewed-by: Andreas
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When premultiplying a color with the opacity, the color's alpha channel
was not set correcly.
Reviewed-by: Tom
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Texture filtering was set before binding the texture, so the gradient
spread was not set correctly.
Reviewed-by: Tom
|
| | |
| | |
| | |
| | | |
Reviewed-by: Tom
|
| | |
| | |
| | |
| | | |
Reviewed-by: Tom
|
| | |
| | |
| | |
| | | |
Reviewed-by: Tom
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I added a QGLContextResource class which can be used internally in Qt
for sharing resources between contexts. The QGLContextResource is a
hash map where the context is used as 'key', and the resource is the
'value'. All the sharing contexts point to the same resource, and the
resource is automatically deleted when it is not referenced any more.
Now, the shader manager uses the QGLContextResource class.
I also added a pointer to a struct in the QGLContextPrivate class. The
struct is shared between all the sharing contexts and is deleted
automatically. Currently, the struct only contains the resolved OpenGL
function pointers.
The shared context register code has been simplified.
Reviewed-by: Tom
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Inheritence of fill attributes was implemented by copying attributes
from the parent node. This approach wouldn't work if the node is
referenced by a 'use' element. Now, only the fill attributes which have
been explicitly set are applied on the painter while drawing.
Reviewed-by: Tor Arne
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
This gives a 5% improvement in performance by avoiding iterating over
the contents more than once.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Avoid calling functions that may have other side effects, like
QString::utf16(). Use pointers whenever possible when iterating over
the string.
|
| | |
| | |
| | |
| | |
| | | |
Use qt_nameprep after all since it's extremely fast for ASCII only and
it does in-place replacement.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since we're going to do nameprepping anyways, avoid the lowercasing
step at the function entry (and thus, one extra temporary). The
nameprepping step is also faster than QString::toLower for the ASCII
case.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Unfortunately, I can't do it all inline because the punycode encoding
and decoding requires reading the source several times. (Maybe the
decoding can be done with some effort in the future)
|
| | |
| | |
| | |
| | | |
This will allow to do less allocations in qt_ACE_do.
|
| | |
| | |
| | |
| | |
| | | |
This way, we can improve QUrl parsing performance by avoiding
unnecessary copies.
|