| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
| |
The reason being that there was an assumption that any non-curved path
was a continous polyline. For paths with multiple subpaths in it
we need to split this up into multiple strokePolygonCosmetic calls.
Task-number: 257621
Reviewed-by: Kim Motoyoshi Kalland
|
|
|
|
|
|
|
|
|
| |
We normally pad the clip rect with the size of the pen and miterlimit
to avoid this, but this didn't handle the case where there was a long
diagonal dash. We also need to multiply the padding with the longest
dash.
Reviewed-By: Tom Cooksey
|
|
|
|
|
|
|
| |
This is a huge impact on performance whenever this path is
taken.
Reviewed-By: Tom Cooksey
|
|
|
|
|
|
|
| |
Regression breakage introduced by the PropertySheet::isEnabled handling in 4.5.
Task-number: 253278
Reviewed-by: Jarek Kobus <jkobus@trolltech.com>
|
|
|
|
|
|
|
|
| |
The translator had been installed for the jui format, but the extension
wasn't recognized.
Task-number: 258547
Reviewed-by: Gunnar
|
| |
|
|
|
|
| |
Reviewed-by: Noam Rosenthal <noam.rosenthal@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Always check the mouse data we read for coordinates rather than asking
the layer. This approach works whether we have layers enabled/window
management enabled or any combination thereof.
Also, make sure we use a software cursor when either of NO_WM or
NO_LAYER is defined.
Reviewed: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
| |
Minor optimization.
Also make sure cursor is drawn in flush even if we're not in Offscreen
mode.
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
Minor optimization
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
| |
Make sure that these calls are in the right order.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch vastly simplifies the geometry handling (setGeometry/move)
It also implements a mode in which DirectFB implementations that do not
support windows can use an offscreen buffer as its backing store.
Previously the only way to do this was to paint directly on the primary
surface. This didn't work when the dfb driver didn't support an
accelerated mouse cursor.
It also detects the situation when the cursor isn't accelerated and
takes care of painting it manually when needed.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code should be a noop in the case where one has a proper dfb cursor
and proper dfb window handling. This was the only case it actually
worked.
This patch makes it work for a screen cursor rendered by Qt and sets
exposeRegion up to work for using an offscreen backing store.
Since one can't query the background color set by directfb this patch
also adds a connect option to set the background color. This is needed
for erasing the background when the mouse cursor moves.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had this #ifdef __OPTIMIZE__ there so that the compiler would know
not to generate unnecessary calls and a long jump table for the switch
of the marshalling code.
Turns out that in release mode, the checks I added to make sure we
detect invalid object paths and signatures were never hit (we always
treated them as pure strings).
So use the signature- and object path-checking code in both release
and debug mode.
Task-number: reported via email (tst_qdbusmarshall failing)
Reviewed-by: Peter Hartmann
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In some cases we might get an invalid timestamp that is far away in
the future, so remembering it will break all consequent X calls that
require a timestamp because it just contains junk (for example
clipboard will stop working). This happens with XIM+SCIM pair -
whenever we start input method and type something to the widget, we
get a XKeyPress event with a commited string, however the 'serial' and
'time' members of the XEvent structure are not initialized (according
to valgrind) and contain junk.
This reverts commit 2ed015b8a0ffad63f0f59b0e2255057f416895fb.
Reviewed-By: Brad
|
|
|
|
|
|
| |
got a new certificate, which is self-signed now
Reviewed-by: Thiago
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm not all to happy with this fix, but its the best that one can
acheive given the current design. The problem is that QPdfBaseEngine
sets a number of states as part of updateState(), but only when we are
playing back through the alpha engine. These states are used in some
draw functions, also when we are recording in the alpha engine. This
leads to the states and their checks being out of sync. So to follow
the existing pattern in the code we need to not touch d-> vars prior
to a check to usesAlphaEngine.
Reviewed-By: Eskil
|
|
|
|
|
|
|
|
| |
The signal could be connected a huge number of times
This is already fixed in master with Qt:UniqueConnection
Task-number: 258381
|
|
|
|
|
|
| |
I had missed this one in my rounds of updates. Bad me.
Reviewed-by: Thorbjorn
|
|
|
|
|
|
|
| |
Setting a file from a resource would result in 'qrc::/file' as
the resource browser returns ':/file'.
Reviewed-by: Jarek Kobus <jkobus@trolltech.com>
Initial-patch-by: andy <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
| |
This is confirmed to resolve a number of problems from the original
reportee. It's already fixed in Qt 4.6 in a more wider fix, but this
one liner is a good to have in Qt 4.5.x anyway.
Task-number: 258194
Reviewed-by: alexis
|
| |
|
|
|
|
| |
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
| |
Don't know how this got lost in the original submit since I had added
both.
Task-number: 257080
Reviewed-by: nrc
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
| |
Task-number: 257080
Reviewed-by: nrc
|
|
|
|
|
|
|
|
|
| |
Properly load the raw headers and properly handle the redirection
when having a network cache in AlwaysCache mode (equals the offline
mode in web browser).
Task-number: 256240
Reviewed-by: Thiago Macieira
|
|
|
|
|
| |
Every source file must end with a newline, otherwise:
"Error: There is extra text on this line."
|
|
|
|
|
|
| |
Fix QDirectFBMousePrivate and QDirectFBKeyboardPrivate
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
In Turkish, lowercase('I') is 'ı', which means comparing "iso-8859-1"
to "ISO-8859-1" will fail.
Reviewed-by: Denis Dzyubenko
|
|
|
|
|
|
|
| |
Trivial fix. Reported by Michael Brasser.
Task-number: 258337
Reviewed-By: Peter Hartmann
|
|
|
|
|
|
|
|
|
|
| |
If you start a hand scrolling and during moving, you press another button
of the mouse than the left one, the scrolling suddently stop working.
In mouseReleaseEvent we just stop the hand scrolling if the button is
left.
Task:258356
Reviewed-by:janarve
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disabled.
Spend a lot of time looking at this and at the CoreFoundation source
code and it seems that we really do get a notification even after the
notifier is disabled. I suspect there's a race condition between when we
disable the socket notifier, but the kernel flags it as needing a read,
then CoreFoundation just sends the notification without checking if the
CFSocket has been disabled. No further notifications come of course.
Since this breaks the invariant that was set in the assert, I'm
replacing it with an if check.
Task-number: 258198
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
|
| |
during application desctruction globalEngineCache is deleted as part
of Q_GLOBAL_STATIC macro. Other instances of code that happen to use
QRegex after the cache destruction will subsequently crash. Most common
reason are other Q_GLOBAL_STATIC instances which happen to use QRegExp
as part of their destructor.
Reviewed-by: Rhys Weatherley
|
|
|
|
|
| |
- make -input-codec affect PO files, default to UTF-8
- add -output-codec for PO files, same default
|
|
|
|
|
|
| |
There is no QDirIterator::isValid() function.
Reviewed-by: David Boddie
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pushSubDirectory was operating on nextFileInfo when it should really be
using the path received as argument.
This fixes an issue introduced when currentFilePath variable was
removed, that was exposed in the auto-tests; fixes a regression
introduced in 4.5.0 -- test case a couple of commits back.
This also allows refactoring calling code and avoid repetition.
Task-number: 258230
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference between a canonical and absolute paths is subtle, and not
what QDirIterator is about. With this change, we still avoid loops
generated by symbolic links but won't duplicate entries because of these
differences.
While at it, when avoiding loops with symbolic links, please don't mess
with the next path! That only added inconsistency.
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
| |
One less variable to maintain reduces the number of bugs and improves
consistency.
Reviewed-by: Olivier Goffart
|
|
|
|
|
| |
Task-number: 258230
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, don't call QWSWindowSurface::winId() in the destructor, as it
will actually request a new id if there isn't already one around - which
is a bit silly and highlighted the "real" bug.
Second, make sure QWSDisplay::Data::takeId() asks for 1 new id before
waiting for more ids to arrive. This is because waitForCreation() calls
QWSServer::processEventQueue(). If the events in the queue cause
takeId() to be called, QWSDisplay::Data::takeId() gets called
recursively. Even though there will be a create 15 ids command in the
queue, that will only allow 15 QWSDisplay::Data::takeId() calls to
return. The 16th call to QWSDisplay::Data::takeId() on the stack will
not be able to return because all the IDs have been taken and (because
it has been called recursively) no new create id commands have been
generated. So the 16th call to takeId() spins in waitForCreate().
Reviewed-by: Paul
|
|
|
|
|
|
| |
replace implicit normalization of individual messages on file writeout
with global normalization which is called by the command line tools.
this should a) be faster and b) cover the most critical case: lrelease.
|
|
|
|
|
| |
Task-number: 236891
Reviewed-By: David Boddie
|
|
|
|
|
|
|
| |
86ea4dbb5a748491656d9621ecd58238bc3e3d82 accidentally took out this
line.
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
Make the code easier to read.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
drawColorSpan is never called from anywhere so we might as well get rid
of the code.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
If DSCAPS_SYSTEMONLY is specified we shouldn't try to create the surface
in video memory.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DirectFB declares variables that are bit fields as enums.
E.g.
DFBSurfaceCapabilities caps;
caps |= DSCAPS_LOCK; // doesn't compile in C++
Work around this problem by declaring operators for these operations.
This greatly improves the readability of the code.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
| |
If the widget under mouse is hidden, Qt can generate a synthetic mouse move
event which gets delivered to the already hidden widget. This can then result
in the wrong item being selected.
Workaround: in QListView, ignore mouse move events when the widget is hidden.
Reviewed-by: Denis
|