| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
That's what I get for not having the brain on when accepting
suggestions...
Reviewed-by: Thiago Macieira
|
|
|
|
|
|
|
| |
Also changed tested type from int to qint64, so we'll be able to see
clipping issues, although there are no large files in this test, yet.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When not using native HANDLEs, the return of isSequential was hardcoded
to true for files with a fd, and for the standard FILE* streams stdin,
stdout and stderr; false for all other FILE* streams.
We now use the native GetFileType call for all files by obtaining a
native handle where required. We also treat files of type FILE_TYPE_CHAR
as sequential, as is the case for the standard streams in console
applications.
When standard streams are redirected to/from files, GetFileType will
return FILE_TYPE_DISK for them and they won't be considered sequential.
This is alright since in this mode they behave like regular files and
QFile::seek() will work for random offsets.
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
| |
The test assumed fileName was stable, but it is documented behaviour
that this can be reset when a file descriptor or FILE* stream is
associated with a QFile. This was the case on Windows.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Obtain file size directly, instead of relying on fseek/ftell and messing
with the file position.
Also changed the return value on errors to 0. This is mostly relevant on
streams and pipes, where we used to return whatever error value ftell
returned (usually -1). This change also makes the return value
consistent with what is returned on Unix platforms and what we document
for Windows CE.
Nevertheless, documentation of this and related issues is misleading and
needs to be updated.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
| |
While POSIX specifies a -1 return on error, on Windows only non-zero is
documented for error conditions. All platforms agree that zero is
returned on success so we check for that instead.
Reviewed-by: Markus Goetz
|
|
|
|
| |
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
| |
The test case creates a (tentatively sparse) very large file with
scattered data and uses it to test various aspects of large file support
in QFile.
Reviewed-by: Thiago Macieira
|
|
|
|
|
|
|
|
|
|
|
| |
This was already being done when attaching to FILE* streams. Doing the
same here makes the API consistent and more usable. Namely, one can use
QFile::pos() to obtain the file position.
Test case verifies this doesn't break support for sequential files. More
thorough test case included in large file support test.
Reviewed-by: Thiago Macieira
|
|
|
|
| |
Reviewed-by: Thiago Macieira
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creating a file mapping for each view mapped to memory is sub-optimal
and slow. With this change, a single mapping is created and reused when
mapping subsequent views of the file.
The handle returned from CreateFileForMapping (used in WinCE 5) is now
discarded, since the kernel manages it automatically with the file
mapping. This simplifies use of the deprecated map API.
Reviewed-by: Maurice Kalinowski
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
|
|
| |
We would previously silently ignore overflows in 32-bit systems and not
properly support 64-bit offsets in systems that support it because of
integer overflow.
There was also a problem that could prevent unmap from succeeding,
because we were passing the wrong length argument.
Task-number: QT-1594
Reviewed-by: Thiago Macieira
|
|
|
|
|
|
|
| |
In platforms with Large File Support, we use mmap64, to be able to
handle offsets (and therefore files) larger than 2Gb.
Reviewed-by: Thiago Macieira
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The two major points were:
- Replacing "s60" with "symbian" in all event handling functions,
since there is nothing S60-specific about them.
- Replace the Symbian event types with the encapsulating
QSymbianEvent container. This allows us to cope with more types of
events in the future without having to add new virtual functions.
AutoTest: QWidget passed
Task: QT-1156
RevBy: Jason Barron
RevBy: Shane Kearns
RevBy: Sami Merila
|
|
|
|
|
|
|
|
| |
In editable QComboBoxes we used cutting-edge technology to display the
text. But that's not always wanted. We actually want to see all pixels
of a string like "why oh why". The lower edge was cut off.
Reviewed-by: thartman
|
|
|
|
|
|
|
|
|
| |
This reverts commit a6af1538ea53408399fb29870a4ef16a92c7893a.
armv6 is not supported by public SDKs, due to armv6/urel not existing.
Such SDKs needs to be fixed by copying the armv5 files. Hence we revert,
and postpone until we have SDKs which actually support armv6, and until
we have a stronger insight into what advantages armv6 brings.
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
| |
If a project was built for more than one target with single sbs
command, .make.cache generation could sometime fail because multiple
jobs attempted to write into it simultaneously. Now only one of the
specified targets will be used to generate .make.cache, making
collisions impossible.
Reviewed-by: Janne Anttila
|
|
|
|
|
|
|
|
|
|
| |
TabWidget for S60Style is too small for touch use, it is rather hard to
accurately touch the tabpane to switch the active tab.
To fix this, we ask the native tabpane height from AVKON and set the
QTabWiget's pane height to native height (or bigger).
Task-number: QTBUG-4243
Reviewed-by: Alessandro Portale
|
|
|
|
|
|
|
|
| |
Change from armv5 to armv6 by default. This updates documentation, the
convenience scripts, and the Raptor/abld qmake generator to use armv6 instead.
Task-number: QTBUG-4891
Reviewed-by: Jason Barron
|
| |
|
|
|
|
| |
Forward port the vxworks changes from d7b688870aead912690188b324d370b920a7a600
|
|
|
|
|
|
|
|
| |
Details: Details: Make localtime a static function. This is needed for linking sqlite3.lib
into webkit and it generally makes sense for our build of sqlite using
the amalgamated build.
(cherry picked from commit 5e326c74239eecbd3e64df90ebbafaf51530d43d)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Include <qconfig.h> and rely on Qt's QT_NO_THREAD
instdead of SQLite's THREADSAFE to toggle source code
releated to threading in SQLite.
* compilation for Windows CE 6
While for WinCE 5 localtime is declared but not defined
in the libraries, for CE 6 they are not even declared.
That usually makes sense but sqlite relies on it being
present in time.h. As sqlite defines their own localtime
for Windows CE, we "only" need to forward declare it
earlier.
Conflicts:
src/3rdparty/sqlite/sqlite3.c
|
| |
|
|\ |
|
| |
| |
| |
| | |
Increasing the alignment does not seem to affect MBX.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When qmake was ran with -r over a subdirs project then it would lose the
error code if a later project succeeded.
This is a refix of the previous revert which has been confirmed to work
all over the place now.
Reviewed-by: Marius Storm-Olsen
|
| |
| |
| |
| |
| |
| | |
Just the default font size will not work for this case. We set it to smaller one. Notice: we should make sure view->length() is different between view->setStretchLastSection(true) and view->setStretchLastSection(false).
RevBy: Aleksandar Babic
|
| |
| |
| |
| |
| |
| |
| |
| | |
with a sample implementation for QAccessibleButton. Not implemented
for all widgets yet (API is preliminary).
Patch has been in the accessibility-fixes branch of qt-maemo for quite
a while now without complains, thus no reviewer.
|
| |
| |
| |
| |
| | |
Patch has been tested thorougly in the accessibility-fixes branch
of the qt-maemo repository, thus no review
|
| |
| |
| |
| |
| | |
The offending code is normally ifdef'ed out, so the bug did not manifest
itself before.
|
| |
| |
| |
| |
| |
| |
| | |
This will result in a warning if the path entered doesn't exist,
which is the behavior of native applications.
Reviewed-by: Prasanth
|
| |\ |
|
| | |
| | |
| | |
| | | |
Reviewed-by: Joerg
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Accounting for double resolution devices on Windows Mobile in the test
data sets (tst_qgraphicsview_2.cpp).
Skipped a test involving mouse tracking (tst_qgraphicsview.cpp).
Reviewed-by: Joerg
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If we reparent a naive menu bar inside a widget that
has a menu bar from before, the old menu bar is lost.
This patch makes sure that we don't set the new
menu bar in this case, but let it remain as-is in
case the widget is reparanted out again later.
Rev-By: MortenS
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
softKeyActions QHash in QDialogButtonBoxPrivate was not kept properly
in sync with standardButtonHash, causing QFileDialog to crash upon
startup.
Reviewed-by: Sami Merila
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Gives better performance in the raster paint engine.
For Symbian 9.3 onwards, this can also be used as the native pixmap
format. For 9.2, conversion is required.
Reviewed-by: Sami Merila
Reviewed-by: Jani Hautakangas
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
QS60Style disregards all selection behaviors for itemviews. This leads
to error when showing a highlighted selection rect; rect is only shown
for cell having focus.
Fixed by setting the highlight to all 'selected' cells.
Task-number: QT-693
Reviewed-by: Alessandro Portale
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-4867
Reviewed-by: Aleksandar Sasha Babic
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This will be handled differently (QTBUG-4751)
This reverts commit b12fb5861ce09539c04cd51db12a9bfbe32a4774.
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | | |
sha1 of the fix: 2633931653757decd93dd3939c09f5e07203da1c
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Reviewed-by: thierry
Reviewed-by: pierre
|
| | | |
| | | |
| | | |
| | | | |
Reviewed-by: alexis
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
After this commit, when you modify the spacing of an anchor you are
effectively modifying the preferred size of the anchor, since all
anchors (except internal ones) have their minimumSizeHint to 0 and
maximumSizeHint to QWIDGETSIZE_MAX.
I also changed the sizeHintsFromItem to be more generic so that I could
use it for anchors. (Thus, it was renamed to "internalSizeHints"). It
now only takes care of setting the min/pref/exp/maxSize of AnchorData
based on the anchor/item size hint and their size policies.
As a consequence of all of this, setFixedSize changed behaviour and
became setPreferredSize (since setSpacing is basically setPreferredSize).
The implementation of that now only sets the prefSize.
The patch also has an unrelated fix for IgnoreFlag, where it will
(again) return the minimumSize for sizeHint(Qt::PreferredSize) instead
of the maximumSize. This was to be more consistent with
qgridlayoutengine.cpp. The docs are not very clear on this behaviour
unfortunately.
This API change has been discussed.
Reviewed-by: alexis
|