| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commits 6e5774d84e7e3b68736f95fae09a084bd5b9ac7a and
014af3e99616f9ee13ca365566828f7daf77a7f6 broke the Qt build for Visual
Studio / IncrediBuild. The problem is as follows: QtWebKit has too many
entries in INCLUDE_PATHS. In moc.prf is a rule that builds a
mocinclude.tmp that contains command line options for moc.
moc gets then called with @mocinclude.tmp.
Above commits create an QMAKE_EXTRA_TARGET for the mocinclude.tmp,
which is necessary for parallel MinGW builds.
Alas, qmake -tp vc doesn't support QMAKE_EXTRA_TARGET.
See task 189914. Once this task is solved, this commit must be reverted.
Reviewed-by: joao
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
passing any `-j' to make.
Change 6e5774d84e7e3b68736f95fae09a084bd5b9ac7a made the problem much
less likely to occur, but in a debug_and_release build, debug and
release would share the same mocinclude.tmp. Therefore, if
exceptionally unlucky, the bug could still arise.
Put mocinclude.tmp under MOC_DIR so each exclusive build has its own.
Reviewed-by: Lincoln Ramsay
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in parallel.
On Windows, when a project has a lot of INCLUDEPATHs, some extra logic
takes place to work around an issue of large command lines.
Instead of passing all the paths directly to moc.exe, the paths are
written to mocinclude.tmp which is then read from by moc.exe.
Prior to this change, every moc rule tries to write to mocinclude.tmp.
When running make with -j, this will happen in parallel, causing this
error message:
"The process cannot access the file because it is being used by another
process"
Change the logic so mocinclude.tmp is generated by its own rule.
Reviewed-by: Lincoln Ramsay
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
append the source dir to the include path, but only after the dirs with
the generated files.
this seems to have worked before only accidentally: the unqualified
default dirs were expanded to the source dir instead of the build dir,
but the build dir is added implicitly by default, so things magically
worked. now that we qualify the moc/ui dirs, projects relying on the
strange side effect suddenly break.
we should probably add the source dir to the include path by default,
but this coupling to uic/moc is closer to the historical behavior and
thus should be safer.
Reviewed-by: mariusSO
|
| |
|
|
| |
sometimes, even two reviews are not enough ...
|
| |
|
|
|
|
|
| |
this time, it can deal with directories which are absolute to start
with.
Reviewed-by: mariusSO
|
| |
|
|
| |
This reverts commit 3aff9113a9702ea6f7e099a73136a718ae1b992f.
|
| | |
|
| |
|
