| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Merge-request: 753
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
eb3afcbfb4006de4015047555cb256fcde93b954 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-05-27 John Sullivan <sullivan@apple.com>
fixed <rdar://problem/6925482> repro crash in WebCore::DragController::dragExited dropping
bookmarks (at least) over Top Sites (at least)
Reviewed by Kevin Decker
* page/DragController.cpp:
(WebCore::DragController::dragExited):
nil check m_documentUnderMouse and take the "local file" case if it's nil
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1535d41a668e5f74f44ff3aa1313a84d5718d2d7 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Fix crashes with the QObject bindings after garbage collection.
There is one QtInstance per wrapped QObject, and that QtInstance keeps
references to cached JSObjects for slots. When those objects get
deleted due to GC, then they becoming dangling pointers.
When a cached member dies, it is now removed from the QtInstance's
cache.
As we cannot track the lifetime of the children, we have to remove
them from QtInstance alltogether. They are not cached and were
only used for mark(), but we _want_ them to be subject to gc.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup,
use qDeleteAll().
(JSC::Bindings::QtInstance::removeCachedMethod): New function, to
clean m_methods and m_defaultMethod.
(JSC::Bindings::QtInstance::mark): Avoid marking already marked objects.
(JSC::Bindings::QtField::valueFromInstance): Don't save children for
marking.
* bridge/qt/qt_instance.h: Declare removeCachedMethod.
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod
with this on the instance.
2009-05-04 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Simon Hausmann.
As Qtish implementation of MIMETypeRegistry::getMIMETypeForExtension()
returns the application/octet-stream mimetype when it can't associate
extension with any mimetype, it can happen that the application/octet-stream
mimetype will hit the list of supported image formats. For instance,
it is possible when QImageReader or QImageWriter support an extension
that is not in the extensions map.
Make sure that this mimetype is not treated as displayable image type.
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
++ b/WebKit/qt/ChangeLog
2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Added a testcase to verify that cached methods in the QOBject bindings
remain alife even after garbage collection.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a3e05ad8acdead3b534d0cef772b85f002e80b8d )
Changes in WebKit since the last update:
++ b/LayoutTests/ChangeLog
2009-06-18 Chris Evans <scarybeasts@gmail.com>
Reviewed by Adam Barth.
Added test for bug 26454 (broken 8-digit hex entities).
https://bugs.webkit.org/show_bug.cgi?id=26454
* fast/parser/eightdigithexentity-expected.txt: Added.
* fast/parser/eightdigithexentity.html: Added.
2009-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Test for https://bugs.webkit.org/show_bug.cgi?id=26554
Test writing to parent and top.
* http/tests/security/cross-frame-access-put-expected.txt:
* http/tests/security/cross-frame-access-put.html:
* http/tests/security/resources/cross-frame-iframe-for-put-test.html:
++ b/WebCore/ChangeLog
2009-06-18 Chris Evans <scarybeasts@gmail.com>
Reviewed by Adam Barth.
Fix 8-digit long hex entities. Fixes bug 26454
https://bugs.webkit.org/show_bug.cgi?id=26454
Test: fast/parser/eightdigithexentity.html
* html/HTMLTokenizer.cpp: fix off-by-ones.
2009-06-20 Sam Weinig <sam@webkit.org>
Reviewed by Adam Barth.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
Shadowing of top and parent
* page/DOMWindow.idl:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
eb4957a561d3f85d4cd5602832375c66f378b521 )
Changes in WebKit since the last update:
++ b/LayoutTests/ChangeLog
2009-06-04 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Added Qt-specific expected result for Canvas pointInPath's test.
Qt's QPainterPath::contains(point) returns false if the point is
exactly along one of the edges (except the origin). Until we
find a workaround for this, compensate it in the expected result.
* platform/qt/fast/canvas/pointInPath-expected.txt: Added.
2009-01-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Oliver Hunt
https://bugs.webkit.org/show_bug.cgi?id=23242
Add testcase for incremental repaint after use of ctx.transform(), and
enhanced isPointInPath testcase to do testing after use of ctx.transform().
* fast/canvas/canvas-incremental-repaint-2.html: Added.
* fast/canvas/pointInPath-expected.txt:
* fast/canvas/pointInPath.js:
* platform/mac/fast/canvas/canvas-incremental-repaint-2-expected.checksum: Added.
* platform/mac/fast/canvas/canvas-incremental-repaint-2-expected.png: Added.
* platform/mac/fast/canvas/canvas-incremental-repaint-2-expected.txt: Added.
++ b/WebCore/ChangeLog
2008-12-18 Bernhard Rosenkraenzer <bero@arklinux.ch>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22205
Fix compatibility with bison 2.4, partially based on older patch by
Priit Laes <amd@store20.com>
* WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
2009-07-13 Cédric Luthi <cedric.luthi@gmail.com>
Reviewed by Tor Arne Vestbø.
Fix NPWindow clip rect in PluginViewMac
The rect should be in window-coordinates. This bug can be observed
with Flash 10 here: http://www.permadi.com/tutorial/cursorTracker/
* plugins/mac/PluginViewMac.cpp:
2009-07-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Ariya Hidayat.
Fix Qt implementation of WebCore::directoryName to return the absolute
directory name instead of the base file name.
* platform/qt/FileSystemQt.cpp:
(WebCore::directoryName):
2009-07-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Ariya Hidayat.
Fix WebCore::Path::isEmpty() for the Qt port to return true
if there is no element in the path.
QPainterPath::isEmpty() returns also true if there is one single
MoveTo element inside, which makes sense but doesn't patch Webcore's
is-empty definition.
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::isEmpty): Use elementCount() == 0.
2009-01-11 Simon Fraser <simon.fraser@apple.com>
Reviewed by Oliver Hunt
https://bugs.webkit.org/show_bug.cgi?id=23242
Fix CanvasRenderingContext2D::transform to do a pre-multiply,
rather than a post-multiply into m_transform. This bug did not affect
drawing, but did cause m_transform to be incorrect, which impacted
willDraw(), and isPointInPath.
Test: fast/canvas/canvas-incremental-repaint-2.html
* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::transform):
2009-07-04 Sriram Yadavalli <sriram.yadavalli@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=26439
QtWebKit fails in loading www.nytimes.com in Windows/Linux
QNetworkReplyHandler is ignoring content associated with 401 error.
This causes the XHR response handling to fail.
Simon: Added also ProxyAuthenticationRequiredError, to handle the same
case when going through proxies, as suggested by Prasanth.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
++ b/WebKit/qt/ChangeLog
Fix crash with plugins when the plugin stream is cancelled.
Similar to r26667 handle the case where didReceiveResponse on the
plugin view results in failure to set up the stream and
setMainDocumentError being called instead. This will set the
m_pluginView back to 0 and we need check for it before calling
didReceiveData.
This was triggered by consecutive execution of
LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
followed by LayoutTests/scrollbars/scrollbar-crash-on-refresh.html
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::committedLoad):
2009-07-13 Simon Hausmann <hausmann@webkit.org>
Reviewed by Ariya Hidayat.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e65b4879116f4a8b0ee8b09607eef666c68c61d6 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix shortcut keyboard handling with plugins on the Qt/Mac build.
When we receive shortcut events like Ctrl+V then the text in the QKeyEvent is
empty. If we're asked to disambiguate the event into a Char keyboard event,
we try to detect this situation and still set the text, to ensure that the
general event handling sends a key press event after this disambiguation.
* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4552f381497b5adc18714d7f6e33eba678e3a9b2 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-06-23 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Fix Qt build with Phonon.
The #include <phonon> header no longer exists. And the <Phonon> or
<Phonon/Phonon> headers have never existed (neither for us nor for the
Phonon sources). You have to select each and every header that you do
want now.
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix NPAPI mouse translation issues on Mac
The WindowRef we pass to the plugin refers to the the top level window,
so the x and y positions have to be relative to this position, but we
have to manually compensate for title bar decorations and other parents
of the QWebView since contentsToWindow() only traverses to the QWebView.
Previously we did this compensation when passing on mouse coordinates to
the plugin, which caused various issues with translations such as not
being able to close the Flash settings dialog, or the hand cursor not
appearing over links.
We now do the compensation as part of the call to NPP_SetWindow, and
then pass mouse coordinates in global context without any compensation,
similar to how both Safari and Mozilla does it.
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::globalMousePosForPlugin):
++ b/WebKit/qt/ChangeLog
2009-06-16 Morten Engvoldsen <morten.engvoldsen@nokia.com>
Reviewed by Ariya Hidayat.
Clearifying QWebFrame docs
Adding docs to toHtml() and toPlainText()
* Api/qwebframe.cpp:
|
| |
|
|
|
|
|
|
|
| |
The #include <phonon> header no longer exists. And the <Phonon> or
<Phonon/Phonon> headers have never existed (neither for us nor for the
Phonon sources). You have to select each and every header that you do
want now.
Reviewed-By: Marius Storm-Olsen
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bd7262be70c02564d655e4f2aaf79cd8302a937f )
Changes in WebKit since the last update:
++ b/JavaScriptCore/ChangeLog
2009-02-02 Darin Adler <darin@apple.com>
Reviewed by Dave Hyatt.
Bug 23676: Speed up uses of reserveCapacity on new vectors by adding a new reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=23676
* API/JSObjectRef.cpp:
(JSObjectCopyPropertyNames): Use reserveInitialCapacity.
* parser/Lexer.cpp:
(JSC::Lexer::Lexer): Ditto.
(JSC::Lexer::clear): Ditto.
* wtf/Vector.h: Added reserveInitialCapacity, a more efficient version of
reserveCapacity for use when the vector is brand new (still size 0 with no
capacity other than the inline capacity).
2009-03-19 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed <rdar://problem/6033712> -- a little bit of hardening in the Collector.
SunSpider reports no change. I also verified in the disassembly that
we end up with a single compare to constant.
* runtime/Collector.cpp:
(JSC::Heap::heapAllocate):
++ b/LayoutTests/ChangeLog
2009-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Tests for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
Incorrect URL returned to the DOM while the user drags a file
* http/tests/local/drag-over-remote-content-expected.txt: Added.
* http/tests/local/drag-over-remote-content.html: Added.
* http/tests/security/drag-over-remote-content-iframe-expected.txt: Added.
* http/tests/security/drag-over-remote-content-iframe.html: Added.
2009-04-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Alexey Proskuryakov.
Fix <rdar://problem/6755724> <audio> and <video> elements can reference local
file:/// URLs from remote in Safari
Test cases to ensure that local 'src', 'poster', and <source> are not loaded.
* http/tests/security/local-video-poster-from-remote-expected.txt: Added.
* http/tests/security/local-video-poster-from-remote.html: Added.
* http/tests/security/local-video-source-from-remote-expected.txt: Added.
* http/tests/security/local-video-source-from-remote.html: Added.
* http/tests/security/local-video-src-from-remote-expected.txt: Added.
* http/tests/security/local-video-src-from-remote.html: Added.
* http/tests/security/resources/load-media.cgi: Added.
* http/tests/security/resources/silence.mpg: Added.
2009-04-14 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Part of <rdar://problem/6150868>
Test for incorrect handling of content that needs to go into the head element
once the head element has been removed.
* fast/parser/head-content-after-head-removal-expected.txt: Added.
* fast/parser/head-content-after-head-removal.html: Added.
2009-04-08 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Big Boy" Garen.
Tests for <rdar://problem/5745677> Possible to stop load during an unload event
* fast/events/resources/pass.html: Added.
* fast/events/resources/subframe-stop-load-in-unload-handler-using-document-write.html: Added.
* fast/events/resources/subframe-stop-load-in-unload-handler-using-window-stop.html: Added.
* fast/events/stop-load-in-unload-handler-using-document-write-expected.txt: Added.
* fast/events/stop-load-in-unload-handler-using-document-write.html: Added.
* fast/events/stop-load-in-unload-handler-using-window-stop-expected.txt: Added.
* fast/events/stop-load-in-unload-handler-using-window-stop.html: Added.
2009-04-08 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Tests for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
* http/tests/security/XFrameOptions: Added.
* http/tests/security/XFrameOptions/resources: Added.
* http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-in-body.html: Added.
* http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-parent-same-origin-allow.html: Added.
* http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe-parent-same-origin-deny.html: Added.
* http/tests/security/XFrameOptions/resources/x-frame-options-deny-meta-tag-subframe.html: Added.
* http/tests/security/XFrameOptions/resources/x-frame-options-deny.cgi: Added.
* http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-allow.cgi: Added.
* http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-deny.cgi: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html: Added.
* http/tests/security/XFrameOptions/x-frame-options-deny.html: Added.
* http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html: Added.
* http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html: Added.
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Update tests for <rdar://problem/6330929>
https://bugs.webkit.org/show_bug.cgi?id=21456
* dom/xhtml/level2/html/HTMLFormElement10-expected.txt:
* fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
* fast/dom/Window/dom-access-from-closure-window-expected.txt:
* http/tests/security/cross-frame-access-document-direct-expected.txt: Added.
* http/tests/security/cross-frame-access-document-direct.html: Added.
* http/tests/security/resources/cross-frame-iframe-for-document-direct-test-victim.html: Added.
* http/tests/security/resources/cross-frame-iframe-for-document-direct-test.html: Added.
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Tests for <rdar://problem/6476356>
https://bugs.webkit.org/show_bug.cgi?id=23148
Test for using the correct global object for location and history object
prototype chain creation.
* http/tests/security/cross-frame-access-history-prototype-expected.txt: Added.
* http/tests/security/cross-frame-access-history-prototype.html: Added.
* http/tests/security/cross-frame-access-location-prototype-expected.txt: Added.
* http/tests/security/cross-frame-access-location-prototype.html: Added.
* http/tests/security/resources/cross-frame-history-prototype-iframe.html: Added.
* http/tests/security/resources/cross-frame-location-prototype-iframe.html: Added.
2009-03-29 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6015407> attr parsing should allow only identifiers
* fast/css/attr-parsing-expected.txt: Added.
* fast/css/attr-parsing.html: Added.
2009-03-16 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Test for <rdar://problem/6320555>
Add an upper limit for setting HTMLSelectElement.length.
* fast/forms/select-max-length-expected.txt: Added.
* fast/forms/select-max-length.html: Added.
2009-02-26 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23500
KURL::parse() incorrectly compares its result to original string
* fast/loader/url-parse-1-expected.txt: Updated results. Neither old nor new results match
Firefox precisely.
++ b/WebCore/ChangeLog
2009-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
Incorrect URL returned to the DOM while the user drags a file
* page/DragController.cpp:
(WebCore::DragController::dragExited):
(WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL,
since that only looks at the text of the document's URL. Do base our
decision on the securityOrigin(), which knows more about the document's
actual origin.
2009-04-14 Eric Carlson <eric.carlson@apple.com>
Reviewed by Alexey Proskuryakov.
Fix <rdar://problem/6755724> <audio> and <video> elements can reference local
file:/// URLs from remote in Safari
Tests: http/tests/security/local-video-poster-from-remote.html
http/tests/security/local-video-source-from-remote.html
http/tests/security/local-video-src-from-remote.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource): Don't pass url to media engine unless loader->canLoad()
says it is OK.
2009-04-14 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Part of <rdar://problem/6150868>
Fix incorrect handling of content that needs to go into the head element
once the head element has been removed.
Test: fast/parser/head-content-after-head-removal.html
* html/HTMLParser.cpp:
(WebCore::HTMLParser::HTMLParser): Remove unneeded initializer of m_head.
(WebCore::HTMLParser::handleError): Update since m_head is now a RefPtr.
(WebCore::HTMLParser::createHead): Ditto.
* html/HTMLParser.h: Make m_head a RefPtr.
2009-04-08 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Big Boy" Garen.
Fix for <rdar://problem/5745677> Possible to stop load during an unload event
Also fixes https://bugs.webkit.org/show_bug.cgi?id=20605
Tests: fast/events/stop-load-in-unload-handler-using-document-write.html
fast/events/stop-load-in-unload-handler-using-window-stop.html
Don't allow calling methods that would stop the new load inside the unload
event.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::stopAllLoaders):
* loader/FrameLoader.h:
2009-04-08 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for <rdar://problem/6226200> Implement Microsoft's X-FRAME-OPTIONS anti-framing defense
Tests: http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html
http/tests/security/XFrameOptions/x-frame-options-deny.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow.html
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Stop the current load and redirect to about:blank
if an X-FRAME-OPTIONS <meta> tag http-equiq dictates we should.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions): Add logic to parse
the X-FRAME-OPTIONS parameter.
* loader/FrameLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveResponse): Stop the current load if framed and
a X-FRAME-OPTIONS header and its parameter dictate that we should.
2009-04-05 Simon Hausmann <hausmann@webkit.org>
Fix the Qt build.
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMethod::createPrototype): Take the JSGlobalObject
as second argument.
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
<rdar://problem/6330929>
https://bugs.webkit.org/show_bug.cgi?id=21456
Don't update the document pointer for all inactive windows on navigations.
This change causes us to differ slightly from Firefox when accessing the
document from within a closure tied to a navigated context, but as all
browsers differ on this edge case, I don't foresee compatibility issues.
Test: http/tests/security/cross-frame-access-document-direct.html
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::~JSDOMWindowBase):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::updateDocument):
* bindings/js/ScriptController.h:
2009-04-03 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for <rdar://problem/6476356>
https://bugs.webkit.org/show_bug.cgi?id=23148
- Use the window object the Location and History objects are directly associated with
instead of the lexical global object to pick the object prototype to serve as the
base of the their respective prototype chains.
- Re-factor as necessary to allow passing the correct global object to the createPrototype
functions.
Tests: http/tests/security/cross-frame-access-history-prototype.html
http/tests/security/cross-frame-access-location-prototype.html
* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::JSAudioConstructor):
* bindings/js/JSDOMBinding.cpp:
(WebCore::getCachedDOMStructure):
(WebCore::cacheDOMStructure):
* bindings/js/JSDOMBinding.h:
(WebCore::getDOMStructure):
(WebCore::getDOMPrototype):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::history):
(WebCore::JSDOMWindow::location):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::JSImageConstructor):
* bindings/js/JSMessageChannelConstructor.cpp:
(WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
* bindings/js/JSNamedNodesCollection.h:
(WebCore::JSNamedNodesCollection::createPrototype):
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::JSOptionConstructor):
* bindings/js/JSRGBColor.h:
(WebCore::JSRGBColor::createPrototype):
* bindings/js/JSWebKitCSSMatrixConstructor.cpp:
(WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
* bindings/js/JSWebKitPointConstructor.cpp:
(WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
* bindings/js/JSWorkerConstructor.cpp:
(WebCore::JSWorkerConstructor::JSWorkerConstructor):
* bindings/js/JSXMLHttpRequestConstructor.cpp:
(WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
* bindings/js/JSXSLTProcessorConstructor.cpp:
(WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/objc/objc_runtime.h:
(JSC::Bindings::ObjcFallbackObjectImp::createPrototype):
* bridge/runtime_array.h:
(JSC::RuntimeArray::createPrototype):
* bridge/runtime_method.h:
(JSC::RuntimeMethod::createPrototype):
* bridge/runtime_object.h:
(JSC::RuntimeObjectImp::createPrototype):
* page/DOMWindow.idl:
2009-03-29 Darin Adler <darin@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6015407> attr parsing should allow only identifiers
Test: fast/css/attr-parsing.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseContent): Allow only CSS_IDENT, and filter out
identifiers that start with "-".
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText): Added a case for CSS_ATTR so the test
case works. This has the pleasant side effect of fixing a bug too.
2009-03-16 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Fix for <rdar://problem/6320555>
Add an upper limit for setting HTMLSelectElement.length.
Test: fast/forms/select-max-length.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setOption):
(WebCore::HTMLSelectElement::setLength):
2009-03-10 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fix for <rdar://problem/6166844>
https://bugs.webkit.org/show_bug.cgi?id=24495
Use same rule for loading java applets as we do for images.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::createRenderer):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem):
2009-02-26 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=23500
KURL::parse() incorrectly compares its result to original string
* platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
|
| |
|
|
| |
Reviewed-by: Ariya
|
| |
|
|
|
|
|
|
|
|
| |
Adding docs to toHtml() and toPlainText()
Task-number: 253088
Rev-by: Ariya Hidayat
Rev-by: David Boddie
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
origin/qtwebkit-4.5 ( 4ee8af9348b3f57d3c0f3575ae0a58336cf07a92 )
Changes in WebKit since the last update:
++ b/LayoutTests/ChangeLog
2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=24510
Add a test case that Netscape Plugin can properly
determine if a given object has a specific method
and property.
The test will ask the plugin to call hasproperty and
hasmethod and will compare the result with what is
expected. This approach is taken from
netscape-get-property-return-value.html
* plugins/netscape-invoke-browserfuncs-expected.txt: Added.
* plugins/netscape-invoke-browserfuncs.html: Added.
++ b/WebCore/ChangeLog
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Do not call the parent implementation (Widget::) in show() and hide()
of the PluginViewQt, as it always changes the visible state of the
platformWidget (equal to the platformPluginWidget in the Qt port),
thus ignoring the isParentVisible() test.
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
2009-04-22 Tamas Szirbucz <szirbucz.tamas@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=25023
Delete reply in QNetworkReplyHandler::abort() to avoid leak.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::abort):
2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=24510
Fix a bug where the browserfuncs were not properly assigned,
make hasproperty use _NP_HasProperty and hasmethod _NP_HasMethod.
Test: plugins/netscape-invoke-browserfuncs.html
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::load): Fix assignment
* plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::load): Fix assignment
++ b/WebKit/qt/ChangeLog
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Fix a plugin bug in the WebKit code, similar to the one in WebCore.
The problem is when a non visible QtPluginWidget would show it self
in a sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::):
++ b/WebKitTools/ChangeLog
2009-05-14 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=24510 where
Add testHasProperty and testHasMethod to the existing functions
of the PluginObject to be able to test the browser hasproperty
and hasmethod implementation. Invoke them from pluginInvoke.
Change the defines to an enum to avoid manually updating
NUM_METHOD_IDENTIFIERS and assigning numbers.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(testHasProperty): test hasproperty
(testHasMethod): test hasmethod
(pluginInvoke): invoke the two
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
origin/qtwebkit-4.5 ( 40b523e9eaaba38c182e5a9c319f0069ebf98330 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-05-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Holger Freyther.
Change Qt port to match the mac and windows ports, and unregister plugins when plugins are stopped.
Not doing that can cause assersion failure.
https://bugs.webkit.org/show_bug.cgi?id=25702
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::stop):
|
| |
|
|
| |
This was accidentally committed.
|
| |
|
|
|
|
| |
origin/qtwebkit-4.5 ( 7b8d6ab6f2b73862d11c2a41ab0223e55585d88f )
Changes in WebKit since the last update:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
origin/qtwebkit-4.5 ( 7b8d6ab6f2b73862d11c2a41ab0223e55585d88f )
Changes in WebKit since the last update:
++ b/WebKit/qt/ChangeLog
2009-03-27 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=24746
Improved selection tests.
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::textSelection):
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
origin/qtwebkit-4.5 ( 1f83e4058bffd5a3fe7e44cf45add01953a772d4 )
Changes in WebKit since the last update:
++ b/LayoutTests/ChangeLog
2009-05-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Dimitri Glazkov.
Added Qt-specific expected result for toDataURL test, since Qt
does not support saving pixmaps to GIF.
* platform/qt/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
2009-05-12 Ariya Hidayat <ariya.hidayat@nokia.com>
Rubber-stamped by Simon Hausmann.
Added Qt-specific expected result for Canvas getImageData's test.
https://bugs.webkit.org/show_bug.cgi?id=22150
Since Qt is internally using premultiplied ARGB32 for doing
alpha-blending painting, reading the color back will not
necessarily give the same exact color.
* platform/qt/Skipped: Excluded canvas-getImageData.
* platform/qt/fast/canvas/canvas-getImageData-expected.txt: Added.
2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Fraser.
Updated expected results after Qt's GraphicsContext fixes.
* platform/qt/fast/canvas/set-colors-expected.txt:
2009-04-24 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
Added Qt-specific expected result for color conversion.
This is to compensate the lack of color profile in Qt to do
color conversion, hence CMYK 0,0,0,1 always give pure black (#000)
instead of very dark black.
* platform/qt/fast/canvas/set-colors-expected.txt: Added.
++ b/WebCore/ChangeLog
2009-05-18 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann.
Done together with Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>.
https://bugs.webkit.org/show_bug.cgi?id=24551
[Qt] Reuse FontPlatformData for the same FontDescription.
This effectively prevents growing heap usage for loading every web page.
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::qHash): Necessary for FontPlatformDataCache.
(WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
it exists, otherwise create a new one and insert it in the cache.
2009-05-18 Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=24551
[Qt] Fix the leak in FontFallbackList::fontDataAt() function.
When creating a new instance of SimpleFontData, put it in the font list
so that it can deleted later on.
* platform/graphics/qt/FontFallbackListQt.cpp:
(WebCore::FontFallbackList::invalidate):
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::fontDataAt):
2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Holger Freyther.
[Qt] In the image decoder, remove the raw image data represented as QImage
once the image is converted to QPixmap and inserted in the pixmap cache.
This effectively reduces the heap usage when running on graphics system
other than raster (i.e the case where QImage != QPixmap).
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::imageAtIndex): Nullified the image on purpose.
* platform/graphics/qt/ImageDecoderQt.h: Made m_imageList mutable.
2009-05-15 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Holger Freyther.
[Qt] Refactor alpha channel detection the image decoder.
Sets the boolean flag as soon as the image is being read.
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ImageDecoderQt): Initialized m_hasAlphaChannel.
(WebCore::ImageDecoderQt::setData): Set the flag when appropriate.
(WebCore::ImageDecoderQt::supportsAlpha): Simplified.
(WebCore::ImageDecoderQt::reset): Resetted the flag.
* platform/graphics/qt/ImageDecoderQt.h: Added m_hasAlphaChannel.
2009-05-13 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Sam Weinig.
[Qt] Fix "lighther" composition mode.
QPainter::CompositionMode_Plus is the right match.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::toQtCompositionMode):
2009-04-29 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Fraser.
[Qt] Initialize GraphicsContext's and ImageBuffer's QPainter to match
the default values of canvas attributes.
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
2009-04-27 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=18475
[Qt] Widget painting should follow the layout direction (LTR, RTL)
of the element style, not the application layout direction.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::applyTheme):
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a6ebe3865025e2bb4d767a79435af4daf5a9b4db )
Changes in WebKit since the last update:
++ b/WebKit/qt/ChangeLog
Rubber-stamped by Ariya Hidayat.
Fix qdoc warning about link to QAction::isEnabled.
* Api/qwebpage.cpp:
2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
242472777d440a540b4bc944c84eb522388e384e )
Changes in WebKit since the last update:
++ b/ChangeLog
2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Added support for generating API docs in the Qt build using "make docs"
* WebKit.pro: Include docs.pri for "make docs" target.
++ b/WebKit/qt/ChangeLog
2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Ariya Hidayat.
Added support for generating API docs in the Qt build using "make docs"
Added code snippets and overview from the Qt sources references in the API docs.
* Api/qwebpage.cpp: Adjust paths to snippets.
* Api/qwebview.cpp: Ditto.
* docs/docs.pri: Added.
* docs/qtwebkit.qdoc: Added.
* docs/qtwebkit.qdocconf: Added.
* docs/webkitsnippets/qtwebkit_build_snippet.qdoc: Added.
* docs/webkitsnippets/qtwebkit_qwebview_snippet.cpp: Added.
* docs/webkitsnippets/simple/main.cpp: Added.
* docs/webkitsnippets/simple/simple.pro: Added.
* docs/webkitsnippets/webpage/main.cpp: Added.
* docs/webkitsnippets/webpage/webpage.pro: Added.
Moved QtWebKit documentation into the WebKit project under src/3rdparty/webkit
This is needed to have "make docs" inside WebKit and allows contributors to the
WebKit project to write API docs. I'm doing the change in 4.5 to simplify
merging with Qt 4.6.
Reviewed-by: Trust me
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
d5ea85e03f22fb6fb87275774a2c53031941017e )
Changes in WebKit since the last update:
++ b/JavaScriptCore/ChangeLog
2009-01-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
<rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2: x }), })()"
<https://bugs.webkit.org/show_bug.cgi?id=23479>
Automatic semicolon insertion was resulting in this being accepted in the initial
nodeless parsing, but subsequent reparsing for code generation would fail, leading
to a crash. The solution is to ensure that reparsing a function performs parsing
in the same state as the initial parse. We do this by modifying the saved source
ranges to include rather than exclude the opening and closing braces.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary): add an assertion for successful recompile
* parser/Lexer.h:
(JSC::Lexer::sourceCode): include rather than exclude braces.
* parser/Nodes.h:
(JSC::FunctionBodyNode::toSourceString): No need to append braces anymore.
2009-01-21 Alexey Proskuryakov <ap@webkit.org>
Suggested by Oliver Hunt. Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=23456
Function argument names leak
* parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.
2009-01-22 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
fast/js/numeric-conversion.html is broken, and corresponding
<rdar://problem/6514842>
The basic problem here is that parseInt(Infinity) should be NaN,
but we were returning 0. NaN matches Safari 3.2.1 and Firefox.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
2009-01-13 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler and Oliver Hunt.
<rdar://problem/6489314> REGRESSION: Business widget's front side
fails to render correctly when flipping widget
The problem here is that parseInt was parsing NaN as 0. This patch
corrects that by parsing NaN as NaN. This matches our old behavior
and Firefox.
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
++ b/LayoutTests/ChangeLog
2009-01-22 Oliver Hunt <oliver@apple.com>
Reviewed by Geoff Garen.
<rdar://problem/6516853> (r39682-r39736) JSFunFuzz: crash on "(function(){({ x2: x }), })()"
<https://bugs.webkit.org/show_bug.cgi?id=23479>
Add additional reparsing tests.
* fast/js/reparsing-semicolon-insertion-expected.txt:
* fast/js/resources/reparsing-semicolon-insertion.js:
(commaParenTest):
(commaParenThrowTest):
2009-01-22 Beth Dakin <bdakin@apple.com>
Reviewed by Sam Weinig.
Fix for https://bugs.webkit.org/show_bug.cgi?id=23461 LayoutTests/
fast/js/numeric-conversion.html is broken, and corresponding
<rdar://problem/6514842>
The basic problem here is that parseInt(Infinity) should be NaN,
but we were returning 0. NaN matches Safari 3.2.1 and Firefox.
* fast/js/numeric-conversion-expected.txt:
* fast/js/resources/numeric-conversion.js:
2009-01-13 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler and Oliver Hunt.
Updated test and results for <rdar://problem/6489314> REGRESSION:
Business widget's front side fails to render correctly when
flipping widget
parseInt(NaN) should be NaN.
* fast/js/numeric-conversion-expected.txt:
* fast/js/resources/numeric-conversion.js:
++ b/WebCore/ChangeLog
2009-03-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=24349
[QT] HTTP status text is never set
Set HTTP status text to the reason phrase attribute of QNetworkReply.
* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
2009-03-02 Dirk Schulze <krit@webkit.org>
Reviewed by Holger Freyther.
Added putImageData to Qt. Discussed with Ariya Hidayat.
[Qt] lacks putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::putImageData):
2009-03-01 Larry Ewing <lewing@novell.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=24080
NPN_GetValue casting to the wrong type and writing outside bounds
Make sure to cast the value to the correct type so that only
memory owned by the value is written to.
* plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
* plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
* plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic):
(PluginView::getValue):
2009-02-27 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24229
If an image has no alpha channel there is no reason to use SourceOver.
* platform/graphics/qt/ImageQt.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
2009-02-27 Zack Rusin <zack@kde.org>
Reviewed by Nikolas Zimmermann.
Qt: be more reasonable about scrolled lines
cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
irritating. so lets scroll vertically by the Qt set number of lines * Qt default
single step scroll
* platform/qt/WheelEventQt.cpp:
2009-02-25 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
Ported arcTo to Qt. Qt has no native support for arcTo. This changes
calculate the behavior of arcTo and draws it with lineTo and arc.
[QT] implement Canvas arcTo
https://bugs.webkit.org/show_bug.cgi?id=23873
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArcTo):
2009-03-12 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=24498
Fix the Qt port to use the same algorithm for drawing dashed and dotted
borders as the other ports. This makes the Qt port pixel-for-pixel perfect
compared to border drawing with Apple's canonical mac port and much closer
to konqueror and firefox behavior.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLine):
2009-03-09 Adam Treat <adam.treat@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=24463
WebCore::qstring is detaching and copying twice for every single
WebCore::TextRun that is processed and drawn. This elevates this method
to one of the top-ten most expensive methods in all of QtWebKit according
to profiling. This changes the method so that QString only detaches
when absolutely necessary.
* platform/graphics/qt/FontQt.cpp:
(WebCore::qstring):
(WebCore::fixSpacing):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
++ b/WebKit/qt/ChangeLog
2009-03-02 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=21230
On X11 match the behavior of Firefox and also copy the url to the
clipboard selection when the action Copy Link Location is executed.
* Api/qwebpage.cpp:
(QWebPage::triggerAction):
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
450331808bfe11b1472c213a8cb311190355c2de )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-02-04 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix.
Changed ASSERT(image) to ASSERT(!image.isNull()).
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getImageData):
++ b/WebKit/qt/ChangeLog
2009-03-07 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Cameron Zwarich.
These methods are clearly returning the wrong values as the two were
returning swapped information.
* Api/qwebpage.cpp:
(QWebPage::totalBytes):
(QWebPage::bytesReceived):
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e446518445c51c56471e41b1697e2a9e9f3adf36 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig.
This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getImageData):
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig and Oliver Hunt.
Added getImageData() support for QtWebKit.
[QT] lacks getImageData / putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getImageData):
2009-04-14 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=25099
When creating a QNetworkRequest make sure to populate the
CacheLoadControlAttribute with the value set by the ResourceRequest::cachePolicy() so that the cache will be used as WebKit expects.
* WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::requestCache):
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
2009-04-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
While working on <rdar://problem/5968249>, noticed some glaring problems with LocalStorage.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::localStorage): Return the cached m_localStorage object if it exists to
avoid creating multiple representations for the same underlying StorageArea.
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalLocalStorage): Return m_localStorage, not m_sessionStorage.
++ b/WebKitTools/ChangeLog
2009-02-25 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Alexey Proskuryakov.
Do not queue the calls to 'DumpRenderTree::dump()' as this can result
in more than one call as a test that calls 'notifyDone()' can then be
subsequently fully loaded and initiate a second dump. Also make sure
to stop any existing page load that is happening before running the next
test. Combined this serves to produce 217 more passing tests for the
Qt port or roughly 5% at this point.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using branch origin/qtwebkit-4.5 (f72c14123c593dc9d649d25b7186334bba0026b5)
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Don't show and hide the platformPluginWidget, as it's our QWebView
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::setParentVisible):
2009-04-06 Mike Belshe <mike@belshe.com>
Reviewed by Eric Seidel.
HTMLCanvasElement crash when ImageBuffer creation fails.
https://bugs.webkit.org/show_bug.cgi?id=23212
Check for NULL before using the ImageBuffer as we might
be low on memory and creation may have failed.
Test case creation blocked by:
https://bugs.webkit.org/show_bug.cgi?id=25055
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
2009-04-05 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=25050
Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asURL):
++ b/WebKitTools/ChangeLog
2009-03-31 Adam Roben <aroben@apple.com>
Make resolve-ChangeLogs -f work when the working tree has spaces in
its path
Reviewed by Mark Rowe and David Kilzer.
* Scripts/resolve-ChangeLogs:
(sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in
case it contains spaces.
2009-03-17 David Kilzer <ddkilzer@apple.com>
resolve-ChangeLogs should not die on unmerged non-ChangeLog files
Reviewed by Adam Roben.
Fixes the following bug in resolve-ChangeLogs:
Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.
* Scripts/resolve-ChangeLogs:
(findUnmergedChangeLogs): Check the result of findChangeLog() to
make sure we don't add undef values to the list of files being
returned.
2009-03-11 David Kilzer <ddkilzer@apple.com>
Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs
<https://bugs.webkit.org/show_bug.cgi?id=24378>
Reviewed by Adam Roben.
* Scripts/resolve-ChangeLogs: If -f|--fix-merged is not passed
and no file or directory names are specified on the command-line
then try to find unmerged ChangeLog files based on 'svn stat' or
'git diff'. Added global $isGit and $isSVN variables so that
isGit() and isSVN() only have to be called once.
(findUnmergedChangeLogs): Added.
|
| |
|
|
| |
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
9c6a4a25fe741b43dd64f5dbaeccfb647cb321fb )
Changes in WebKit since the last update:
++ b/WebKit/qt/ChangeLog
2009-04-02 Takumi Asaki <takumi.asaki@nokia.com>
Reviewed by Simon Hausmann.
Fix pre-edit handling of text fields with input methods.
The input method sends an empty preeditString() if all characters of
the preedit should be deleted. So inputMethodEvent() has to use
preeditString() if it's empty.
* Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent):
2009-03-30 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Document that setHtml/setContent loads only the html/data immediately, not external objects.
* Api/qwebframe.cpp:
* Api/qwebview.cpp:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1beae2b64b5b1e9b97e82dc94de18ebac1c19efc )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-03-27 Zack Rusin <zack@kde.org>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=24280
Fix propagation of fill rules when rendering paths in the Qt build.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::toQtFillRule):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
2009-03-27 Zack Rusin <zack@kde.org>
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=24275
Fix text field theming in the Qt build with the KDE 4 Oxygen
style by adjusting the size vertically and horizontally to
set padding on the element equal to the width of the style painted border.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
* platform/qt/RenderThemeQt.h:
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0b6fc217c2b853827926313c09bb3c32f66ffe43 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-02-06 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Hausmann.
Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
the context transparent.
[QT] clearRect fill's a given rect with white
https://bugs.webkit.org/show_bug.cgi?id=23728
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clearRect):
++ b/WebKit/qt/ChangeLog
2009-03-26 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Fix the documentation of the QLocale usage in userAgentForUrl.
* Api/qwebpage.cpp:
2009-03-20 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Fix for InsertParagraphSeparator and InsertLineSeparator so that
QWebPage::action() creates QActions for them. Also make sure they get
updated appropriately.
* Api/qwebpage.cpp:
(QWebPagePrivate::updateEditorActions):
(QWebPage::action):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::textEditing):
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
70604503a0365edaeff82ffad7b71f90641fa592 )
Changes in WebKit since the last update:
++ b/WebKit/qt/ChangeLog
2009-03-20 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Tor Arne Vestbø.
Fix QWebPage::WebActions action states to more closely match when they are
actually applicable and remove erroneous documentation.
* Most WebActions implemented using editor commands now use the
Editor::Command::isEnabled() to control their availability.
* SelectAll is always enabled (since it's editor command is).
* SetTextDirection{} family of WebActions are available when canEdit() is true
and not just canEditRichly().
Fix and clarify documentation about the availability of various web actions.
* Api/qwebpage.cpp:
(QWebPagePrivate::updateAction):
(QWebPagePrivate::updateEditorActions):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::textSelection):
|
| |
|
