| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
New private class, needed for the rewrite of the upload side of
QNetworkAccessManager. Allows to have a "byte pointer view" on stuff
like QRingBuffer, QByteArray, QFile and any QIODevice.
Reviewed-by: Thiago Macieira
Reviewed-by: Peter Hartmann
|
| |
| |
| |
| |
| |
| |
| | |
The private class was already declared and defined in the qfileinfo.cpp
file.
Reviewed-by: thiago
|
| |\ |
|
| | |
| | |
| | |
| | | |
Reviewed-by: Peter Hartmann
|
|\ \ \
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | | |
We don't need Q_D if we don't use the d pointer.
Reviewed-by:TrustMe
|
| | | |
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 253179
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using setFileName in QFile::copy (introduced recently) has a nasty
side-effect of leaking file descriptors in QTemporaryFile. This happens
because the code assumes the file has been closed. In QTemporaryFile,
we need to explicitly call native file engine close.
Test case by Thiago. Bug report from Arora developers.
Reviewed-by: thiago
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Explained why you cannot use stdin and atEnd() together.
Task-number:251171
Rev-by: Andreas Aardal Hanssen
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
qt_cmp_si_sort_flags could be read and written from different threads.
Use qStableSort with functor instead of libc's quicksort.
Found with helgrind on kdevelop
Reviewed-by: Marius Storm-Olsen
|
| | |
| | |
| | |
| | | |
This reverts commit da1416cef6b1d24156739ded101df895ee4e80d9.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We shouldn't return since the SetErrorMode was called and we need to
reset it back afterwards.
Patch-by: ritt.k
Reviewed-by: mauricek
|
| |\ \
| | |/
| | |
| | |
| | |
| | | |
Conflicts:
src/gui/kernel/qcocoaview_mac_p.h
src/gui/widgets/qmainwindow.cpp
|
| | |
| | |
| | |
| | |
| | |
| | | |
Explained why you cannot use QTextStream::atEnd with stdin.
Task-number:251171
|
| | |
| | |
| | |
| | |
| | |
| | | |
utf encoding by BOM.
Reviewed-by: Simon Hausmann
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These functions were checking the error state after calling close(),
without first resetting the error state. Turns out close() only resets
the error state if isOpen() returns false.
Also, the fallback for the copy operation opens the file for reading
but wasn't closing it again afterwards. Now fixed.
Added autotests to cover these situations.
Reviewed-by: MariusSO
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We always called QStringList::split in this function, which was
just expensive.
Reviewed-by: mauricek
|
| |\ \
| | |/
| | |
| | |
| | | |
Conflicts:
src/gui/itemviews/qheaderview_p.h
|
| | |
| | |
| | |
| | | |
Reviewed-By: thiago
|
| | | |
|
| |\ \
| | |/
| | |
| | |
| | | |
Conflicts:
tests/auto/qpainterpath/tst_qpainterpath.cpp
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
QProcessPrivate and QNativeSocketEnginePrivate were reporting a wrong
number of bytes available on 64-bit machines, due to use of size_t in
ioctl. That was required by Irix, which we dropped support for, so we
can also drop size_t
Reviewed-by: Thiago
Task-number: 249537
|
| | |
| | |
| | |
| | | |
Reviewed-by: mariusSO
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
mode, the settings are stored in
HKEY_LOCAL_MACHINE\Software\WOW6432node.
Task-number: 232011
Reviewed-by: Martin Petersson <martin.petersson@trolltech.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
RevBy: Samuel
Details: Creating the intermediate stringlist and appending all the temporary
strings to it costs quite a bit. Fix this by introducing a StringSpliter
class that is malloc-free and uses QStringRef instead.
Found during S60 Performance week
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
RevBy: Samuel
Details: We have the size of the array and we don't realloc, so we can use direct
pointer access. This saves us a few detach() calls and some refcount
checking in the inner loops...
Found during S60 Performance week...
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
RevBy: Samuel
Details: When doing initFileEngine on a operational QFileInfo, it
will detach(), which creates copy of the file engine, then
we delete this engine and create our own engine. Creating a
clean QFileInfo, saves us one temporary file engine..
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Move the cleanPath call out of the function and outside the loops to
avoid doing the same work over and over.
Reviewed-by: Gunnar Sletta
|
| | |
| | |
| | |
| | | |
Reviewed-by: mariusSO
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
mode, the settings are stored in
HKEY_LOCAL_MACHINE\Software\WOW6432node.
Task-number: 232011
Reviewed-by: Martin Petersson <martin.petersson@trolltech.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Some documentation fixes.
More clear handling of what is and isn't a valid indexes.
Added functions for the 'really long lived circular buffer use case'
Improved unit tests.
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| | |
The buffer was only shrinked if we reach exactly the end of it.
Reviewed-by: Andreas
Reviewed-by: Thiago
Task-number: 221316
|
|\ \
| |/
| |
| |
| | |
Conflicts:
tools/linguist/shared/profileevaluator.cpp
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is an untested bugfix -- comes solely from reading the code.
In QFile::copy's fallback implementation a (temporary) file is created
for block copying from the source file. When Qt is built without
temporary file support this doesn't seem to be deleted in case of an
error while block copying or renaming to the final destination.
Reviewed-by: mariusSO
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QFile made no attempt to reset the file name on a rename. We now reset
the fileEngine's fileName if it was able to handle the rename.
Otherwise, we call setFileName, which will result in reallocation of the
fileEngine.
Task-number: 244485
Reviewed-by: mariusSO
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The fallback implementation for rename would return true in some
situations where the move failed. Also the destination file might be
created and left there in these cases.
Task-number: 244500
Reviewed-by: mariusSO
|
|\ \
| |/
| |
| |
| | |
Conflicts:
src/gui/inputmethod/qximinputcontext_x11.cpp
|
| |
| |
| |
| | |
Reviewed-by: Anders Bakken <anders.bakken@nokia.com>
|
| |
| |
| |
| |
| |
| |
| | |
is not already running.
Task-number: 231513
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| | |
Handle cases where QProcess::start() and startDetached() are passed a
null, empty, or "invalid" program string instead of crashing.
Task-number: 247865
Reviewed-by: Andreas Aardal Hanssen
|
| |
| |
| |
| |
| |
| |
| |
| | |
We basically store the currentFileInfo and use another one to continue
moving into the dir.
Task-number: 247645
Reviewed-by: Olivier
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
using truncate() on the file name was a bad idea, since
the OS had to open it again - on some file systems, this would
just error out, so QFile::resize() failed by default.
Reviewed-by: Thiago
|