| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
This is future compatibility: we must rely on them being 0 in older
versions of Qt.
Reviewed-by: Bradley T. Hughes
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QContiguousCache is a new type, so there are no binary compatibility
issues.
QHash and QMap didn't have any public qMalloc / qFree, so the entire
logic is contained in .cpp code. However, since old code will not
inform us of the alignment requirements, we need to add a bit to the
structure to indicate whether strict alignment is in use or not.
QList doesn't require any changes. For small, movable types, they're
all stored in the pointer array itself, so they're aligned. For larger
types, we use new(), so types with stricter requirements should define
their own operator new().
QLinkedList cannot be fixed. It uses new() on the QLinkedListNode,
which contains a T type. Sorry.
QVector did have public qMalloc / qFree. I've moved the calls to the
inner function and made it keep the old calls if the alignment
requirement is below a certain threshold. The idea is that, if it's
above, no one was using QVector anyway.
Reviewed-by: Bradley T. Hughes
|
| |
| |
| |
| |
| |
| |
| |
| | |
The private inheritance ensures that we don't try to access the types
under the wrong pointer. If we did that, we'd cause strict aliasing
violations.
Reviewed-by: Olivier Goffart
|
|\ \ |
|
| |/
| |
| |
| | |
Reviewed-by: Denis Dzyubenko
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| | |
In qdatetime UTC conversion functions, variable res was declared in
incorrect scope and went out of scope too soon in Symbian.
Reviewed-by: Janne Koskinen
|
|\ \
| |/ |
|
| |
| |
| |
| |
| | |
Task: 262677
Reviewed-by: joao
|
|/
|
|
|
|
|
|
|
|
|
|
| |
The current implementation of qBinaryFind use 64bit arithmetics even
on a 32bit system, which make it slow
The docs mention qBinaryFind will find any occurence of the search
value not necessarily the first one, but this is not case with
current implementation
So nothing prevents the use of qLowerBound
Reviewed-by: Olivier Goffart
Merge-request: 1513
|
|
|
|
|
|
|
| |
Some of the methods used in QDate/QTime/QDateTime have been
reimplemented to use native Symbian calls.
Reviewed-by: Janne Anttila
|
|
|
|
|
|
| |
localtime_r."
This reverts commit 2f7d1318d2dc63322a468d8c301ae718eaba0d03.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OpenC incorrectly caches DST information between localtime_r
calls, i.e. if previous call to localtime_r has been called for DST
affected date, also the second call will be affected by DST even
the date is such that DST should not be applied.
The workaround is to call mktime with non-DST affected date before
calling localtime_r. mktime call resets the OpenC internal DST cache
to right value and localtime_r will return correct values.
This commit can be reverted once Open C bug 9525 has been reverted.
AutoTest: Fixes tst_QDateTime::totime_t
Reviewed-by: Aleksandar Sasha Babic
|
|
|
|
|
|
|
| |
Made it thread-safe and actually make sure that we don't initialize the
data several times.
Reviewed-by: axis
|
|
|
|
|
|
|
|
| |
Source-incompatible change
This reverts commit 8714892977269591bb9b348c6eb549a7f2c45cbc.
Rev-by: Trustme
|
|
|
|
| |
Reviewed-by: thiago
|
| |
|
|
|
|
|
|
|
|
| |
getMacPreferredLanguageAndCountry can crash when called e.g. as a
root user because CFPreferencesCopyValue will return 0.
Reviewed-by: denis
Task-number: 261664
|
|
|
|
|
|
|
| |
RVCT has problems with scoping, the similar workaround has been used
in qhash.h also.
Reviewed-by: Janne Koskinen
|
|
|
|
|
|
|
|
|
| |
Try not to hold an unused 4k QByteArray. This may introduce a
performance regression e.g. for QNetworkReply in exchange for lower
memory usage.
We will see if this is really the case.
Reviewed-by: Thiago
|
|
|
|
|
|
|
|
|
| |
such as
margins.h:90: warning: declaration of ???bottom??? shadows a member of _this_"
'a' stands for argument
Reviewed-by: jbache
|
|
|
|
|
|
|
|
|
|
| |
Get rid of the pages of warning you get when compiling code that uses
QtConcurrent::map for instance.
qmap.h:607: warning: dereferencing pointer 'y' does break strict-aliasing rules
qmap.h:605: note: initialized from here
Reviewed-by: Peter Hartmann
|
| |
|
|
|
|
|
|
| |
Because of QLocale limitations this broke other places.
Reviewed-by: Denis Dzyubenko
|
|
|
|
|
|
|
|
|
|
|
| |
It is not possible to escape a wildcard character in the Wildcard
mode of QRegExp. This follows the kind of wildcard of the CLI of Windows
The new WildCardUnix follows the escaping of a unix's bash.
Task-number: 241346
Reviewed-by: Olivier Goffart
Reviewed-by: Matthew Cattell
|
| |
|
| |
|
|
|
|
|
|
| |
Wonder how it survived for so long.
Reviewed-by: Peter Hartmann
|
|
|
|
|
|
| |
Also fix the relations in the documentation
Reviewed-by: David Boddie
|
|
|
|
|
|
|
| |
Previously it always returned the C locale's language, which is of not
much help for an application.
Reviewed-by: Morten Sorvig <msorvig@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to detect "int foo = myQReal" mistakes, one needs to compile with -Wconversion.
However that flag triggers many warnings inside Qt. This commit fixes many of them, like
qchar.h:295: warning: conversion to 'ushort' from 'unsigned int' may alter its value
qglobal.h:1026: warning: conversion to 'qreal' from 'qint64' may alter its value
qbytearray.h:441: warning: conversion to 'char' from 'int' may alter its value
Other warnings remain (such as those coming from bitfields)
Merge-request: 1460
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
| |
qUncompress shouldn't crash when running out of memory, since it might deal
with buffers which are not under user control (same behavior as Qt 4.5).
It will however throw a std::bad_alloc exception if Qt is compiled with
exception handling.
Reviewed-by: Harald Fernengel
Reviewed-by: Ralf Engels
Reviewed-by: Lars Knoll
|
| |
|
|\ |
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| | |
Task-number: 219152
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The refactoring of current++ and src++ out of the new line makes the
code easier to understand but it also seems to be significant at least
in the ::isComplex case. I suspect that the ordering increment
operations vs throw from new is not well defined, or not implemented as
you might hope (with the ++ happening very last).
The changes in the catch blocks mean that it deletes the created
objects, rather than trying with the first failed object.
The test code has been updated with a +=(Container) test, and to force
testing of both static and moveable types.
Reviewed-by: Harald Fernengel
|
|/
|
|
|
| |
Task-number: 241223
Reviewed-by: Janne Koskinen
|
|
|
|
|
|
|
|
| |
We had append(str,len) before and now we also have insert(index,str,len)
and prepend(str,len).
Task-number: 247881
Reviewed-by: Thiago
|
|
|
|
| |
That's the last of them... for now.
|
| |
|
|
|
|
| |
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempting to make use of the inlined QList::node_copy without
including <string.h> or <cstring> with gcc 4.4 results in (e.g.)
/usr/lib64/qt4/include/QtCore/qlist.h: In member function "void QList<T>::node_copy(QList<T>::Node*, QList<T>::Node*, QList<T>::Node*) [with T = net::Port]":
/usr/lib64/qt4/include/QtCore/qlist.h:600: instantiated from "void QList<T>::detach_helper() [with T = net::Port]"
/usr/lib64/qt4/include/QtCore/qlist.h:121: instantiated from "void QList<T>::detach() [with T = net::Port]"
/usr/lib64/qt4/include/QtCore/qlist.h:462: instantiated from "void QList<T>::append(const T&) [with T = net::Port]"
/usr/src/ark/BUILD/kdenetwork/kget/transfer-plugins/bittorrent/libbtcore/net/portlist.cpp:54: instantiated from here
/usr/lib64/qt4/include/QtCore/qlist.h:388: error: "memcpy" was not declared in this scope
Task-number: reported, but not yet assigned a number
Merge-request: 1388
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
|
|
|
|
| |
Also removed four function declarations from QMargins
that had no definitions.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Since we need QMargins for other things then
the CSS helper functions in drawutil, we have to make it more
generic. It is already useful for QWidget::contentsMargins
for example. This ensures we have some flexibility on how to
use and modify it in the future.
Reviewed-by: mbm
|
| |
|