| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Reviewed-by: Olivier Goffart
Reviewed-by: Peter Hartmann
Reviewed-by: João Abecasis
|
|
|
|
|
|
|
|
|
|
| |
currentFileInfo is only used for returning from the public functions
since the file info used in the algorithm is one step ahead.
nextFileInfo is the one actually used in the algorithm. The bug was
introduced in a compile fix for Windows and broke the stopLinkLoop test
for QDirIterator.
Reviewed-by: Olivier
|
|
|
|
| |
Reviewed-by: David Boddie
|
|
|
|
|
|
|
|
| |
Adding more details on QUrl::addQueryItem()
Task-number: 234125
Rev-by: Thiago Macieira
|
|
|
|
| |
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
| |
Task-number: 253835
Reviewed-by: David Boddie
|
|
|
|
|
| |
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Reviewed-By: Thiago Macieira
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's wrong to assume that static_cast<> is allowed everywhere where
dynamic_cast<> is allowed. For example, if class C derives from both A
and B, then you can dynamic_cast<B *>(ptr_to_A), but you can't
static_cast.
So introduce a helper for dynamic casts that doesn't do
static_cast.
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
| |
Usually, "the the" is not proper English
Reviewed-By: Thiago Macieira
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
while using QOrderedMutexLocker::relock we might unlock our mutex
protecting the 'senders' list for a short moment. Another thread may then
modify or remove element on the list.
Therefore, we need to recheck the consistency of the list once we did
that.
Also, we cannot call removeSender because that will remove every
connections, making impossible for another object destroyed in the same
time to clean up the senders list, so call derefSender instead.
Reviewed-by: Brad
|
|
|
|
|
|
| |
foo == QString() should be foo.isNull(). Fixes 7 warnings in the Norwegian Breakfast Network
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
| |
Highlight part of the general description in QTimeLine
Task-number: 218487
Rev-by: Geir Vattekar
|
|
|
|
|
|
|
|
| |
Adding note about requriements for converting QVariants
Task-number: 192607
Rev-by: David Boddie
|
| |
|
| |
|
|
|
|
|
|
|
| |
Clearifying details about bit size of the wchar_t input and the way they are handled.
Task-number:227709
Rev-by: Marius Storm-Olsen
|
|
|
|
| |
Reviewed-by: Peter Hartmann
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
We use MIPS2 instructions in the inline assembler, so we need to make
sure that the assembler is informed of this.
Task-number: 253275
Reviewed-by: thiago
|
|/ |
|
|
|
|
|
| |
Task-number: 253179
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
| |
Using setFileName in QFile::copy (introduced recently) has a nasty
side-effect of leaking file descriptors in QTemporaryFile. This happens
because the code assumes the file has been closed. In QTemporaryFile,
we need to explicitly call native file engine close.
Test case by Thiago. Bug report from Arora developers.
Reviewed-by: thiago
|
| |
|
|
|
|
|
|
|
| |
Explained why you cannot use stdin and atEnd() together.
Task-number:251171
Rev-by: Andreas Aardal Hanssen
|
|
|
|
|
|
| |
The d->capacity could be modified even if ref was more than 1
Reviewed-by: Marius Storm-Olsen
|
|
|
|
|
|
|
|
|
|
| |
qt_cmp_si_sort_flags could be read and written from different threads.
Use qStableSort with functor instead of libc's quicksort.
Found with helgrind on kdevelop
Reviewed-by: Marius Storm-Olsen
|
|
|
|
| |
This reverts commit da1416cef6b1d24156739ded101df895ee4e80d9.
|
|
|
|
|
|
| |
Explained why you cannot use QTextStream::atEnd with stdin.
Task-number:251171
|
|
|
|
|
|
|
|
|
| |
The held results were not cleared by QFutureInterface::operator=(QFutureInterface)
Add call to resultStore().clear(), similar to the destructor.
This needs to be done in the header since we know the template type here.
Task-number: 252208
Reviewed-by: brad
|
|
|
|
|
|
|
|
| |
I found out that all I needed to load the proper libraries was
to add a string to the ".interp" section of the ELF executable
containing the path to ld.so
Reviewed-By: Marius Storm-Olsen
|
|
|
|
|
|
|
| |
Added a comment about the use of negative indexes.
Task-number: 249344
Rev-by: Marius Storm-Olsen
|
|
|
|
|
|
|
| |
We always called QStringList::split in this function, which was
just expensive.
Reviewed-by: mauricek
|
|
|
|
|
|
|
|
|
|
|
| |
written, IANA hadn't assigned one.
Requested/spotted by Nokia i18n team.
Task-number: 251790
Reviewed-by: Brad
Reviewed-by: Denis
AutoTest: In this submit.
|
|
|
|
|
|
|
|
| |
Requested/spotted by Nokia i18n team/Darpan.
Task-number: 252102
Reviewed-by: Denis
AutoTest: In this submit.
|
|
|
|
| |
Reviewed-By: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy constructor and assignment operator lose data: pointer to content
and the length of content also need to be copied over.
QByteArrayMatcher::pattern() would return a null byte array if instance
was initialized with c-string.
Changed default constructor to explicitly initialize pattern length to
zero.
The bug in the assignment operator is a regression against 4.4.3.
Task-number: 251958
Reviewed-by: MariusSO
Reviewed-by: paul
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
constructed
Fix a regression from 4.3 to 4.4 that prevented QThread from starting
timers and event loops before QCoreApplication was instantiated. Even
though this is documented not to work, it seems that people have been
relying on it.
This reverts commit e52e5acdfa198cd079bbfe3a9302debf46c7cadd which
attempted to work around not calling g_thread_init() multiple
times. The proper fix is to serialize the g_thread_supported() checks
in the Glib event dispatcher.
Task-number: 248191
Reviewed-by: denis
|
|
|
|
| |
Reviewed-by: Thiago
|
|
|
|
|
|
|
| |
Update the script, and update the generated file.
Reviewed-by: Thiago
Reviewed-by: Paul Olav Tvete
|
|
|
|
| |
Signed-off-by: Thiago Macieira <thiago.macieira@nokia.com>
|
|
|
|
|
|
|
| |
Updated the project files and headers necessary for enabling this.
Reviewed-by: Thiago Macieira
Reviewed-by: Jens Bache-Wiig
|
|
|
|
| |
Reviewed-By: thiago
|
| |
|
|
|
|
|
|
|
|
|
|
| |
QProcessPrivate and QNativeSocketEnginePrivate were reporting a wrong
number of bytes available on 64-bit machines, due to use of size_t in
ioctl. That was required by Irix, which we dropped support for, so we
can also drop size_t
Reviewed-by: Thiago
Task-number: 249537
|
|
|
|
| |
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
| |
mode, the settings are stored in
HKEY_LOCAL_MACHINE\Software\WOW6432node.
Task-number: 232011
Reviewed-by: Martin Petersson <martin.petersson@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NSOpenGLContext seems to be tied to the window. So if the view
changes from one window to another, the OpenGL context needs to be
cleared. We can do this by hooking into the viewWillChangeWindow and
viewDidChangeWindow events and clear and reset the drawable
respectively. We also found out that QCocoaOpenGLView was not being used
at all, so just remove it to get rid of any confusion.
Task-number: 250066
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
|
| |
When QString::replace was optimized, this specific overload missed out
on sanity checking of the arguments.
Task-number: 249517
Reviewed-by: Joao
Reviewed-by: hjk
BT: yes
|
|
|
|
| |
Reviewed-by: hjk <qtc-committer@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zero timers on Windows would continue to fire even after being stopped
as long as a new timer was started that reused the pointer address of
the zero timer. Fix this by only re-firing zero timers if the zero
timer hadn't been stopped (we can check this by looking at the
inTimerEvent flag, which is set to false by registerTimer()).
Task-number: 247401
Reviewed-by: Denis Dzyubenko
Reviewed-by: Prasanth Ullattil
|