| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
currentFileInfo is only used for returning from the public functions
since the file info used in the algorithm is one step ahead.
nextFileInfo is the one actually used in the algorithm. The bug was
introduced in a compile fix for Windows and broke the stopLinkLoop test
for QDirIterator.
Reviewed-by: Olivier
|
| |
| |
| |
| | |
Reviewed-by: David Boddie
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adding more details on QUrl::addQueryItem()
Task-number: 234125
Rev-by: Thiago Macieira
|
| |
| |
| |
| | |
Reviewed-by: Marius Storm-Olsen
|
| |
| |
| |
| |
| | |
Task-number: 253835
Reviewed-by: David Boddie
|
| |
| |
| |
| |
| | |
Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Reviewed-By: Thiago Macieira
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It's wrong to assume that static_cast<> is allowed everywhere where
dynamic_cast<> is allowed. For example, if class C derives from both A
and B, then you can dynamic_cast<B *>(ptr_to_A), but you can't
static_cast.
So introduce a helper for dynamic casts that doesn't do
static_cast.
Reviewed-by: Olivier Goffart
|
| |
| |
| |
| |
| |
| | |
Usually, "the the" is not proper English
Reviewed-By: Thiago Macieira
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
David Faure (1):
Fix compilation with strict iterators
Merge-request: http://qt.gitorious.org/qt/qt/merge_requests/437
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
|
| | | |
|
| | |
| | |
| | |
| | | |
Makes it possible to find it when using QtCreator :)
|
|\ \ \
| | |/
| |/|
| | |
| | |
| | |
| | | |
Conflicts:
src/corelib/kernel/qobject.cpp
src/corelib/kernel/qobject_p.h
src/network/access/qhttpnetworkconnection.cpp
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
while using QOrderedMutexLocker::relock we might unlock our mutex
protecting the 'senders' list for a short moment. Another thread may then
modify or remove element on the list.
Therefore, we need to recheck the consistency of the list once we did
that.
Also, we cannot call removeSender because that will remove every
connections, making impossible for another object destroyed in the same
time to clean up the senders list, so call derefSender instead.
Reviewed-by: Brad
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This way the content of QVectorData is not duplicated in the code.
Reviewed-by: Thiago
Reviewed-by: Brad
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use QVectorData whenever possible instead of QVectorTypedData.
It is not safe to convert the shared_null to QVectorTypedData as
different instance of qvector with different type may cast it in the
same function (because everything is inline) and that would break strict
aliasing.
Reviewed-by: Thiago
Reviewed-by: Brad
|
|\ \
| |/
| |
| |
| | |
Conflicts:
tools/macdeployqt/shared/shared.cpp
|
| |
| |
| |
| |
| |
| | |
foo == QString() should be foo.isNull(). Fixes 7 warnings in the Norwegian Breakfast Network
Reviewed-by: Samuel
|
| |
| |
| |
| |
| |
| |
| |
| | |
Highlight part of the general description in QTimeLine
Task-number: 218487
Rev-by: Geir Vattekar
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adding note about requriements for converting QVariants
Task-number: 192607
Rev-by: David Boddie
|
|\ \ |
|
| |\ \
| | |/
| | |
| | |
| | | |
Conflicts:
tests/auto/qgraphicsview/tst_qgraphicsview.cpp
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
New private class, needed for the rewrite of the upload side of
QNetworkAccessManager. Allows to have a "byte pointer view" on stuff
like QRingBuffer, QByteArray, QFile and any QIODevice.
Reviewed-by: Thiago Macieira
Reviewed-by: Peter Hartmann
|
| | |
| | |
| | |
| | | |
Ability to read from a QRingBuffer at any position without modifying it.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The private class was already declared and defined in the qfileinfo.cpp
file.
Reviewed-by: thiago
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Clearifying details about bit size of the wchar_t input and the way they are handled.
Task-number:227709
Rev-by: Marius Storm-Olsen
|
| | |
| | |
| | |
| | | |
Reviewed-by: Peter Hartmann
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We use MIPS2 instructions in the inline assembler, so we need to make
sure that the assembler is informed of this.
Task-number: 253275
Reviewed-by: thiago
|
| | |/ |
|
| | | |
|
|\ \ \
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is to help undo the some magic that is in the Qt/Mac port. Qt
automatically flips the Meta and Control keys on Mac. This is a
"feature" that makes porting older programs that don't use standard
shortcuts easier as Ctrl and Command usually map to the same shortcuts
in the application. The upshot of this is that I need to strip the
text() out of key events if they contain the Control or Meta modifier.
This causes much headache for anyone writing a terminal emulator. Though
they would still have to write special code because the keys are swapped
anyway. This allows people to write the terminal emulator where hitting
the Control key will really send a Control key modifier.
We've also done the extra work to ensure that standard shortcuts work
correctly regardless of what the value of the attribute is. That is, if
you specify QKeySequence::Cut for a shortcut you can always hit
Command+X and things will work.
|
| | |
| | |
| | |
| | |
| | |
| | | |
We don't need Q_D if we don't use the d pointer.
Reviewed-by:TrustMe
|
| | | |
|
| | | |
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 253179
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using setFileName in QFile::copy (introduced recently) has a nasty
side-effect of leaking file descriptors in QTemporaryFile. This happens
because the code assumes the file has been closed. In QTemporaryFile,
we need to explicitly call native file engine close.
Test case by Thiago. Bug report from Arora developers.
Reviewed-by: thiago
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Explained why you cannot use stdin and atEnd() together.
Task-number:251171
Rev-by: Andreas Aardal Hanssen
|
| | |
| | |
| | |
| | |
| | |
| | | |
The d->capacity could be modified even if ref was more than 1
Reviewed-by: Marius Storm-Olsen
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
qt_cmp_si_sort_flags could be read and written from different threads.
Use qStableSort with functor instead of libc's quicksort.
Found with helgrind on kdevelop
Reviewed-by: Marius Storm-Olsen
|
| | |
| | |
| | |
| | | |
This reverts commit da1416cef6b1d24156739ded101df895ee4e80d9.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We shouldn't return since the SetErrorMode was called and we need to
reset it back afterwards.
Patch-by: ritt.k
Reviewed-by: mauricek
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Destroying a QObject which is connected to many signals was slow.
We had to loop over all the ConnectionsList of all the connected object
to remove the connections. (in QObjectPrivate::removeReceiver)
The idea is to now use lists of pointer to Connection both in the
connection list, and in the list of senders. So clearing the connection
should be faster.
Task-number: 251097
Reviewed-by: Brad
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It seems that plugins were never explicitly unloaded, resulting in leaks
of the instance object. Added a static deleter to ensure deletion on
exit. The QPointer (previously in place) ensures we don't do a
double-free nor try to access an invalid pointer.
Task-number: 253013
Reviewed-by: mariusSO
|