| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bug happened when you were typing a password and pressing "Done"
softkey very quickly. Because of the temporarily visible character,
the widget would not contain the full string at the time of softkey
triggering, only the *** part.
Fixed by having the input context listen for softkey (command) events
and commit the temporary character before the softkey action is
triggered.
AutoTest: Included
Task: QTBUG-12949
RevBy: Miikka Heikkinen
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixed a case where using password mode would lead to Qt
believing that the cursor was one step to the left of where it really
was. This would have the effect of replacing the last character
instead of appending to it, and even crashing if the cursor was all
the way to the left.
The code is also much cleaner this way, but it meant that QTBUG-9867
had to be solved differently this time. We do this by assuming that
and empty FEP update means "erase last character", which seems to
work well in practice.
Also added a long overdue autotest for the FEP input methods. Most
tests pass, but some don't, which I will try to fix later.
Task: QTBUG-9867
Task: QTBUG-12949
RevBy: Miikka Heikkinen
AutoTest: Included
|
| |
|
|
|
|
|
|
|
| |
This reverts commit 05eacd9ad40f8adb5aaa12a8b90113a73b43f642.
Conflicts:
src/gui/inputmethod/qcoefepinputcontext_p.h
src/gui/inputmethod/qcoefepinputcontext_s60.cpp
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were two bugs:
- First, we need to avoid triggering the CancelTransaction call when
committing the temporary preedit text, because otherwise FEP starts
sending us spurious backspace events. Since the
"triggeredBySymbian" variable is no longer descriptive for that use
case, I renamed it in the process and that changed the negation of
the flag. Notice the absense of a change inside
commitTemporaryPreeditString(). That is because we want that one
to avoid the transaction cancel, and therefore wee keep the old
negation.
- Second, m_cursorPos needs to be kept in sync with the widget state
when we send the temporary preedit string, because the input
context cannot separate between types of preedit text when it hits
the first block in commitCurrentString() (types being either our
temporary text, or FEP's text), and we have to avoid the longPress
code path.
RevBy: Janne Koskinen
|
| |
|
|
| |
RevBy: Trust me
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
This was done by intercepting key events with text in them, and
temporarily submit them as preedit text instead of real input text.
Currently it does not work in WebKit, but that is because WebKit
hides preedit text as well, which is a bug of its own.
RevBy: Simon Hausmann
Autotest: Manual testing went fine
|
| |
|
|
| |
Reviewed-by: Trust Me
|
| |\ |
|
| | |
| |
| |
| |
| |
| | |
The word 'module' was missing.
Reviewed-By: TrustMe
|
| | |
| |
| |
| | |
RevBy: Trust me
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The native FEP handles the 'pencil' key on some platforms by opening an
edit menu on the screen that contains things like 'Insert Symbol' and
'Writing Language' for text input widgets. This was previously not
working in the Qt input method implementation because in order for the
FEP system to open the menu, it must be able to access the menu bar
(CBA). This is done my using the object provider mechanism (MOP) and
an implementation of the MopNext() function was missing. Adding this
and also setting the AppUi as the MOP parent for top level widgets
allowed the FEP framework to find it's way to the menubar and thus
open a menu.
Task-number: QTBUG-5606
Reviewed-by: axis <qt-info@nokia.com>
Reviewed-by: mread <qt-info@nokia.com>
|
| |/
|
|
|
|
|
|
|
|
|
|
|
|
| |
Qt key event was not handled properly in the case of long key press.
With long key press, QCoeFepInputContext::commitCurrentString gets
called 3 times("q", "", "1"). (Normal key press is causing one call).
This is how aknfep works, so commitCurrentString was modified
to replace first character if long key press event detected.
E.g. "q" is replaced with "1".
qlinecontrol modified to keep cursor position correct.
Signed-off-by: axis <qt-info@nokia.com>
|
| |
|
|
| |
RevBy: Iain
|
| |
|
|
|
| |
Task: QT-2418
RevBy: Shane Kearns
|
| |
|
|
| |
Reviewed-by: Trust Me
|
| |
|
|
| |
Reviewed-by: Trust Me
|
| |
|
|
| |
RevBy: Trust me
|
| |
|
|
| |
RevBy: Trust me
|
| |
|
|
| |
RevBy: Trust me
|
| |
|
|
|
| |
Contains some smaller fixes and renaming of macros. Looks big,
but isn't scary at all ;)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Task: 257214
The problem happened if a user called setFocus() on an input capable
widget, and then tried to open the input panel by sending an event.
Since the call to InputCapabilitiesChanged is asynchronous, Symbian
would not yet know about the updated state, and the event would be
lost.
Now we generate our own asynchronous event, and ensure that it is
synchronous in the cases where it's needed.
|
| |
|
|
|
|
|
|
| |
Task: 257215
The capabilities would not be updated if the IM hints were the same.
We still try to avoid that when we can, but now we update the
capabilities if we really have to.
|
| |
|
|
|
|
| |
We now commit the text if the mouse handler is invoked. This prevents
the case where the VK cannot be brought up because the widget is the
only focusable widget and is stuck in inline edit mode.
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
This was done by making sure that the format code is called from both
start and update, because S60 will often return nothing in start, but
then later on return something in update.
In addition, we fall back on our own format if S60 does not give us
anything. Currently it seems to give us a format only when using
predictive text.
|
| |
|
|
|
| |
Made it more robust, as well as added support for the new
ImhDigitsOnly and ImhFormattedNumbers flags.
|
| | |
|
| |
|
|
| |
RevBy: Trustme
|
| |
|
