| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
fullscreen on Mac OS X.
We are just enforcing what the documentation
recommended.
Task-number: QTBUG-13772
Reviewed-by: Samuel
(cherry picked from commit 5fd505cac71e97cf181c0d05867a77e640814fc6)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When we receive a COMPOUND_TEXT data and convert it to multi-byte, if
the new length is less than the original buffer, we resize the buffer,
but then we need to make sure we reset the buffer_offset variable,
which is returned as a "size" of the buffer to a caller.
The conversion to COMPOUND_TEXT format was totally wrong, we were using
the wrong length of the input text, so the converted string was
truncated.
Task-number: QTBUG-8644
Reviewed-by: Bradley T. Hughes
(cherry picked from commit 4b81cb847647450f4bad8a0d9a278d43ebdfecc6)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In send_selection when we decide to use INCR properties we set the
given property value to be INCR atom, however we were also sending
SelectionNotify event containing the name of the property that the
client should watch as INCR, which is wrong, we should send the
original property that we were asked to use instead.
This fixes copying large junks of data from Qt application, for
example copying text (>200k) to gedit or images to gimp.
Task-number: QTBUG-8644
Reviewed-by: Bradley T. Hughes
(cherry picked from commit 62ee836fafe515c03b0be716585f8c2354e188f7)
|
|
|
|
|
|
|
|
|
| |
The crash was caused while checking the visibility of the toolbar inside
a native cocoa window. There is no toolbar for a drawer window.
Task-number: QTBUG-11138
Reviewed-by: Denis
(cherry picked from commit 84756e043fa2bd9c83b24abffb280290ad3667cd)
|
|
|
|
|
|
|
|
|
|
|
| |
We use the TrackMouseEvent() to keep track of enter and leave messages.
Upon receiving a WM_MOUSELEAVE, the effect of that function call is over,
we need to call it again if we need more messages. This was not done when
we close a popup because of mouse click outside.
Task-number: QTBUG-11582
Reviewed-by: Bradley T. Hughes
(cherry picked from commit d806b996beab76cbc43ffa11bc38721fa19c9c81)
|
|
|
|
|
|
|
|
|
| |
Commit 392123ef5432643d1047d1e1dd71512ec39d382d introduced the
leak.
Task-number: QTBUG-11432
Reviewed-by: Trond
(cherry picked from commit 38adb59a9e80a23d37ff0820ef62ebd45ab1e4ae)
|
|
|
|
|
|
|
|
|
|
|
| |
When the app that owns the selection quits and there is no clipboard manager
running we emit the changed signal whenever the timestamp of the event we got
is greater than our timestamp.
Task-number: QTBUG-8157
Reviewed-by: Thiago Macieira
Author: Luboš Luňák
(cherry picked from commit 1448e36be786648a7764255c24edddc636315427)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem was that we didn't take the children's effective mask
into account when checking whether a point was inside or not.
This commit is also an optimization since we no longer check the point
against the widget's rect twice. Furthermore, unnecessary
QRegion operations are completely avoided in the common case.
Auto tests included.
Task-number: QTBUG-7150
Reviewed-by: paul
(cherry picked from commit 7101ae5a0e90d97acf86a444c4d51ca45e7863fe)
|
|
|
|
|
|
|
|
|
| |
This was a regression introduced by 8da880e77db04c. The saved key
event needs to be cleared if we process a valid raw key event.
Task-number: QTBUG-7099
Reviewed-by: Richard Moe Gustavsen
(cherry picked from commit e30e3bb524536ef0f6b55272901b24bbbd4dfbd6)
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a guard check to return if the given input context is the same is we
already have.
Explicitly mention in the doc that we take ownership of the given input context
object.
Task-number: QTBUG-10780
Reviewed-by: Thomas Zander
(cherry picked from commit a32c96e753c2f5a123e518a92762ec9c9ff3b0b7)
|
|
|
|
|
|
| |
Reviewed-by: Morten Sorvig
Task-number: QTBUG-6384
(cherry picked from commit 3aee7881eaa45d4cbc1d0a353772cbf44638dadc)
|
|
|
|
|
|
|
|
|
| |
We should not ignore WM_xBUTTONUP messages after WM_xBUTTONDBLCLK. Treat
these messages like WM_xBUTTONDOWN messages.
Task-number: QTBUG-7172
Reviewed-by: Thierry
(cherry picked from commit 3fbedcd085b3e89e3646bf49264001ee216c5852)
|
|
|
|
|
|
|
|
|
|
| |
On X11 when creating a widget that has a parent, there is no reason to create a
native window handle right away since we don't know yet if the window is going
to be ever shown.
Task-number: QTBUG-9215
Reviewed-by: Bradley T. Hughes
(cherry picked from commit 1d506981bcc3d2b8aad67989fd7946a0ad826856)
|
|
|
|
|
|
|
|
|
|
|
|
| |
When QCocoaView receives a keyDown or keyUp event, we translate it to QKeyEvent
and deliver it to qt widgets, propagating if necessary. However if none of Qt
widgets accepted the event we should propagate it back to cocoa - to get a beep
from it, or for example if Qt widget is embedded into a native widget.
Task-number: related to QTBUG-6444
Task-number: QTCREATORBUG-698
Reviewed-by: Richard Moe Gustavsen
(cherry picked from commit 90dfb5e5d8fc8cb841b0762cd88aa4b996c38312)
|
|
|
|
|
|
|
|
|
| |
We now terminate the application as long as Qt
says we can. If not, then we cancel the
termination.
Task-number: QTBUG-6296
Reviewed-by: Morten Sorvig(cherry picked from commit 12308db7663679e42c87aa72c564ec3f9f1a457f)
|
|
|
|
|
|
|
| |
GL widgets and native controls have paintonscreen set and bypasses
backingstore. They can thus not rely on the windowsurface flushing
but must be repainted via normal means
(cherry picked from commit ac99b3e243b331d26815b80aab97cdaf0ed06b0f)
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that setParent_sys is wiping out opacity for the
window regardless of what the value is from before. This patch
does the correct thing, namely look at the WA_WState_WindowOpacitySet
flag.
Task-number: QTBUG-5100
Reviewed-by: cduclos
(cherry picked from commit 06638a4c08aaf86d606abc59f642c3c34815e8e6)
|
|
|
|
|
|
|
|
|
| |
Use the coordinates passed in the LPARAM parameter, the pt passed with
the MSG is not always correct.
Task-number: QTBUG-7637
Reviewed-by: Denis
(cherry picked from commit 234e849cfc85d5618d2f703bb92701042993d2de)
|
|
|
|
|
|
|
|
|
|
|
| |
Window modal dialogs are shown as sheets on Mac, reusing them is showing
some painting artificats. So make sure we create a new window everytime
a sheet is shown. This only applies to Carbon, the Cocoa versions dont
have this problem.
Task-number: QTBUG-8198
Reviewed-by: MortenS
(cherry picked from commit 08ec00c081ce51a924c65df3998657174f9428b6)
|
|
|
|
|
|
|
|
|
| |
Not creating screen furniture in full screen caused regression
when swapping into idle screen and back on Nokia 5800.
Task-number: QTBUG-10985
Reviewed-by: Jason Barron
(cherry picked from commit 4a4e5e7d54c559d54e9079dacb9c2fd32770f018)
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
| |
Task-number: QTBUG-10986
Reviewed-by: Jason Barron
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 24b811e53b30546279346ab7b16799be119ab8c4 on 4.7 includes bug
fixes which are needed for 4.6 as well.
1. TouchEnd event was missing
2. pressure in touchpoints was set to 0.0 for non pressure sensitive
touch screens, it should be set to 1.0 for consistency with existing
Qt ports (e.g. mac).
Task-number: QTBUG-10885
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
|
|
|
| |
Native menus are dismissed by the key press event.
The Qt application then receives the key up event, as it now has keyboard
focus.
The virtual mouse implementation now filters out select key press/release
which don't match the expected mouse button state.
Task-number: QTBUG-9860
Reviewed-by: Alessandro Portale
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After replacing some code with a function call to s60UpdateIsOpaque()
we introduced a crash for widgets that set
Qt::WA_TranslucentBackground. The reason for the crash was that the
Qt::WA_WState_Created attribute was being set before calling this
function, but *not* before setWinId() was being called. This meant that
s60UpdateIsOpaque() assumed that the window was created (and the handle
added to the widget map), but this was not actually the case.
The fix here is to move the call to s60UpdateIsOpaque() after the call
to setWinId() such that those assumptions are true.
Reviewed-by: Jani Hautakangas
|
|
|
|
|
|
|
|
|
| |
Adding the same menu action object to n menu bars resulted in n
QAction::triggered() signals. Now, we're comparing the active window
with the parent HWND of the menu bar before triggering.
Task-number: QTBUG-10402
Reviewed-by: thartman
|
|
|
|
|
|
|
|
| |
The 'iPosition' that we receive from the TAdvancedPointerEvent is
relative to the origin of the window that received the event, not the
screen so it needs to mapped to be correct.
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CEikCba class casting is not binary compatible between at least
S60 3.2 and 5.0 platforms, even though it is source compatible.
The removed code was causing stack corruption on emulator
when binaries were built on S60 3.2 SDK and run on S60 5.0 SDK.
Another solution for this feature needs to be found.
Task-number: QTBUG-10199
Reviewed-by: Shane Kearns
Reviewed-by: Janne Anttila
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the create_sys() function where native handles are created, we were
only looking at the "isOpaque" flag to determine if a window should be
translucent or not. This is not the correct thing to do because
transparency should only be granted if the application explicitly sets
the Qt::WA_TranslucentBackground flag.
The fix is to defer the transparency decision to s60UpdateIsOpaque()
which does the right thing.
Reviewed-by: Jani Hautakangas
|
|
|
|
|
|
|
|
|
|
|
| |
If a widget is initially shown as maximized or fullscreen then the
normal geometry is calculated before the status pane has been created.
When returning to the "Normal" window state the geometry needs to be
tweaked to compensate the fact that there is a status present now. This
should only happen if the application has not been given an explicit
position.
Reviewed-by: Janne Anttila
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that the S60 screen furniture construction is delayed, we need to
manually set the status pane observer to get notifications about
changes in the size of the status pane. Using the AppUi would have been
the obvious choice here, but sadly CAknAppUi (base class for
QS60MainAppUi) uses private inheritance when implementing the
MEikStatusPaneObserver interface.
To work around this problem we make QSymbianControl implement the
interface and use the instance of this class that is associated with
QDesktopWidget to recevive the notifications and then call the function
in the AppUi to maintain the same behavior.
Reviewed-by: Janne Anttila
Reviewed-by: mread
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the S60 screen furniture (Status Pane and CBA) was being
constructed when QApplication was constructed. This meant that if you
never created a widget, you would still get those app panes which is
not what we want.
This patch avoids constructing these panes in QApplication, and manually
creates them later when the first window is shown in a state where they
would be needed.
Reviewed-by: Janne Anttila
Reviewed-by: mread
|
|
|
|
|
|
|
|
|
|
| |
setGeometry() has the side effect that it internally sets both the
WA_Moved and WA_Resized attributes and these attributes should only be
used when the application has explicitly set a size or position. When
a widget is resized due to being maximized or fullscreened then we
should resize the native window handle instead of calling setGeometry.
Reviewed-by: Janne Anttila
|
|
|
|
|
|
|
|
| |
The native window is used quite early in this function so as soon as we
determine that this does in fact require a native window, we should
create it immediately.
Reviewed-by: Janne Anttila
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/oslo-staging-2:
QMenu: Behavior regression
Mac: Graphics View starving user events and sometimes crashes.
Fixed a crash on Windows 7 systems with invalid PrinterPorts entries.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Problem was that we called processEvents() and excluded user input
events. The idea was to only process pending update
requests, but by doing that there's also a chance that user input events
will starve. Also, there's no gurantee that only update requests
will be processed by processEvents(), so a safer solution is to call
"HIViewRender" on Carbon and "displayIfNeeded" on Cocoa. This will for
sure dispatch pending update requests and nothing else (which is exactly
what we want).
No auto test regressions.
Fixes tst_qgraphicsproxywidget::updateAndDelete failure on Carbon.
Benchmarks indicate an increase in performance.
Task-number: QTBUG-7502
Reviewed-by: richard
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| | |
4.6-integration
* '4.6' of scm.dev.nokia.troll.no:qt/qt-s60-public:
Symbol visibility fixes for RVCT4 on Symbian
Symbol visibility fixes for RVCT4 on Symbian
Symbol visibility fixes for RVCT4 on Symbian
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
RVCT 4 is far more strict with regards to symbol visiblity that RVCT
2.2, and will hide symbols unless all references have default visibility
in the object files. Update the various places in Qt code where the
symbol visibility was set incorrectly for DLL-based platforms (those that
use __declspec(dllimport) and (dllexport).
Note: QtWebkit and QtScript are fixed in different commits.
Task-number: QTBUG-9903
Reviewed-by: Jason Barron
|
|/
|
|
|
|
|
|
|
| |
Help event was not propagated to the widget. Also fixes tooltip value
propagation when setting it on the proxy or on the widget.
Autotest included.
Task-number: QTBUG-5349
Reviewed-by: bnilsen
|
|
|
|
|
|
|
|
|
|
|
| |
Triggered signal is useful for detecting native 'Options' menu
launches in Symbian. QMenu::aboutToShow event is currently also not
generated, but that is part of another bug report. And
QMenu::aboutToShow would not even be generated for 'Options' menu
itself but only for its sub/cascade menus.
Task-number: QTBUG-9669
Reviewed-by: Sami Merila
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As described in QTBUG-8698, Qt for Symbian has been generating
incorrect focus and window activation events. This has happened since
launching menu from QSoftkeyManager with TryDisplayMenuBarL, invokes
eventually QSymbianControl::FocusChanged. But when the FocusChanged is
called menu being launched is not yet set to visible, meaning that
IsDisplayingMenuOrDialog returns false.
Because there is no way in platform to detect that menu is being
launhced, the fix is to add a new flag QS60Data, which can be used to
detect if FocusChanged event is received due to the fact that menu
is being constructed/launched.
Task-number: QTBUG-8698
* Fixes issues 2, 3 and 4
Reviewed-by: Sami Merila
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change includes a fix for QTBUG-4887 and other exception safety
problems found while testing it.
The QTBUG-4887 fix is to qimage.cpp. QImage doesn't throw exceptions on
failure like a proper class should, instead it tries to fail "nice".
What happens here is that setAlphaChannel would crash on OOM as after
the convertToFormat call, d could be NULL. This new version checks the
result of the conversion before using it.
The other fixes are all cases where exceptions were thrown from
destructors. I added code to the test app to help debug these cases,
and I fixed all the problems I found.
With these changes, tst_exceptionsafety_objects runs and passes on the
Symbian emulator.
Reviewed-by: Shane Kearns
|
|
|
|
|
|
|
|
|
|
|
| |
During softkey refactoring this piece of code get changes, but the
changed code did not work correctly if window had no softkey actions.
Switched back to old way where softkey source is stored to variable,
and windowType is asked from stored variable. If softkey source is
dialog or popup, "Exit" is not added automatically to RSK.
Task-number: QT-2203
Reviewed-by: Sami Merila
|
|
|
|
|
| |
Merge-request: 544
Reviewed-by: Benjamin Poulain <benjamin.poulain@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When running on WINSCW, the nativePaintMode variable was becoming
corrupted. The point at which this corruption occurs is unclear,
but it can be reproduced as follows:
1. Launch qmediaplayer
2. In the Phonon::MMF::DsaVideoOutput constructor, the
nativePaintMode flag is set to QWExtra::ZeroFill
3. Open a video clip
4. During start of playback, QSymbianControl::Draw is called on the
native control corresponding to the DsaVideoOutput object. This
checks the value of nativePaintMode; it does not match any of
the valid NativePaintMode values, so an assertion fails.
This crash does not occur on target, suggesting that the cause may
be an error in the WINSCW compiler. Although the C++ standard allows
bitfields to have boolean, integral or enumeration type, the latter
is not permitted by C99.
Neither increasing the number of bits allocated to nativePaintMode,
nor changing it position in the list of platform-specific bitfields
has any effect.
After making nativePaintMode into a normal field rather than a
bitfield, the crash no longer happens. Note that, since bitfields
must be kept together, nativePaintMode is moved to the end of the
structure.
|
|
|
|
| |
Reviewed-By: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously softkey implementation assumed that source for softkey
actions is focused widget or activewindow if there is no focused
widget. Since for example pop-up menu does not take focus immediately
in touch enabled devices, the underlying widget softkeys were visible
and usable when menu was open. This lead to problem that underlying
widget could be interacted via softkeys when popup menu was open.
For example as reported in QTBUG-8688, it was possible to close the
underlying filedialog from which the currently active context menu was
launched. It was also possible to open "Options" menu of underlying
widget when context menu was open, leading to situation where several
context menus could be launched via "Actions" item of "Options" menu.
This was reported as an issue: QTBUG-6167
In addition when user started navigating in context menu via keypad,
the menu got focus and softkeys changed to partially correct. Only
partially correct, since context menu "Select" action and "Options"
action had same priority and both associated to LSK. In addition the
context menu action "Cancel" associated to RSK was set to invisible,
meaning that it was also disabled and appeared in sofkeys as dimmed.
All of these issues were fixed by making making the popup and modal
dialogs highest priority softkey source. In case the focused widget
is inside popup or modal dialog it is being used as an initial softkey
source. In addition the softkeys created with
QSoftKeyManager::createAction or QSoftKeyManager::createKeyedAction are
now by default invisible i.e. not visible in context menu and have
special property set to make them still normally enabled in softkeys.
Task-number: QTBUG-6167
Task-number: QTBUG-8688
Task-number: QTBUG-9144
Reviewed-by: Sami Merila
|
|
|
|
|
|
|
|
|
|
|
| |
availableGeometry returns incorrect area after cba is made invisible,
it seems that this happens because CAknToolbar is not made invisible.
Fixed the problem by reverting back to SetExtentToWholeScreen usage
when the widget is really fullscreen, i.e.
Qt::WindowSoftkeysVisibleHint is not set.
Task-number: QTBUG-9038
Reviewed-by: Miikka Heikkinen
|
|
|
|
|
|
| |
Added the missing \row tag
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We shouldn't really care about ReparentNotify when waiting for a window to be
"managed" by the window manager.
We only need to wait until the window is Mapped and Exposed for the first time,
then we (most likely) can safely assume that the window manager has finished
managing the window.
Task-number: QTBUG-9097
Reviewed-by: Bradley T. Hughes
(cherry picked from commit fb6cfbe48bc4f2148062d50d4df95616e06f9324)
|