| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
4.6-staging2
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Basically this has three minor fixes:
- remove unused style parts that were left over after unifying textEdit
and lineEdit graphics
- make radiobutton indicator one pixel smaller so it is perfect
circle
- replace magic "10" with calculated value
Reviewed-by: Alessandro Portale
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After initial fix, 99% of widgets draw temselves properly after
orientation switch. However, QScrollAreas lose their palette hash,
which causes scrollarea background to re-start from theme background
top-left.
As a correction, we re-set the theme palette hash after calling
QApplication::setPalette, since that clears palette hash.
Task-number: QTBUG-6125
Reviewed-by: Alessandro Portale
|
| |
| |
| |
| |
| |
| | |
Remove some white space from QS60Style classes.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixing previous fixes of QS60StylePrivate::setBackgroundTexture with
commit SHAs a80e58335e69c8ce96d1596e0ed2d14e424a0d5e and
d4089399a3ab7548a864d5a399e08df85c444783
Now, the palette gets the updated background brush and the palette is
actually set as application palette.
Also making sure that QS60StylePrivate::handleDynamicLayoutVariantSwitch
does the right things in the right order. So that Table headers are not
broken after orientaion switch.
Task-number: QTBUG-6125
Task-number: QT-1478
|
| |
| |
| |
| |
| |
| | |
Don't request a palette if you do not use it.
Reviewed-By: Trustme
|
| |
| |
| |
| |
| |
| | |
Not used or missed, anywhere.
Reviewed-By: Trustme
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After initial fix, 99% of widgets draw temselves properly after
orientation switch. However, QScrollAreas lose their palette hash,
which causes scrollarea background to re-start from theme background
top-left.
As a correction, we re-set the theme palette hash after calling
QApplication::setPalette, since that clears palette hash.
Task-number: QTBUG-6125
Reviewed-by: Alessandro Portale
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixing previous fixes of QS60StylePrivate::setBackgroundTexture with
commit SHAs a80e58335e69c8ce96d1596e0ed2d14e424a0d5e and
d4089399a3ab7548a864d5a399e08df85c444783
Now, the palette gets the updated background brush and the palette is
actually set as application palette.
Also making sure that QS60StylePrivate::handleDynamicLayoutVariantSwitch
does the right things in the right order. So that Table headers are not
broken after orientaion switch.
Task-number: QTBUG-6125
Task-number: QT-1478
Reviewed-by: Shane Kearns
|
|/
|
|
|
| |
Task-number: QTBUG-5830
Reviewed-by: Richard
|
|\ |
|
| |
| |
| |
| | |
Reviewed-by: jbache
|
|/
|
|
|
|
|
|
|
|
|
|
|
| |
The problem was the QMacStyle didn't handle the pixel metric for
PM_TitleBarHeight correctly when passing a style option containing
an unitialized rect (empty rect). It already had special logic for
invalid rects, so the fix is simply to extend the check to also handle
empty rects.
Auto-test included.
Task-number: QTBUG-4160
Reviewed-by: msorvig
|
|
|
|
|
|
|
|
|
| |
Some style relies on this broken behaviour that was fixed in commit
e1a81c96790bee72ee4fbd2b0c4a7b48078c4ec1
The text on the combobox uses the wrong palette role.
Reviewed-by: jbache
|
|\ |
|
| |\
| | |
| | |
| | | |
4.6-staging2
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
To get a mobile friendly 1-column layout, we can set
QFormLayout's rowWrapPolicy. S60Style should return
QFormLayout::WrapLongRows as the SH_FormLayoutWrapPolicy
styleHint.
Reviewed-by: Jason Barron
|
| |\ \
| | |/
| |/| |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the webpage does define BODY colors for background, it is possible
that lineEdits are not drawn at all. Actually, they are drawn but with
transparent background, which makes them near-invisible. This is due
to that QS60Style tries to check if the themePalette has been changed
and if it has forwards the drawing of that particular widget to common
style. Common style unfortunately uses active style's palette to draw
the widget. S60Style defines Base to be transparent (to get the
theme background shine through) and common style tries to use Base
to draw lineEdit. End result is transparent lineEdit on webpage.
This fix makes more educated deduction when it tries to see if style
has been changed. This is related to QTBUG-4885.
Task-number: QTBUG-4885
Reviewed-by: Janne Koskinen
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Qt 4.6 reports smaller sizes for all fonts which means a lot of
the size adjustments QGtkStyle does were now off. I have adjusted
most of them including some fixes to menu items themselves.
Note that the changes were introduced with this change:
04d18b38c38c5ff623b30366ea08d56128b9b7d0
We now also adapt to GNOME 2.16 style submenu arrow sizes.
Combo boxes, line edits, spin boxes and push buttons should
finally have a uniform height.
Task-number: QTBUG-5753
Reviewed-by: thorbjorn
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a workaround for a bug that we introduced with the QGtkStyle refactoring
to properly support Maemo5.
RevBy: jbache
|
|\ \ \ |
|
| | |/
| |/| |
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When setting the contents frame layout, the overlapping amount used was the
one from the base style because we were checking the wrong widget. We now
ensure that it's the QTabWidget we are checking for the pane pseudo-element
subrule.
Reviewed-by: Olivier
Task-number: QTBUG-2555
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It makes no sense to use the S60-theme based palette in web based
widgets. Web pages do not generally show theme background, but their
own (or by default white) which clashes badly with WindowText and Text
that are set to work with theme background. Therefore, QWebView and
QGraphicsWebView need to be set their own palette for texts in
theme palette hash. This improves visibility of text in webkit
when QS60Style is active.
Task-number: QTBUG-4885
Reviewed-by: Janne Koskinen
|
|\ \ \
| |/ / |
|
| |\ \
| | |/
| |/| |
|
| | | |
|
| | | |
|
| |\ \
| | | |
| | | |
| | | | |
4.6-staging2
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Changed s60style HighlightedText to pickup the correct
colour from S60 themes.
Task-number: QTBUG-5709
Reviewed-by: Sami Merila
|
| |\ \ \
| | |/ /
| |/| /
| | |/ |
|
| |\ \
| | | |
| | | |
| | | | |
4.6-staging2
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
With certain themes it is really apparent that the tabshape rect and
position deduction in QS60Style has some issues. See for example
5800Xm's default theme. TabShapes have huge spaces between them.
Problem is that the initializer in style for tab shape assumes
that the side parts of the frame are squares and will use 1:1 ratio
(width:height) when upscaling the theme graphic draw area.
This leads to that tabshape graphics will not fill in the
whole area reserved for them.
When initial area has ratio of 1:2 (for horizontal tab shape),
upscaling pruduces correct rect and graphic is drawn correctly.
Task-number: QTBUG-5659
Reviewed-by: Alessandro Portale
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 676780d515cedca85829ae962e4f501c5e5b6581.
Conflicts:
src/gui/painting/qblendfunctions.cpp
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit d9a275b3cc4a248da1f392fb5649b9fe7a93b12c.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Due to bad first fix for QT-1478, palette is still not updated
correctly. Changed palette needs to be set back to QApplication.
Task-number: QT-1478
Reviewed-by: Alessandro Portale
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
QS60Style::setStyleProperty() and QS60Style::styleProperty() were
intended as generic property setter/getters, but are not needed
anymore.
Reviewed-by: Sami Merila
modified: src/gui/styles/qs60style.cpp
modified: src/gui/styles/qs60style.h
modified: src/gui/styles/qs60style_p.h
modified: src/gui/styles/qs60style_s60.cpp
modified: src/gui/styles/qs60style_simulated.cpp
modified: src/s60installs/eabi/QtGuiu.def
|
| | |\ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Added two missing qreal conversion from QS60Style.
Task-number: QTBUG-4894
Reviewed-by: Aleksandar Babic
|
| | |\ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/gui/painting/qblendfunctions.cpp
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We want to force use of qreal where possible. This can lead to better
performance on platforms where qreal -> float (i.e. ARM). To achieve
this we:
1. changed from 'double' to 'qreal', where justified
2. using qreal() to intialize constants, where justified
3. adding helper functions that are overloaded for qreal
like qAtan2(), qAcos(), qFabs() ...
4. defining QT_USE_MATH_H_FLOATS for Symbian platform
In addtion we used opportunity to improve code with some small things
5. converting divisions to multiplications
(i.e. '/ 2.0' -> '* qreal(0.5)')
6. defining new constants (i.e. 'Q_PI / 180.0' -> 'Q_PI180')
7. declaring variables as 'const', where justified
Reviewed-by: Andreas Aardal Hanssen
Reviewed-by: Gunnar Sletta
Reviewed-by: Jan-Arve
Reviewed-by: Kim Motoyoshi Kalland
Reviewed-by: Alessandro Portale
Reviewed-by: Janne Koskinen
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | | |
|
| | |_|_|/
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Probably due to the font height being reduced by one pixel earlier, the
menu bar now seems to need both pixels added by the QCleanLooks style.
Previously it was ignoring this and adding only one, resulting in a menu
bar that was one pixel too narrow compared to a real GTK one.
Reviewed-by: mae
|
|\ \ \ \ \
| | |/ / /
| |/| | | |
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Conflicts:
src/gui/painting/qbrush.cpp
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When using background-image and background-attachement: scroll
and background-repeat: no-repeat
The rectangle used to draw the image was not correctly computed.
Reviewed-by: Thierry
Task-number: QTBUG-3783
|
| | |/ / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When setting a gradian brush as a base for a QTreeWidget (with
stylesheet), the branch decoration would be plain black.
This is because the color() of a gradient brush is always black.
Fix it by using the base brush itself to paint the decoration if
the brush is not solid color.
Task-number: QTBUG-3816
Reviewed-by: Thierry
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
The word 'module' was missing.
Reviewed-By: TrustMe
|