| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
The word 'module' was missing.
Reviewed-By: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QS60Style::setStyleProperty() and QS60Style::styleProperty() were
intended as generic property setter/getters, but are not needed
anymore.
Reviewed-by: Sami Merila
modified: src/gui/styles/qs60style.cpp
modified: src/gui/styles/qs60style.h
modified: src/gui/styles/qs60style_p.h
modified: src/gui/styles/qs60style_s60.cpp
modified: src/gui/styles/qs60style_simulated.cpp
modified: src/s60installs/eabi/QtGuiu.def
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QPaintDevice and QImage used the functions numColors(), setNumColors(),
and numBytes(). However, this is not consistent with the rest of the Qt
API which uses *Count() and set*Count().
Removed all usage of these functions inside Qt and test-cases.
Reviewed-by: Andreas Aardal Hanssen
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
dist/changes-4.6.0
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The old button sizes were just to big. For example the trivialwizard
example had a minimal width that was much too wide for the screen.
Task-number: QTBUG-3613
Reviewed-by: thartman
|
| |/
| |
| |
| | |
Reviewed-by: Maurice
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
dist/changes-4.6.0
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In S60 the single line and multi line editors have same theme
background. We should share one as well. Now we are using fancy
notepad graphic with QTextEdit, but it makes QTextEdits to look
apart from QLineEdits and in some themes it is styled rather badly
(as it is not a central graphic item in a theme). Therefore it is
better to use one and same graphic for both widgets.
Task-number: QTBUG-5259
Reviewed-by: Alessandro Portale
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Style draws the ends of scrollbar as too wide, causing the themegraphic
to stratch which looks horrible.
Task-number: QTBUG-5445
Reviewed-by: Alessandro Portale
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
QS60Style does not draw checked menu indicators at all. This is due
to that it initializes used style option with style option's base class.
Therefore relevant data for menu item indicator is not copied.
Task-number: QTBUG-4717
Reviewed-by: Alessandro Portale
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
QToolButton rect does not include reserved area for menu indicator,
so drawing the indicator makes the rest of the toolbutton area smaller.
Fixed by including the menu indicator area into tool button.
Task-number: QTBUG-5266
Reviewed-by: Alessandro Portale
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currenly QS60Style relies on QCommonStyle to calculate correct button
content size. Unfortunately, common style does not understand frames,
so it is possible that the frame-border of theme graphic gets under
button content. This change makes both QPushButton and QToolButton
bigger.
Task-number: None
Reviewed-by: Alessandro Portale
|
|\ \ \
| | |/
| |/| |
|
| |\ \
| | |/
| |/|
| | |
| | |
| | | |
Conflicts:
src/gui/kernel/qevent.cpp
src/gui/kernel/qgesture.cpp
|
| | |
| | |
| | |
| | | |
Reviewed-by: Trust Me
|
| |\ \
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
dist/changes-4.6.0
src/gui/kernel/qevent.h
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Task: QTBUG-4988
68c0e6a8ba1e92bf0152adcaa86eebb83dcfd1d8 introduced
a regression preventing the mac-spesific standardIcon
code form being called.
Call the Mac code if desktopSettingsAware is set.
(QIcon::themeName() is only set on X11)
|
| |\ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Leaving function called without a TRAP
Reviewed-by: Sami Merila
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
QS60Style ignores toolButton's menu indicator rect. This means that the
button's menu cannot be triggered by the user, as the style does not
draw the indicator at all.
With this fix, style calculates a rect (including margins) for menu
indicator and draws that (arrow down) into toolButton (by making the
button bevel larger).
Task-number: QTBUG-5266
Reviewed-by: Alessandro Portale
|
| | |\ \ \
| | | | |/
| | | |/| |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
S60Simulated style broke down after change
SHA da9880eaed0d09338717db1a73db01e6b0ab080d, because part()-method
call in simulated style was not updated to have additional parameter.
Task-number: None
Reviewed-by: Shane Kearns
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Style sets the tabWidget palette hash only for QPalette::Active.
So, when widget becomes disabled, text color changes back to default.
Task-number: QTBUG-4625
Reviewed-by: Alessandro Portale
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Currently, after orientation switch when new theme background is applied,
it is done using QApplication::setPalette(). This unfortunately tosses
away the palette hash. So instead directly calling
QApplication::setPalette(), the fix is to call the style's internal
setThemePalette(), which copies the hash also to QApplication palette.
This is related to bug QT-1478 in Private JIRA.
Task-number: QT-1478
Reviewed-by: Shane Kearns
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
QS60Style ignores user defined palettes for QHeaderViews.
With this fix, style takes palette changes into account and also draws
QTableCornerButton correctly.
Task-number: QTBUG-4522
Reviewed-by: Alessandro Portale
|
| | |\ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This fixes private JIRA issue: QT-1479.
The change makes itemview items taller by twice the QStyle::PM_FocusFrameVMargin
amount (both margins) when touch is in use. It is rather curious that
the QCommonStyle modifies QRect for itemviews in horizontal direction
by twice the QStyle::PM_FocusFrameHMargin amount, but does not do it in
vertical direction.
Task-number: QT-1479 (private)
Reviewed-by: Alessandro Portale
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Now passes tst_QStyleSheetStyle::emptyStyleSheet with gtk style
Somehow there were some wrong and uneeded default padding for the QLineEdit
with some styles
Task-number: QTBUG-5434
Reviewed-by: axis
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When using style sheets, the fallback for the menu item is
QWindowsStyle. However, QWindowsStyle doesn't draw anything when the item is
not checked.
We now mimick what QWindowsStyle would draw in
QStyleSheetStyle::drawControl().
The "static const int windows*" variables in qwindowsstyle.cpp
have been moved into QWindowsStylePrivate to make them accessible to
QStyleSheetStyle.
Reviewed-by: Olivier
Task-number: QTBUG-2218
Task-number: QTBUG-2217
Task-number: QTBUG-3479
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Two problem:
- When QWindowsStyle draw CC_ComboBox, it does not save/restor the
painter, whilt it does modify the pen and the brush.
- QStyleSheetStyle CE_ComboBoxLabel did not specify the palette role
to paint the text with, leaving the one from the palette
Task-number: QTBUG-3974
Reviewed-by: Gabriel
|
|\ \ \ \ \ \
| |/ / / / / |
|
| |\ \ \ \ \ |
|
| | | |_|/ /
| | |/| | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The QGtk class has been refactored into a private d class for QGtkStyle.
This allows us to re-use a lot of code for the Maemo5 style without changing
a single line in QGtkStyle itself plus we can easily add virtual functions
where the two styles need to behave different.
There shouldn't be any new functionality added (or old functionality lost) by
this commit.
Reviewed-By: jbache
Reviewed-By: Ralf Engels
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
Reviewed-by: TrustMe
|
| |\ \ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reviewed-by: tom
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reviewed-by: tom
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
nothing to draw
This fixes the focus rect that appears on buttons with GtkStyle if a
stylesheet is used.
Task-number: QTBUG-4488
Reviewed-by: Gabriel
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I am not sure why the code was there, but after some testing, it is better
to remove it:
- While painting the branch, we should not look at the ::item pseudo class
at all.
- Items specific stuff is drawn in PE_PanelItemViewItem, not PE_PanelItemViewRow
- Selection is handled his way by the native style. background-color is not for
selection and should not depends on SH_ItemView_ShowDecorationSelected
Reviewed-by: Thierry
Task-number: QTBUG-5228
Task-number: 258382
Task-number: QTBUG-4338
|
|\ \ \ \ \ \
| | |/ / / /
| |/| | | | |
|
| |\ \ \ \ \
| | | |_|_|/
| | |/| | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This also adds QStyleOptionTabWidgetFrameV2 so that we do not have
to do ugly hacks in the style to obtain it.
Task-number: QTBUG-5187
Reviewed-by: ogoffart
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
While drawing the tabbar frame, mac style needs the QTabBar pointer to
calculate the correct size.
Since the QTabWidget also uses the PE_FrameTabBarBase to draw background
of the corner widgets, the mac style has to use position passed with the
style option. This only works with horizontal tabs.
Reviewed-by: Jens Bache-Wiig
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The subcontrol rect offset was correctly reporting
not to work on Vista style. The problem was that we were
getting the size of the arrow by subtracting the xoffset.
But this would mean that the
Reviewed-by: ogoffart
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When a tool button is not in a tool bar on XP and Vista it will get a
slightly different appearance from normal tool buttons. I resolved
this by drawing a normal tool button with a divider line on top
if the autoraise property is not set on the button. (which is by
default enabled only for buttons in a tool bar).
Task-number: QTBUG-5061
Reviewed-by: prasanth
|
| | |\ \ \ \
| | | |/ / /
| | |/| | |
| | | | | | |
4.6-WM_NULL-driven
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The default height of tab bar is 22 pixels in Snow Leopard. We used to
draw tabs taller than 21 pixels to a pixmap and stretch to the required
size. The limit is now changed to 22 pixels (which is the most common
use case). The stretched drawing is not perfect in Snow Leopard due to
some changes in how HITheme draws tabs.
Reviewed-by: Jens Bache-Wiig
|