| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Previously we didn't update the editor contents if the new preedit
string was empty. However, it could be empty because the user just
erased it, so the bug was fixed by checking whether the preedit
string in the event and in the editor are different.
RevBy: Denis Dzyubenko
|
|
|
|
|
|
|
| |
fontDef.pixelSize is a qreal now and we should round it after
multiplication to avoid an accuracy loss.
Reviewed-by: mae
|
|\ |
|
| |\ |
|
| | |\
| | | |
| | | |
| | | |
| | | | |
Conflicts:
src/gui/effects/qgraphicseffect.cpp
|
| | | |\ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This amend previous commit by removing the duplicate function.
The quote need to be escaped in attributes.
Reviewed-by: Thomas Zander
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If a QTextDocument contains an anchor with a & in it, this & is not
escaped in the toHtml() function, meaning the resulting document
can't be parsed as XML as it will contain invalid entities.
Reviewed-by: Olivier Goffart
Merge-request: 1753
|
| | | |\ \
| | | | |/
| | | |/|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
git://gitorious.org/~fleury/qt/fleury-openbossa-clone into openbossa-fleury-fixes3
Conflicts:
src/gui/graphicsview/qgraphicsanchorlayout_p.cpp
src/gui/graphicsview/qgraphicsanchorlayout_p.h
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes a refcount bug that occurs when QFont is constructed from a
QFontPrivate* that was created without an initial ref().
Merge-request: 1831
Reviewed-by: Olivier Goffart <ogoffart@trolltech.com>
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | | |
However, compiling with QT_NO_ICON will still not work :(
Reviewed-by: tom
|
|\ \ \ \
| | |/ /
| |/| | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
On Mac OS X, Cocoa, we would synthesize italics on the text by slanting
it in the incorrect direction (so it leaned to the left) when generating
a path from the text, e.g. when printing.
The patch makes the text slant the correct way, and the logic now
becomes identical with the synthesized italics in the draw() function.
Task-number: QTBUG-4969
Reviewed-by: Trond
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Font names were not retrieved correctly after the QT_WA removal patch.
The old code always used the GetTextOutlineA() API, except for WinCE,
even when a Unicode compatible Windows platform was used.
Reviewed-by: Kim
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Formerly, QTextDocument::revision() could be used to guesstimate the
number of available undo steps that was used in Qt Creator to store
cursor positions in parallel to the actual text contents. Now that
revision() is strictly increasing, another means is needed, therefore
the new functions providing the needed data.
Reviewed-by: mae
|
| |
| |
| |
| | |
Reviewed-by: Sarah Smith
|
| |
| |
| |
| |
| |
| |
| |
| | |
After 04d18b38c38c5ff623b30366ea08d56128b9b7d0 Qt didn't compile for
QWS. Will email original committer to verify that original intent is
maintained.
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QTextEdit (via QTextLayout) and QPlainTextEdit in Qt used to ignore
any font leading but added one extra pixel in QFontMetrics. With many
freetype fonts, this resulted in a "spacy" text layout.
The necessary fixes on X11 and Windows were to take (positive) leading
into account, to make the font database convert point sizes to pixel
sizes without rounding to plain integer values, and to subtract the
extra pixel from QFontMetrics from the font engines' descent value.
The change also fixes several places in styles and widgets, where
QFontMetrics::lineSpacing() was wrongly used instead of
QFontMetrics::height().
Ideally we should also handle negative leading, which would require
additional and bigger code changes in QTextLayout and QPlainTextEdit.
In addition, all other editors we have tested seem to ignore leading on
X11. If we choose to believe the values provided by freetype, our text
layout would be one pixel smaller than everybody else's.
On the Mac, this change does nothing. There our layout is still too spacy,
and for smaller fonts quite ugly compared to native Mac applications.
Done with mae.
Reviewed-by: mae
|
|\ \
| |/ |
|
| |
| |
| |
| | |
Reviewed-by: thartman
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In non-GUI applications on X11, QFont and QFontInfo return different
point size because for QFontInfo, the point size is converted to pixel
size and back, but with different dpis. This commit improves the
situation for the case where font config is used, but the bug still
needs to be fixed properly by using the same dpi for all point<->pixel
size conversions.
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| | |
Make the shapeText function return numGlyphs properly - its not always
the same as length of string.
Task-number: QTBUG-4848
Reviewed-by: Rhys Weatherley
|
|/
|
|
|
|
| |
The positioning is still wrong, but now it at least the glyphs are ok
Reviewed-by: msorvig
|
|
|
|
|
|
|
| |
The previous commit 9c6e466dc09813dd4a641b2cf385f35ac99346f5
included some changes which were not meant to be pushed.
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
Accidentally used git commit -a when should have used only git commit :(
This reverts commit 9c6e466dc09813dd4a641b2cf385f35ac99346f5.
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
| |
When dragging text from a non editable widget, QTextControlPrivate was
passing allowed actions = CopyAction, default action = MoveAction.
Default action is always used if you don't press any modifier keys, so
text could be moved (cut) out of a non editable widget such as QLabel
Task-number: QTBUG-4356
Reviewed-by: Aleksandar Sasha Babic
|
|
|
|
|
|
|
|
| |
ODF seems to not specify this property, while xslt (which odf copied
for this) does, writing it out will be much more useful than loosing the
info silently, though.
Reviewed-by: Denis Dzyubenko
|
|
|
|
|
|
|
| |
QFontEngineXLFD::boundingBox() function did not take justification into
account when calculating the bounding box for a set of glyphs.
Reviewed-by: Eskil
|
|
|
|
| |
Reviewed-by: Espen Riskedal
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When FontConfig was enabled, bitmap fonts would often get a different
pixel size than the one we requested. Usually the size would only be
a pixel off, but this was especially visible when printing in highres
with bitmap fonts, because in those cases we would request a pixel size
which was computed based on the printer's high dpi.
The result was that all printed text with bitmap fonts would be really
really tiny. The fix falls back to using the XLFD font engine when
using bitmap fonts (when the returned pixel size is different from the
requested), because this engine scales the fonts for us. This will
cause bitmap fonts to be rendered without antialiasing.
Task-number: QTBUG-3620
Reviewed-by: Simon Hausmann
|
|
|
|
| |
Reviewed-by: Richard
|
|
|
|
|
| |
Merge-request: 1716
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
|
|
|
| |
Rev-By: Trust-Me
|
|
|
|
|
|
|
|
|
| |
QTextControl showed inconsistent behaviour with DeleteEndOfWord and
DeleteStartOfWord when the cursor had a selection. With this patch,
the commands will simply delete the existing selection, which is
consistent behaviour with in other IDEs.
Reviewed-by: Simon Hausmann
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since vista style polish sets the font on polish, the
check for WA_SetFont will succeed, hence we never set the
actual font. I replaced the check with a full resolve.
However since the resolve would clear the resolve_mask,
from the widget font it has to be restored manually
so that QPainter:setFont can resolve it later.
Task-number: QTBUG-4646
Reviewed-by: trond
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The QPF implementation of alphaMapForGlyph() was returning
color values of RGBA = (a, a, a, 255) instead of (0, 0, 0, a),
which was inconsistent with all the other font engines.
This inconsistency caused some QPF-specific workarounds in the
OpenGL and OpenVG paint engines. This change removes the workarounds
and makes QPF generate the right colors from the start. Paint
engines that ignore the color table or which don't use the
alphaMapForGlyph() function (e.g. raster) are not affected.
Reviewed-by: Paul
|
| |
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
examples/webkit/formextractor/formextractor.pro
mkspecs/features/qt.prf
src/gui/painting/qpaintengineex.cpp
|
| |
| |
| |
| |
| |
| |
| |
| | |
Revert parts of adf322c514a5781dcb9ec304d44229fa47d5e8b3 to
get this to work as in 4.5.2 again. What the original
patch fixed, we don't really know..
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| | |
We have to munmap() what we have mmap()ed
Reviewed-by: Gunnar
Reviewed-by: Jeremy
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| |
| | |
After separating document revisions from the undo stack, the initial
revision after setText/setHtml could get to high. Now it's +1 from
the previous revision
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We only want to expand the width of the text, never shrink it. This is
so that we can account for text where the pixels of the text extend
beyond the edge of the last glyph. When we shrinked the width, code
that depended on the natural text width equalling the advance of the
text (such as WebKit) broke, and some text items would be positioned
wrongly. We now only take negative right bearings into account (right
bearing is left-bound), meaning that we only expand the text width,
never shrink it due to right bearing.
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| | |
In certain situations text would toggle between sub-pixel hinted
and normal antialiased, when e.g. drawing menus with -graphicssystem
opengl.
Reviewed-by: Samuel
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The revision was bound to the current depth of the undo stack. This
had the negative side effect, that equal revisions could point to
different documents, and sometimes changes would not even increase
the revision (in the case of undo command merging).
Reviewed-by: Roberto Raggi
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The change makes QTextCursor not extend the selection when inserting
characters at the end of the selection, provided that the cursor
position is at the end.
Reviewed-by: Simon Hausmann
Reviewed-by: Roberto Raggi
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a text in QTextLayout contained tabs, these would be counted as
single glyphs when breaking the text on a fixed number of columns,
rather than the number of characters they span.
The patch calculates the number of characters represented by a tab by
using the average character width of the font engine.
Task-number: QTBUG-4468
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
1. The mono format was not handled at all.
2. We really, really wanted to use sub-pixel hinted glyphs even
when they were not available.
3. The glyphFormat type in the FT font engine wasn't updated to
reflect the correct system glyph type.
Reviewed-by: Kim
|