| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
The created keyed actions are passed to wrong widget if this pointer
is passed insted of itemView. Also create softkey actions in
setItemView method instead of constructor in order that custom items
views are also working correctly.
Task-number:: QTBUG-4702
AutoTest: All QComboBox tests passed
Reviewed-by: Jason Barron
|
|
|
|
|
|
|
|
|
| |
setReadOnly.
Should set Qt::WA_InputMethodEnabled after set the flags, just because shouldEnableInputMethod() will read the flags.
Task-number: QTBUG-4917
Reviewed-by: Shane Kearns
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
|
| |
Use an internal class to reset the activationRecursionGuard when the scope is closed.
Reviewed-by: Leo Cunha
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The two major points were:
- Replacing "s60" with "symbian" in all event handling functions,
since there is nothing S60-specific about them.
- Replace the Symbian event types with the encapsulating
QSymbianEvent container. This allows us to cope with more types of
events in the future without having to add new virtual functions.
AutoTest: QWidget passed
Task: QT-1156
RevBy: Jason Barron
RevBy: Shane Kearns
RevBy: Sami Merila
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If we reparent a naive menu bar inside a widget that
has a menu bar from before, the old menu bar is lost.
This patch makes sure that we don't set the new
menu bar in this case, but let it remain as-is in
case the widget is reparanted out again later.
Rev-By: MortenS
|
| |
| |
| |
| |
| |
| |
| |
| | |
softKeyActions QHash in QDialogButtonBoxPrivate was not kept properly
in sync with standardButtonHash, causing QFileDialog to crash upon
startup.
Reviewed-by: Sami Merila
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Softkeys have a QAction that is related to some action widget.
The initial state of the action was set according the state of action
widget (enabled/disabled). Now, if action widget's state changes,
the softkey's action remain in the initial state.
This was fixed by removing the enable/disable from the QAction and
instead use the real state of action widget when handling the
command of softkey.
Task-number: QTBUG-4619
Reviewed-by: Janne Anttila
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/gui/kernel/qcocoaview_mac.mm
src/network/access/qhttpnetworkconnection.cpp
src/opengl/qgl_qws.cpp
src/opengl/qglpixelbuffer_egl.cpp
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The commit faec535829a0e454a6784b0c5c37cb63e7da8f73 introduced this bug.
Since we can add a submenu to the same supermenu, we should consider it
before disabling the submenu who already have a supermenu.
Reviewed-by: MortenS
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The bug against QFxTextInput is actually due to a bug in QLineControl.
Task-number: QT-2319
Reviewed-by: Martin Jones
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Made QComboBox::removeItem() do nothing instead of asserting if index
is out of range.
Reviewed-by: Andy Shaw
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QGraphicsView.
The main problem here is that QWidget assume that they are in the screen
somewhere, which means inside the available geometry provided by
QDesktopWidget. But in QGraphicsView the button can be in a position
that is way bigger than the screen resolution. Lot of widgets make
this assumption when positionning subpopups or submenus. Instead of
applying the same code on tons of QWidgets, it's better to have an
helper function in desktop widget which catch this case. It's not
pretty (since it has nothing to do with QDesktopWidget) but we don't
have better solution.
Task-number:QTBUG-3822
Reviewed-by:brad
|
| |
| |
| |
| |
| |
| |
| | |
The previous commit 9c6e466dc09813dd4a641b2cf385f35ac99346f5
included some changes which were not meant to be pushed.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| | |
Accidentally used git commit -a when should have used only git commit :(
This reverts commit 9c6e466dc09813dd4a641b2cf385f35ac99346f5.
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
Implemented gestures using gesture events and separate
QGesture/QGestureRecognizer classes.
Reviewed-by: trustme
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It turns out that scrolling appears to be slow when using
non-mac mice with the carbon build. This patch introduces a
an acceleration algorithm that closer resembles the one
used by Cocoa.
Rev-By: prasanth
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes issue that both DialogButtonBox and softkeys are visible
(e.g. in Ftp example) at the same time.
Reason is that the previous implementation did the visiblitity setting when buttons were created.
Unfortunately buttons can be created without parent and let layout manager to find parent them
for you - so dialog as parent (=hide dialogbuttonbox as softkeys are in use) check failed.
Now similar check is done before showing the widget - it is layoutted here, so it has parent as well.
As a bonus, the event handling is already looking for dialog parent, so we can avoid doing another
for-loop.
Task-number: QTBUG-4739
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We should not create a QAction instance at program startup,
that is before QApplication was initialized. One reason not
to do that is that internal fonts are prematurely initialized
without QApplication::qt_is_gui_used set to true, which leads
to wrong font Dpis in qt_defaultDpiX().
This issue was detected due to the failure in tst_QTextLayout,
cases: testDefaultTabs, testTabs, testMultilineTab,
testRightTab, testTabsInAlignedParag, testCenteredTab,
testDelimiterTab, testMultiTab and tabsForRtl.
Fix: create a Q_GLOBAL_STATIC_WITH_ARGS for that QAction
instance.
Reviewed-by: Liang QI
|
| |
| |
| |
| |
| |
| | |
We need to test through extension tool button and menu for it when there is no enough width on embedded devices.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using very large fonts, sometimes the scrollbar of the
QPlainTextEdit will allow you to do scroll down past the end of the
document, in which case the currentBlock in hitTest() is inValid() which
caused an assert in currentBlock.next().
Task-number: QT-938
Reviewed-by: mae
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QTextControl has two independent interaction flags
TextEditable and TextSelectableByKeyboard, i.e. the latter can also
apply in read-only mode. This used to be handled incorrectly
in QTextEdit.
Reviewed-by: con
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QTextControl has two independent interaction flags
TextEditable and TextSelectableByKeyboard, i.e. the latter can also
apply in read-only mode. This used to be handled incorrectly
in QPlainTextEdit.
Reviewed-by: con
|
| |
| |
| |
| | |
The variable updatesEnabled is not used on Mac OS X.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The reason for the crash was the following: When we make menu entries
in Qt, we assign each item an arbitrary command ID. This is because
Symbian usually puts the items in a resource file and refers to them
by ID, but we need to be dynamic. These command IDs are also assigned
to cascading menu items (sub menus). When we then get a callback in
RestoreMenuL with one of submenu IDs, we used to ask Symbian to
construct the menu items for them, but Symbian doesn't know about
them.
Fixed by avoiding call into S60 code if the ID belongs to Qt.
Also put a cap on the number of menu items. It's very unlikely that
anyone will reach it, but it's better to have an actual check.
Task: QT-646
AutoTest: Manual testing went fine
RevBy: mread
|
| | |
|
| | |
|
| |
| |
| |
| | |
RevBy: Trust me
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When rendering etched text on disabled rich text labels
we would previously draw distorted links.
This is basically because anything that
did not render with the text foreground role would
be drawn twice as a shadow. Since there is no way to properly
render this text etched we will rather disable it completely
when the label uses rich text.
Task-number: QTBUG-4543
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| | |
Seems like I forgot to handle page scrolls.
Also did a small optimization
(see also 45f095b8970dc3c1b6f6e97fa2323654ba848288)
|
| |
| |
| |
| |
| |
| |
| |
| | |
It turns out that we need to let singleStep keep its value
in qtextedit so that pushing the up/down buttons on the slider
works as they should. Moreover, overriding the behaviour in
abstract slider also makes QGraphicsView work out of the box.
Also added in the test fix suggested by Olivier.
|
| |
| |
| |
| |
| |
| |
| | |
The change implements the same logic for QLabel which QLineEdit (and
implicitely QSpinBox and QComboBox) already had.
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A wheel event contain delta values that describe the rotation
angle the wheel was rotated (in 1/8 of a degree).
For some mouse devices (thinking of mac mighty mouse/trackpad)
the resolution is better than the standard 15 degrees. The Qt
docs describe how to deal with this. But abstract scrollbar does
did follow this recipe, but it does now with this patch.
Reb-By: prasanth
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since vista style polish sets the font on polish, the
check for WA_SetFont will succeed, hence we never set the
actual font. I replaced the check with a full resolve.
However since the resolve would clear the resolve_mask,
from the widget font it has to be restored manually
so that QPainter:setFont can resolve it later.
Task-number: QTBUG-4646
Reviewed-by: trond
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Reviewed-by: TrustMe
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Fixes QComboBox edit field geometry in s60style
Fixes softkey crash when setting a custom itemview to QComboBox
Fixes Symbian keyboard input interval in tst_QComboBox::virtualAutocompletion()
Reviewed-by: Sami Merila
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The problem is that it is using mapToGlobal to translate a mouse
position andthat doesn't work well when the widget is mebedded inside
graphics view.
Task-number: QT-2218
Reviewed-by: Bjoern Erik Nilsen
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Softkey actions need to copy enable state from action widget to prevent
crash when action is triggered and action widget is disabled.
OPEN: dynamically setting enable state for softkey actions.
Task-number: QT-2117
Reviewed-by: Jason Barron
|
|\ \
| |/
| |
| |
| |
| |
| |
| |
| | |
Reviewed-by: Joao
Conflicts:
src/gui/graphicsview/qgraphicsview.cpp
src/gui/widgets/qspinbox.cpp
tests/auto/qgraphicsview/tst_qgraphicsview.cpp
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Removing dubious intermediate detection code that also had a buffer
overflow. The results were inconsistent and not dependable on.
Processing was inefficient and end value to user experience dubious.
Test cases that abused the former behaviour were changed to consider
input in an Intermediate where it was previously considered Invalid.
With this change, user input will mostly be considered in an
intermediate state, until it is effectively validated.
Task-number: 255019
Reviewed-by: Anders Bakken
|
| |
| |
| |
| | |
Reviewed-by: Paul
|
| |
| |
| |
| |
| |
| |
| | |
The mouse move events were eaten regardless of the dragging state.
Task-number: 238004
Reviewed-by: Thierry
|
| |
| |
| |
| |
| |
| | |
These should not be exported anymore after commit c13b97f2.
RevBy: Jason Barron
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In S60 softkeys and menu items do not support key accelerators (i.e.
CTRL+X). Therefore, removing the accelerator characters from both softkey
and menu item texts.
Related to task QT-1505 "Make Qt dialogs look native"
Reviewed by Jason Barron
|