| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Reviewed-by: Trust Me
|
|\
| |
| |
| |
| |
| | |
Conflicts:
tests/auto/network-settings.h
tests/auto/qpainter/tst_qpainter.cpp
|
| |
| |
| |
| |
| |
| |
| |
| | |
We need to floor instead of round to prevent rectangles that are on the
edge from being shifted one pixel down / right.
Task-number: 258776
Reviewed-by: Kim
|
| | |
|
| |
| |
| |
| |
| |
| | |
Copy variable initialization/cleanup code from X11
Reviewed-by: Tom
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
To support correctly breaking text and calculating the bounding rect
of text that has a right bearing (like italic text), we need to take
the bearing into account when doing the layout. We add the bearing when
checking whether we need to break the text, and we add it to the natural
width of the text whenever we've finished a text line, so that we get
the correct bounding rectangle.
This patch only takes the last glyph's bearing into account. The
theoretically correct approach would be to take all bearings into account
and use the one which gives the longest text width. However, in practice
the bearing of the glyph will not be great enough for it to span over
several other glyphs.
Also refactored a little to make the code simpler.
Task-number: 176401
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| | |
The order of the parameters to the QMargins constructor changed in
commit 758f4735bcae034ac25730e53bb371df3b7d6e8a.
Reviewed-by: Alessandro Portale <alessandro.portale@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The widget needs to use the naturalTextWidth to adjust the horizontal
scrolling, otherwise it will not fit correctly the text in the visible
area when resized.
Merge-request: 1410
Reviewed-by: Alan Alpert
|
| |
| |
| |
| |
| |
| |
| | |
In icon mode, if you click on the viewport (with extended selection),
the selection should be cleared when you release the mouse button.
Reviewed-by: ogoffart
|
| |
| |
| |
| | |
That's the last of them... for now.
|
|\ \
| |/
| |
| |
| | |
Conflicts:
src/gui/kernel/qapplication.cpp
|
| |
| |
| |
| | |
Reviewed-by: thartman
|
| |
| |
| |
| | |
Reviewed-by: trustme
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Oxygen did not use icons in dialogs. This is obviously
incorrect compared with other KDE apps. We changed common style
to enable button icons by default on X11 and explicitly
disabled them for Windows and Motif styles.
We also updated the icons for YES and NO actions to use
dialog-ok and process-stop to reflect the usaged in
KDE itself.
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| |
| |
| | |
Do not call clearFocus() for child item in setParentItemHelper() if
called from destructor: At this time, the ~QGraphicsItem destructor
already deleted all its children.
Reviewed-by: Andreas Aardal Hanssen
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit fixes some issues which occur when pressing the Shift key
while selecting items (new unit tests included):
1. The offset of the visible area is missing at one point in
QAbstractItemView::keyPressEvent, causing Shift-Arrow selection to fail
if the view is scrolled down.
2. Shift-click and Shift-Arrow selection fail after a rubberband
selection because d->pressedPosition does not correspond to a valid
QModelIndex.
The problems have been found in Dolphin:
http://bugs.kde.org/show_bug.cgi?id=163451
Merge-request: 1426
Reviewed-by: Olivier Goffart <ogoffart@trolltech.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The fontSizeAdjustment defaulted to 0 which means "medium" in internal
semantics. This will override any font size you set in the short-hand.
In other locations, fontSizeAdjustment defaults to -255 which has no
meaning attached. To allow setting the font size in short-hand (as in
"font: 20px Arial"), we can't default to a specific adjustment.
Two tests are added: The first verifies the case that already worked,
where you specify the font size using the "font-size" property. The
other verifies the short-hand case and would previously fail.
Task-number: 207189
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| | |
Optimizations in change 8e447e8a did not handle the case when the target
width is less than the width of a tile.
Task-number: 260759
Reviewed-by: Samuel
|
| |
| |
| |
| |
| |
| |
| | |
The custom shader code in the OpenGL2 paint engine needs time to
mature before we make this official public API.
Reviewed-by: trustme
|
|\ \
| |/
| |
| |
| | |
Conflicts:
src/gui/itemviews/qlistview.cpp
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On 10.5 and below the pixmap data bytes happened to be initialized by
malloc, on 10.6 this is no longer the case.
Revby: Gunnar Sletta <gunnar@trolltech.com>
Similar to 28f94e1ef94f.
|
| |
| |
| |
| |
| |
| |
| | |
We need to clear the QPixmap before the image is drawn using the
CGContextDrawImage().
Reviewed-by: Norwegian Rock Cat
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When setRowHidden() was called after a root index was set then it would
not actually hide the row, if a root index is not set then it worked
fine.
Task-number: 260879
Reviewed-by: Jan-Arve
|
| |
| |
| |
| | |
Q_DECLARE_METATYPE must appear before qRegisterMetaType.
|
| |
| |
| |
| |
| |
| |
| |
| | |
QRasterizer, QClipData and QRasterBuffer only need to exported when
QRasterPaintEnginePrivate is subclassed which only is the case for
DirectFB.
Reviewed-by: Noam Rosenthal <noam.rosenthal@nokia.com>
|
| |
| |
| |
| |
| | |
Task-number: 258991
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This lets us stream a single QPaintBuffer instead of one QPaintBuffer
per frame in the trace graphicssystem, which leads to not streaming
pixmaps / images once per frame. Performance when doing a trace is also
a lot better for painting heavy applications.
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| | |
This reduces the size of the trace files significantly in certain cases.
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Second try.
This is a fixed version of the one reverted in commit 25014061b8de
The difference is that it does
text[offset] = QChar::LineSeparator;
instead of
chr = QChar::LineSeparator;
Reviewed-by: Eskil
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fix prevents crashes in
QGraphicsItem caused by calls to pure virtual functions as an item
tries to access its dying parent. This happens when an item is moved
by an ancestor during this ancestor's destructor.
Autotests included.
Reviewed-by: bnilsen
|
| |
| |
| |
| |
| |
| | |
This also needs to be reviewed by andreas.
Reviewed-by: Michael Brasser
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Note that the constraint is only enforced when resizing the window
interactively. Calling setGeometry() will not try to enforce the
constraint.
See the graphicsview/flowlayout example for a "manual test".
Task-number: 257455
|
| |
| |
| |
| |
| | |
Adjust the constraint with the widget margin before passing it on to
d->layout->effectiveSizeHint().
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When we export a bulleted list to HTML, we add a meta-block around the
list items to set the bullet style of the list (<ul> or <ol>.) This
block will implicitly have a margin, even if the list itself does not
in the internal document. The result is that exporting a list to HTML
and then reloading it will give a different apperance, because the 0
margin of the original was not saved. The fix is to always set the
meta-block's margin to 0, since it is only there to set the bullet
style and should not affect the layout at all.
Task-number: 201228
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On 10.5 and below the pixmap data bytes happened to be initialized by
malloc, on 10.6 this is no longer the case.
Revby: Gunnar Sletta <gunnar@trolltech.com>
Similar to 28f94e1ef94f.
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Because we did not reiimplement SE_TabBarTabText to force the
parentstyle to call the virtual function back, we got the normal style
margins in addition to the one by the stylesheet.
Also added test for !hasNativeBorder to suport cases where we just
specify a border
Reviewed-by: jbache
Task-number: 196326
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Before the QLineEdit change, the QLineEdit::displayText used to return the
currently entered text when we call validate() on the validator.
Now, the displayText is set _after_ the validation.
Hence, the QDateTimeEdit::validate did not had access to the real text.
Reviewed-by: Thierry
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 253733
Reviewed-by: Bjørn Erik Nilsen
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Arabic and Syriac are connected scripts where the letter shape changes
depending on the context. Text eliding should not affect that letter
shape if the truncation happens in the middle of a word.
The patch ensures that by adding a Unicode ZWJ character between the
text and the eliding in case the character would connect in the full
string.
Reviewed-by: Simon Hausmann
|
| | |
| | |
| | |
| | |
| | | |
1. "is is" -> "it is"
2. remove excess use of the work "unexpected"
|
| | |
| | |
| | |
| | | |
Reviewed-by: TrustMe
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | | |
Reviewed-by: Trond
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | | |
Reviewed-by: Trust Me
|
| |\ \ \ |
|
| | |\ \ \ |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Some concerns were expressed about the float precision of QMatrix4x4,
which this change addresses by using qreal instead.
The QVector2D/3D/4D classes still use float internally, so that they
can be used directly in large arrays of vertex values to be uploaded
to an OpenGL server.
QQuaternion is a client-side class, and it should produce rotations
that are consistent with QMatrix4x4. So its precision was changed too.
A consequence of this change is that the following no longer works
in a portable fashion:
QMatrix4x4 mat;
...
glLoadMatrixf(mat.constData());
The caller must now repack the argument to convert from qreal to GLfloat.
Reviewed-by: Michael Goddard
Reviewed-by: Andreas
|
| | |/ / /
| |/| | |
| | | | |
| | | | | |
Reviewed-by: Trust Me
|