| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
It is only used for creating the bitmap context, so there is no reason
to keep it around.
Reviewed-by: Morten Sørvig
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to this, the behaviour of count(), itemAt() and removeAt() was
different between QGraphicsLinearLayout and QGraphicsGridLayout.
QGraphicsGridLayout does it right.
This adds some behaviour changes:
1. QGraphicsLinearLayout::count() is no longer affected by inserted
stretches (through insertStretch)
This means that code like this will break:
QGraphicsLinearLayout *linearLayout = new QGraphicsLinearLayout;
linearLayout->addItem(new QGraphicsWidget);
linearLayout->addStretch();
int count = linearLayout->count();
linearLayout->removeAt(count - 1);
// before this patch it would do nothing (and it wouldn't
// actually remove the stretch), with the new patch it would
// remove the QGraphicsWidget.
2. count(), itemAt() and removeAt() now prints a warning for an invalid
index.
The documentation actually says that "The reimplementation can assume
that index is valid (i.e., it respects the value of count()", but I
decided that its too risky to not assume that it is valid, since it
would break the following common pattern:
while(layout->itemAt(0)) {
layout->removeAt(0);
}
Cleaned up autotests (and a small codeblock) that assumed
itemAt/removeAt with an invalid index to work, since we should try to
follow our own advice. :-)
This change is also an alignment with what QGraphicsGridLayout does
(it checks the index argument and prints a warning too.)
|
|
|
|
|
|
|
|
| |
QSpinBox failed to recalculate its cached size hint
when setting the range, prefix, or suffix.
Reviewed-by: janarve
Task-number: 255051
|
|
|
|
| |
Reviewed-by: trustme
|
|
|
|
|
|
| |
I was a bit overzelous removing them, but they should remain for 10.4
Reviewed-by: Morten Sørvig
|
|
|
|
|
|
|
|
|
| |
This is somewhat related to task 254526. The height of buttons
on Vista/XP is a few pixels too tall in standard dialogs because
they incorrectly reserve space for a default frame which is
not used in these styles.
Reviewed-by: prasanth
|
|
|
|
|
|
| |
Removed lots of places where we check for Tiger. Now we can assume it.
Reviewed-by: Morten Sørvig
|
|
|
|
|
|
|
|
|
| |
These are used enough (at least on the mac) to justify them being
accessible in a private header. As a bonus it "hides" the actual
container being used, so we could potentially sway it out with something
different.
Reviewed by: Jens Bache-Wiig
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ah! One less ###!
The scroll functions in Carbon and Cocoa don't scroll the regions that
have been marked dirty. In the past, we killed performance by updating
the whole view. We got a workaround for Carbon in the form of an SPI,
but I wasn't aware of a corresponding item in the NSView API, but it is
there publically and available in 10.5. Fast scrolling in Cocoa now for
people who like to use the keyboard.
Reviewed by: Morten Sørvig
|
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty/webkit/VERSION
src/3rdparty/webkit/WebCore/ChangeLog
src/3rdparty/webkit/WebKit/qt/ChangeLog
tests/auto/qgraphicsitem/tst_qgraphicsitem.cpp
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
After discussing with some of the Objective-C
people I have finally got a fair number of the
warnings to disappear in both 10.5 and 10.6. I
also took the opportunity to remove a bunch of
other warnings.
Reviewed by: Morten Sørvig
|
| |
| |
| |
| |
| | |
Task-number: 256720
Reviewed-by: Trond
|
| |
| |
| |
| |
| | |
Task-number: 254805
Reviewed-by: prasanth
|
| |
| |
| |
| |
| |
| |
| |
| | |
gcc 4.1.2 on X11 somehow confuses assignment of a temporarily
constructed QSettings object to a reference with invalid access
to the private assignment operator of QSettings.
Reviewed-by: mgoetz
|
|\ \
| |/
| |
| |
| | |
Conflicts:
src/sql/drivers/psql/qsql_psql.cpp
|
| |
| |
| |
| |
| |
| |
| | |
Re-enable fractional coordinates for text output, to produce the same
output as regular Carbon/ATSUI applications.
Reviewed-by: Norwegian Rock Cat <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
object.
QWizard crashed when removing a page after deleting an object
that was already registered as a field for the page. This patch
prevents such a crash by doing the necessary cleanup immediately
when the object is deleted. QWizard::removePage() will then see a
consistent state in this case.
Reviewed-by: janarve
Task-number: 255350
|
| |
| |
| |
| |
| |
| |
| | |
focusWidget().
Reviewed-by: Thierry
Task-number: 255468
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The problem was that we did an accelerated move, i.e. scrolled the
widget's contents in the backing store and repainted the old area. We
cannot do this trick when the widget has been invalidated (show(),
resize()). In this case the widget had never been painted, so we
basically scrolled the content of its parent and the widget itself
appeared as invisible.
Auto-test included.
Task-number: 255117
Reviewed-by: Paul
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
of bounds access.
This problem is encountered if a model doesn't report it's changes correctly.
Reviewed-by: Thierry
Task-number: 256617
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The documentation is a bit ambiguous on what the expected behavior here
is, but the behavior was consistent across paint engines before 4.5.
QPaintEngineEx introduced inconsistencies in the raster and OpenGL paint
engines, so this patch reverts the behavior back to what it was in 4.4.
Task-number: 256549
Reviewed-by: Trond
|
| | |
|
| |
| |
| |
| |
| |
| | |
Use the display color space for QNativeImage to avoid format conversions.
Reviewed-by: Samuel
|
| |
| |
| |
| |
| | |
This change also moves the EGL support classes from QtOpenGL to QtGui
so they can be shared between OpenGL and OpenVG.
|
| |
| |
| |
| | |
Task-number: 212058
|
| |
| |
| |
| |
| |
| | |
From 14 per X11 application down to 4.
Reviewed-by: jbache
|
| |
| |
| |
| |
| |
| |
| |
| | |
Change 855aa89e0ba99f8a0f75d7b31930bab2cefb93f8 incorrectly changed
toNormalizedFillRect to use int truncation instead of qRound. This
fixes the autotest failure in tst_QPainter::drawRect2 as well.
Reviewed-by: Trond
|
| |
| |
| |
| | |
Task-number: 256287
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It's a member in QRasterPaintEngine which is subclassed by
QDirectFBPaintEngine which lives in a plugin.
Partial revert of 48257d751a76699e548e59b76fc79303ef328375
Reviewed-by: TrustMe
|
| |
| |
| |
| | |
Every cycle counts :)
|
| |
| |
| |
| |
| |
| |
| |
| | |
It's easier to read and maintain the code now. This version is also
faster than the old one and makes it easier to implement another
cut-off I'm working on.
All auto-tests still pass. Examples/demos run fine.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
enum Qt::Uninitialized contains one value, which is also called
Uninitialized. Because the type and the value used the same name,
wherever the type Qt::Uninitialized was used in a function signature,
you had to include the enum keyword. But qdoc's preprocessor doesn't
like that, so you have to take the enum keyword out of the signatures.
But then the compiler complains because the type and the value look
the same. So I had to change the enum type name to Initialization, so
the compiler can distinguish it from the value name. And qdoc likes
that too.
|
| |
| |
| |
| |
| |
| | |
button and still be able to activate an action
Task-number: 253494
|
| |
| |
| |
| | |
Reviewed-by: Samuel
|
|\ \
| |/
| |
| |
| |
| |
| | |
Conflicts:
configure.exe
tests/auto/qpainter/tst_qpainter.cpp
translations/qt_ru.ts
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QItemEditorCreator
The creators were not deleted i nthe destructor of QItemEditorFactory
and they could not be safely used for more than one type.
Task-number: 228255
Reviewed-by: jasplin
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts a behavior change introduced with Qt 4.5.0 where
QInputDialog::getText() returned the line edit's text when the dialog
was rejected.
However, the behavior since Qt 4.0 has been to return a null QString
when the dialog is rejected.
Task-number: 256299
Reviewed-by: Andy Shaw
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Change from a relative to an absolute fuzzy compare as was the case
pre-4.4. With a relative fuzzy compare points that have an x or y
coordinate of 0 will never be merged with points that are very close to
0, for example (1e-15, 0).
Task-number: 251909
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| | |
Make sure not to use the broken QRect constructor, and do an early check
on whether the clip rect is empty in QRasterizer::rasterizeLine().
Task-number: 254105
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
model
This is a part of a bigger patch from 4.6
90cdbf8bd409652fd1e28adcd7f02fc1fae2c1c0
Task-number: 256183
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
of the boundaries of the viewport.
Now we catch this and don't call update. This was a performance
regression against 4.4.
Task-number: 256183
Reviewed-by: alexis
|
| |
| |
| |
| |
| |
| |
| |
| | |
This could happen when the list of styles depending on the font is
different from the font you selected before. It then is not updated
and the style of the font returned by the QFontDialog is wrong.
Task-number: 256466
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These constructors are useful when you have to create a temporary
uninitialized QTransform/QMatrix and later initialize it to something
else.
Done with Lars.
Reviewed-by: samuel
|
| |
| |
| |
| |
| |
| |
| |
| | |
An item without menu could stay highlighted even when the mouse left
the menu bar.
Task-number: 256322
Reviewed-by: alexis
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The QtSVG module failed to link because it includes qgraphicsitem_p.h,
which had an inlined function (updateHelper) that called an undeclared
function (QGraphicViewPrivate::update(Region|Rect))...Resulting in
unresolved symbols.
Reviewed-by: MariusSO
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the widget under mouse is hidden, Qt can generate a synthetic mouse move
event which gets delivered to the already hidden widget. This can then result
in the wrong item being selected.
Workaround: in QListView, ignore mouse move events when the widget is hidden.
Reviewed-by: Denis
|
| |
| |
| |
| |
| | |
I changed the logic in e920c83084b48db7fe1925c7b98e34794eec6d55 and this
negation incidentally snuck in.
|
| |
| |
| |
| | |
We save three function calls by calling item->paint() directly.
|
| |
| |
| |
| | |
Avoid QTransform copy in common case.
|