| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
More information in task 166873.
Merge-request: 514
Reviewed-by: Jan-Arve Sæther <jan-arve.saether@nokia.com>
|
|
|
|
|
|
|
|
| |
Some checks where in the wrong locations, and some endifs where
hard to read.
Merge-request: 611
Reviewed-by: Marius Storm-Olsen <marius@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The fix that was introduced adds regressions, and I don't see a way we
can fix it without breaking someone elses code. So restoring the
original fix that just avoid a crash (autotest by Thierry is included).
Revert "Revert Avoid a crash when setting a focus in a widget
hierarchy containing"
Revert "Setting a focus on a widget hierarchy which contains both
visible and invisible widgets could cause a crash."
This reverts commit be833a4f25a8ec8c3dd7a8ac4fa4b0507c93e7ee.
This partially reverts commit 1a7da7096bbda17197738061902f4489af234bc0
Reviewed-by: Thierry Bastian
Reviewed-by: Prasanth Ullattil
|
|
|
|
| |
Reviewed-by: Joerg
|
|
|
|
|
|
|
|
|
|
|
| |
The check for cleartype in qt_win_read_cleartype_settings() was not
correct for Windows Mobile
For anti-aliased text rendering we also have to use another
pixel format for the native image.
Task-number: 249642
Reviewed-by: mauricek
|
|
|
|
|
|
|
|
|
| |
We've had a problem with a stale cache for color profiles this should
make things work well. We get the callback for each display whether it
needs it or not, but honesly I would rather that we update this a few
times too many when people change their display profile than not at all.
FWIW, this code is inspired from Apple's Tech Note TN2035.
|
|
|
|
|
|
|
|
|
|
| |
What could happen starting with 4.4 is that you could move a toolbar.
If you then added actions, the toolbar would grom and make the other
toolbars move to the right although it had enough space already to show
the newly created actions.
Autotest will follow shortly.
Task-number: 226060
|
|
|
|
|
| |
Merge-request: 384
Reviewed-by: Marius Storm-Olsen <marius@trolltech.com>
|
|
|
|
|
|
|
| |
seem fixable easily)
Merge-request: 594
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
|
|\ |
|
| |
| |
| |
| |
| |
| | |
We were saying that it connected to accepted it all these cases, but it
actually is doing some nice magic that makes sense assuming you document
it.
|
| |
| |
| |
| |
| |
| |
| |
| | |
No progress bars on the mac show text and it would be bad if we allowed
it. There's nothing stopping people from connecting the valueChanged()
signal to a slot and have a real label layed out correctly that actually
updates with the amount of time it takes to complete, etc. This is more
what they do on Mac OS X if they decide to show a label.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QMotifStyle
Same fix as in e9a7e43031d7c1ee712e43be682c4e2c183759c4 but with motif
Reported by https://bugs.kde.org/show_bug.cgi?id=193911
Task-number: 255138
Reviewed-by: jbache
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This was quite a bug and it showed to some issues that I hadn't taken
into account when doing the initial port to Cocoa. The issue was that we
weren't "merging" items into the application menu if an item had already
been associated with it. Which seems OK for applications that create one
window with one menubar, but breaks down horrible when you have multiple
windows with each having their own menubar. The result is that items in
the application menu potentially go to the wrong window (and the
potential crash). Since there can only ever be one "Quit", "About", or
"Preferences" menu item in Cocoa, we need to make sure that we keep
these items in sync whenever we switch the menubar or remove actions
that are being deleted. That's what we do here.
FWIW, QActions with "ApplicationSpecificRole" for their menu role have
potential to cause memory leaks or other bugs if abused. If you are a
happy open source hacker who wants a thankless job, solving them would
get you lots of goodwill in my book.
Task-number: 255038
Reviewed-by: Richard Moe Gustavsen
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The blend functions assume the width / height of the images being
blended to be greater than 0. A width of 0 caused the first iteration of
a duff's device memcpy (QT_MEMCPY_USHORT) to be executed, thus blending
8 pixels instead of none.
BT: yes
Task-number: 255014
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| | |
The R and B channels were swapped on little endian machines with
BGR layout.
Task-number: 254934
Reviewed-by: Samuel
|
| |
| |
| |
| | |
Reviewed-by: Thierry Bastian
|
| |
| |
| |
| | |
There should be no QT_{BEGIN,END}_HEADER here; this is a private header.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
HITheme doesn't seem to support the reverse thing. I filled a bug about
it, but this is easy to emulate in the horizontal case and the
"Inverted" orientation works great for vertical.
Task-number: 217594
Reviewed-by: Morten Sørvig
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| | |
Reviewed-by:David Boddie
|
| |
| |
| |
| |
| |
| |
| |
| | |
In the style code, the internal UsePixmapCache flag made
no sense in practice, so it was removed. A fortunate side-effect
of the patch is that the code is now accepted by Sun CC 5.5.
Reviewed-by: jbache
|
| |
| |
| |
| | |
Reviewed-by: tbastian
|
| |
| |
| |
| |
| |
| |
| | |
a QStatusBar
Task-number: 253717
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| | |
These function exist for making code not look so crazy, so let's
actually use that in code where it didn't exist before.
|
| |
| |
| |
| |
| |
| |
| | |
but the current highlighted item doesn't change
Task-number: 254238
Reviewed-by: ogoffart
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When pressing the <- key on a Windows mobile device, the window gets
a minimized event (no other soft keys behave like that). Restoring the
window via the app menu isn't possible, because the window get a
WM_ACTIVATE but its internal state is still minimized.
It makes sense to unminimize activated apps on Windows mobile.
Task-number: 254673
Reviewed-by: thartman
|
| |
| |
| |
| | |
Copy&paste error; the classes are in Gui, not Core.
|
| |
| |
| |
| |
| | |
Merge-request: 578
Reviewed-by: Simon Hausmann <simon.hausmann@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Now there's only a copy of the texture glyph cache in graphics memory,
avoiding the system memory copy that we used earlier. In addition the
texture will use the GL_ALPHA texture format when possible, making it
consume less graphics memory as well.
Reviewed-by: Tom
|
| |
| |
| |
| |
| |
| | |
This reverts commit a5b11b9031f9a2a97b65e9a6134244249845491a.
The proper fix is 1a7da7096bbda17197738061902f4489af234bc0.
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
both visible and invisible widgets.
This is a quick hack to avoid a crash in Qt when setting a focus on a
visible widget that has invisible parent. Proper fix was committed
into master 1a7da7096bbda17197738061902f4489af234bc0, see it's
description for more details.
Task-number: 254563
Reviewed-by: Thierry Bastian
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QFont has a feature that you can pass a comma-separated list and it will
walk through the list and match the font that it hits first. There's a
nice static function that X11 and Windows uses, but the Mac was using an
older copied version of it. This old version didn't handle quoting which
is what happens in the style sheet. So, using the same code makes
everything work well. As a bonus, Creator looks correct again.
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| | |
This won't leak on error case, and will work with arbitrary sizes.
Also changed from int to short as instructed by Samuel.
Reviewed-by: Samuel <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On Mac, a widget with a NoFocus policy could still get focus
(if only temporarily) as the result of a native focus event.
In particular, a line edit with a completer should
not lose focus (if only for a brief moment) as a result of the
completer popup being shown. This will for example cause an
item delegate to think that the user has navigated away from
the cell and delete the line edit as a result. This will in turn
cause the completer to access a null pointer.
Reviewed-by: Richard Moe Gustavsen
Task-number: 254456 and 254460
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
invisible widgets could cause a crash.
Also, when there is a widget hierarchy A->B->C and A and C are marked
as visible but B is hidden, when the user gives focus explicitely to
C, we should remember that and respect it when B becomes visible.
Task-number: 254563
Reviewed-by: Thierry Bastian
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were only "constraining" headers if they were large, but ignoring the
small and mini ones. This resulted in the small and mini headers looking
bigger than their normal ones which looked strange. Since the headers
have no real small or mini size for a header, we'll make sure to
constrain them all the same.
Task-number: 221115
Reviewed-by: Richard Moe Gustavsen
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In the past, TempLocation would return something like:
/private/var/folders/4k/4k97GBy2Ha46D3DAWSLbQE+++TI/TemporaryItems
Now it returns something like:
/var/folders/4k/4k97GBy2Ha46D3DAWSLbQE+++TI/-Tmp-
This isn't that different and it's a temporary location so it shouldn't
effect many people (and it will be gone once the system reboots anyway),
but the issue could be that TemporaryItems isn't there and that it's a
bit more "Carbon" to use TemporaryItems. Also our own documentation
claims they are equivalent and I'm happy to do that.
I also enforced the Qt-style of if-statements and got rid of the extra
qualifiers to make the code look nicer.
Task-number: 253806
Reviewed-by: Morten Sørvig
|
|\ \
| |/
| |
| |
| |
| |
| |
| | |
Conflicts:
src/opengl/gl2paintengineex/qpaintengineex_opengl2.cpp
tests/auto/qgraphicswidget/tst_qgraphicswidget.cpp
tests/auto/selftests/expected_skip.txt
tests/auto/selftests/tst_selftests.cpp
|
| |
| |
| |
| |
| | |
KDE Bug: https://bugs.kde.org/show_bug.cgi?id=191759
Reviewed-by: Bradley T. Hughes
|
| | |
|
| |
| |
| |
| |
| | |
Task-number: 254549
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were adding two times in the QActionPrivate list the entry for
the current QGraphicsWidget if the action was existing before.
Task-number:KDE
Reviewed-by:bnilsen
BT:yes
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
An optimization was made to the sorting of QFileDialog to sort only
the current root (meaning what the user see). This avoided slowness
when the model was big with lots of leafs. The problem here is
for the treeview, the root is always the same, we expands only
nodes. In that case, a recursive sorting is needed to ensure that
all expanded nodes are correctly sorted (and filtered). This will
be slower that's why i use an hidden flag in the d pointer to
deactivate the recursive sort for the QFileDialog.
Task-number:254701
Reviewed-by:olivier
BT:yes
|
| |
| |
| |
| |
| |
| |
| |
| | |
When QWidget::scroll() is called on a widget with WA_PaintOnScreen,
scroll the dirty region.
Task-number: 254742
Reviewed-by: bnilsen
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If pixmaps were added through QIcon::addFile() with different sizes
than the sizes of the pixmaps themselves, streaming the icon in didn't
work properly.
Task-number: 254374
Reviewed-by: Kim
|
| |
| |
| |
| |
| |
| |
| | |
The bounding rect computed in fixup() is one pixel too wide, causing
potential memory corruption by painting outside device boundaries.
Reviewed-by: Trond
|
| |
| |
| |
| | |
The signature was using qreal, when it should have used T.
|