| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Reset the dangling subFocusItem pointer in ~QGraphicsItem,
after all the child items have been deleted.
This replaces commit d724c91a0ae.
Reviewed-by: Thomas Hartmann
|
|\
| |
| |
| | |
kinetic-declarativeui
|
| |
| |
| |
| | |
Reviewed-by: trustme
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Oxygen did not use icons in dialogs. This is obviously
incorrect compared with other KDE apps. We changed common style
to enable button icons by default on X11 and explicitly
disabled them for Windows and Motif styles.
We also updated the icons for YES and NO actions to use
dialog-ok and process-stop to reflect the usaged in
KDE itself.
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| |
| |
| | |
Do not call clearFocus() for child item in setParentItemHelper() if
called from destructor: At this time, the ~QGraphicsItem destructor
already deleted all its children.
Reviewed-by: Andreas Aardal Hanssen
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit fixes some issues which occur when pressing the Shift key
while selecting items (new unit tests included):
1. The offset of the visible area is missing at one point in
QAbstractItemView::keyPressEvent, causing Shift-Arrow selection to fail
if the view is scrolled down.
2. Shift-click and Shift-Arrow selection fail after a rubberband
selection because d->pressedPosition does not correspond to a valid
QModelIndex.
The problems have been found in Dolphin:
http://bugs.kde.org/show_bug.cgi?id=163451
Merge-request: 1426
Reviewed-by: Olivier Goffart <ogoffart@trolltech.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The fontSizeAdjustment defaulted to 0 which means "medium" in internal
semantics. This will override any font size you set in the short-hand.
In other locations, fontSizeAdjustment defaults to -255 which has no
meaning attached. To allow setting the font size in short-hand (as in
"font: 20px Arial"), we can't default to a specific adjustment.
Two tests are added: The first verifies the case that already worked,
where you specify the font size using the "font-size" property. The
other verifies the short-hand case and would previously fail.
Task-number: 207189
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| | |
Optimizations in change 8e447e8a did not handle the case when the target
width is less than the width of a tile.
Task-number: 260759
Reviewed-by: Samuel
|
| |
| |
| |
| |
| |
| |
| | |
The custom shader code in the OpenGL2 paint engine needs time to
mature before we make this official public API.
Reviewed-by: trustme
|
| |\
| | |
| | |
| | |
| | | |
Conflicts:
src/gui/itemviews/qlistview.cpp
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
On 10.5 and below the pixmap data bytes happened to be initialized by
malloc, on 10.6 this is no longer the case.
Revby: Gunnar Sletta <gunnar@trolltech.com>
Similar to 28f94e1ef94f.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We need to clear the QPixmap before the image is drawn using the
CGContextDrawImage().
Reviewed-by: Norwegian Rock Cat
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When setRowHidden() was called after a root index was set then it would
not actually hide the row, if a root index is not set then it worked
fine.
Task-number: 260879
Reviewed-by: Jan-Arve
|
| | |
| | |
| | |
| | | |
Q_DECLARE_METATYPE must appear before qRegisterMetaType.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
QRasterizer, QClipData and QRasterBuffer only need to exported when
QRasterPaintEnginePrivate is subclassed which only is the case for
DirectFB.
Reviewed-by: Noam Rosenthal <noam.rosenthal@nokia.com>
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 258991
Reviewed-by: Trust Me
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This lets us stream a single QPaintBuffer instead of one QPaintBuffer
per frame in the trace graphicssystem, which leads to not streaming
pixmaps / images once per frame. Performance when doing a trace is also
a lot better for painting heavy applications.
Reviewed-by: Trond
|
| | |
| | |
| | |
| | |
| | |
| | | |
This reduces the size of the trace files significantly in certain cases.
Reviewed-by: Trond
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Second try.
This is a fixed version of the one reverted in commit 25014061b8de
The difference is that it does
text[offset] = QChar::LineSeparator;
instead of
chr = QChar::LineSeparator;
Reviewed-by: Eskil
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fix prevents crashes in
QGraphicsItem caused by calls to pure virtual functions as an item
tries to access its dying parent. This happens when an item is moved
by an ancestor during this ancestor's destructor.
Autotests included.
Reviewed-by: bnilsen
|
| | |
| | |
| | |
| | |
| | |
| | | |
This also needs to be reviewed by andreas.
Reviewed-by: Michael Brasser
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Note that the constraint is only enforced when resizing the window
interactively. Calling setGeometry() will not try to enforce the
constraint.
See the graphicsview/flowlayout example for a "manual test".
Task-number: 257455
|
| | |
| | |
| | |
| | |
| | | |
Adjust the constraint with the widget margin before passing it on to
d->layout->effectiveSizeHint().
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When we export a bulleted list to HTML, we add a meta-block around the
list items to set the bullet style of the list (<ul> or <ol>.) This
block will implicitly have a margin, even if the list itself does not
in the internal document. The result is that exporting a list to HTML
and then reloading it will give a different apperance, because the 0
margin of the original was not saved. The fix is to always set the
meta-block's margin to 0, since it is only there to set the bullet
style and should not affect the layout at all.
Task-number: 201228
Reviewed-by: Simon Hausmann
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
On 10.5 and below the pixmap data bytes happened to be initialized by
malloc, on 10.6 this is no longer the case.
Revby: Gunnar Sletta <gunnar@trolltech.com>
Similar to 28f94e1ef94f.
|
| |\ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Because we did not reiimplement SE_TabBarTabText to force the
parentstyle to call the virtual function back, we got the normal style
margins in addition to the one by the stylesheet.
Also added test for !hasNativeBorder to suport cases where we just
specify a border
Reviewed-by: jbache
Task-number: 196326
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Before the QLineEdit change, the QLineEdit::displayText used to return the
currently entered text when we call validate() on the validator.
Now, the displayText is set _after_ the validation.
Hence, the QDateTimeEdit::validate did not had access to the real text.
Reviewed-by: Thierry
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Task-number: 253733
Reviewed-by: Bjørn Erik Nilsen
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Arabic and Syriac are connected scripts where the letter shape changes
depending on the context. Text eliding should not affect that letter
shape if the truncation happens in the middle of a word.
The patch ensures that by adding a Unicode ZWJ character between the
text and the eliding in case the character would connect in the full
string.
Reviewed-by: Simon Hausmann
|
| | | |
| | | |
| | | |
| | | |
| | | | |
1. "is is" -> "it is"
2. remove excess use of the work "unexpected"
|
| | | |
| | | |
| | | |
| | | | |
Reviewed-by: TrustMe
|
| | |\ \
| | | |/ |
|
| | | |
| | | |
| | | |
| | | | |
Reviewed-by: Trond
|
| | | |\ |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Reviewed-by: Trust Me
|
| | |\ \ \ |
|
| | | |\ \ \ |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Some concerns were expressed about the float precision of QMatrix4x4,
which this change addresses by using qreal instead.
The QVector2D/3D/4D classes still use float internally, so that they
can be used directly in large arrays of vertex values to be uploaded
to an OpenGL server.
QQuaternion is a client-side class, and it should produce rotations
that are consistent with QMatrix4x4. So its precision was changed too.
A consequence of this change is that the following no longer works
in a portable fashion:
QMatrix4x4 mat;
...
glLoadMatrixf(mat.constData());
The caller must now repack the argument to convert from qreal to GLfloat.
Reviewed-by: Michael Goddard
Reviewed-by: Andreas
|
| | | |/ / /
| | |/| | |
| | | | | |
| | | | | | |
Reviewed-by: Trust Me
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Done by Lars
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The logic of numCopies() returning 1 to indicate how many times you
have to run your printing code is not ideal and prevents the
"property" to be used as a placeholder for the value, which was
required by KDE. Added QPrinter::actualNumCopies() to ask
for the value set through setNumCopies() or through the print dialog.
Reviewed-by: Trond
|
|\ \ \ \ \ \
| | |/ / / /
| |/| | | |
| | | | | | |
kinetic-declarativeui
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reviewed-by: Aaron Kennedy
|
| |\ \ \ \ \
| | | |/ / /
| | |/| | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Missing from e3c62dc1def9270761ca63c73ae76fdca9d61582 is the actual
change to the (generated) scanner, namely to skip lowercase conversion
for each and every character.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reviewed-By: TrustMe
|
| | |\ \ \ \ |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This way we avoid having a lot of code in a static (and
unmaintainable) library. The s60main static library now currently has
only one task: to call main().
To move the initialization into QtGui also meant a change in how the
S60 framework is created, because we can no longer use the trick
where we create and start the the S60 event loop and then have the
framework call us back to start main(). The initialization now
follows the creation and destruction of QApplication, which is a lot
more in line with how other platforms do it.
Since S60 doesn't support creating the environment, and *then*
starting it (both are executed by the same call), we had to open up
the S60 framework construction classes and just mirror what they do.
This means that after QApplication construction is done, the S60
framework is initialized, but nothing will run yet and control will
return to main(), where the user can start the event loop himself.
One of the quirks of this approach is that the construction of the
S60 framework makes a new cleanup stack. This means that any active
traps will not be active anymore, and leaving without setting a new
trap will most likely panic. This shouldn't be a problem for us,
since Qt is never supposed to leave, but it means that if anyone uses
the cleanup stack without setting a new trap, they will receive a
panic.
It was considered to add a trap mark in QApplication construction and
then removing it on destruction, but it was dropped because leaving
from main() is still undefined (even if the old cleanup stack would
be restored in the destructor, we wouldn't be able to stop the
exception from unwinding the stack, and the cleanup stack would then
be unbalanced).
RevBy: Jason Barron
RevBy: Janne Anttila
AutoTest: QWidget passed with same failure count
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Reviewed-by: Yann Bodson
|