| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Whitespaces in identifiers now past autotests
Reviewed-by:Bill King
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
| |
After the coverity fix, the proper code path executed, which failed to
enquote the date field properly, so this fix fixes that issue.
|
|
|
|
| |
Found by coverity.
|
|
|
|
|
|
|
| |
Mysql queries other than select can't be prepared, otherwise they fail
to return the necessary meta-information to enable them to be seen as
returning data under certain versions of mysql. This fixes the hack
to work correctly until we stop preparing queries automagically.
|
|
|
|
|
| |
Every source file must end with a newline, otherwise:
"Error: There is extra text on this line."
|
|
|
|
|
|
|
| |
Call PQclear() regardless of the status of the result returned by
PQexec().
Reviewed-by: Bill King
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
When contructing the EXECUTE statement, there is a special case that
we need to handle whereby we explicitly put quotes around the
special float values before submutting the statement for execution
Task-number:233829
Reviewed-by: Bill King
|
|
|
|
|
| |
Task-number: 257247
Reviewed-by: trustme
|
|
|
|
|
|
| |
The comparison was mistakenly only uppercasing one side, so mixed case
table names were reporting back as if they weren't found for both
QSqlDatabase::record() and QSqlDatabase::primaryIndex()
|
|
|
|
|
| |
When the precisionpolicy is high, and the field is numeric, it was getting
confused as a string field and pulling the wrong length value.
|
|
|
|
|
| |
Tinyint only supports 0-255, so mark it as unsigned despite sign flag,
which have the time is inverted/wrong.
|
| |
|
|
|
|
|
|
| |
- as was not the case for the psqlODBC driver
Reviewed-by: Bill King
|
|
|
|
|
|
|
| |
- case for QVariant::Bool in switch statement was missing
Task-number: 215511
Reviewed-by: TrustMe
|
| |
|
|
|
|
| |
delete -> delete []
|
|
|
|
|
|
|
|
| |
- add checks for failed malloc's
- convert some of the obvious malloc'ed stuff to use new/delete
Task-number: 200217
Reviewed-by: Bill King
|
| |
|
|
|
|
|
|
| |
Passes all autotests.
Task-number: 251739
|
|
|
|
|
|
|
|
| |
Until the PostgreSQL API has this functionality.
Use a hack to find out if a transaction has failed or not.
This hack is a limited to 8.x versions of PostgreSQL.
Bill King
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
| |
This reverts commit bb7bddc47dd0748b45d22180d9e3c8e5209010b3
due to forward binary compatibility issues in a point release.
|
|
|
|
|
|
| |
Found by valgrind, value isn't set but is used, fixes this.
Reviewed-by: Justin McPherson
|
|
|
|
|
|
| |
As found by valgrind. Also add error reporting that was missing.
Reviewed-by: Justin McPherson
|
|
|
|
|
|
| |
As suggested in gitorius merge request 421, solution supplied by Harald.
Reviewed-by: Harald Fernengel
|
|
|
|
|
|
| |
Allows for cleaner multi-thread working for mysql clients.
Task-number: 253407
|
|
|
|
|
|
| |
Uses fb_interpret instead of isc_interprete if using firebird. Closes a potential security hole/buffer overrun.
Reviewed-by: Justin McPherson
|
|
|
|
|
|
|
| |
If a QSqlQuery survived the lifetime of removal of a mysql db connection (that failed), the cleanup code would cause a segfault because it was using an out of date pointer that was pointing at memory that'd been freed by the removeDatabase() call.
Revby: Justin McPherson
Task-number: 205701
|
|
|
|
| |
Task-number: 246808
|
|
|
|
| |
Reviewed-by: nrc
|
|
|
|
| |
Task-number: 250632
|
|
|
|
| |
Best as I can determine via trial and error. It should make vc6 compile again though.
|
|
|
|
| |
It seems that after approx version 2.7.0, microsoft changed the ODBC types of certain functions, to cater for 64bit architectures. This tries to be a little bit smarter about which types are used in which places.
|
|
|
|
|
|
|
| |
Alleviates the performance hit of querying the database except when necessary,
try and use XSQLVAR as much as possible, except for floating point fields.
Task-number: 252426
|
|
|
|
|
| |
Differring case of username shouldn't mean adding the username on front.
Also fixes autotest failures.
|
|
|
|
|
|
|
| |
This test has always been wrong/confusing. Fix it to work, and make sense.
Task-number: 250026
Revby: Lincoln Ramsay
|
|
|
|
|
|
|
| |
Microsofts SQL Server odbc driver calls SET QUOTED_IDENTIFIER_ON,
but freetds doesn't, so any quoting fails. This fixes that issue.
Reviewed-by: abcd
|
|
|
|
|
|
|
|
|
|
|
| |
If no quotes around identifiers are provided by the programmer,
identifiers are treated identically to how the underlying engine
would behave. i.e. some engines uppercase the identifiers
others lowercase them. If the programmer wants case sensitivty
and/or use whitespaces they will need to quote their identifiers.
The previous (incorrect) behaviour always quoted the identifiers.
Reviewed-by: Bill King
|
|
|
|
|
|
|
|
|
| |
The high precision code path was getting an empty string on the second
call to getstringdata, which was causing it to return empty for the
field. Really only needed to call it once anyway, so use the original
call.
Reviewed-by: Justin McPherson
|
|
|
|
| |
Last of the changes to include behaviour from QPtrVector
|
|
|
|
|
|
|
| |
Looks like they were using the old QPtrVector in qt3, and didn't quite
handle the porting correctly.
Reviewed-by: Lincoln Ramsay
|
|
|
|
|
|
|
|
|
| |
offsets not handled correctly
Now also removes negative timestamps.
Task-number: 249059
Reviewed-by: Justin McPherson
|
|
|