summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Store QObject*'s in the QVariant data structureAaron Kennedy2009-08-072-3/+14
| | | | | | | | Rather than requiring an allocation of the "shared data" region, QObject *'s should be stored directly in the data structure. This very marginally, but measurably, improves QVariant performance. Reviewed-by: Thiago Macieira
* fixing outputMessage in qplaintestlogger.cpp for Windows CEJoerg Bornemann2009-08-061-5/+7
| | | | | | | | There's a restriction to output only 255 characters per line. The loop we had before was wrong and did some read operations somewhere behinde the end of the message string. Reviewed-by: thartman
* Fix a bug in QProcess. QProcess was not reentrant on UnixBenjamin Poulain2009-08-061-1/+11
| | | | | | | | | QProcess is supposed to be reentrant but was not on Unix. The constructor of QProcessManager could be exectued several time when QProcess is created. The construction is now protected by a mutex. Task-number: 254246 Reviewed-by: Olivier Goffart
* Fix warnings on mingwThierry Bastian2009-08-061-3/+3
| | | | mingw doesn't support format with %llu or %ll. So I used a QString
* multimedia: fix warnings on mingwThierry Bastian2009-08-064-4/+3
| | | | | moved static CRITICAL_SECTIONs to cpp files. In header they would be declared more than once depending on what file includes those headers.
* build fix for mingwThierry Bastian2009-08-061-0/+1
| | | | getQApplicationPrivateInternal was not declared
* Fix compile on WindowsJens Bache-Wiig2009-08-061-1/+1
| | | | Reviewed-by: jesper
* Cocoa: Add support for native gesturesRichard Moe Gustavsen2009-08-062-13/+51
| | | | Cocoa: Add support for native gestures
* Fix warnings on MSVCThierry Bastian2009-08-062-2/+2
|
* Fix test failure in tst_QDateTimeEdit::task118867Eskil Abrahamsen Blomfeldt2009-08-061-1/+1
| | | | | | | setCursorPosition() should be able to set the cursor at the end of the string. This is a copy-paste error made when refactoring QLineEdit. Reviewed-by: Gunnar
* Fix QObjectRace testOlivier Goffart2009-08-061-1/+1
| | | | We should not unlock too early, or node might get deleted.
* Make sure cursorPositionChanged is emitted when cursor position changesEskil Abrahamsen Blomfeldt2009-08-061-0/+1
| | | | | | | | | | | When selecting the text and setting the cursor position, we need to emit the cursorPositionChanged signal. This seems to be a copy-paste error from refactoring QLineEdit, as the function call is there in the original version of setSelection(). The effect was two test breakages in tst_QDateTimeEdit, because the section and cursor position of the QDateTimeEdit would be out of sync. Reviewed-by: Gunnar
* QMenuBar: we can't test the action geometries when it is nativeThierry Bastian2009-08-061-0/+3
|
* QStandardItem::takeRow() would crash when it had no columns.Gabriel de Dietrich2009-08-061-8/+10
| | | | Reviewed-by: olivier
* Make sure QWidget::setStyle() relayouts its children.Jan-Arve Sæther2009-08-061-1/+3
| | | | | | | | | | | | Changing a style on a widget should invalidate the widget's layout, since the layouts spacings and margins may depend on the style. One optimization could be to check to see if the spacing and margins have changed due to the style change, but the old style is not available in changeEvent, so we'll keep it simple for now. RevBy: paul Task: 256986
* QMenu: small little code simplificationThierry Bastian2009-08-061-12/+5
| | | | Reviewed-by: trustme
* Fix QMacStyle subControlRect()-reporting for CC_SpinBoxTor Arne Vestbø2009-08-061-3/+9
| | | | | | | | | The mac style ignored the QAbstractSpinBox::NoButtons flag for the SC_SpinBoxEditField sub-control, effectivly always making room for the spinner buttons. Now it's in line with both the Cleanlooks style and the Windows (common) style. Reviewed-by: Jens Bache-Wiig <jbache@trolltech.com>
* QMenu could return wrong geometries for its actionsThierry Bastian2009-08-061-0/+2
| | | | | We needed to call ensurePolished before updating the action rects.
* Faster quaternion multiplications.Ariya Hidayat2009-08-061-18/+11
| | | | | | | | | | | | | Use the known factorization trick to speed-up quaternion multiplication. Now we need only 9 floating-point multiplications, instead of 16 (but at the cost of extra additions and subtractions). Callgrind shows that the function now takes 299 instructions instead of 318 instructions, which is not a big win. However I assume the speed-up has a better effect for mobile CPU, where multiplications are more expensive. Reviewed-by: Rhys Weatherley
* Compile fix for gestures.Denis Dzyubenko2009-08-061-5/+4
| | | | Reviewed-by: trustme
* Support _NET_WORKAREA on Xinerama setups in QDesktopWidgetBradley T. Hughes2009-08-061-8/+18
| | | | | | | Instead of ignoring _NET_WORKAREA, merge it with each screen geometry to give a meaningful availableGeometry() for all screens. Reviewed-by: denis
* Fixes a regression in qwidget when setting a large minimum size.Denis Dzyubenko2009-08-061-9/+9
| | | | | | | | | Setting a minimum size to a value that is larger then the biggest allowed widget size, we should costrain the widget to that max allowed size as we did before. Change 6a2621b6832dbdd349f77cf1f3242b4a6ba3c740 broke it. Reviewed-by: Bradley T. Hughes
* Small fix for native gestures on windows.Denis Dzyubenko2009-08-061-7/+2
| | | | | | We should close the gestureinfo handle only we managed to open successfully. Reviewed-by: trustme
* Enable pan gesture on all QAbstractScrollArea-based widgets.Denis Dzyubenko2009-08-067-29/+40
| | | | | | | | | Two-finger panning will work on all QAbstractScrollArea based widgets, however single-finger panning will be enabled only on some special widgets that always wants it - for example we don't want it on QGraphicsView, and we might want it on itemviews *sometimes*. Reviewed-by: trustme
* Changed setting state in a QGestureDenis Dzyubenko2009-08-064-40/+55
| | | | | | | | | | | | Instead of having a protected setter for the state and forcing the application developer to emit signals manually (which leads to misunderstanding - i.e. if the started() signal should be emitted only once, or of the triggered() signal should be emitted before the finished() signal, etc). So I've added an protected updateState(state) function that sets the internal state and emits appropriate signals depending on the old and new states. Reviewed-by: Volker Hilsheimer Reviewed-by: Richard Moe Gustavsen
* Rearranged the gesture code a bit for future native gestures on Windows.Denis Dzyubenko2009-08-069-45/+80
| | | | | | | | Moved the code that subscribes to native gestures on Windows to a private function in QWidget which will check which gestures the widget is subscribed to and enable native gestures as requested. Reviewed-by: trustme
* Fix build for mingwThierry Bastian2009-08-061-1/+2
| | | | | Unfortunately mingw doesn't know about the IFileDialog interface. So it might have issues on Vista with a file dialog with search enabled.
* Fixed crash in tst_qitemview.Gabriel de Dietrich2009-08-061-1/+2
| | | | | | QAbstractItemViewPrivate::selectionModel may be null. Reviewed-by: olivier
* Replace instances of weak linking for 10.3 with 10.4.Morten Sorvig2009-08-061-1/+1
|
* Merge commit 'origin/4.5'Rohan McGovern2009-08-069-11/+40
|\ | | | | | | | | | | | | | | Conflicts: src/gui/dialogs/qfiledialog.cpp src/gui/dialogs/qfiledialog_win.cpp tests/auto/qicoimageformat/tst_qicoimageformat.cpp tests/auto/qscriptqobject/qscriptqobject.pro
| * Fix a bug when activating HideNameFilterDetails on Windows filedialog.Alexis Menard2009-08-052-11/+19
| | | | | | | | | | | | | | | | | | | | The HideNameFilterDetails was not taken in account for windows file dialog. This patch fix that. For Windows Vista and later we use now the new COMMON_ITEM_DIALOG API (in master) where it add always the filter extension like *.txt so no point to take that flag in account. Task-number: None, during testing Reviewed-by: prasanth
| * Fix compilation when QT_NO_HTTP is definedMarkus Goetz2009-08-056-5/+12
| | | | | | | | | | | | | | | | Note however you still need to -nomake examples -nomake demos when configuring Qt. Reviewed-by: Thiago Task: 259179
| * Fixes hangup when pressing key in QListWidgetOlivier Goffart2009-08-051-0/+7
| | | | | | | | | | | | | | | | | | If there is severals matching items but all of them are disabled, it would have produced an infinite loop. Block the loop once we reach an already matched item. Task-number: 258949 Reviewed-by: Thierry
| * Cocoa: Menus show old selected values.Richard Moe Gustavsen2009-08-051-0/+6
| | | | | | | | | | | | | | | | | | | | We never told Cocoa that it needed to redraw the window view when a window was shown. This is implicit if the window is shown for the first time, but needs to be done explicit if you hide and show it again. Task-number: 254672 Reviewed-by: bnilsen
* | Make QLineEdit cursor blink againAlan Alpert2009-08-061-0/+3
| | | | | | | | | | | | | | Somehow forgot to hook up the blinking signal (in the new QLineControl) to QLineEdit. Reviewed-by: Trust Me
* | Compile Fix for QT_KEYPAD_NAVIGATIONAlan Alpert2009-08-067-11/+29
| |
* | Doc: fix qdoc errors in QSharedPointer documentation.Thiago Macieira2009-08-052-2/+3
| | | | | | | | | | | | | | | | | | | | I added the documentation to QWeakPointer::data, but I forgot to declare the class in the qdoc stub. Also, apparently I cannot link to a specific overload of a given function. Reviewed-by: Volker Hilsheimer
* | Restore symmetry between QSharedPointer and QWeakPointer on QObjects.Thiago Macieira2009-08-053-0/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the previous commit, you could create a QWeakPointer from any QObject-derived object. It's possible because QObject now has a pointer to the QWeakPointer's d-pointer. However, if you did: QSharedPointer<QObject> obj(new QObject); QWeakPointer<QObject> weak1(obj); QWeakPointer<QObject> weak2(obj.data()); Then weak1 would shared d-pointers with QSharedPointer, but weak2 wouldn't. Also, weak1.toStrongRef() would work, but weak2.toStrongRef() wouldn't. This change makes QObject know where the d-pointer created by QSharedPointer is, so weak2 would get the same d-pointer. As a nice side-effect, you can check if a given QObject is shared by trying to promote its QWeakPointer to QSharedPointer. Reviewed-by: Bradley T. Hughes
* | Performance improvements by avoiding creation of temporary QSharedPointers ↵Thiago Macieira2009-08-051-43/+25
| | | | | | | | with d=value=0
* | Add support for using QWeakPointer with QObject, replacing QPointer.Thiago Macieira2009-08-054-5/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem with QPointer is that it's a simple QObject*. So the only way for QPointer to do what it's supposed to do is if the object it's pointing to clears all QPointers when getting deleted. That means the QObject must know each and every QPointer pointing to it. To make matters worse, QPointers can be deleted while the object they're pointing to also gets deleted. So deleting QObjects must do locking. The solution to the QPointer problem is that both QObject and the "QPointer" reference something outside the QObject. This way, QObject doesn't have to lock anything to destroy itself: it's simply setting a volatile integer to zero when it gets deleted. Since the integer is outside the QObject, the integer is also refcounted. It's also O(1), so there's no problem having as many "QPointer". The two-atomic-ints structure is exactly what QSharedPointer and QWeakPointer use internally. We just abuse this structure for QObject needs, setting the strong reference count to -1 to indicate that it's a QObject that cannot be managed by a QSharedPointer. But QWeakPointer can still work and replace QPointer neatly. Reviewed-by: Bradley T. Hughes Reviewed-by: Jarek Kobus
* | ItemViews: make it possible for chekcable items to get partiallyCheckedThierry Bastian2009-08-052-2/+13
| | | | | | | | | | | | | | Previously it was only switching between checked and unchecked. Task-number: 259008 Reviewed-by: ogoffart
* | QTapAndHoldGesture is gone, remove referenceVolker Hilsheimer2009-08-051-1/+1
| |
* | Fix compilation for compilers that don't have template friends.Thiago Macieira2009-08-051-1/+0
| | | | | | | | | | | | | | GCC has template friends, so I wasn't seeing the error that d is protected. Thanks to Robert for pointing out. Reviewed-by: Robert Loehning <robert.loehning@nokia.com>
* | Fixed setting a style shet on a QSpinBox to change the arrow possitionOlivier Goffart2009-08-051-4/+4
| | | | | | | | | | | | | | If you only set the position, of the button without setting a geometry, it did not work. Task-number: 259226
* | Fix regressions introduced by 31edb4d5a63b9b3c28cce1c4ca6eb99f62a09759Alexis Menard2009-08-052-5/+11
| | | | | | | | | | | | | | | | | | | | The commit 31edb4d5a63b9b3c28cce1c4ca6eb99f62a09759 introduced regressions in filters which breaks the mac native dialog, the non native dialog with HideNameFilterDetails activated. Task-number:259105 Reviewed-by:olivier Reviewed-by:prasanth
* | MainWindow: fixed an update issue when moving a separatorThierry Bastian2009-08-051-0/+3
| | | | | | | | | | | | A non painted (ie. garbage) area could appear if you had a fixed size dock widget and you moved the separator. The previous place where the separator was painted was not updated
* | Re-enable the use of Common Item DialogPrasanth Ullattil2009-08-051-1/+3
| | | | | | | | | | | | This was disabled by patch bf305bc2e488ad4f08c49767246f31a81218991e Reviewed-by: Thomas Hartmann
* | QMenu: fix a crash depending on stylesThierry Bastian2009-08-051-9/+13
| | | | | | | | | | We were calling pixelMetric and sizeFromContents with a NULL styleoption That crashes on mac and might also with other styles.
* | Merge AudioServices into mainline.Justin McPherson2009-08-0545-0/+10166
| |
* | Merge branch '4.5'Bill King2009-08-055-12/+36
|\ \ | |/ | | | | | | | | Conflicts: src/gui/graphicsview/qgraphicsitem.cpp
generated by cgit v0.12 at 2024-11-11 08:56:35 (GMT)