| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
We should allways use the brush and not the color if possible.
Task-number: 240842
Reviewed-by: nrc
|
|
|
|
| |
Reviewed-by: mariusSO
|
|
|
|
|
|
|
|
| |
The fix is basically remove the whitespaces at the end otherwise the
reg exp will be wrong.
Task-number: 240789
Reviewed-by: jasplin
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a few of the remaining glitches tabbar animations have:
* We no longer grab tabs but paint them through QStyle. This makes tabs
work and animate correctly when they are outside the visible region.
* Buttons now correctly follow tabs when dropped
* Gtkstyle recieved some polish to make it look more native.
Task-number: 247694, 251166
Reviewed-by: nrc
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Clip both against the source and target device rectangles.
Task-number: 247937
Reviewed-by: Trond
BT: yes
|
|\ \
| |/
| |
| | |
Merge commit '4e9c2364e8e9580aa317e9387338d45207ac4baa' into HEAD
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
same.
updateBoudingRect update the item only if the boundingRect change
but if we have 123 as an initial text and then we set 321 as the new
text, then nothing happen because the rect is the same.
In case the boundingRect change then we call update 2 times but
the item is already dirty so the second call will just return.
BT:yes
Reviewed-by: Andreas
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Mac/Cocoa.
Check if the view is visible before attaching it to a context.
Task-number: related to 250066
Reviewed-by: Norwegian Rock Cat
BT: yes
|
| |
| |
| |
| | |
It worked in 4.5.0, so it should work in 4.5.1 too.
|
|/
|
|
|
|
|
|
| |
mode, the settings are stored in
HKEY_LOCAL_MACHINE\Software\WOW6432node.
Task-number: 232011
Reviewed-by: Martin Petersson <martin.petersson@trolltech.com>
|
|
|
|
|
|
| |
glpixmapfilter should not be compiled for OpenGL ES 2.0 on nay platform
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
|
|
|
|
|
| |
The NSOpenGLContext seems to be tied to the window. So if the view
changes from one window to another, the OpenGL context needs to be
cleared. We can do this by hooking into the viewWillChangeWindow and
viewDidChangeWindow events and clear and reset the drawable
respectively. We also found out that QCocoaOpenGLView was not being used
at all, so just remove it to get rid of any confusion.
Task-number: 250066
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
|
| |
We did not update initGtkWidgets on theme changes which could
lead to crashes as the contents of the widget hash depend on
certain properties in the style. A simple way to reproduce this would
be to change between the redmond gtk theme and cleanlooks.
Task-number: 251115
Reviewed-by: paul
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e446518445c51c56471e41b1697e2a9e9f3adf36 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig.
This is a follow up of r40546. Call toImage() once speeds up ImageBuffer::getImageData()
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getImageData):
2009-02-03 Dirk Schulze <krit@webkit.org>
Reviewed by Sam Weinig and Oliver Hunt.
Added getImageData() support for QtWebKit.
[QT] lacks getImageData / putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::getImageData):
2009-04-14 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=25099
When creating a QNetworkRequest make sure to populate the
CacheLoadControlAttribute with the value set by the ResourceRequest::cachePolicy() so that the cache will be used as WebKit expects.
* WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::requestCache):
* platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
2009-04-07 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler
While working on <rdar://problem/5968249>, noticed some glaring problems with LocalStorage.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::localStorage): Return the cached m_localStorage object if it exists to
avoid creating multiple representations for the same underlying StorageArea.
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalLocalStorage): Return m_localStorage, not m_sessionStorage.
++ b/WebKitTools/ChangeLog
2009-02-25 Adam Treat <adam.treat@torchmobile.com>
Reviewed by Alexey Proskuryakov.
Do not queue the calls to 'DumpRenderTree::dump()' as this can result
in more than one call as a test that calls 'notifyDone()' can then be
subsequently fully loaded and initiate a second dump. Also make sure
to stop any existing page load that is happening before running the next
test. Combined this serves to produce 217 more passing tests for the
Qt port or roughly 5% at this point.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
|
|
|
|
|
|
|
|
| |
emit disconnected() if we were in ConnectedState or in ClosingState
before
Reviewed-by: Thiago
Task-number: 250976
|
|
|
|
|
|
|
|
| |
The submenu would always appear to the side of the menu instead of its
right.
Task-number: 250673
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
| |
QSortFilterProxyModel::hasChildren need to construct the mapping. And when it
tries to construct the mapping, it needs to fetch the childs, so there is none.
Task-number: 250023
Reviewed-by: Marius Bugge Monsen
|
|
|
|
| |
Reviewed-by: bnilsen
|
|
|
|
|
|
|
|
|
|
| |
When QString::replace was optimized, this specific overload missed out
on sanity checking of the arguments.
Task-number: 249517
Reviewed-by: Joao
Reviewed-by: hjk
BT: yes
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Regression caused by optimizations in QGraphicsItem and QGraphicsScene.
The changes in QGraphicsItem fix bugs in QGraphicsItem::mapToParent
functions, which did the translation before applying the transformation,
instead of the other way (transform, then translate). This bug caused
almost all mapToParent and mapRectToParent functions to behave wrongly.
Unfortunately the new helper functions in QGraphicsScene for discovering
items made use of these functions, which introduced a regression. Fixing
these functions also fixes item discovery.
The other part of this change fixes a regression caused by c1909321,
which luckily happened after 4.5.0 and never saw the light of day. The
fix is to also invalidate the cached clip path even if there is no scene,
which is necessary if you build your scene graph outside the scene, and
finish off by adding the root item to the scene.
Task-number: 250680
Reviewed-by: Alexis
|
| |
| |
| |
| |
| |
| |
| |
| | |
qt_accHotKey() was pretty buggy; it could both crash or spin forever
in some cases.
Task-number: 221731
Reviewed-by: alexis
|
|/
|
|
| |
Reviewed-by: hjk <qtc-committer@nokia.com>
|
|
|
|
|
|
|
| |
Microsofts SQL Server odbc driver calls SET QUOTED_IDENTIFIER_ON,
but freetds doesn't, so any quoting fails. This fixes that issue.
Reviewed-by: abcd
|
|
|
|
|
|
| |
Error was introduced in change 52f87de53328c661049acf09d5fedc1850aa9bfa.
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
|
|
|
| |
If no quotes around identifiers are provided by the programmer,
identifiers are treated identically to how the underlying engine
would behave. i.e. some engines uppercase the identifiers
others lowercase them. If the programmer wants case sensitivty
and/or use whitespaces they will need to quote their identifiers.
The previous (incorrect) behaviour always quoted the identifiers.
Reviewed-by: Bill King
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem here is that we are filling the sceneEventFilters map
when we install evenfilter but we never remove the references of an
item if it has been removed from the scene or deleted. The deletion can
keep stale pointers into the map and a crash can happen.
BT:yes
Task-number:250272
Reviewed-by: bnilsen
Reviewed-by: andreas
|
|
|
|
|
|
|
|
|
|
|
| |
[regression]
The problem was that we didn't update the new region when we paint the
rubber band and we scroll at the same time
BT:yes
Task-number: 245766
Reviewed-by: bnilsen
Reviewed-by: andreas
|
|
|
|
|
|
|
|
|
|
|
|
| |
QGLPixelBuffer::generateDynamicTexture() will bind the texture to the
pbuffer regardless. Why this works on Carbon is a mystery, but if we're
to follow our own docs, we should NOT bind the texture to the pbuffer
by default. An explicit call to ::bindToDynamicTexture() is required for
that.
Task-number: 250664
Reviewed-by: Samuel
BT: yes
|
|
|
|
| |
Reviewed-by: Norwegian Rock Cat
|
|
|
|
|
|
|
|
|
|
|
| |
This regression probably happened because of the fix to task 244485
(see 8d500381), which made QFile follow a rename. This means that
QTemporaryFile removes its target when it is deleted.
This fixes a number of caching autotests that are failing.
Reviewed-by: Markus Goetz
BT: yes
|
|
|
|
|
|
|
|
|
|
| |
Cocoa has a different way of dealing with cursors than our heavy handed
approach that we used in Carbon. We simply need to re-implement the
proper function in NSView and set up the rectangles for the cursor
correctly. We also need to expose an QCursor2NSCursor type functions
since the current QCursor::handle() is useless for doing this and we
shouldn't change that. With this change things seem to work much more
like the native stuff for both Carbon and Cocoa.
|
|
|
|
|
|
|
| |
Reviewed-by: Thomas Hartmann
need to check for valid menuBar, otherwise dereferencing will
horribly fail.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The way font propagation work has changed since 4.4: When there is a
stylesheet enabled, font does not propagate.
So when settings a font to the QAbstractItemView, the viewport font will
not change, and hence no QEvent::FontChange on it.
So catch the QEvent::FontChange in QAbstractItemView::event in addition
to QAbstractItemView::viewportEvent. (we seems to use the view's font
everywhere anyway)
Task-number: 250754
Reviewed-by: Jens Bache-Wiig
|
|
|
|
|
|
|
| |
Discovered in Kopete trunk
BT: yes
Reviewed-by: Thierry
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with Cocoa support on Mac.
The Cocoa API doesn't have a concept of Z-ordering of widgets, and it's
implemented by reordering the widget hierarchy for normal widgets. This
does unfortunately not work for GL widgets, and it's not supported by
Apple. This apparently work with the Carbon AGL API though.
Task-number: 244890
Reviewed-by: Gunnar Sletta
BT: yes
|
|
|
|
|
|
|
| |
Setting properties on an invalid printer is not supported. Use isValid() to check if it valid.
Rev-by: Trond Kjernåsen
Rev-by: Geir Vattekar
|
|
|
|
|
|
|
|
| |
The pen width should not be scaled for cosmetic pens.
Task-number: 247083
Reviewed-by: Trond
BT: yes
|
|
|
|
|
|
|
|
|
|
| |
NSPanels are set to hide when the application becomes inactive by
default. This is not what we wan't for normal dialogs in Qt. This
patch makes this setting explicit, in case the window we're about
to create is a dialog.
Task-number: 250869
Reviewed-by: Trenton Schulz
|
| |
|
| |
|
|
|
|
|
|
| |
This was causing compile warnings.
Reviewed-by: nrc
|
|
|
|
|
|
|
|
| |
Also add support for setting the width and height of the primary surface
using display arguments (which can be good when debugging performace
issues).
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
|
| |
When this code was written there was never a case when we would not blit
our flips and hence the entire if (!(flipFlags & DSFLIP_BLIT)) business
seems not to have been tested anyway. Since I don't see the point of
this I am taking it out. Might enable us to actually create the primary
surface in video memory more often.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
If connect options are set to include videoonly and creating the primary
surface in video memory fails warn even in release mode.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
The QVarLengthArray approach makes no sense with DirectFB. Draw.*s is a
regular function call and the receiving function even memcpy's the data
on arrival anyway.
Just call the Draw.* functions one by one
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
| |
Opacity doesn't play well with PorterDuff so we need to disable the
porter duff when opacity is set. Also the DSBLIT_SRC_PREMULTCOLOR flag
is not the right thing for us.
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: TrustMe
|