| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
... but leave it there on Symbian.
Reviewed-by: Aleksandar Sasha Babic
|
|
|
|
|
|
|
|
| |
QGraphicsView can set the system clip in order to handle clipping
of QGraphicsView children, and we have to take that into account
in the GL 2 engine, as we did in the GL 1 engine.
Reviewed-by: Samuel
|
|
|
|
|
| |
Unfortunately, qt_get_hex_rgb() is in QtGui (qcolor_p to be exact).
Hence, we need to duplicate the implementation for QtSvg.
|
|
|
|
|
|
|
|
|
| |
Both the shaders and the engine states were shared between OpenGL
contexts, but the states should be only apply to one context, not a
group of contexts. This commit separates the shaders and the states.
Task-number: 257254
Reviewed-by: Samuel
|
| |
|
|
|
|
|
|
| |
Thank you coverity!
Reviewed-by: Marius Storm-Olsen
|
|
|
|
| |
Reviewed-by: Trond Kjernåsen
|
|
|
|
|
|
|
| |
This was flagged by Coverity. We already have a struct filled from
IPC_STAT above, we shouldn't be passing unitialized data for IPC_RMID.
Reviewed-by: Marius Storm-Olsen
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since we are iterating all the XML attributes, we find and locate the id
while we are inside the loop. Thus, no need to retrieve the id via
QXmlStreamAttributes::value().
Also, get rid of someId(QSvgAttributes) function and use the 'id' member
variable directly.
Loading tiger.svg (tests/benchmarks/qsvgrenderer) enjoys 1.2% speed-up.
Reviewed-by: Kim
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the color starts with '#', let's parse it ourselves rather than
waiting for the (fall-back) QColor-from-QString which even requires
us to create a QString out of the QStringRef.
All widely used illustration programs output SVG with #rrggbb format
to specify the color.
Loading tiger.svg (tests/benchmarks/qsvgrenderer) enjoys 2.4% speed-up.
Reviewed-by: Kim
|
| |
| |
| |
| |
| |
| | |
Loading tiger.svg (tests/benchmarks/qsvgrenderer) enjoys 1% speed-up.
Reviewed-by: Kim
|
| |
| |
| |
| |
| |
| |
| | |
We try to use QStringRef as much as possible. Loading tiger.svg
(tests/benchmarks/qsvgrenderer) enjoys 1.2% speed-up.
Reviewed-by: Kim
|
| |
| |
| |
| | |
Reviewed-by: Kim
|
| |
| |
| |
| | |
Reviewed-by: Kim
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The default value is planned to be changed in the next minor update to
Gtk+ (2.28), hence we need to read this dynamically now. We also
added a helper-function to easily read a gconf bool.
Note, as a bonus feature I also added support for
"buttons_have_icons".
Task-number: 260684
Reviewed-by: joao
|
| |
| |
| |
| | |
That's the last of them... for now.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
This fixes the autotest that was crashing
Task-number: 246056
Reviewed-by: ogoffart
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
(It had to be minimum three anchors.)
|
| |\ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It used to compress it because in the layout we were never picking the
sizeHint. Now we do.
Task-number: 260483
|
| | |
| | |
| | |
| | | |
Reviewed-by: Tom
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This commit also adds initial support for fading behind modal dialogs.
Avoid unnecessary local/global capturing since when having global
capture enabled we cannot for example tap icons on statusbar.
The logic how pointer events for popups and modal dialogs shall work:
- Modal dialogs:
* Shall not close when outside dlg is clicked
* Shall not allow usage or underlying control with mouse
* Achieved with SetGloballyCapturing and SetPointerCapture
in enterModal_sys / leaveModal_sys
- Popups
* Shall close when the outside popup is clicked
* Achieved with enabling the SetPointerCapture only for topmost
popup and canceling it for all underlyuing ones.
* In addition long tap timer needs to be canceled for underlying
widgets when opening a pop-up. Otherwise theu get longtap event
whcih causes unexpected behaviour.
TODOs:
- Fading does not work correctly when more than two levels of modal
dialogs are opened.
- Fading does not work correctly when switching away from app and
back to it with fast swap window (using menu works)
- Check if fading should be implemented with MAknFadedComponent and
TAknPopupFader, in order to support cross-application fading
- Should popups closes when application loses the focus?
Reviewed-by: Janne Koskinen
|
| |
| |
| |
| |
| |
| |
| | |
Do not convert JSC::Identifier to QString to convert it later to
JSC::Identivier again
Reviewed-by: Kent Hansen
|
| |
| |
| |
| |
| |
| |
| |
| | |
Let us be optimistic here and reserve some space in the CSS symbols
array before parsing starts. This gives 3% speed-up when loading
tiger.svg (tests/benchmarks/qsvgrenderer).
Reviewed-by: Olivier Goffart
|
| |
| |
| |
| |
| |
| | |
derived class).
Reviewed-by: bill king
|
| |
| |
| |
| | |
Reviewed-by: Trust Me
|
| |
| |
| |
| |
| | |
Task-number: 176267
Reviewed-by: Justin McPherson
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
DirectFB allows you to have a locked subSurface that remains valid while
you paint on the unlocked "parent" surface.
The only limitation is that when accessing the locked memory you might
have to call DirectFB->WaitIdle() in case pending GPU operations aren't
finished.
After this we keep the locked surface around at all times (from the
first time it's requested) until the surface dies. Previous calls to
lock() will just call WaitIdle if necessary and previous calls to unlock
now just mark the surface as dirty and in need of a WaitIdle if someone
needs to access its pixel data.
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
| |
| |
| |
| | |
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
| |
| |
| |
| | |
Reviewed-by: Donald Carr <donald.carr@nokia.com>
|
| |
| |
| |
| | |
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
| |
| |
| |
| | |
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
| |
| |
| |
| |
| |
| | |
Making coverity happy.
Reviewed-by: Olivier Goffart
|
| |
| |
| |
| |
| |
| |
| |
| | |
It's very likely that some of the shader objects in required program
will be null, as not all are manditory. Check to see if they exist
before de-referencing them and asking for their log string.
Reviewed-by: Trustme
|
| |\
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/network/access/qnetworkaccessbackend.cpp
src/network/access/qnetworkreplyimpl.cpp
tests/auto/qabstractnetworkcache/tst_qabstractnetworkcache.cpp
|
| | |
| | |
| | |
| | | |
Discussed with Ben Meyer.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
any point. Rather then keep a separate pointer to the cache in the
reply use the pointer kept by the manager so the reply never tries
to access a cache pointer that has already been deleted.
Autotest: included
Merge-request: 1124
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
and when creating a CacheBackend set the manager pointer.
Merge-request: 1124
Reviewed-by: Thiago Macieira <thiago.macieira@nokia.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Thank you Coverity! Thank you Biochemist!
Reviewed-by: joao
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Instead of using operations that shuffle the array of numbers, just
use pointer to iterate the numbers. This reduced the amount of
memory operations during the parsing.
In addition, parse the numbers to QVarLengthArray instead of QVector.
This works well because usually a path element is typically followed by
a short list of numbers.
Loading tiger.svg (tests/benchmarks/qsvgrenderer) is now 8% faster,
mostly due to the time spent in parsePathDataFast is reduced from
26.1 millions instructions to just 20.5 millions (27% speed-up).
Reviewed-by: Kim
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There is really no need to use QString for parsing the matrix, hence
use QStringRef. In a complex SVG, this cuts significantly the time
spent in parseTransform().
Reviewed-by: Kim
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 257292
Reviewed-by: Trust Me
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 256745
Reviewed-by: Trust Me
|
| | |
| | |
| | |
| | | |
Reviewed-by: Trond
|