| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
The current implementation fails when moving the
widget onto an area that has just been exposed
as a part of a window resize operation.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the stringToCMap() fails, it can be because it did not have enough
space in the layout, or it can because of other errors. In order to
implement "try-again" processing in a simple way, we had an infinite
loop which assumed that stringToCMap() would always succeed in the
second run (which would be the case if the only possible error was
"not enough space".)
Since there are other possible failures not related to the number of
glyphs, you could easily get into an infinite loop here, e.g. when
laying out text that contains the Byte Order Mark.
The fix changes the implementation to explictly try stringToCMap()
twice at max, and is also how it's implemented in the default
qtextengine.cpp.
Task-number: QTBUG-4680
Reviewed-by: Trond
Conflicts:
src/gui/text/qtextengine_mac.cpp
tests/auto/qtextlayout/tst_qtextlayout.cpp
|
|
|
|
|
|
|
|
| |
Calling QWidget::setCursor() outside of the event loop causes a memory
leak in Cocoa. Adding an autorelease pool plugs it.
Merge-request: 1791
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@nokia.com>
|
|
|
|
|
|
| |
Cherry-picked from d8a2e52e
Merge-request: 419
Reviewed-by: Olivier
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem occurred on Windows due to a call to repaint() on a top-level
window from setDisabledStyle() in qwidget.cpp. This function is called
whenever a window is blocking. In this particular case the children of
the repainted window are opaque, and should therefore not be repainted,
which also means that the top-level have to subtract the region of the
opaque children when filling the background. This region is cached,
and the problem was that the cached region was wrong. It was wrong
because it was not invalidated properly.
Task: QTBUG-4245
Reviewed-by: Paul
|
|
|
|
|
|
|
|
| |
The background color of PE_Frame was palette().light() and has been
changed to use palette().background() now. This fixes the autotest
tst_QStyleSheetStyle::task188195_baseBackground for Windows mobile.
Reviewed-by: thartman
|
|
|
|
|
|
|
|
| |
The original approach of modifying the font for QAbstractButtons in
QWindowsMobileStyle::polish broke the autotest
tst_qstylesheetstyle::fontPropagation.
Reviewed-by: thartman
|
|
|
|
|
|
|
|
|
| |
This is an addition to
commit 5651d2547261ccecbf50f8141c634f59c0adc00d to make it obvious that
in cocoa nothing is returned.
Task-number: QTBUG-4873
Reviewed-by: MortenS
|
|\ |
|
| |
| |
| |
| |
| | |
Task-number: Salesforce 00062670
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If the QWS_DISPLAY is specified as "Transformed:powervr:...",
then we will encounter QScreen::TransformedClass rather than
QScreen::ProxyClass when searching for the QGLScreen. This change
makes the code search for both.
Task-number: QT-2261
Reviewed-by: Sarah Smith
Back port of 8e4fa6e87f74cfb3457e8270a361cf30ca7d3593
|
| |
| |
| |
| |
| |
| |
| |
| | |
The commit faec535829a0e454a6784b0c5c37cb63e7da8f73 introduced this bug.
Since we can add a submenu to the same supermenu, we should consider it
before disabling the submenu who already have a supermenu.
Reviewed-by: MortenS
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The PvrEglSurfaceHolder is a hold-over from Qtopia that isn't
needed any more and was never very stable anyway.
Reviewed-by: trustme
Back port of f613b0170d0fe806378779472315d0bbdc1aada9
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
8ee6d090d45198fb2530849236c97f014666b7e4: fix EGL_SAMPLES
b125af1b298d694c332f56deebe4755d0c985d5d: memory leak of EGLSurface's
ef8d9fa7091b0d45fe15aae43b8f1c47547cb16d: double-destroy of pbuffer
73d9dced8298dfad7bc72607146e81e96fffb6d4: suppress pbuffer warnings
Reviewed-by: Donald Carr
|
| |
| |
| |
| |
| |
| |
| |
| | |
Backport af71faf8cb2c9cbf34c408b81ce7ae1ef6c6403e from 4.6 to
4.5.
Task-number: 261999
Reviewed-by: Peter Hartmann
|
|/
|
|
|
|
|
|
|
| |
This change improves the behavior of QMenu when Key_Back and Key_Forward
are used as shortcuts. A dotted arrow appears on carbon, and
on Cocoa the image is blank, instead of undefined as it was before.
Task-number: QTBUG-4873
Reviewed-by: msorvig
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
geometry() is in parent coordinate. We want the coordinate in viewport
coordinate.
There is an offset (the header geometry) between the two.
So the first item was not refreshed.
(Regression because of e5b32fbe0efc8 and a54c18e27bbb)
Reviewed-by: Gabriel
Reviewed-by: Alexis
Task-number: QTBUG-4849
|
|
|
|
|
|
|
|
|
| |
The gobal variable which stores the current mouse event can be updated
before dragImage() call(blocking) is finished. So make a local copy of
the information required by the QDragManager::drag().
Task-number: QTBUG-4814
Reviewed-by: MortenS
|
|
|
|
|
| |
Pre-multiply fix: 01a671ff0bd380e5cff311cc233352c867a041a0
Painting performance: c3cfba7295c990d8135e1dd70b8cdbefd25615ab
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code was searching for an exact pbuffer format of
RGBA = 1, 1, 1, 0, which of course is never going to happen.
Instead, search for the best format.
Reviewed-by: trustme
Conflicts:
src/opengl/qglpixelbuffer_egl.cpp
Back-port of 46843022acd7322c42a98858ec52b65ce7451d06
|
|
|
|
|
|
|
| |
We used to check the 100 first sections and 100 last sections
Now we make sure we check 100 visible sections
Task-number: 255574
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some strange reason, I get the following message if I press a
non-numerical key on the SIP of a Samsung Omnia device, running Windows
mobile 6.1:
WM_KEYDOWN
wParam == 0
lParam == 1
That message is invalid. We must ignore it.
Reviewed-by: mauricek
|
|
|
|
|
|
|
|
|
|
|
|
| |
pixel size
Use QFontInfo to query the pointSize() instead of asking the font
directly, fixing this assert:
ASSERT failure in QFont::setPointSize: "point size must be greater than 0", file text/qfont.cpp, line 855
Task-number: QTBUG-3555
Reviewed-by: Simon Hausmann
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit ed375675d4a4f6fd63edeb242e23c87b3de4be6f triggers a behavior in
Glib's mainloop implementation where some event sources are not
"serviced" every iteration of the mainloop context. This breaks an
invariant that many tests relied on, so we need to solve the problem.
The invariant is that a newly added timer that would normally fire on
the next pass of the event loop (liker a zero timer) SHOULD actually
fire. We do this by registering 2 timer event sources with Glib's
mainloop: one normal priority source and one idle priority source. The
idle priority source is the one that will send events most of the
time, with the normal priority one taking over only when
processEvents() is called manually.
Task-number: QT-877
Reviewed-by: jbache
Reviewed-by: thiago
Reviewed-by: denis
(cherry picked from commit d0d0fdb8e46351b4ab8492de31e5363ef6662b57)
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you set the flag itemClipsChildrenToShape to true on a parent, an
optimization was made in 4.5.0 to not add children of this parent in
the index. But when you set the flag back to false all the sub-tree
of the parent should be re-added to the index otherwise the index will
never find all children. This code is not relevant for 4.6 since
the index part of QGraphicsView has been refactored and handle this case
with itemChange in QGraphicsSceneIndex.
Reviewed-by:andreas
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When QGLWidget was used as a viewport for QGraphicsView, it was
still treating the window surface as RGB16. Use the screen's actual
pixel format.
Also ensure that PvrEglWindowSurface::image() returns a non-null
QImage if the drawable hasn't been created yet.
Reviewed-by: trustme
Back port of 53b3a0572242d0a425e74848afba1293f195d29b
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the editor had been created inside the QtPropertyEditorView (inheriting
QTreeWidget), the subsequent show sent a synthetic mouse move event down to
the QLineEdit, and a new selection was made on the text because the mouse
button was marked as pressed in the event.
QApplicationPrivate::sendSyntheticEnterLeave() now sends a mouse move event
without any button pressed. Auto-test included in tst_QWidget.
Task-number: QTBUG-4055
Task-number: 253159
Task-number: QT-659
Task-number: 245398
Reviewed-by: bnilsen
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes handling selection requests for invalid targets - when
someone asks for a target that is not supported by the clipboard content
we shouldn't do anything (unless it's MULTIPLE).
Fixes copying data when using Synergy which tries to get all targets it
knows about even if they are not listed in TARGETS.
Task-number: QTBUG-4652
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
| |
Send a header that we accept every language. Works around a bug in some
broken websites and is hopefully of no harm for us.
Task-number: QT-952
Reviewed-by: Thiago
|
|
|
|
|
|
|
|
| |
Task: QT-1027
RevBy: Andrew den Exter
Details:
All gst disk sources support setting device name with "device" property,
otherwise the default device is used.
|
|
|
|
|
|
|
| |
RevBy: Andrew den Exter
Details:
Phonon gstreamer backend used cdda:// URL and corresponding
gst source element regardless of disk type.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert this change:
----
2008-12-18 Bernhard Rosenkraenzer <bero@arklinux.ch>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22205
Fix compatibility with bison 2.4, partially based on older patch by
Priit Laes <amd@store20.com>
* WebCore/css/CSSGrammar.y: Made compatible with bison 2.4
-----
Cherry-picked from qtwebkit.git 4.5 repository/branch with commit
23d13ba45ee59379c04afdef8472acc8611bb36a
|
|
|
|
| |
Task-number: QT-754
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
updated
When calling QGraphicsItem::update() on a cached item, the cache is
meant to be invalidated.
In the reported bug, the user had a fixed scene rect
set for his scene, and removing an item caused the entire scene to be
updated (marked as "all needs to be updated"). In this case, calling
update() on the cached item did not cause the item's cache to be
invalidated. The item's new appearance didn't show up until the next
invalidation, which was the same call to update(), but this time without
a preceeding full scene update.
The fix is to always invalidate the cache, regardless. But only
schedule a repaint of the item in some cases (e.g., in this case the
whole scene was marked for update, in which case it's unnessary for this
one item to schedule a repaint of itself).
It's worth noting that in 4.6, removing an item be delete does not cause
the whole scene to be updated, and because of that this error was not
exposed. It's there nevertheless.
Reviewed-by: bnilsen
|
|/
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression against Qt 4.4. Children of items with ItemClipsChildrenToShape
would only be discovered if the view's expose region contained the outer
bounding rect of all items, _if_ there was at least one item in the
scene that enabled ItemIgnoresTransformations.
The reason for this bug is that the presence of an untransformable item
causes the item lookups to go through a different path
(QGraphicsViewPrivate::itemsInArea()). This function had the bug that it
didn't correctly discover children of clip-items. Because of this, in
the provided test case you could "work around" the bug by either removing
the clip flag, or the transformation flag.
Task-number: QTBUG-4151
Reviewed-by: Alexis
|
|
|
|
|
|
| |
This fix just fixes up coding bugs here and there
Reviewed-by: Brad
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing dubious intermediate detection code that also had a buffer
overflow. The results were inconsistent and not dependable on.
Processing was inefficient and end value to user experience dubious.
Test cases that abused the former behaviour were changed to consider
input in an Intermediate where it was previously considered Invalid.
With this change, user input will mostly be considered in an
intermediate state, until it is effectively validated.
Task-number: 255019
Reviewed-by: Anders Bakken
|
|
|
|
| |
Task-number: QT-1683
|
|
|
|
|
|
|
|
| |
Revert parts of adf322c514a5781dcb9ec304d44229fa47d5e8b3 to
get this to work as in 4.5.2 again. What the original
patch fixed, we don't really know..
Reviewed-by: Simon Hausmann
|
|
|
|
| |
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
| |
[NSWindow orderFront:] on a hidden window will make it visible. So
raise_sys() will now check if window is visible before this method is
called.
Task-number: 255428
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
|
|
| |
This fixes a regression introduced in Qt 4.5.0, when dragging an item
within a QTreeView it would not call clone() when it was dropped even if
a prototype was set on the QStandardItemModel.
Reviewed-by: Marius Bugge Monsen
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This issue affects both tool buttons and buttosn
with menus. The problem is that the Windows metric
we were using to calculate the size changed on
Windows 7. It seems not to be the correct metric so it
seems more reliable to use the dpi-scaled constant 12 as we
were doing in common style already. This should make appearance
consistent between the windows versions.
Task-number: QTBUG-4241
Reviewed-by: denis
|
|
|
|
|
|
|
|
|
| |
Fix QGraphicsItem to clear clip path for items with an ancestor that
clips to shape. Added autotest to demonstrate clipping path problem.
Merge-request: 810
Reviewed-by: Alexis
Reviewed-by: Andreas
|
|
|
|
|
|
|
|
|
|
| |
On Windows CE the plugin path is likely to be the same as the
application directory. That's why we must not compare app_location
with the plugins path.
The check app_libpaths->contains(app_location) should be enough.
Autotest: tst_QApplication::libraryPaths
Reviewed-by: thartman
|