| Commit message (Collapse) | Author | Age | Files | Lines |
|\ |
|
| |\
| | |
| | |
| | |
| | | |
Conflicts:
tests/auto/qgraphicsview/tst_qgraphicsview.cpp
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There's no need for using QByteArrayMatcher for one single character,
so avoid the overhead.
Also validate the message header a bit more: we require the status
line to start with "HTTP/n.m " where n and m are positive integers
less than 10.
Task-number: 248838
Reviewed-by: Markus Goetz
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
proper HTTP reply.
If the server's reply doesn't start with "HTTP/", then the reply is
not valid. This could happen if we connected via HTTP to an HTTPS
server. It could also happen with an Icecast server (reply ICY/x.y).
Task-number: 248838
Reviewed-by: Markus Goetz
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In QGraphicsScene::_q_emitUpdated() the slot
QGrpahicsView::updateScene(QList<QRectF>) gets connected and a boolean
(connectedToScene) is set to prevent double connections. The problem is
that this boolean was not reset when the view gets a new scene.
Task-number: 253415
Reviewed-by: andreas
|
| | |
| | |
| | |
| | |
| | | |
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago Macieira
|
| | |
| | |
| | |
| | |
| | | |
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago Macieira
|
| | |
| | |
| | |
| | |
| | | |
Reviewed-by: Thiago Macieira
Reviewed-by: Peter Hartmann
|
| | |
| | |
| | |
| | |
| | | |
Reviewed-by: Peter Hartmann
Reviewed-by: Thiago Macieira
|
| | |
| | |
| | |
| | | |
Reviewed-by: Thiago Macieira
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
New private class, needed for the rewrite of the upload side of
QNetworkAccessManager. Allows to have a "byte pointer view" on stuff
like QRingBuffer, QByteArray, QFile and any QIODevice.
Reviewed-by: Thiago Macieira
Reviewed-by: Peter Hartmann
|
| | |
| | |
| | |
| | | |
Ability to read from a QRingBuffer at any position without modifying it.
|
| | |
| | |
| | |
| | | |
Reviewed-by: Denis
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The private class was already declared and defined in the qfileinfo.cpp
file.
Reviewed-by: thiago
|
| |\ \
| | |/ |
|
| | |
| | |
| | |
| | | |
Reviewed-by: thartman
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If a QSqlQuery survived the lifetime of removal of a mysql db connection (that failed), the cleanup code would cause a segfault because it was using an out of date pointer that was pointing at memory that'd been freed by the removeDatabase() call.
Revby: Justin McPherson
Task-number: 205701
|
| | |
| | |
| | |
| | | |
Reviewed-by: Donald <qt-info@nokia.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
addFile makes a QIcon not null, which may be a surprise if the path
given is bad.
Reviewed-by: Jens Bache-Wiig
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There was a qFree() call missing.
Task-number: related to 253367
Reviewed-by: jbache
|
| | |
| | |
| | |
| | |
| | | |
Task-number: 253427
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | | |
Q_ACCESSIBLE_OBJECT was missing
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Clearifying details about bit size of the wchar_t input and the way they are handled.
Task-number:227709
Rev-by: Marius Storm-Olsen
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The handling of gradients with object bounding mode on pens in the
emulation paint engine has been changed to agree with the SVG standard,
where pen widths are ignored when calculating bounding boxes. Instead
of converting strokes to fills and then transforming the gradients
based on the fills' bounding box, the gradients are now transformed
first based on the bounding box of the stroke path.
Reviewed-by: Trond
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
For a QGraphicsWidget w, a shortcut with Qt::WidgetWithChildren context would
trigger even if w did not have focus (provided no other widgets in the view
had focus).
Reviewed-by: andreas
Task-number: 250119
|
| | |
| | |
| | |
| | |
| | |
| | | |
Since this is C there are no constructors.
Reviewed-by: Donald <qt-info@nokia.com>
|
| | |
| | |
| | |
| | | |
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | |
| | |
| | | |
QDirecttFBPixmapData => QDirectFBPixmapData
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If an application calls QIcon::actualSize() for SVG based icons, before
the icon is drawn for the first time, the actualSize() call will
result in the SVG file being loaded and parsed for each call.
Instead of doing that, just render a pixmap of the queried size and
then the resulting actualSize() calls will used the size of the
cached pixmap.
Task-number: related to 251106
Reviewed-by: Kim
|
| | |
| | |
| | |
| | | |
Reviewed-by: Peter Hartmann
|
| | |\ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We use MIPS2 instructions in the inline assembler, so we need to make
sure that the assembler is informed of this.
Task-number: 253275
Reviewed-by: thiago
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Explained the role of the key attribute.
Task-number:246839
Rev-by: Richard Moe Gustavsen
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In older Freetype headers FT_LCD_FILTER_DEFAULT is apparently defined to
be ((const FT_Byte*)(void*)(ft_ptrdiff_t)1), which leads to a compile
error due to precision loss when casting to int.
Task-number: 253186
Reviewed-by: Trond
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
in 4ffda2918b3f5c789ef325cdeaac72e5e7ef2c0c savedFlags has been made
crossplatform by switching from ulong to Qt::WindowFlags. WinCE does
not have an automatic conversion between those types, thus bails out
with an error. Need to cast it to the proper type.
Reviewed-by: Marius Storm-Olsen
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I actually found a few functions that were not even implemented, only
declared. Those should obviously not be in the header file. I've also
removed a few functions not in use / not belonging to QWidgetPrivate.
Reviewed-by: Olivier
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This patch cleans up several things, like bit fields that are
interleaved with with other variables, resulting in bits not being
packed properly.
Example: "uint a : 8; int c; uint b: 8;" -> "uint a : 8; uint b : 8; int c;"
In that case we'll use 12 bytes instead of 8 bytes.
I've also changed the order we declare certain variables to avoid
unnecessary gaps/padding on 64-bit architectures.
Example: "char *a; int c; char *b;" -> "char *a; char *b; int c;"
Pointers are 64-bit aligned, so padding appears between 'c' and 'b',
resulting in a total use of 24 bytes instead of 20 bytes.
...and since I anyways was moving the code around, I took the
opportunity to add some overall structure by first declaring
cross-platform functions/variables followed by platform specific
functions/variables. ...and it was kinda scary to actually be
able to see all the QStrings, pointers and whatnot we put into
QWidgetPrivate. I'm sure we can remove lots of stuff, but I'll do
that in a separate commit.
Quick numbers (X11/64 bit):
sizeof(QWidgetPrivate) == before: 472, after: 456
sizeof(QTLWExtra) == before: 112, after: 104
sizeof(QWExtra) == before: 152, after: 144
Acked-by: Olivier
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Our destructor didn't call close, which meant that we never emitted
lastWindowClosed.
Task-number: 253333
Reviewed-by: Bradley T. Hughes
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Task-number: 253427
Reviewed-by: TrustMe
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
their root. This can be different.
...especially if one manages the selection by program or if you share
the selection model with a treeview.
Task-number: 196118
Reviewed-by: ogoffart
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
shown
The problem is that it gets the previous geometry of the cell whereas
its own sizeHint might lead to change the geometry of the cell.
Task-number: 253109
Reviewed-by: ogoffart
|
| | | |
| | | |
| | | |
| | | |
| | | | |
That code is only executed if the environment varible
QT_GRAPHICSLAYOUT_DEBUG is set to1
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Reviewed-by: Kavindra
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Luckilly, that bug was only there if you had QT_GRAPHICSLAYOUT_DEBUG
set as an environment variable.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
aren't really supported.
Also set the default focus to be the preview widget itself.
|
| | | |
| | | |
| | | |
| | | | |
its buttons.
|