| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
We were trying to check the column/row count but always from the root of
the model insteal of the root that can be defined in the view.
Task-number: QTBUG-5773
|
|
|
|
|
|
|
|
| |
fixes minor coding issues for
"Use OpenSSL X509_NAME_ENTRY API to parse UTF8 subjectName/issuerName"
Task-number: QTBUG-7912
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
|
|
|
|
|
|
|
|
| |
... to be able to display non-ASCII names from subject and issuerInfo.
Task-number: QTBUG-7912
Merge-request: 922
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The destructor function destroy_current_thread_data_key() was always
called on library unload, even if the pthread_key_t was not initialized.
This can cause us to destroy a key that doesn't belong to us, as pointed
out in the task below.
Fix this by creating a function static instance of a class whose
destructor will destroy the key.
Task-number: QTBUG-10861
Reviewed-by: Morten Sørvig
|
|
|
|
|
|
|
|
| |
This could happen when dragging an extended toolbar from a mainwindow
PAtch was provided on IRC by ravek (#dev)
Task-number: QTBUG-10920
Reviewed-by: Trust-Me
|
|
|
|
|
|
|
| |
The editor was always considered opaque and clipping was set on the
painter. This assumption can't be verified.
Task-number: QTBUG-11367
|
|
|
|
|
|
|
|
|
| |
Basically the same optimisation that had been made long ago in the tree view:
Use the right data structure for QListViewPrivate::hiddenRows
(QSet instead of QVector)
Task-number: QTBUG-11438
Reviewed-by: Gabriel
|
|
|
|
|
|
|
|
|
| |
QLineControl passes a QRect to tell when a partial update is needed.
We used to connect this slot to update. This made the whole lineedit
update when the cursor blinked.
Task-number: QTBUG-12709
Reviewed-by: gabi
|
|
|
|
|
| |
Task-number: QTBUG-13015
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
|
| |
For Qt apps running in GNOME, we use the GTK+ settings by
default (instead of fontconfig settings).
Task-number: QTBUG-13800
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When merging fontconfig patterns, we need to clean up existing object
first, otherwise the added object will be appended instead of replacing
the existing object. When multiple font engines are using shaping, if
fontconfig patterns are not correctly merged, it will result using the
old font. For instance, in "<b>Fake Bold</b> Normal", "Normal" text will
continue using the font for "Fake Bold" (that only happen with fallback
fonts).
Task-number: QTBUG-14455
Reviewed-by: Eskil
|
|
|
|
|
|
|
|
| |
This function call was simply not converted to use the new proxy
style, hence preventing people from overriding it properly.
Reviewed-by: Andy Shaw
Task-number: QTBUG-16127
|
|
|
|
|
|
|
|
| |
Fix a bug in pdf print engine that was noticeable when printing
a webpage: the missing image graphic didn't appear in the pdf.
Task-number: QTBUG-16435
Reviewed-by: sroedal
|
|
|
|
|
|
|
|
| |
Made toHsl() work the same way as toHsv(), ensuring the hue gets set to
USHRT_MAX and not 0.
Task-number: QTBUG-16530
Reviewed-by: Eskil Abrahamsen Blomfeldt
|
|
|
|
|
|
|
| |
Return the MoveTo element instead of QPointF(0, 0).
Task-number: QTBUG-16788
Reviewed-by: Eskil Abrahamsen Blomfeldt
|
|
|
|
|
| |
Task-number: QTBUG-17278
Reviewed-by: jiang
|
|
|
|
|
|
|
| |
Show same fatal message as when trying to instantiate a QWidget.
Task-number: QTBUG-17873
Reviewed-by: Gunnar Sletta
|
|
|
|
|
|
|
| |
This function always returned false, even if the socket was connected.
Task-number: QTBUG-18204
Reviewed-by: Martin Petersson
|
|
|
|
|
|
| |
Merge-request: 1148
Task-number: QTBUG-18233
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@nokia.com>
|
|
|
|
|
|
| |
Task-number: QTBUG-18374
Reviewed-by: Olivier Goffart
Merge-request: 1157
|
|
|
|
|
|
|
|
| |
0.5 is double a literal, and they force computation on double
while it would be more optimized on qreal if qreal is a float
Task-number: QTBUG-16673
Reviewed-by: Thierry
|
| |
|
|
|
|
|
|
|
|
|
| |
A single digit after RTL text will be considered as RTL because it
was treated as Other Neutral (DirON), it can be solved by changing
it to DirAN.
Task-number: QTBUG-2795
Reviewed-by: Lars Knoll
|
|
|
|
|
|
|
|
| |
We need to send the hover leave event on the proper receiver in case
the widget we embed in a complex hierarchy not the widget itself.
Task-number:QTBUG-6986
Reviewed-by:bnilsen
|
|
|
|
|
| |
Use QFutureInterface::reportException() in the
same way that we do in QtConcurrent::map().
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if current directory is a symlink to another directory
on the same drive (the simplest example; say, c:\current\dir
is a symlink to c:\target) then the first valid prefix for
"c:\target" in canonicalized() is "c:" (NOT "c:\") and would
be treated like "c:\current\dir" again...and again...
until stack overflow :)
Merge-Request: 494
Task-number: QTBUG-7610
Reviewed-by: Zeno Albisser
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are couple of memory leaks in XmlPatterns when parsing XSD
files. The reason is that the module over uses the shared data
pointer and generates many cyclic reference loop. Some part of
the code is refactored. Instead of using shared data pointer,
normal C++ pointer is used to break the ownership loop. This is
bug fix for QTBUG-8948.
Task-number: QTBUG-8948
Reviewed-by: Sami Merila and Laszlo Agocs
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If user information is present in the Url, QNetworkAccessHttpBackend
will cache the connection with a key in the format of user@hostname.
This causes the following tests in QtWebKit to fail:
LayoutTests/http/tests/xmlhttprequest/re-login.html
LayoutTests/http/tests/xmlhttprequest/re-login-async.html
The tests call the same url with user1 credentials, no credentials,
user 2 credentials and no credentials. In the second and fourth calls
Qt should use the most recently stored credentials. For the fourth
call it currently uses user1's credentials instead of user2's. This
is because it retrieves the cached connection from the third call
and uses the user/pass in that connection's authenticator - which is
user1's.
In order to retrieve the connection with the most recently used
credentials userinfo should be removed when caching the connection
in QNetworkAccessCache. This will allow Qt to retrieve the connection
used in the third call, in fact the same cached connection for all
four calls.
Merge-request: 623
Reviewed-by: Markus Goetz <Markus.Goetz@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
If the size of the widget is an odd number, the layout rect
will be positioned at a 0.5 offset. The clipping set further
below will snap this to 1 and thus clip away the anything drawn
on the first row of pixels. Fix this by aligning the rectangle
we get by layout rect.
Reviewed-by: Eskil
Task: http://bugreports.qt.nokia.com/browse/QTBUG-9684
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In certain uncommon situations, where different Qt versions are used
on the same system, the plugin caching optimization may identify a dll
as a valid plugin, even though it will later fail to load. This fix
will avoid that Qt repeatdly tries to reopen such dlls, something
which caused a significant performance hit in these cases. E.g. where
Qt would unsuccessfully try to load a number of KDE image format plugins
for every image loading operation.
Task-number: QTBUG-10066
Reviewed-by: thiago
Reviewed-by: janarve
|
|
|
|
|
|
|
| |
This fix is needed since windows uses case insensitive filesystems.
Reviewed-by: Joao
Task-number: QTBUG-10305
|
|
|
|
|
|
|
|
|
|
| |
Function converting from QVariant to QScriptValue is smart and tries
to unwrap a value. So QVariant(1234) after conversion will be equal
to QScriptValue(1234). It is ok, but QVariant(QVariant(...)) should be
unpacked only once.
Reviewed-by: Kent Hansen
Task-number: QTBUG-10315
|
|
|
|
|
|
|
| |
Auto-test included
Reviewed-by: Olivier
Task-number: QTBUG-10491
|
|
|
|
|
|
|
|
|
|
| |
We dont use the WS_POPUP style when one of the following window flags
are set (WindowSystemMenuHint, WindowTitleHint, WindowMinMaxButtonsHint
WindowCloseButtonHint, WindowContextHelpButtonHint). None of these flags
can conflict with this style, hence being removed.
Task-number: QTBUG-10589
Reviewed-by: Denis
|
|
|
|
|
|
|
| |
The problem was that the internal state of the tree was not correctly
reset. Patch comes from the task.
Task-number: QTBUG-10850
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes two issues.
- The indeterminate animation was sometimes incorrectly disabled
when value was 0
- The progress animation was incorrectly stopped when progress
bars were disabled
Task-number: QTBUG-10957
Reviewed-by: richard
|
|
|
|
|
|
|
|
|
| |
QLibrary::isLibrary() returns true for files with the sufix .bundle.
But we did not use to determine the proper library within the bundle
in that case.
Reviewed-by: Fabien Freling
Task-number: QTBUG-11217
|
|
|
|
|
|
|
|
| |
This is mainly done by reverting the commit
04e34fe3aecca482abeeabe2e31778e9102eeb08
Task-number: QTBUG-11518
Reviewed-by: Samuel
|
|
|
|
|
|
|
|
|
|
|
| |
Because of the time zone change we get an "overflow" in the min and max time.
For example min 00:00:00 becomes 01:00:00 and max 23:59:59 becomes 00:59:59
which is an invalid time span and the displayed time gets fixed to the newly
set min/max value.
Autotest included.
Task-number: QTBUG-12384
Reviewed-by: Gabriel
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reason is that cocoa expects the unicode control character for
"enter", rather than the glyph showing an arrow. So rather than
using the glyph-table from QKeySequence, we should use a table
containing a mapping from Qt::Key to Cocoa control key. Luckily,
such a table exists allready in qt_cocoa_helpers, but reversed (
cocoa key to Qt::Key). So this patch creates a function that
binds all this together.
Reviewed-by: cduclos
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating the native key sequences for menu items, Qt prefers the
non private unicode characters. But the characters in the NSEvent for
keyboard events can contain characters form the unicode range reserved
for Apple.
For e.g. when user presses the "delete" key, the event contains
NSDeleteFunctionKey, where in Qt is expecting NSDeleteCharacter. For now
this is the only key identified for translation. If we find similar
translations, those can be added to qt_mac_removePrivateUnicode().
Task-number: QTBUG-12495
Reviewed-by: Denis
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Libraries on Windows 7 are user-defined collection of folders, which
is only a logical representation. There are no file system entries
associated with it .
This patch makes sure that user cannot choose a library when using the
QFileDialog::getExistingDirectory(), in such cases it will show a
standard windows warning message.
Task-number: QTBUG-12655
Reviewed-by: Thierry Bastian
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to the c++ specificaiton, 3.9.1 [basic.fundamentals]
Plain char, signed char, and unsigned char are three distinct types
In QMetaType, I decide that 'signed char' alias with 'char'
This allow qint8 to work nice (and which is already registered as
an alias to char (QMetaType::Char)
Reviewed-by: Joao
Task-number: QTBUG-12920
|
|
|
|
|
| |
Task-number: QTBUG-13055
Reviewed-by: Markus Goetz
|
|
|
|
|
| |
Task-number: QTBUG-13055
Reviewed-by: Olivier Goffart
|
|
|
|
|
|
|
|
|
|
| |
Setting the QTextOption::SuppressColors tag on a QTextDocument
breaks all text format, not just colors. This patch fix this by
selectively ignoring color properties in the format and keeping
other properties.
Task-number: QTBUG-13090
Reviewed-by: Eskil
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, if QSqlField's QVariant value had type "invalid", this
caused the field to be omitted in data-changing SQL statements generated
from QSqlRecord edit buffers.
Complaints against this mechanism:
- It precludes initializing value type to field type, which would
otherwise seem sensible and useful, such as when using model.data() in
contexts where the field type is not readily available.
- QSqlField::clear() does initialize value type to match field type and
so is incompatible with this mechanism.
- Problems such as described in QTBUG-13211.
- Unwanted distinction between "invalid" and "null" when mapping field
values to SQL values.
- QSqlField's generated flag already provides a mechanism for
controlling SQL generation.
These complaints are redressed here by replacing this mechanism with
reliance on QSqlField's generated flag. The flag is initialized to false
in new edit records and set to true when a value is set. Applications
can still manipulate generated flags directly to control SQL generation.
Generation of SELECT statements already used the generated flag and is
unaffected by this change.
Merge-request: 1114
Reviewed-by: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
Reviewed-by: Michael Goddard
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Qt clobbers the cache-control headers set by WebCore when
CacheLoadControlAttribute == QNetworkRequest::AlwaysNetwork.
This causes at least one QtWebKit layout test to fail:
http/tests/misc/refresh-headers.php
Qt needs to detect if the client has already made a cache-control
decision in the headers before overwriting them.
See https://bugs.webkit.org/show_bug.cgi?id=45598
Task-Number: QTBUG-13564
Merge-request: 2472
Reviewed-by: Markus Goetz <Markus.Goetz@nokia.com>
|
|
|
|
|
| |
Task-number: QTBUG-13593
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. The opentype init feature was applied to some characters
even when the character appeared inside a word.
2. Using the ZWJ to separate Ra and Halant Ya should connect
the two latter characters and form a Yaphala
3. Some Oriya chars were not correctly marked as below-base
form.
Task-number: QTBUG-13620, QTBUG-13616, QTBUG-13542
Merge-request: 2484
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@nokia.com>
|