| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
|
| |
negative sign.
I don't know why, but this only triggers for the month of October
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
| |
It's the logical time that matters, not the exact date representation.
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test if we're not past the end of the array before we attempt to read it.
Dates without timezone information are taken to be UTC, so merge the code.
If the date parsing failed, don't add a malformed cookie. Better to
have no cookie than to have it for past its expiration date.
Also update the autotests, since we now can cope with some of the
invalid cookies seen on the net.
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
|
|
| |
then only allowing the three date formats that are in the rfc allow a much wider set of date strings. Because many browsers support this many websites send dates strings that are not in the rfc format.
See documentation in parseDateString for more details about the implementation.
Signed-off-by: Thiago Macieira <thiago.macieira@nokia.com>
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
| |
Make sure that we can handle two Set-Cookie headers.
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the date and to differentiate between multiple cookies. When there are multiple set-cookie headers rather then combining them with ', ' use '\n' like Firefox because we are 100% sure that we have multiple cookies and using , can result in cases where the , is interpreted as as part of the date such as the following
set-cookie:a=b; expires=2009 mar 10
set-cookie:c=d
Combined the old way they result in the second cookie being ignored
a=b; expires=2009 mar 10, c=d
Using '\n' moves our cookie parser closer to Firefox's algorithm which
will result in more behavior and bug for bug compatibility.
Attempting to be smarter about the , will result in incompatibility
with Firefox's implementation (as my first attempt at fixing this bug
resulted).
Also when parsing multiple cookies when we have an error
don't return an empty list of cookies, but return the list of
cookies we were able to parse successfully so far.
Signed-off-by: Thiago Macieira <thiago.macieira@nokia.com>
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
| |
the location header will be used to determine where to go.
Signed-off-by: Thiago Macieira <thiago.macieira@nokia.com>
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
| |
QNetworkReply::finished() signal is emited.
Signed-off-by: Thiago Macieira <thiago.macieira@nokia.com>
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
|
|
|
|
|
| |
specifically match the behavior of Firefox which servers test against. - When updating the cache metadata don't update content-* headers - Don't lowercase headers names when updating them - Fixed a typo in QNETWORKACCESSHTTPBACKEND_DEBUG code
Originally seen on http://www.bibelbund.de/htm/99-4-306.htm where on
refresh the 304 will set the content type of text/plain.
Signed-off-by: Thiago Macieira <thiago.macieira@nokia.com>
Signed-off-by: Peter Hartmann <peter.hartmann@trolltech.com>
|
|
|
|
|
| |
Everything else capitalizes both the F and the B. s/Fb/FB/g
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
qWarning and qFatal should be in Latin1.
Reviewed-by: Thiago
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
documentation and updated a diagram.
Task-number: 228201
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DirectFB sets the alpha byte to 0 in RGB32 for all drawing operations.
The raster paint engine needs this padding byte to be 0xFF as it shares
some code paths with RGBA8888_Premultiplied. So, always fall back to
raster engine for draw operations.
This is really due to a bug in the raster paint engine (Tracked by task
184073), which should ignore the extra byte. Once this task is fixed,
this patch can probably be reverted.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
|
| |
qt_win_display() will always trigger an assert and should not be used
in the src/painting directory.
Task-number: 248266
Reviewed-by: Samuel Rødal <sroedal@trolltech.com>
|
|
|
|
|
|
|
|
| |
PRINTER is dependant upon the PICTURE feature in 4.5, since the
PDF and PS engines now uses the QAlphaPaintEngine internally.
Task-number: 248568
Reviewed-by: Samuel Rødal <sroedal@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cocoa actually has a nice feature that if you pass arguments on the
command-line, Cocoa will pass those along as Open events later. This is
probably how we should have handled things inside of Qt as it would have
unified the file opening code. Unfortunately, we can't turn back time on
this, so we need to prevent it because people probably aren't expecting
it (i.e., they expect to do the parsing themselves, and not to get
events later). This also means that we can send the event immediately
instead of posting it, because the race that we had before no longer
exists. We only do this check during launch time because that's the only
time we may get bitten by it (people usually only parse the arguments
once).
Someday, people may actually WANT this functionality though. When that
comes along, we should make it an application attribute.
Task-number: 249553
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
|
|
|
| |
Seems that things are a little less transparent in 10.5 (and have a
blur). Getting the blur in is going to be difficult, but adjusting the
opacity will get us closer than we are now.
Task-number: 249364
Reviewed-by: Jens Bache-Wiig
|
|
|
|
|
|
|
|
| |
QPicture didn't have an implementation for drawImage(). All images were
converted to QPixmaps before they were drawn.
Task-number: 249322
Reviewed-by: Gunnar Sletta
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to our documentation we should ignore leading and trailing
whitespaces when converting a string to number with QLocale::toInt and
similar functions. However that didn't work for some locales - for
those ones that declare groupseparator as 0xa0 (which looks similar to
space) since we provide a workaround to accept space as a group
separator for those locales. And since the workaround was there for a
long time it doesn't make sense to change the behavior and the fix is
to explicitely remove leading and trailing whitespaces before doing
any conversion.
Reviewed-by: mariusSO
|
|
|
|
|
|
|
| |
Call isEmpty() on the normalized rect instead of the original rect.
Task-number: 247505
Reviewed-by:
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 7d2c8eb99c563b4fb236fe538123255f52f293a2.
This commit was not reviewed and breaks compile of QtNetwork on win32
with this error...
src\network\kernel\qauthenticator.cpp(55) : fatal error C1083: Cannot
open include file: '../3rdparty/des/des.cpp': No such file or
directory
... because the generated Makefile no longer contains src/network
as an include path.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently we have a problem with these default parameters. We have
basically:
template<typename T> void func(T * = 0);
template<> void func<Something>(Something *);
Now, according to GCC, I can't add "= 0" to the template
specialisation. However, MSVC 2008 isn't able to call the
specialisation without my extra 0 here. I've seen a similar issue
before in QSharedPointer.
I don't think this is a big deal because the error message output by
MSVC 2008 indicates this is likely a compiler bug:
qdbuspendingreply.h(98) : error C2440: 'default argument': cannot
convert from 'T1 *' to 'QVariant *'
where
[
T1=QVariant
]
|
|
|
|
| |
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This happens in heavily threaded applications: libdbus-1 asks us to add
and remove timers (and watches, but those less often) from any thread.
Since QObject's model requires that timers and QSocketDescriptors be
added only in the object's own thread, we have to sync back to the main
thread.
However, since D-Bus keeps adding and removing the timers, we have to
keep a queue of timers to be added and that list is accessed by any
thread. Make sure that list is only accessed in locked conditions.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1beae2b64b5b1e9b97e82dc94de18ebac1c19efc )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-03-27 Zack Rusin <zack@kde.org>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=24280
Fix propagation of fill rules when rendering paths in the Qt build.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::toQtFillRule):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
2009-03-27 Zack Rusin <zack@kde.org>
Reviewed by Tor Arne Vestbø.
https://bugs.webkit.org/show_bug.cgi?id=24275
Fix text field theming in the Qt build with the KDE 4 Oxygen
style by adjusting the size vertically and horizontally to
set padding on the element equal to the width of the style painted border.
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
* platform/qt/RenderThemeQt.h:
|
|
|
|
| |
Reviewed-by: thiago
|
|
|
|
|
|
|
|
|
|
| |
When the size of one of the screen changes but the geometry of the
whole desktop hasn't been changed the resized() signal wasn't emitted.
The patch by Lubos Lunak also adds emitting of a signal whenever the
screen is turned on or off.
Task-number: 226048
Reviewed-by: Brad
|
|
|
|
|
|
|
| |
Check for Qt::NoBrush and return early in the composite() function.
Task-number: 249628
Reviewed-by: Trond
|
|
|
|
|
|
|
|
| |
acquire guard of the local static.
This only buys us one warning less by helgrind.
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
|
| |
work)
This code was apparently mostly unchanged since 2005. Update it to match
the atomics code.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure all QDirectFBPaintDevice surfaces always are created with a
format that is either QScreen::pixelFormat() or
QDirectFBScreen::alphaPixmapFormat().
Also, clean up surface creation by providing more high level functions.
Fix a bug where we would assume that ARGB means
Format_ARGB32_Premultiplied and not Format_ARGB32.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This may happen if you only have something like
QAbstractScrollArea:focus { background: foo; }
and you do not have a background set for the general case
and the viewport has a different background role (such as QTextEdit,
QAbstractItemView, ....)
This is a regression from 4.4 since in 4.4 the :focus has no effect if
you didn't have a background for the general case.
Reviewed-by: bnilsen
Task-number: 188195
|
|
|
|
|
|
|
|
| |
Use QStroker::setRect() to avoid dashing parts of the path that are
outside the device rect.
Task-number: 246573
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
|
| |
When drawing ellipse without stroke we need to use the same width/height
for the fill as we would use for the stroke for the stroke and fill to
match. Filling first and then stroking should produce the same result as
filling and stroking in one go.
Task-number: 249490
Reviewed-by: Trond
|
|
|
|
|
|
|
|
| |
Monochrome images should be converted to black and white, not
transparent and white. Reported on qt-interest.
Task-number: 249175
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
| |
uic is set in default_pre. this leads to useless -I compiler flags when
no ui files are used in fact, so it would be nice to get rid of it in
cases where it is not used. for backwards compat, don't remove it from
the _pre, but add some magic to _post to remove it again if QT does not
contain gui. of course, we need a force_uic CONFIG to enable an
exception for QtGui itself ...
|
|
|
|
|
| |
the exact length of the template is known, so there is no point in using
the more complex (and thus potentially slower) strncmp instead of memcmp.
|
|
|
|
| |
this function is always called with found != 0 nowadays
|
| |
|
|
|
|
|
|
|
|
| |
When the current focus widget enforces the creation of the native
window handle we should reset the input context.
Task-number: 249578
Reviewed-by: Brad
|
|
|
|
|
|
|
|
|
|
|
| |
On X11 when user manually creates a QDesktopWidget object it breaks
notifications from the root window since we have several
QDesktopWidgets that have the same native window id and the
wid->qwidget mapper (QWidgetPrivate::mapper) goes crazy. So whenever
we get x11 event from the root window we cannot find a qwidget that
corresponds to the window id and discard these events.
Reviewed-by: Brad
|
|
|
|
|
|
|
|
|
|
| |
commit b1220858d9c15b661b7825e733be448ea9962895
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 18:37:47 2009 +0100
Doc: Added information about the default value of QGraphicsTextItem::tabChangesFocus().
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 20864878d046b2ce6bf5fc54868be8df346ce0c8
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 18:30:32 2009 +0100
Doc: Fixed qdoc warning by adding more descriptive text.
Reviewed-by: TrustMe
commit 3b620a0a4d1b02105c9761384a5abc4ecf11e9d2
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 18:29:56 2009 +0100
Doc: Added macros for future use.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 23e30464792f7e403e0815775eb7acbaad975238
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 17:41:20 2009 +0100
Doc: Added some basic documentation for the QSvgGenerator class.
Task-number: 244944
Reviewed-by: TrustMe
commit f84c1806d2ba40a61499584562d754f65d43f854
Merge: 8a42be7... 213d922...
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 16:59:14 2009 +0100
Merge branch '4.5' of ../qt-45 into qt/4.5
commit 8a42be789077de45f8fd9f13afd177798df7495e
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 16:58:33 2009 +0100
Doc: Added missing pieces for the SVG Generator example.
Reviewed-by: David Boddie <dboddie@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
key events.
We need to be more explicit in setting the first responder, and a bit
more agressing about rejecting it when called with no responder.
It seems that Cocoa has a tendency to reset the first responder when
lots of widgets get hidden or shown. During this it will call
"makeFirstResponder" on the window with a nil responder. Doing this will
reset our what Cocoa thinks is the focus widget, but Qt will still show
a focus widget. The way to solve it is to reject the make first
responder if the responder is nil. I'm not sure if there will be far
reaching implications for this, but it seems to be doing the right thing
at the moment.
We also need to share this code between QCocoaWindow and QCocoaPanel.
Thanks to the dynamic nature of objective-C we have to have a copy of
the code in both places. It's unfortunate.
Finally, it's also important to have the QWidget let Cocoa know it has
focus after it has been created. So, make sure that is in sync.
Task-number: 249296
Reviewed-by: Prasanth Ullattil
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0b6fc217c2b853827926313c09bb3c32f66ffe43 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-02-06 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Hausmann.
Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
the context transparent.
[QT] clearRect fill's a given rect with white
https://bugs.webkit.org/show_bug.cgi?id=23728
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clearRect):
++ b/WebKit/qt/ChangeLog
2009-03-26 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Fix the documentation of the QLocale usage in userAgentForUrl.
* Api/qwebpage.cpp:
2009-03-20 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Fix for InsertParagraphSeparator and InsertLineSeparator so that
QWebPage::action() creates QActions for them. Also make sure they get
updated appropriately.
* Api/qwebpage.cpp:
(QWebPagePrivate::updateEditorActions):
(QWebPage::action):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::textEditing):
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
qscriptvalue_cast implementation was changed from 4.4 to 4.5 because
of the introduction of QScriptValue constructors that don't take an
engine pointer. However, when the old constructors are used, the
behavior of qscriptvalue_cast should be as before, which this patch
ensures. In short: If we have an engine pointer, use it.
Task-number: 248802
Reviewed-by: Ariya Hidayat
|