| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
The high precision code path was getting an empty string on the second
call to getstringdata, which was causing it to return empty for the
field. Really only needed to call it once anyway, so use the original
call.
Reviewed-by: Justin McPherson
|
|
|
|
| |
Last of the changes to include behaviour from QPtrVector
|
|
|
|
|
|
|
| |
Looks like they were using the old QPtrVector in qt3, and didn't quite
handle the porting correctly.
Reviewed-by: Lincoln Ramsay
|
|
|
|
|
|
|
|
|
| |
Drawing operations with DirectFB in RGB32 changes the alpha byte to 0.
This doesn't play well with QRasterEngine.
See 5fb7752ff93b31635e64fa321917749744cc9db6 and
34059fba55816496d2570b3306ac2b631b12a5c6
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
| |
Make it more flexible. This patch allows people to use DFB without
DSFLIP_BLIT. Also, before this patch the flip= options weren't really
used for anything.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
It seems DirectFB doesn't preserve alpha value of a blit unless BLEND is
specified and if it is we need to Clear to transparent first.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
Using #ifndef QT_NO_OPENSSL without first #include'ing something will
never work. Which means we always include qsslsocket.h. The problem
is: if OpenSSL isn't enabled, then that file is a no-op and we never
include qabstractsocket.h.
Reviewed-by: Markus Goetz
|
|
|
|
|
|
|
|
|
|
| |
We had to revert an earlier fix since it obviously did
not work correctly. However since we do not really need to propagate the
palette on the viewContainer _before_ it is created, we can simply avoid
the issue alltogether as it would happen because we implicitly added
a child widget during the polish of the combo box.
Reviewed-by: nrc
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gah, my original change (f5ef0eb1a6543abdd29e07c23de7fa1128f6d623) had
its heart in the right place, but it seems that it can cause crashes
on closing where we refuse to give up the first responder and we end up
with a dangling pointer. This lets that case happen (when we have no
focus widget and are setting a nil first responder, there's no reason to
stop that, but it refuses to do that when we do have a focus widget.
Hopefully we don't get in a situation where our focus widget gets out of
sync.
Reviewed-by: Prasanth Ullattil
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Symptom: checkboxes didn't get checked if you press, hold for some
seconds and then release the mouse or stylus.
In QAbstractButton we reacted on the contextMenuEvent that gets sent if
the system recognizes the context menu gesture (tap and hold) and did
call setDown(false).
This change has been done because buttons in tool bars stayed in the
down state when displaying the context menu with this gesture.
I've now moved the handling of this to qtoolbar.cpp.
Task-number: 246619
Reviewed-by: thartman
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the Cocoa Builds.
The drag move events were compressed based only on the position of the
cursor. It has to be based on both position and the "drag operation" in
native event.
Reviewed-by: nrc
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Mac OS X - cocoa
The filename as NSString that we get from Cocoa does not have
the correct file system encoding. This means that certain characters are
implemented differently than what e.g. QFile::encoded returns. This fix
normalizes the string from cocoa before using it.
Task-number: 249928
Reviewed-by: Trenton Schulz
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In our Cocoa menu we check if we need to send the key event to the
qwidget before the menu has a chance at it, because logically in Qt, the
key event should go to the widget and not the menubar first (a bit
different than what happens on the mac). The way to determine this is to
send a shortcut override event and see if it accepts it. If it does,
that means we should just send it the key event. Previously we were
sending the shortcut override, but not following through on the key
event because we thought (however foolishly). That returning "YES" but
not setting an action would somehow forward the event (it doesn't).
There still seems to be some problems if you have a Dvorak-QWERTY+CWD
layout, but this probably needs to be dealt with at the key mapper
level.
Reviewed-by: Prasanth Ullattil
|
| |
| |
| |
| | |
Someone messed up the whitespace on this comment.
|
|/
|
|
|
|
| |
RevBy: mauricek
Details: using prefix qt_ instead of ::global namespace
|
|
|
|
|
|
|
|
|
| |
same value -> crash on SetTitle()
Task: 242484
RevBy: mauricek
AutoTest:
Details: Since we do not respect binary compatibility on Windows CE we just change the enum
|
|
|
|
|
|
|
|
|
| |
We did not enable hover on list view item views. This is
inconsistent with how QTreeView works as well as different
from how native icon views behave.
Reviewed-by: Prasanth Ullattil
Task number: 242519
|
|
|
|
| |
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
|
|
| |
When the connection is established, the socket notifier is deleted,
but not the connection timer, so the opened connection will be closed
after 30 seconds.
Task-number: none
Reviewed-by: Andreas
Reviewed-by: Thiago
|
|
|
|
|
|
| |
Looks like a typo.
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QWidget::childAt() makes some assumptions about its children (they are
all contained in its geometry). This does not hold up when using the
unified toolbar because the toolbar ends up in the "non-client" area.
So, when dispatching an enter/leave event in tooltip show, we end up
dispatching to the wrong widgets and that results in the tooltip
cleverly thinking that it needs to hide itself because we've left the
widget that needs the tooltip. I've special cased this by just having a
"native" mapFromParent() that is only called for on the mac, though
there is nothing that is limiting this from being called on other
platfroms.
Also QWidget::mapFromParent() probably needs to be looked at at some
point.
Task-number: 248048
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
| |
Reviewed-by: Trond
|
|
|
|
|
|
|
| |
Full fix will potentially break other code and is thus avoided
Task-number: 248992
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
| |
RevBy: bnilsen
Task: 249394
Details: When going through the backingstore a repaint in a
toplevel resize should just discard the repaint() as
it will repaint shortly after anyway. This is in line
with the implementation of update().
|
|
|
|
|
|
| |
RevBy: Samuel
Details: The IMAGE_FROM_PIXMAP has to be doing a local copy or
something, because it is sure not fast...
|
|
|
|
| |
RevBy: Samuel
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
QT_NO_DIRECTFB_LAYER doesn't work unless QT_NO_DIRECTFB_WM also is
defined.
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
QDirectFBPaintDevice's know their screen. No need to use instance() in
these cases.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
| |
DirectFB caches the last source surface in the target surface after a
Blit. This can cause a surface to be kept around longer than desired
since the caching increases the ref-count. Unless it's likely that the
blit will happen again soon we Release the source.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
This is essentially a return to the earlier version of toImage(). Use a
preallocated surface that operates on the returned image to do the
conversion. If this causes drawing bugs it is likely a bug in the
directfb driver and can be worked around by compiling with
QT_NO_DIRECTFB_PREALLOCATED.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
| |
If we're asking for the stride it's very likely the next thing we'll do
is ask for the bits() so there's no good reason to unlock it again.
In the raster buffer case memory() will be called just before
bytesPerLine() so the code won't be hit but it's still the right thing
to do.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
This is not X11. There's no need to create another structure to hold the
DFB rectangles. Verified by DirectFB expert.
Reviewed-by: TrustMe
|
|
|
|
| |
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
Need to set blitting flags before blitting from a surface with alpha
channel. Otherwise alpha areas become white.
For some reason setting the porterduff to DSPD_SRC does not fix this.
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
Make sure we retain the alpha channel of the original surface.
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
Make sure we keep retain alpha if there is one in the source.
Reviewed-by: TrustMe
|
|
|
|
|
|
| |
Use the intended functions for surface creation.
Reviewed-by: TrustMe
|
|\ |
|
| |
| |
| |
| | |
Reviewed-by: trustme
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
For an example of something that breaks without this fix show a spinbox
in plastique style.
The clip is never removed.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| | |
CreateWindow gives you more control over how windows are created. Make
sure to specify that they're in the same format as the primary surface
and that they're in video memory if this is supported.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| | |
Need to set forceRaster to true if the window surface is RGB32.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| | |
DirectFB can only handle cases where the pen's brush is Qt::SolidPattern
Reviewed-by: TrustMe
|
|/
|
|
|
|
|
|
|
|
| |
The compile under OS-X was failing due to unfound symbols.
Given that the implementation of these functions is not in
the header file, they should not have inline keywords.
Removing the inline keywords allowed compilation to succeed.
Reviewed-by: Rhys Weatherley
|
|
|
|
|
|
|
| |
Make sure we create the surface from the converted image and not the
original one.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
| |
QT_BEGIN_NAMESPACE is not defined until qglobal.h is included,
but some of the QtNetwork headers were listing it before.
Reviewed-by: Ian Walters
|
|
|
|
|
|
|
| |
If flags does not contain DSDESC_CAPS caps might very well be
uninitialized. Make sure to properly deal with this situation.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
| |
a NULL value
Task-number: 189093
|