| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
acquire guard of the local static.
This only buys us one warning less by helgrind.
Reviewed-by: Trust Me
|
|
|
|
|
|
|
|
|
| |
work)
This code was apparently mostly unchanged since 2005. Update it to match
the atomics code.
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure all QDirectFBPaintDevice surfaces always are created with a
format that is either QScreen::pixelFormat() or
QDirectFBScreen::alphaPixmapFormat().
Also, clean up surface creation by providing more high level functions.
Fix a bug where we would assume that ARGB means
Format_ARGB32_Premultiplied and not Format_ARGB32.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This may happen if you only have something like
QAbstractScrollArea:focus { background: foo; }
and you do not have a background set for the general case
and the viewport has a different background role (such as QTextEdit,
QAbstractItemView, ....)
This is a regression from 4.4 since in 4.4 the :focus has no effect if
you didn't have a background for the general case.
Reviewed-by: bnilsen
Task-number: 188195
|
|
|
|
|
|
|
|
| |
Use QStroker::setRect() to avoid dashing parts of the path that are
outside the device rect.
Task-number: 246573
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
|
| |
When drawing ellipse without stroke we need to use the same width/height
for the fill as we would use for the stroke for the stroke and fill to
match. Filling first and then stroking should produce the same result as
filling and stroking in one go.
Task-number: 249490
Reviewed-by: Trond
|
|
|
|
|
|
|
|
| |
Monochrome images should be converted to black and white, not
transparent and white. Reported on qt-interest.
Task-number: 249175
Reviewed-by: Trond
|
|
|
|
|
|
|
|
|
| |
uic is set in default_pre. this leads to useless -I compiler flags when
no ui files are used in fact, so it would be nice to get rid of it in
cases where it is not used. for backwards compat, don't remove it from
the _pre, but add some magic to _post to remove it again if QT does not
contain gui. of course, we need a force_uic CONFIG to enable an
exception for QtGui itself ...
|
|
|
|
|
| |
the exact length of the template is known, so there is no point in using
the more complex (and thus potentially slower) strncmp instead of memcmp.
|
|
|
|
| |
this function is always called with found != 0 nowadays
|
| |
|
|
|
|
|
|
|
|
| |
When the current focus widget enforces the creation of the native
window handle we should reset the input context.
Task-number: 249578
Reviewed-by: Brad
|
|
|
|
|
|
|
|
|
|
|
| |
On X11 when user manually creates a QDesktopWidget object it breaks
notifications from the root window since we have several
QDesktopWidgets that have the same native window id and the
wid->qwidget mapper (QWidgetPrivate::mapper) goes crazy. So whenever
we get x11 event from the root window we cannot find a qwidget that
corresponds to the window id and discard these events.
Reviewed-by: Brad
|
|
|
|
|
|
|
|
|
|
| |
commit b1220858d9c15b661b7825e733be448ea9962895
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 18:37:47 2009 +0100
Doc: Added information about the default value of QGraphicsTextItem::tabChangesFocus().
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 20864878d046b2ce6bf5fc54868be8df346ce0c8
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 18:30:32 2009 +0100
Doc: Fixed qdoc warning by adding more descriptive text.
Reviewed-by: TrustMe
commit 3b620a0a4d1b02105c9761384a5abc4ecf11e9d2
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 18:29:56 2009 +0100
Doc: Added macros for future use.
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 23e30464792f7e403e0815775eb7acbaad975238
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 17:41:20 2009 +0100
Doc: Added some basic documentation for the QSvgGenerator class.
Task-number: 244944
Reviewed-by: TrustMe
commit f84c1806d2ba40a61499584562d754f65d43f854
Merge: 8a42be7... 213d922...
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 16:59:14 2009 +0100
Merge branch '4.5' of ../qt-45 into qt/4.5
commit 8a42be789077de45f8fd9f13afd177798df7495e
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 26 16:58:33 2009 +0100
Doc: Added missing pieces for the SVG Generator example.
Reviewed-by: David Boddie <dboddie@trolltech.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
key events.
We need to be more explicit in setting the first responder, and a bit
more agressing about rejecting it when called with no responder.
It seems that Cocoa has a tendency to reset the first responder when
lots of widgets get hidden or shown. During this it will call
"makeFirstResponder" on the window with a nil responder. Doing this will
reset our what Cocoa thinks is the focus widget, but Qt will still show
a focus widget. The way to solve it is to reject the make first
responder if the responder is nil. I'm not sure if there will be far
reaching implications for this, but it seems to be doing the right thing
at the moment.
We also need to share this code between QCocoaWindow and QCocoaPanel.
Thanks to the dynamic nature of objective-C we have to have a copy of
the code in both places. It's unfortunate.
Finally, it's also important to have the QWidget let Cocoa know it has
focus after it has been created. So, make sure that is in sync.
Task-number: 249296
Reviewed-by: Prasanth Ullattil
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0b6fc217c2b853827926313c09bb3c32f66ffe43 )
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-02-06 Dirk Schulze <krit@webkit.org>
Reviewed by Simon Hausmann.
Fix bug in clearRect(). Use fillRect() instead of eraseRect() to get
the context transparent.
[QT] clearRect fill's a given rect with white
https://bugs.webkit.org/show_bug.cgi?id=23728
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clearRect):
++ b/WebKit/qt/ChangeLog
2009-03-26 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Fix the documentation of the QLocale usage in userAgentForUrl.
* Api/qwebpage.cpp:
2009-03-20 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
Fix for InsertParagraphSeparator and InsertLineSeparator so that
QWebPage::action() creates QActions for them. Also make sure they get
updated appropriately.
* Api/qwebpage.cpp:
(QWebPagePrivate::updateEditorActions):
(QWebPage::action):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::textEditing):
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
qscriptvalue_cast implementation was changed from 4.4 to 4.5 because
of the introduction of QScriptValue constructors that don't take an
engine pointer. However, when the old constructors are used, the
behavior of qscriptvalue_cast should be as before, which this patch
ensures. In short: If we have an engine pointer, use it.
Task-number: 248802
Reviewed-by: Ariya Hidayat
|
|/
|
|
|
|
|
| |
the task.
Task-number: 249423
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
The pieceTable member was only initialized by QTextDocumentPrivate
_after_ the call to createObject. This patch initializes it at
construction time.
Task-number: 246138
Reviewed-by: Simon Hausmann
|
|
|
|
|
|
|
|
| |
This results in a syscall and is very slow. Make the call once and cache
the value.
Task-number: 244718
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
| |
This is a good example of how to not use QStyleOption when added new
features. It's important to start with the most compatible and then cast
to the more specific versions to get the new fields.
Task-number: 248769
Reviewed-by: Jens Bache-Wiig
|
|
|
|
| |
bits(). The non-const bits() may detach and realign the data, so that the previous result of bytesPerLine() ist invalid. On S60, we actually had a 'skew' effect because of that.
|
|
|
|
|
|
|
|
|
|
| |
This makes QGtkStyle style QFrame. In order to avoid
negatively affecting the performance we cheat by using a border image
without the center part filled. GtkScrolledWindow style
is used as QFrame is generally mapped to item views.
249363
ogoffart
|
|
|
|
|
|
|
|
| |
Fixes two bugs with regards to Flip(). We blit'ed the boundingRect of
the updated region rather than each rect which is wasteful. More
importantly we ignored the offset which would lead to painting errors.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
|
| |
Store the QDirectFBPaintDevice we're painting and use this when
unlocking/locking instead of working on QPaintEngine::device() which
isn't necessarily the same.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
| |
Improve readability of code.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
| |
This class should never be instantiated without being subclassed so a
protected constructor is the clean thing to do.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
| |
It's never necessary. Any surface we ever intend to lock and write to
should never have a color table.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
| |
No sense in locking every time we want the bpl. The bpl won't change
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
| |
No need to go through the FillRectangles case which would allocate a
bunch of T on the stack.
Reviewed-by: Tom Cooksey
|
|
|
|
|
|
|
|
|
| |
QDockWidget's minimum title width was not computed correctly and was
thus provoking some strange layout issues. We need to ask for the
widget's sizeHint for the close and float buttons.
Task-number: 241577
Reviewed-by: ogoffart
|
|
|
|
|
| |
Task-number: None
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
| |
QApplication class and the QSessionManager class a documentation
overhaul.
Task-number: 249220
Reviewed-by: TrustMe
|
|
|
|
|
|
|
|
|
|
|
| |
Calling setCompletionPrefix() on a QCompleter from a slot connected
to the editingFinished() signal of the corresponding QLineEdit
could in some cases alter the internal state of the completer in
such a way that an assertion would fail. The fix prevents the
asserting code from being called in this particular state.
Reviewed-by: janarve
Task-number: 246056
|
|
|
|
|
|
|
|
| |
The default size of a docka area invalid and thus the gap
had an invalid size.
Task-number: 248069
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
|
| |
Even when not animated, we need to set the plugging widget when
plugging. This avoids a hover to be triggered in the middle of the
operation.
Task-number: 248069
Reviewed-by: ogoffart
|
|
|
|
|
|
| |
This stylesheet used to crash: *::title { border 1px solid black }
Reviewed-by: bnilsen
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interrupted twice by a signal.
If we're interrupted only once, there's no problem. If we're
interrupted twice, we subtract the elapsed time since the beginning
from the remaining time, so this won't work. The correct thing is to
recalculate from the original timeout value.
This is extremely difficult to test, since it requires that the
select(2) call be interrupted twice by signals. The only way to do
this is by sending two signals to a program from another program (or
threads, with pthread_kill(3)) with less than half of the time left,
then send data to cause the loop to exit with success.
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
application.
If it's used as a static, then the order of destruction is
ill-defined. The QSharedPointer object may be destroyed after our
Q_GLOBAL_STATIC knownPointers has been deleted, thus causing a
null-pointer dereference.
Reviewed-by: Peter Hartmann <peter.hartmann@nokia.com>
Task-number: 246843
|
|
|
|
|
|
|
| |
aefadefae655972287b196e6c0f0563c4fb4666c was not good enough
Task-number: 248094
Reviewed-by: Jens Bache-Wiig <jbache@trolltech.com>
|
|
|
|
|
|
|
|
| |
Removed a lie, and made it more clear that you must reimplement this
function in order for a layout to arrange the item.
Task-number: 245550
Reviewed-by: alexis
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 57ce15b2984cb7ccc4ab0b5dc03812d525d52620
Author: David Boddie <dboddie@trolltech.com>
Date: Tue Mar 24 16:55:41 2009 +0100
Removed internal, hidden documentation.
Also fixed the language used, slightly.
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
commit 0a81cc2a6dfc98087de92e53d493bed56826642f
Merge: 4bd3eca... dd7b1f1...
Author: David Boddie <dboddie@trolltech.com>
Date: Tue Mar 24 15:24:32 2009 +0100
Merge branch '4.5' of git@scm.dev.nokia.troll.no:qt/qt into 4.5
commit 4bd3eca8855bb2564e146be4d0a3bba836d20122
Merge: dc789e3... 1d1c52c...
Author: David Boddie <dboddie@trolltech.com>
Date: Mon Mar 23 19:20:05 2009 +0100
Merge branch 'qt/4.5' of ../qt-45-documentation into 4.5
commit 1d1c52c60995058b61ee35e3970fecc1de3b85b6
Merge: 6c5de23... 381b6cc...
Author: David Boddie <dboddie@trolltech.com>
Date: Mon Mar 23 19:17:37 2009 +0100
Merge branch 'qt/4.5' of git://scm.dev.nokia.troll.no/qt/qt-45 into qt/4.5
commit 6c5de23611baef3c6be59b94ebd29d901056c2fc
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 19 18:26:11 2009 +0100
Fixes: Doc: Fixed typo.
Reviewed-by: David Boddie <dboddie@trolltech.com>
commit 5d710cc183699513b1582507dcb4cddefb91c8ad
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 19 18:24:31 2009 +0100
Fixes: Doc: Made it clearer what qDebug() actually does.
Reviewed-by: David Boddie <dboddie@trolltech.com>
commit 1fae0b3b34bf066e2356671a5c6187485b2b587d
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 19 17:53:09 2009 +0100
Fixes: Doc: Added a note about not modifying the text document in a paint event handler.
Task-number: 246550
Reviewed-by: David Boddie <dboddie@trolltech.com>
commit 29662d44de9b42d811e60a1b57d871335888373a
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 19 17:04:07 2009 +0100
Fixes: Doc: Fixed styling of code in this tutorial.
Task-number: 247053
Reviewed-by: David Boddie <dboddie@trolltech.com>
commit 630c11d6f9f20d5f99bc964efaf4b39daaeb32c4
Author: David Boddie <dboddie@trolltech.com>
Date: Thu Mar 19 15:19:24 2009 +0100
Fixes: Doc: Note the use of just the name of a method rather than a complete signature.
Task-number: 247857
Reviewed-by: David Boddie <dboddie@trolltech.com>
|
|
|
|
|
|
|
|
|
|
| |
When a toplevel window is the widget that can accept keyboard input,
it doesn't get focus when shown. The fix is to check if the toplevel
is activated and noone has focus, then give focus to the toplevel
itself.
Reviewed-by: Brad
Task-number: 244607
|
|
|
|
|
|
|
|
|
| |
When a wiget that accepts keyboard input looses focus and the input
context is resetted we should clear the old preedit string by sending
an empty commit string only if the widget received non-empty pre-edit
string before.
Reviewed-by: Brad
|
|
|
|
|
|
|
|
|
| |
This patch basically ensure that we share the same QFileinfo all over
the place for each nodes (then we benefit of the cache). It fix also an
extra stat due of a bugfix that was not optimal.
Task-number: 247645
Reviewed-by: jasplin
|
|
|
|
|
|
|
| |
model is reset
Task-number: 248868 (part 2)
Reviewed-by: Thierry
|
|
|
|
|
| |
Task-number: 248868 (part 1)
Reviewed-by: Thierry
|