| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Remobe another instance of for ... in use.
|
|
|
|
|
| |
Don't use the "for ... in" syntax. This is Objective-C 2, which is
only supported on 10.5 and up.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
This change ensures that mouse presses received by the scene when there
are no current mouse grabbers trigger hover event delivery. This is
useful when the scene only receives presses, and no mouse moves (e.g.,
disabling mouse tracking on the viewport, or on systems where the
mouse press is the first received event).
Reviewed-by: Michael Brasser
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change f68fed3 introduced a few regressions in the QGraphicsWidget
autotests. It turned out those autotests relied on behavior that this
fix "fixed". The exact bugs were 1) that setting focus on a window
or a child of a window that isn't active will automatically give that
item focus, despite that its window is inactive (in contrast it should
just set up subfocus and give the item focus when the window is
activated), and 2) that adding a window to a scene that is active did
not immediately activate that window.
So one fix in the test and one in QGraphicsScene. The autotests were
modified so that the respective tests operate on an active scene (by
assigning the scene to an active view). The change in QGraphicsScene
ensures that the first window that gets added to an active scene that
does not have any active windows already, automatically gets activated.
Reviewed-by: Michael Brasser
|
|
|
|
|
|
|
| |
Add using to prefer QObject::children() over the obsolete
QGraphicsItem::children() function.
Reviewed-by: Henrik Hartz
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The idea of having separate rotationX/Y/Z, shearX/Y, etc.
methods in QGraphicsItem turned out to be not giving us
the flexibility we need and wanted.
The new code now implements a different scheme, where we
keep simple rotate (around z-axis), scale and
transformOriginPoint methods, but remove the other ones.
Instead we now have an additional list of QGraphicsTransform
object. QGraphicsTransform is an abstract class that inherits
QObject. Several specializations are provided and can be
used to transform (and through property bindings animate)
the item.
Reviewed-By: Andreas
|
|
|
|
|
|
|
|
| |
If comparing two variants fails, the failure message will now output
the type and value of the variants (rather than
"Compared values are not the same").
Reviewed-by: Thiago
|
| |
|
|
|
|
|
| |
Clarified that the format used in QImage::fromData() is the image format,
not the pixel format.
|
|
|
|
|
|
| |
These structures are only used in versions after 0.922.
Reviewed-by: Donald <qt-info@nokia.com>
|
|
|
|
|
|
|
|
|
| |
throwing them.
Autotest included.
Task: 258081
Reviewed-by: Trustme
|
|
|
|
| |
to respective APIs.
|
| |
|
|
|
|
| |
This closes task 235801.
|
|
|
|
| |
Reviewed-by: Gunnar Sletta
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some compilers don't obey the same rules of "top-of-object" values for
casting a pointer from a given class to void *. In any case, that can
only work for polymorphic types (with a virtual table).
So don't track the pointers by their pointer value, but instead by the
d-pointer of the QSharedPointer object.
The same cases that were caught before should still be caught. We
still won't catch the creating a second QSharedPointer for the same
object if the pointer values are different, though (when cast to
void*).
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
| |
In de05f9a40e41deb79daf5c4935b2645d70d7f322 I removed the fcntl that
set FD_CLOEXEC because it was supposed to be set by
qt_safe_pipe. Turns out that this code didn't call the wrapper
function...
Reviewed-by: ossi
|
|
|
|
|
|
| |
I don't know if this was only the debugging symbols or if the compiler
was really wrong. But while debugging, Self was
ExternalRefCountWithCustomDeleter, which is wrong at this point.
|
|
|
|
| |
But I'm told 5.10 does.
|
|
|
|
| |
Reviewed-by: Trustme
|
|
|
|
|
|
|
|
|
| |
When you have an icon set we do not show the text label,
but the previous code would still use the text for the size
hint calculation.
Task-number: 218836
Reviewed-by: ogoffart
|
| |
|
|
|
|
|
|
| |
RevBy: Frans Englich
Details: QHash::value creates an internal compiler error in this case
on Metrowerks, using find instead
|
| |
|
|
|
|
|
| |
Solaris seems to define glXReleaseTexImageEXT rather than let it be
resolved as a function pointer.
|
|
|
|
|
|
|
|
|
|
|
| |
Checkboxes would animate when first shown if they were checked.
This is unintentional and looks a bit odd in wizard for instance.
To fix this we simply check if the old state was set. Note that
this is safe because we will at least require the enabled state
flag to be set.
Task-number:253075
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtConcurrent had the following code:
template <typename T> class ThreadEngineStarterBase
{ ...
protected:
ThreadEngine<T> *threadEngine;
};
template <typename T>
class ThreadEngineStarter : public ThreadEngineStarterBase<T>
{
public:
ThreadEngineStarter(ThreadEngine<T> *threadEngine)
:ThreadEngineStarterBase<T>(threadEngine) {}
[...]
};
The Sun CC compiler simply didn't parse the parameter declaration in
the constructor. Instead of complaining, it silently ignored the
problem. Which meant that the constructor simply used the
uninitialised member variable from the base class to call the parent
constructor, which ended up initialised with itself.
You'd think that it's just because the parameter has the same name as
a member variable. But it appears to be a compiler bug altogether. If
you change the name, then you start getting compile errors.
This change is a workaround that worked.
Reviewed-By: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had added the version check when we only had CC 5.5 and 5.6,
expecting that 5.7 would have the support. And if it didn't, then
someone would notice the compile error in QtConcurrent, bumping the
version number here.
Except that QtConcurrent was never enabled with Sun CC. Which meant
that we never got to test TTP support.
Reviewed-By: Bradley T. Hughes
|
|
|
|
|
|
|
| |
See ba191b0a26b966ad1fb596a905307399922bc44a for a similar commit done
to QStringMatcher.
Reviewed-By: Bradley T. Hughes
|
|
|
|
|
| |
As pointed out on IRC, setTransform is used most frequently in code and in
an ideal world would be the only such function.
|
|
|
|
| |
Reviewed-by: TrustMe
|
| |
|
|
|
|
| |
Need the right include for the mach_*() functions.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The arrow was reported to be on the wrong side of the control.
Technically the arrow part seems to cover the whole rect on
Vista and Gtk+ but due to compatibility it is probably safer to keep
the old rects for now.
Task-number: 252857
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| | |
Mac OS X only change
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Merge the monotonic clock source detection in
qeventdispatcher_unix.cpp with that in qcore_unix.cpp. As discussed
with Thiago, we're also removing older compat code at the same time
(spinning on select() when we think it woke up early).
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| | |
QPainter.
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QTransform and respective APIs should be used. Still some changes required
- Some references to QMatrix left in documentation
- Qt code uses QMatrix APIs (ie translationX)
Reviewed-by: Samuel
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
The comment was speaking about upload progress, however the code
is about download progress.
Reviewed-by: TrustMe
|
| | |
|
| |
| |
| |
| |
| |
| | |
Task: 258573
Reviewed-By: TrustMe
|
|/
|
|
|
|
|
|
|
| |
Handle the case when insertText is called with no corresponding
keyDown.
This fix is for the Cocoa port.
Task-number: 147379
|
|
|
|
|
|
|
|
| |
Call [NSToolbar setShowsBaselineSeparator] on the (unified) toolbar
if the window contains tabs in document mode.
Task-number: 252660
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
| |
The conditionals were the wrong way round.
Reviewed-By: Samuel
|