| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
to respective APIs.
|
| |
|
|
|
|
| |
This closes task 235801.
|
|
|
|
| |
Reviewed-by: Gunnar Sletta
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some compilers don't obey the same rules of "top-of-object" values for
casting a pointer from a given class to void *. In any case, that can
only work for polymorphic types (with a virtual table).
So don't track the pointers by their pointer value, but instead by the
d-pointer of the QSharedPointer object.
The same cases that were caught before should still be caught. We
still won't catch the creating a second QSharedPointer for the same
object if the pointer values are different, though (when cast to
void*).
Reviewed-by: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
| |
In de05f9a40e41deb79daf5c4935b2645d70d7f322 I removed the fcntl that
set FD_CLOEXEC because it was supposed to be set by
qt_safe_pipe. Turns out that this code didn't call the wrapper
function...
Reviewed-by: ossi
|
|
|
|
|
|
| |
I don't know if this was only the debugging symbols or if the compiler
was really wrong. But while debugging, Self was
ExternalRefCountWithCustomDeleter, which is wrong at this point.
|
|
|
|
| |
But I'm told 5.10 does.
|
|
|
|
| |
Reviewed-by: Trustme
|
|
|
|
|
|
|
|
|
| |
When you have an icon set we do not show the text label,
but the previous code would still use the text for the size
hint calculation.
Task-number: 218836
Reviewed-by: ogoffart
|
| |
|
|
|
|
|
|
| |
RevBy: Frans Englich
Details: QHash::value creates an internal compiler error in this case
on Metrowerks, using find instead
|
| |
|
|
|
|
|
| |
Solaris seems to define glXReleaseTexImageEXT rather than let it be
resolved as a function pointer.
|
|
|
|
|
|
|
|
|
|
|
| |
Checkboxes would animate when first shown if they were checked.
This is unintentional and looks a bit odd in wizard for instance.
To fix this we simply check if the old state was set. Note that
this is safe because we will at least require the enabled state
flag to be set.
Task-number:253075
Reviewed-by: ogoffart
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QtConcurrent had the following code:
template <typename T> class ThreadEngineStarterBase
{ ...
protected:
ThreadEngine<T> *threadEngine;
};
template <typename T>
class ThreadEngineStarter : public ThreadEngineStarterBase<T>
{
public:
ThreadEngineStarter(ThreadEngine<T> *threadEngine)
:ThreadEngineStarterBase<T>(threadEngine) {}
[...]
};
The Sun CC compiler simply didn't parse the parameter declaration in
the constructor. Instead of complaining, it silently ignored the
problem. Which meant that the constructor simply used the
uninitialised member variable from the base class to call the parent
constructor, which ended up initialised with itself.
You'd think that it's just because the parameter has the same name as
a member variable. But it appears to be a compiler bug altogether. If
you change the name, then you start getting compile errors.
This change is a workaround that worked.
Reviewed-By: Bradley T. Hughes
|
|
|
|
|
|
|
|
|
|
|
|
| |
I had added the version check when we only had CC 5.5 and 5.6,
expecting that 5.7 would have the support. And if it didn't, then
someone would notice the compile error in QtConcurrent, bumping the
version number here.
Except that QtConcurrent was never enabled with Sun CC. Which meant
that we never got to test TTP support.
Reviewed-By: Bradley T. Hughes
|
|
|
|
|
|
|
| |
See ba191b0a26b966ad1fb596a905307399922bc44a for a similar commit done
to QStringMatcher.
Reviewed-By: Bradley T. Hughes
|
|
|
|
|
| |
As pointed out on IRC, setTransform is used most frequently in code and in
an ideal world would be the only such function.
|
|
|
|
| |
Reviewed-by: TrustMe
|
| |
|
|
|
|
| |
Need the right include for the mach_*() functions.
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The arrow was reported to be on the wrong side of the control.
Technically the arrow part seems to cover the whole rect on
Vista and Gtk+ but due to compatibility it is probably safer to keep
the old rects for now.
Task-number: 252857
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| | |
Mac OS X only change
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Merge the monotonic clock source detection in
qeventdispatcher_unix.cpp with that in qcore_unix.cpp. As discussed
with Thiago, we're also removing older compat code at the same time
(spinning on select() when we think it woke up early).
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| | |
QPainter.
Reviewed-by: Simon Hausmann
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QTransform and respective APIs should be used. Still some changes required
- Some references to QMatrix left in documentation
- Qt code uses QMatrix APIs (ie translationX)
Reviewed-by: Samuel
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
The comment was speaking about upload progress, however the code
is about download progress.
Reviewed-by: TrustMe
|
| | |
|
| |
| |
| |
| |
| |
| | |
Task: 258573
Reviewed-By: TrustMe
|
|/
|
|
|
|
|
|
|
| |
Handle the case when insertText is called with no corresponding
keyDown.
This fix is for the Cocoa port.
Task-number: 147379
|
|
|
|
|
|
|
|
| |
Call [NSToolbar setShowsBaselineSeparator] on the (unified) toolbar
if the window contains tabs in document mode.
Task-number: 252660
Reviewed-by: Richard Moe Gustavsen
|
|
|
|
|
|
| |
The conditionals were the wrong way round.
Reviewed-By: Samuel
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If you set this flag on an item, and descendant item that gains input
focus will become this item's focus proxy. This simplifies how focus
proxy items are assigned from QML; instead of binding the possible
focusProxy property to a named child widget, this assignment happens
automatically as you set the focus property of a descendant to true.
As part of this change, QGraphicsWidget::focusWidget behavior has been
improved and moved into QGraphicsItem. For example, if you set focus on
an item that it's part of a scene, it can gain focus once the parent
has been assigned (which is how object trees are built in QML).
Autotests are included.
Reviewed-by: Michael Brasser
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This reverts commit 1368c210ef9976f68eb9fb1c3e4dc14f4fa4edd2, which
accidentially reverted previous commits.
|
| |
|
|
|
|
|
| |
I don't know exactly why this is needed, but otherwise GCC complains
that there is no default constructor.
|
|
|
|
|
| |
Don't use old-style casts in Qt code. And avoid signed/unsigned
comparisons (sizeof returns size_t, which is unsigned).
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use the same trick as the custom deleter: we allocate memory for an
object of class ExternalRefCountWithContiguousData<T>, but we do that
only to be certain of the alignment requirements for T. We initialise
the d-pointer via placement new and the T object is left for
initialisation by the outermost function.
The reason for that last trick is to support passing parameters in the
future with the least amount of template functions necessary. I still
plan on supporting arguments only with C++0x (maybe up to one
without).
|
|
|
|
|
|
|
| |
structure in QSharedPointer""
This restores the original implementation of the creating
function. The next commit will make it suitable for use.
|
|
|
|
|
|
|
|
|
|
| |
This should be binary- and source-compatible, since these
QSharedPointer internal classes aren't exported. The compiler should
generate the symbols in all libraries and applications that used it,
which means removing it from Qt won't affect them.
(In fact, these symbols shouldn't be in QtCore at all, since we don't
use QSharedPointer in it)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of using a template class derived from
QtSharedPointer::ExternalRefCountData, use a non-template class that
has a function pointer. This avoids generating a virtual table for
each QSharedPointer type and custom deleter.
The trick here is that we don't "new" the d pointer anymore, but we
simply allocate memory (via ::operator new, so it may throw an
exception), then we use the placement new to initialise the
non-template d-pointer and the template deleter sub-objects. Then we
store the pointer to a regular function which will execute the user's
custom deleter.
I also added operator delete() to the class to make sure no smarty
compiler decides to delete the d-pointer with a fixed size (I don't
think that happens, but just to be on the safe side).
|