| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
The method can help to avoid many calls to the rather
expensive qFuzzyCompare in the cases where we compare
a number against 0 or 1.
|
|
|
|
|
|
|
|
| |
Now that we have QPainterPath::translate, we can use
that instead of itemTransform()/map(To|From)Scene, which
lowers the number of QTransform operations involved.
Reviewd-by: Andreas
|
|
|
|
|
|
|
| |
Also removed the old obsolete qkbpc101_qws files. Somehow this removal got
lost in the rebase before the keyboard handler refactoring commit.
Reviewed-by: TrustMe
|
| |
|
|
|
|
|
|
|
|
|
| |
Do not update the cache's exposed list if the entire cache
is already exposed.
Makes tst_QGraphicsItem::cacheMode pass again.
Reviewed-by: Andreas
|
|\
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/gui/graphicsview/qgraphicsitem.cpp
src/gui/graphicsview/qgraphicsitem_p.h
src/gui/graphicsview/qgraphicsscene.cpp
src/gui/painting/qtransform.cpp
|
| |
| |
| |
| | |
Reviewed-by: ogoffart
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When the connection is established, the socket notifier is deleted,
but not the connection timer, so the opened connection will be closed
after 30 seconds.
Task-number: none
Reviewed-by: Andreas
Reviewed-by: Thiago
|
| |
| |
| |
| |
| |
| | |
Looks like a typo.
Reviewed-by: Bradley T. Hughes
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
QWidget::childAt() makes some assumptions about its children (they are
all contained in its geometry). This does not hold up when using the
unified toolbar because the toolbar ends up in the "non-client" area.
So, when dispatching an enter/leave event in tooltip show, we end up
dispatching to the wrong widgets and that results in the tooltip
cleverly thinking that it needs to hide itself because we've left the
widget that needs the tooltip. I've special cased this by just having a
"native" mapFromParent() that is only called for on the mac, though
there is nothing that is limiting this from being called on other
platfroms.
Also QWidget::mapFromParent() probably needs to be looked at at some
point.
Task-number: 248048
Reviewed-by: Richard Moe Gustavsen
|
| |
| |
| |
| | |
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| | |
Full fix will potentially break other code and is thus avoided
Task-number: 248992
Reviewed-by: Trond
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
RevBy: bnilsen
Task: 249394
Details: When going through the backingstore a repaint in a
toplevel resize should just discard the repaint() as
it will repaint shortly after anyway. This is in line
with the implementation of update().
|
| |
| |
| |
| |
| |
| | |
RevBy: Samuel
Details: The IMAGE_FROM_PIXMAP has to be doing a local copy or
something, because it is sure not fast...
|
| |
| |
| |
| | |
RevBy: Samuel
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| | |
QT_NO_DIRECTFB_LAYER doesn't work unless QT_NO_DIRECTFB_WM also is
defined.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| | |
QDirectFBPaintDevice's know their screen. No need to use instance() in
these cases.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| | |
DirectFB caches the last source surface in the target surface after a
Blit. This can cause a surface to be kept around longer than desired
since the caching increases the ref-count. Unless it's likely that the
blit will happen again soon we Release the source.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is essentially a return to the earlier version of toImage(). Use a
preallocated surface that operates on the returned image to do the
conversion. If this causes drawing bugs it is likely a bug in the
directfb driver and can be worked around by compiling with
QT_NO_DIRECTFB_PREALLOCATED.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If we're asking for the stride it's very likely the next thing we'll do
is ask for the bits() so there's no good reason to unlock it again.
In the raster buffer case memory() will be called just before
bytesPerLine() so the code won't be hit but it's still the right thing
to do.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
This is not X11. There's no need to create another structure to hold the
DFB rectangles. Verified by DirectFB expert.
Reviewed-by: TrustMe
|
| |
| |
| |
| | |
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Need to set blitting flags before blitting from a surface with alpha
channel. Otherwise alpha areas become white.
For some reason setting the porterduff to DSPD_SRC does not fix this.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| | |
Make sure we retain the alpha channel of the original surface.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| | |
Make sure we keep retain alpha if there is one in the source.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| | |
Use the intended functions for surface creation.
Reviewed-by: TrustMe
|
| |\ |
|
| | |
| | |
| | |
| | | |
Reviewed-by: trustme
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
For an example of something that breaks without this fix show a spinbox
in plastique style.
The clip is never removed.
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
CreateWindow gives you more control over how windows are created. Make
sure to specify that they're in the same format as the primary surface
and that they're in video memory if this is supported.
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | |
| | | |
Need to set forceRaster to true if the window surface is RGB32.
Reviewed-by: TrustMe
|
| | |
| | |
| | |
| | |
| | | |
DirectFB can only handle cases where the pen's brush is Qt::SolidPattern
Reviewed-by: TrustMe
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The compile under OS-X was failing due to unfound symbols.
Given that the implementation of these functions is not in
the header file, they should not have inline keywords.
Removing the inline keywords allowed compilation to succeed.
Reviewed-by: Rhys Weatherley
|
| |
| |
| |
| |
| |
| |
| | |
Make sure we create the surface from the converted image and not the
original one.
Reviewed-by: TrustMe
|
| |
| |
| |
| |
| |
| |
| | |
QT_BEGIN_NAMESPACE is not defined until qglobal.h is included,
but some of the QtNetwork headers were listing it before.
Reviewed-by: Ian Walters
|
| |
| |
| |
| |
| |
| |
| | |
If flags does not contain DSDESC_CAPS caps might very well be
uninitialized. Make sure to properly deal with this situation.
Reviewed-by: Donald <qt-info@nokia.com>
|
| |
| |
| |
| |
| |
| | |
a NULL value
Task-number: 189093
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The old code did not split up the frame from the central
parts of the itemview selection box correctly. We now
draw the edges as border images instead. Previously this
would lead to somewhat ugly scaling artifacts for small
header sections.
Task: 248839
Reviewed-by: ogoffart
|
| |
| |
| |
| | |
RevBy: Thiago
|
| |
| |
| |
| | |
(cherry picked from commit fd9b788bd6a99630b06cffee4c9fa9f4c06b0ef1)
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The previous change 6c2dd295b2ca2f9125fe072d035a3784ce748718 to remove
usage of NaN in SVG gradients was incomplete. This commit should fix
that.
Task-number: 250146
Reviewed-by: Samuel
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Using branch origin/qtwebkit-4.5 (f72c14123c593dc9d649d25b7186334bba0026b5)
Changes in WebKit since the last update:
++ b/WebCore/ChangeLog
2009-04-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Don't show and hide the platformPluginWidget, as it's our QWebView
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::setParentVisible):
2009-04-06 Mike Belshe <mike@belshe.com>
Reviewed by Eric Seidel.
HTMLCanvasElement crash when ImageBuffer creation fails.
https://bugs.webkit.org/show_bug.cgi?id=23212
Check for NULL before using the ImageBuffer as we might
be low on memory and creation may have failed.
Test case creation blocked by:
https://bugs.webkit.org/show_bug.cgi?id=25055
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
2009-04-05 Erik L. Bunce <elbunce@xendom.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=25050
Fix an assert failure when dropping an 'empty' text/uri-list on a QWebView.
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asURL):
++ b/WebKitTools/ChangeLog
2009-03-31 Adam Roben <aroben@apple.com>
Make resolve-ChangeLogs -f work when the working tree has spaces in
its path
Reviewed by Mark Rowe and David Kilzer.
* Scripts/resolve-ChangeLogs:
(sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in
case it contains spaces.
2009-03-17 David Kilzer <ddkilzer@apple.com>
resolve-ChangeLogs should not die on unmerged non-ChangeLog files
Reviewed by Adam Roben.
Fixes the following bug in resolve-ChangeLogs:
Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.
* Scripts/resolve-ChangeLogs:
(findUnmergedChangeLogs): Check the result of findChangeLog() to
make sure we don't add undef values to the list of files being
returned.
2009-03-11 David Kilzer <ddkilzer@apple.com>
Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs
<https://bugs.webkit.org/show_bug.cgi?id=24378>
Reviewed by Adam Roben.
* Scripts/resolve-ChangeLogs: If -f|--fix-merged is not passed
and no file or directory names are specified on the command-line
then try to find unmerged ChangeLog files based on 'svn stat' or
'git diff'. Added global $isGit and $isSVN variables so that
isGit() and isSVN() only have to be called once.
(findUnmergedChangeLogs): Added.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There was a regression in the background color for QComboBox popups.
This should resolve it. It essentially tells the system to stay off
the system palette while QGtkStyle is used. We will introduce
a cleaner style hint for this in 4.6.
Reviewed-by: nrc
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This change shows a limitation in Graphics View caused by QPen's
default width being 0 (cosmetic), while Graphics View actually
does not support cosmetic pens at all. Because items are at risk of
drawing lines that poke 1 pixel outside their bounding rect,
QGraphicsView must look for items that are up to one pixel
larger than their bounding rect mapped to viewport coordinates.
Furthermore, mapToScene(QRect) forces us to adjust the
input rectangle by (0, 0, 1, 1), because it uses QRect::bottomRight()
(etc) when mapping the rectangle to a polygon (which is _wrong_). Since
this behavior has been there since 4.2, we don't want to fix it in
a 4.5 patch release...
The only _proper_ fix to this problem is for the view to know the item's
"adjust" in device coordinates, allowing items to use cosmetic pens
freely. Fex, we could introduce QGraphicsItem::viewportMargins() or so.
Added an autotest to ensure this doesn't break again.
Reviewed-by: bnilsen
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
0aa2ef27249dc8e782c2942340776bb19de80a0d
RevBy: TrustMe
AutoTest: tst_QGraphicsItem::boundingRegion() pass again
Details: The original code adjusted the QRect version of a mapped bounding rect,
wheras my patch adjusted a mapped bounding rect (QRectF) and then
converted it to a QRect.
|
| |
| |
| |
| |
| |
| |
| |
| | |
RevBy: Andreas
AutoTest: Still pass
Details: QRectF::intersects does not work with flat rectangles, so
we cannot intersect the bounding rect without adjusting it
first.
|
| |
| |
| |
| |
| | |
RevBy: Olivier
AutoTest: Still pass
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
RevBy: Andreas
AutoTest: tst_QGraphicsView::itemAt2 pass again
Details: A QPoint in the view has to be mapped to a pixel in the
scene, otherwise it won't be possible to e.g. click
on items that are smaller than a pixel.
So...we have to optimize the hit-testing code in another way
|
| |
| |
| |
| |
| | |
RevBy: Andreas
AutoTest: included
|